From unknown Mon Jun 23 18:33:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18034: toggle-read-only used in the code Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Jul 2014 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18034@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14055224966213 (code B ref -1); Wed, 16 Jul 2014 14:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jul 2014 14:54:56 +0000 Received: from localhost ([127.0.0.1]:56673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7Qbf-0001c9-DB for submit@debbugs.gnu.org; Wed, 16 Jul 2014 10:54:55 -0400 Received: from fely.am-1.org ([78.47.74.50]:47243) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7Qbb-0001by-Oc for submit@debbugs.gnu.org; Wed, 16 Jul 2014 10:54:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Sender:Date:Subject:To:From; bh=jUtNHnSKhBu1NiU9/oAwBABN0i4p9FhhuDyjJJkgm+k=; b=U9ENh1ivcYiPEKyNlqHAX37e+XHpByeSoQHC32fRbNskHlw8JFSivmR1TEsjfln+2EUskmzSkMckHEPgKmQu+tjI6piPQKSyKYPzbYHI/Yj1P3QjJGLn2aBRjzF8Z1N7LMz8ZaOz6rvmkU32DKTS2+xz0effaZO83Ok3ulI18zc=; Received: from host-46-241-38-202.bbcustomer.zsttk.net ([46.241.38.202] helo=waterlily.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1X7Qba-00060y-8N for submit@debbugs.gnu.org; Wed, 16 Jul 2014 14:54:50 +0000 Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by waterlily.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1X7QbT-0001cQ-K8 for submit@debbugs.gnu.org; Wed, 16 Jul 2014 21:54:43 +0700 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.80) (envelope-from ) id 1X7QaL-0006mF-Et for submit@debbugs.gnu.org; Wed, 16 Jul 2014 21:53:33 +0700 From: Ivan Shmakov Date: Tue, 15 Jul 2014 18:44:28 +0000 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Message-ID: <87tx6h2w43.fsf@violet.siamics.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Package: emacs Severity: minor Even though toggle-read-only was marked as obsolete back in 2012, =?UTF-8?Q?there=E2=80=99re?= still a handful of references to it remaining in the code, most notably in vc/*.el. Consider, =?UTF-8?Q?e.=C2?= g.: [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.8 DATE_IN_PAST_12_24 Date: is 12 to 24 hours before Received: date 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Package: emacs Severity: minor Even though toggle-read-only was marked as obsolete back in 2012, =?UTF-8?Q?there=E2=80=99re?= still a handful of references to it remaining in the code, most notably in vc/*.el. Consider, =?UTF-8?Q?e.=C2?= g.: [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.8 DATE_IN_PAST_12_24 Date: is 12 to 24 hours before Received: date 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Even though toggle-read-only was marked as obsolete back in 2012, there=E2=80=99re still a handful of references to it remaining in the code, most notably in vc/*.el. Consider, e.=C2=A0g.: $ find lisp/ -type f -name \*.el \ -exec gawk 'FILENAME ~ /\/ { print FILENAME ":" FNR ":\t" $0; }' {} +=20 lisp/dired.el:1553: (define-key map [remap toggle-read-only] 'dired-tog= gle-read-only) lisp/progmodes/hideif.el:192: 'toggle-read-only 'hide-ifdef-toggle-out= side-read-only map) lisp/vc/vc-hooks.el:637: 'vc-toggle-read-only 'toggle-read-only "24.1") lisp/vc/ediff-init.el:1349: (defvar ediff-toggle-read-only-function 'toggle= -read-only lisp/vc/ediff-util.el:1030: 'toggle-read-only) lisp/vc/ediff-util.el:1031: (file-writable 'toggle-read-only) lisp/vc/ediff-util.el:1042: (setq toggle-ro-cmd 'toggle-read-only)) lisp/vc/ediff-util.el:1057: (setq toggle-ro-cmd 'toggle-read-only) lisp/vc/ediff-util.el:1063: (string-match "toggle-read-only" (symbol-nam= e toggle-ro-cmd))) $=20 For one thing, typing A or B in when using Ediff results in the respective message: `toggle-read-only' is an obsolete command (as of 24.3); use `read-only-mode= ' instead. I suggest these be replaced with read-only-mode as appropriate. TIA. --=20 FSF associate member #7257 http://boycottsystemd.org/ --=-=-= Content-Type: text/plain Content-Disposition: inline commit e7b7bf65b489c5890c4f64245769b8dc5c7fd916 Author: Stefan Monnier AuthorDate: Wed Aug 29 11:11:51 2012 -0400 * lisp/files.el (read-only-mode): New minor mode. (toggle-read-only): Use it and mark obsolete. (find-file--read-only): * lisp/vc/vc.el (vc-next-action, vc-checkout): * lisp/vc/vc-cvs.el (vc-cvs-checkout): * lisp/obsolete/vc-mcvs.el (vc-mcvs-update): * lisp/ffap.el (ffap--toggle-read-only): Update callers. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 14:04:24 2016 Received: (at control) by debbugs.gnu.org; 2 Jun 2016 18:04:24 +0000 Received: from localhost ([127.0.0.1]:52004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Wym-0005R9-JQ for submit@debbugs.gnu.org; Thu, 02 Jun 2016 14:04:24 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Wyl-0005Qx-0b for control@debbugs.gnu.org; Thu, 02 Jun 2016 14:04:23 -0400 Received: by mail-oi0-f50.google.com with SMTP id e72so89953141oib.1 for ; Thu, 02 Jun 2016 11:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to; bh=bnZ4GLt0Bf83Yx38srxDVZ7vPzcinu3MJwBpwUN4WuQ=; b=ytfq0RTqQlo88rMfOAJ/5T8EQicpDWqyyeCOrkOPZOGp3yCYPwUzcbRqgq36GMX+wz o+Hfo9KDkKw/gZ1D08JGCVI7lNTU8AiNxkKWqqnBvMwFq+ljEIlaqw438LKJjZN5U/9q ldHn7cPum2+Jgc8wYrr2cLbM1rxrGWWGt6x+g3JKLRQ8GDnixI7atPgDRtRUOGYoVpFn S98DcgpKSrLXyrlJWVF/LT+wOjdxXT78LRKkAib8fqUOh8kB55H0ITyey3TWVkUYva73 BH5CMHIIWS0YRopCjE2a3QkVauI5S7zzAUxCUY2+W07pJ4BZdXzD8Bczt4yW8bpHZ54l ZlQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to; bh=bnZ4GLt0Bf83Yx38srxDVZ7vPzcinu3MJwBpwUN4WuQ=; b=SJEwpuG2HgEIKs+/or6ecVUKKjbThg66fd+pNHQWZwwBBJZqshA8rV1QCV7XAb3riw 9pidFKjjI60oib00xBDwr8oUklaStN4WZdNv9Kv5nDR9oaGWR3V3jFXoCAxN9sXHv5b0 a4awB2EOqZZjZi/TdUIFfSYin0xhr/KewCknr6F7rszkz8N3ESnxB90SDQ5QF7rToMkG B+lJGS6ys/6VFYGz6YFJ+2mbpfPzF1kXwuukkET7GaoTvqaE63norqMLqyCEcMe4coSW 3y7RGCuECk9yuHJjRU6vNrePz+SZDbnAsY2t+UVKPrngJ0T/mE0AldJUY5XqLMc71f+d w28w== X-Gm-Message-State: ALyK8tKvNfwCvvCXuuK23MNEehaSrhNPfcSbiS4UfDbjVQGZjQrjur5PR06/0ABVh62kHLQIG0g0SgndXv4BAQ== MIME-Version: 1.0 X-Received: by 10.202.168.131 with SMTP id r125mr1973962oie.40.1464890657282; Thu, 02 Jun 2016 11:04:17 -0700 (PDT) Received: by 10.157.34.169 with HTTP; Thu, 2 Jun 2016 11:04:17 -0700 (PDT) Date: Thu, 2 Jun 2016 14:04:17 -0400 X-Google-Sender-Auth: DIbznSTbLj823hPbnjxK9_Eyc-w Message-ID: Subject: Re: bug#18039: 24.3; Broken docstring in cl-style functions From: Noam Postavsky To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) found 18039 24.5 fixed 18034 25.0.94 close 18039 merge 18039 21839 quit From unknown Mon Jun 23 18:33:56 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ivan Shmakov Subject: bug#18034: closed (Bug #18034: toggle-read-only used in the code) Message-ID: References: <87tx6h2w43.fsf@violet.siamics.net> X-Gnu-PR-Message: they-closed 18034 X-Gnu-PR-Package: emacs Reply-To: 18034@debbugs.gnu.org Date: Sun, 26 Jun 2016 05:41:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1466919662-27583-1" This is a multi-part message in MIME format... ------------=_1466919662-27583-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18034: toggle-read-only used in the code which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18034@debbugs.gnu.org. --=20 18034: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18034 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1466919662-27583-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18034-done) by debbugs.gnu.org; 26 Jun 2016 05:40:37 +0000 Received: from localhost ([127.0.0.1]:55979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o9-00079v-4G for submit@debbugs.gnu.org; Sun, 26 Jun 2016 01:40:37 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o7-00079c-V1; Sun, 26 Jun 2016 01:40:36 -0400 Received: by mail-oi0-f46.google.com with SMTP id u201so164112318oie.0; Sat, 25 Jun 2016 22:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=pGWklxGOerB4sjJ+cHyNnckUqHc3XoT1MSAP4gEtDpkagGKqwzRjfHkbtS+NaO21Sn HPl8Dmiedt1/EN2lnS4fEVdZDXaDJEB7WXnA9/zgW67YvgYQ9/z3m4j6b31+VasTcTLX rzPI0qVBQL8b/kqGZDkAwVVQibe57XvYRx7lFfMAd0cJ6KFoYkDKeNkBTymxFdlOGgVF 6GsaOEBVQneeiuGx9+zuUl7ruvbmkPPov/Hg5r4ovcueXDC03FpyqEalXjgjvMsSIom9 4q7BGQR5ZGCDWiuB2uAGy42QJPFMQdo883mnVhaVqHmNyuRyRTCzyINDu3I4fPVhiNyz tLaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=bx3bmbsBkmwsYg5U5RnIH3ja6FVQvicuE8ClhNmvP24CDuXfyg0LY/Jv1illmKfzH3 R0ivFlCSiBc53nyS+llgMvWKI+Iaq/O+2DAD9Qbk5ycKnzm49o1uxT5Pv/oQWfMKRJUF BUONANapIgEqvP5a1biLzuu+gt0zDUOEivnJMptwEYL7kPgqb/0F3pBL7JePz/7F2PH4 ONbdezuLoXFXGX/hQNihRPpNK5AoFkZWKSmjRK8hyRS6pig/h4NlrmEd5oARiHPY8DQw s2bmwThdmSExmBqm6/iXttBWV+mc77nyndTw6NhTszBbVrDgLRapZ9PoNYVRIA+3ZJF5 HXZA== X-Gm-Message-State: ALyK8tI3CundH5wGIhtXwNjUfx0oVn1SsgUQh66oAoRYkZegFhUMUOKZbyzDF96OS0JinUiyCJWBHswtQd1UMA== X-Received: by 10.202.207.16 with SMTP id f16mr6491125oig.178.1466919630353; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) From: Noam Postavsky Date: Sun, 26 Jun 2016 01:40:30 -0400 X-Google-Sender-Auth: RyP4tpJGeObNUm2OdclUvMp-jec Message-ID: Subject: Bug #18034: toggle-read-only used in the code To: GNU bug tracker automated control server , 18034-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18034-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) # I accidentally marked 18034 fixed due to typo but I meant 18039 fixed 18039 25.0.94 quit However, this bug is fixed as well. I ran the find+gawk expression against emacs-25 sources, only 3 occurences left, and they are acceptable uses kept for backwards compat reasons. I've added context to each hit: ~/src/emacs$ find emacs-25/lisp/ -type f -name \*.el -exec gawk 'FILENAME ~ /\/ { print FILENAME ":" FNR ":\t" $0; }' {} + ;; toggle-read-only is obsolete since 24.3, but since vc-t-r-o was made ;; obsolete earlier, it is ok for the latter to be an alias to the former, ;; since the latter will be removed first. We can't just make it ;; an alias for read-only-mode, since that is not 100% the same. emacs-25/lisp/vc/vc-hooks.el:573: (defalias 'vc-toggle-read-only 'toggle-read-only) (substitute-key-definition 'read-only-mode 'hide-ifdef-toggle-outside-read-only map) ;; `toggle-read-only' is obsoleted by `read-only-mode'. (substitute-key-definition emacs-25/lisp/progmodes/hideif.el:195: 'toggle-read-only 'hide-ifdef-toggle-outside-read-only map) (define-key map [remap read-only-mode] 'dired-toggle-read-only) ;; `toggle-read-only' is an obsolete alias for `read-only-mode' emacs-25/lisp/dired.el:1561: (define-key map [remap toggle-read-only] 'dired-toggle-read-only) ------------=_1466919662-27583-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Jul 2014 14:54:56 +0000 Received: from localhost ([127.0.0.1]:56673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7Qbf-0001c9-DB for submit@debbugs.gnu.org; Wed, 16 Jul 2014 10:54:55 -0400 Received: from fely.am-1.org ([78.47.74.50]:47243) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7Qbb-0001by-Oc for submit@debbugs.gnu.org; Wed, 16 Jul 2014 10:54:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Sender:Date:Subject:To:From; bh=jUtNHnSKhBu1NiU9/oAwBABN0i4p9FhhuDyjJJkgm+k=; b=U9ENh1ivcYiPEKyNlqHAX37e+XHpByeSoQHC32fRbNskHlw8JFSivmR1TEsjfln+2EUskmzSkMckHEPgKmQu+tjI6piPQKSyKYPzbYHI/Yj1P3QjJGLn2aBRjzF8Z1N7LMz8ZaOz6rvmkU32DKTS2+xz0effaZO83Ok3ulI18zc=; Received: from host-46-241-38-202.bbcustomer.zsttk.net ([46.241.38.202] helo=waterlily.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1X7Qba-00060y-8N for submit@debbugs.gnu.org; Wed, 16 Jul 2014 14:54:50 +0000 Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by waterlily.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1X7QbT-0001cQ-K8 for submit@debbugs.gnu.org; Wed, 16 Jul 2014 21:54:43 +0700 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.80) (envelope-from ) id 1X7QaL-0006mF-Et for submit@debbugs.gnu.org; Wed, 16 Jul 2014 21:53:33 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: toggle-read-only used in the code Date: Tue, 15 Jul 2014 18:44:28 +0000 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Message-ID: <87tx6h2w43.fsf@violet.siamics.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Package: emacs Severity: minor Even though toggle-read-only was marked as obsolete back in 2012, there’re still a handful of references to it remaining in the code, most notably in vc/*.el. Consider, e. g.: [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.8 DATE_IN_PAST_12_24 Date: is 12 to 24 hours before Received: date 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Package: emacs Severity: minor Even though toggle-read-only was marked as obsolete back in 2012, there’re still a handful of references to it remaining in the code, most notably in vc/*.el. Consider, e. g.: [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.8 DATE_IN_PAST_12_24 Date: is 12 to 24 hours before Received: date 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Even though toggle-read-only was marked as obsolete back in 2012, there=E2=80=99re still a handful of references to it remaining in the code, most notably in vc/*.el. Consider, e.=C2=A0g.: $ find lisp/ -type f -name \*.el \ -exec gawk 'FILENAME ~ /\/ { print FILENAME ":" FNR ":\t" $0; }' {} +=20 lisp/dired.el:1553: (define-key map [remap toggle-read-only] 'dired-tog= gle-read-only) lisp/progmodes/hideif.el:192: 'toggle-read-only 'hide-ifdef-toggle-out= side-read-only map) lisp/vc/vc-hooks.el:637: 'vc-toggle-read-only 'toggle-read-only "24.1") lisp/vc/ediff-init.el:1349: (defvar ediff-toggle-read-only-function 'toggle= -read-only lisp/vc/ediff-util.el:1030: 'toggle-read-only) lisp/vc/ediff-util.el:1031: (file-writable 'toggle-read-only) lisp/vc/ediff-util.el:1042: (setq toggle-ro-cmd 'toggle-read-only)) lisp/vc/ediff-util.el:1057: (setq toggle-ro-cmd 'toggle-read-only) lisp/vc/ediff-util.el:1063: (string-match "toggle-read-only" (symbol-nam= e toggle-ro-cmd))) $=20 For one thing, typing A or B in when using Ediff results in the respective message: `toggle-read-only' is an obsolete command (as of 24.3); use `read-only-mode= ' instead. I suggest these be replaced with read-only-mode as appropriate. TIA. --=20 FSF associate member #7257 http://boycottsystemd.org/ --=-=-= Content-Type: text/plain Content-Disposition: inline commit e7b7bf65b489c5890c4f64245769b8dc5c7fd916 Author: Stefan Monnier AuthorDate: Wed Aug 29 11:11:51 2012 -0400 * lisp/files.el (read-only-mode): New minor mode. (toggle-read-only): Use it and mark obsolete. (find-file--read-only): * lisp/vc/vc.el (vc-next-action, vc-checkout): * lisp/vc/vc-cvs.el (vc-cvs-checkout): * lisp/obsolete/vc-mcvs.el (vc-mcvs-update): * lisp/ffap.el (ffap--toggle-read-only): Update callers. --=-=-=-- ------------=_1466919662-27583-1--