From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 08:27:03 2014 Received: (at submit) by debbugs.gnu.org; 10 Jul 2014 12:27:03 +0000 Received: from localhost ([127.0.0.1]:51782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5DRD-0000Xr-8s for submit@debbugs.gnu.org; Thu, 10 Jul 2014 08:27:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56571) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5DR7-0000XX-1G for submit@debbugs.gnu.org; Thu, 10 Jul 2014 08:26:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5DQu-0004GS-AK for submit@debbugs.gnu.org; Thu, 10 Jul 2014 08:26:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5DQu-0004GO-6v for submit@debbugs.gnu.org; Thu, 10 Jul 2014 08:26:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5DQn-00023v-4v for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 08:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5DQg-0004EX-5J for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 08:26:33 -0400 Received: from mout.gmx.net ([212.227.15.19]:63505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5DQf-0004EK-QL for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 08:26:26 -0400 Received: from rosalinde.fritz.box ([89.245.109.192]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MLunc-1WxXOL27Ce-007iAC for ; Thu, 10 Jul 2014 14:26:21 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 24.3.92; doc-view-open-text raises wrong-type-argument error Date: Thu, 10 Jul 2014 14:26:18 +0200 Message-ID: <87r41twgb9.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:SgLyFCHjLndljNMd0aNvW0TDIBZHpQoWvJWzr5ie1A++Y3Ex4CV YPWLaS/1uRhxmbvDUjiTz0qh4AtnXfMyrnZn/f6PtlxzDgBPzuJMPebUQNSiDk7ZXPs8ZGq NHxFHANAAkQlDEm38iOfSN+uNGF26aA1LXOR84M9s35WiuimCq1KO9xLRsS+bhPqDzcMulG 64lNK3+KcClXQ5cb+HYlg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) If I'm using Gnus to read mail with an attachment, I can type `c' on the attachment to view it in another buffer, and if the attachment is something that Doc View can handle, I can type `C-c C-c' in the buffer to view the rendered image of the attachment. But if I then type `C-c C-t' (doc-view-open-text) to view the ascii text of the attachment, I get this error: Debugger entered--Lisp error: (wrong-type-argument stringp nil) file-name-nondirectory(nil) doc-view-open-text() call-interactively(doc-view-open-text nil nil) command-execute(doc-view-open-text) The reason is that Doc View expects the buffer to be visiting a file. But with an mail attachment, that does not have to be the case (when I type `C-c C-c', Doc View says: "The buffer has been modified. Save the changes? (y or n)", but if I answer "n", it still renders the image). The following patch lets me view the ascii text whether or not the buffer containing the document is visiting a file. (The patch is against emacs-24; the error also happens in trunk.) Steve Berman In GNU Emacs 24.3.92.7 (x86_64-suse-linux-gnu, GTK+ Version 3.10.4) of 2014-07-10 on rosalinde Repository revision: 117368 monnier@iro.umontreal.ca-20140709185406-m0q0fjepl42pcrqx Windowing system distributor `The X.Org Foundation', version 11.0.11403901 System Description: openSUSE 13.1 (Bottle) (x86_64) Configured using: `configure --without-toolkit-scroll-bars CFLAGS=-g3' Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix === modified file 'lisp/doc-view.el' *** lisp/doc-view.el 2014-04-04 17:42:55 +0000 --- lisp/doc-view.el 2014-07-10 11:54:18 +0000 *************** *** 1402,1412 **** (interactive) (if doc-view--current-converter-processes (message "DocView: please wait till conversion finished.") ! (let ((txt (expand-file-name "doc.txt" (doc-view--current-cache-dir)))) (if (file-readable-p txt) (let ((name (concat "Text contents of " ! (file-name-nondirectory buffer-file-name))) ! (dir (file-name-directory buffer-file-name))) (with-current-buffer (find-file txt) (rename-buffer name) (setq default-directory dir))) --- 1402,1413 ---- (interactive) (if doc-view--current-converter-processes (message "DocView: please wait till conversion finished.") ! (let ((txt (expand-file-name "doc.txt" (doc-view--current-cache-dir))) ! (bname (or buffer-file-name (buffer-name)))) (if (file-readable-p txt) (let ((name (concat "Text contents of " ! (file-name-nondirectory bname))) ! (dir (or (file-name-directory bname) default-directory))) (with-current-buffer (find-file txt) (rename-buffer name) (setq default-directory dir))) From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 28 05:12:11 2014 Received: (at 17985-close) by debbugs.gnu.org; 28 Jul 2014 09:12:11 +0000 Received: from localhost ([127.0.0.1]:40153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBgyZ-0003lX-4W for submit@debbugs.gnu.org; Mon, 28 Jul 2014 05:12:11 -0400 Received: from deliver.uni-koblenz.de ([141.26.64.15]:51577) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBgyW-0003lM-H2 for 17985-close@debbugs.gnu.org; Mon, 28 Jul 2014 05:12:09 -0400 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 14A0D1A8499; Mon, 28 Jul 2014 11:12:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iJCoiBri3D27; Mon, 28 Jul 2014 11:12:06 +0200 (CEST) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from thinkpad-t440p (dhcp201.uni-koblenz.de [141.26.71.201]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id AF2501A8493; Mon, 28 Jul 2014 11:12:06 +0200 (CEST) From: Tassilo Horn To: Stephen Berman Subject: Re: bug#17985: 24.3.92; doc-view-open-text raises wrong-type-argument error References: <87r41twgb9.fsf@rosalinde.fritz.box> Date: Mon, 28 Jul 2014 11:10:06 +0200 In-Reply-To: <87r41twgb9.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Thu, 10 Jul 2014 14:26:18 +0200") Message-ID: <87d2cpg87l.fsf@gnu.org> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 17985-close Cc: 17985-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Stephen Berman writes: > If I'm using Gnus to read mail with an attachment, I can type `c' on > the attachment to view it in another buffer, and if the attachment is > something that Doc View can handle, I can type `C-c C-c' in the buffer > to view the rendered image of the attachment. But if I then type `C-c > C-t' (doc-view-open-text) to view the ascii text of the attachment, I > get this error: > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > file-name-nondirectory(nil) > doc-view-open-text() > call-interactively(doc-view-open-text nil nil) > command-execute(doc-view-open-text) > > The reason is that Doc View expects the buffer to be visiting a file. > But with an mail attachment, that does not have to be the case (when I > type `C-c C-c', Doc View says: "The buffer has been modified. Save the > changes? (y or n)", but if I answer "n", it still renders the image). > The following patch lets me view the ascii text whether or not the > buffer containing the document is visiting a file. (The patch is > against emacs-24; the error also happens in trunk.) Thanks, I've committed it on the trunk. (As it's not a regression, I don't think it should go in emacs-24.) ,---- | revno: 117599 | author: Stephen Berman | committer: Tassilo Horn | branch nick: trunk | timestamp: Mon 2014-07-28 11:07:56 +0200 | message: | Open doc text also if it's not saved to a file. | | * doc-view.el (doc-view-open-text): Don't require that the | document is saved in a file (e.g., email attachment). `---- Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 28 05:21:21 2014 Received: (at 17985) by debbugs.gnu.org; 28 Jul 2014 09:21:21 +0000 Received: from localhost ([127.0.0.1]:40164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBh7M-00040g-S0 for submit@debbugs.gnu.org; Mon, 28 Jul 2014 05:21:20 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:59597) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBh7J-00040N-JW for 17985@debbugs.gnu.org; Mon, 28 Jul 2014 05:21:14 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0N9F009000K67S00@mtaout28.012.net.il> for 17985@debbugs.gnu.org; Mon, 28 Jul 2014 12:20:55 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9F00NIF0MVN1C0@mtaout28.012.net.il>; Mon, 28 Jul 2014 12:20:55 +0300 (IDT) Date: Mon, 28 Jul 2014 12:21:22 +0300 From: Eli Zaretskii Subject: Re: bug#17985: 24.3.92; doc-view-open-text raises wrong-type-argument error In-reply-to: <87d2cpg87l.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: Tassilo Horn Message-id: <83lhrdhm99.fsf@gnu.org> References: <87r41twgb9.fsf@rosalinde.fritz.box> <87d2cpg87l.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17985 Cc: tsdh@gnu.org, stephen.berman@gmx.net, 17985@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Tassilo Horn > Date: Mon, 28 Jul 2014 11:10:06 +0200 > Cc: 17985-close@debbugs.gnu.org > > Thanks, I've committed it on the trunk. (As it's not a regression, I > don't think it should go in emacs-24.) IMO, as the bug is quite an annoyance, and the fix is so simple and obviously correct, it should go to emacs-24. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 28 05:35:45 2014 Received: (at 17985) by debbugs.gnu.org; 28 Jul 2014 09:35:45 +0000 Received: from localhost ([127.0.0.1]:40174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBhLI-0004Na-SI for submit@debbugs.gnu.org; Mon, 28 Jul 2014 05:35:44 -0400 Received: from deliver.uni-koblenz.de ([141.26.64.15]:56893) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBhLC-0004NM-9u for 17985@debbugs.gnu.org; Mon, 28 Jul 2014 05:35:38 -0400 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id A74E31A84A2; Mon, 28 Jul 2014 11:35:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vdNyGaUmpPO0; Mon, 28 Jul 2014 11:35:33 +0200 (CEST) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from thinkpad-t440p (dhcp201.uni-koblenz.de [141.26.71.201]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 5DE3F1A849A; Mon, 28 Jul 2014 11:35:33 +0200 (CEST) From: Tassilo Horn To: Eli Zaretskii Subject: Re: bug#17985: 24.3.92; doc-view-open-text raises wrong-type-argument error References: <87r41twgb9.fsf@rosalinde.fritz.box> <87d2cpg87l.fsf@gnu.org> <83lhrdhm99.fsf@gnu.org> Date: Mon, 28 Jul 2014 11:33:32 +0200 In-Reply-To: <83lhrdhm99.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 28 Jul 2014 12:21:22 +0300") Message-ID: <878undg74j.fsf@gnu.org> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 17985 Cc: stephen.berman@gmx.net, 17985@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Eli Zaretskii writes: >> Thanks, I've committed it on the trunk. (As it's not a regression, I >> don't think it should go in emacs-24.) > > IMO, as the bug is quite an annoyance, and the fix is so simple and > obviously correct, it should go to emacs-24. Ok, done. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 28 06:07:36 2014 Received: (at 17985) by debbugs.gnu.org; 28 Jul 2014 10:07:36 +0000 Received: from localhost ([127.0.0.1]:40209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBhq7-0005Bg-M7 for submit@debbugs.gnu.org; Mon, 28 Jul 2014 06:07:35 -0400 Received: from mout.gmx.net ([212.227.17.21]:54350) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBhq2-0005BN-AS for 17985@debbugs.gnu.org; Mon, 28 Jul 2014 06:07:30 -0400 Received: from rosalinde.fritz.box ([89.245.80.115]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Lxt3Q-1WOOyQ30Kq-015MHa; Mon, 28 Jul 2014 12:07:18 +0200 From: Stephen Berman To: Tassilo Horn Subject: Re: bug#17985: 24.3.92; doc-view-open-text raises wrong-type-argument error References: <87r41twgb9.fsf@rosalinde.fritz.box> <87d2cpg87l.fsf@gnu.org> <83lhrdhm99.fsf@gnu.org> <878undg74j.fsf@gnu.org> Date: Mon, 28 Jul 2014 12:07:18 +0200 In-Reply-To: <878undg74j.fsf@gnu.org> (Tassilo Horn's message of "Mon, 28 Jul 2014 11:33:32 +0200") Message-ID: <87oaw96bl5.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:9y/z308pkjHAl0VAwyHl5dof3Sm0IfyXBWLbQLL4RXLV1SZ48eG YkdLH3h/eMhjp4y8eqowT9/zLlOYDL+IjOg4gVLJlm0uKETeeNNB/hnnYbvnT1zh3d6E89R IcVmHE/dCaPUEHF2HDOFXDlDhnqfurkpeGMWMt5KpvWouMH/PfGIICNrSUvZXZ19NHvb7Ah DT0NVFKYFcCMVYM7uU2Kw== X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 17985 Cc: Eli Zaretskii , 17985@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On Mon, 28 Jul 2014 11:33:32 +0200 Tassilo Horn wrote: > Eli Zaretskii writes: > >>> Thanks, I've committed it on the trunk. (As it's not a regression, I >>> don't think it should go in emacs-24.) >> >> IMO, as the bug is quite an annoyance, and the fix is so simple and >> obviously correct, it should go to emacs-24. > > Ok, done. Thanks. Steve Berman From unknown Mon Aug 18 14:22:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 25 Aug 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator