GNU bug report logs - #17970
log-edit creates unwanted ChangeLog buffers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Subject: bug#17970: closed (Re: bug#17970: log-edit creates unwanted
 ChangeLog buffers)
Date: Wed, 09 Jul 2014 18:56:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#17970: log-edit creates unwanted ChangeLog buffers

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17970 <at> debbugs.gnu.org.

-- 
17970: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17970
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17970-done <at> debbugs.gnu.org
Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers
Date: Wed, 09 Jul 2014 14:54:57 -0400

> C-x C-b
-> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer.

I installed the patch below which seems to fix this problem.


        Stefan


=== modified file 'lisp/vc/log-edit.el'
--- lisp/vc/log-edit.el	2014-07-01 15:15:03 +0000
+++ lisp/vc/log-edit.el	2014-07-09 18:52:47 +0000
@@ -905,6 +905,7 @@
              ;; that memoizing which is undesired here.
              (setq change-log-default-name nil)
              (find-change-log)))))
+    (when (file-exists-p changelog-file-name)
     (with-current-buffer (find-file-noselect changelog-file-name)
       (unless (eq major-mode 'change-log-mode) (change-log-mode))
       (goto-char (point-min))
@@ -942,7 +943,7 @@
                   (setq pos (max (1+ pos) (elt entry 1)))
 		  (goto-char pos)))
 
-	      (cons (current-buffer) texts))))))))
+                (cons (current-buffer) texts)))))))))
 
 (defun log-edit-changelog-insert-entries (buffer beg end &rest files)
   "Insert the text from BUFFER between BEG and END.

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: log-edit creates unwanted ChangeLog buffers
Date: Mon, 07 Jul 2014 22:35:39 -0400

Package: emacs
Version: 24.3.92
Severity: minor

## Just making a test repo:
mkdir /tmp/foo
cd /tmp/foo
bzr init
touch 1
bzr add 1

emacs -Q 1
C-x v v
enter some log message
C-c C-c

C-x C-b
  -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer.


I wish it would not create the ChangeLog buffer (especially when the
the repo does not use ChangeLogs).

Emacs 24.3 does not create these buffers.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.