From unknown Fri Jun 20 07:20:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17970 <17970@debbugs.gnu.org> To: bug#17970 <17970@debbugs.gnu.org> Subject: Status: log-edit creates unwanted ChangeLog buffers Reply-To: bug#17970 <17970@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:20:07 +0000 retitle 17970 log-edit creates unwanted ChangeLog buffers reassign 17970 emacs submitter 17970 Glenn Morris severity 17970 important thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 07 22:35:42 2014 Received: (at submit) by debbugs.gnu.org; 8 Jul 2014 02:35:42 +0000 Received: from localhost ([127.0.0.1]:46383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4LFu-0006bj-2v for submit@debbugs.gnu.org; Mon, 07 Jul 2014 22:35:42 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:42073 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4LFs-0006ba-GN for submit@debbugs.gnu.org; Mon, 07 Jul 2014 22:35:40 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4LFr-0008IW-KI; Mon, 07 Jul 2014 22:35:39 -0400 From: Glenn Morris To: submit@debbugs.gnu.org Subject: log-edit creates unwanted ChangeLog buffers X-Spook: munitions AMEMB Peking clones John Kerry interception CDC X-Ran: 0jLJf8x=Dwd'(`fk)Q}-:k>#g!%nTX(3zf`_9.S9,hB<(3;@+1ze User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Package: emacs Version: 24.3.92 Severity: minor ## Just making a test repo: mkdir /tmp/foo cd /tmp/foo bzr init touch 1 bzr add 1 emacs -Q 1 C-x v v enter some log message C-c C-c C-x C-b -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer. I wish it would not create the ChangeLog buffer (especially when the the repo does not use ChangeLogs). Emacs 24.3 does not create these buffers. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 08 14:08:46 2014 Received: (at control) by debbugs.gnu.org; 8 Jul 2014 18:08:46 +0000 Received: from localhost ([127.0.0.1]:47215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4Zon-0003Uc-Hw for submit@debbugs.gnu.org; Tue, 08 Jul 2014 14:08:46 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:12991) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4Zoh-0003UI-Jb for control@debbugs.gnu.org; Tue, 08 Jul 2014 14:08:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArQGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEVjMLNBIUGA2IMNIZF48BFoQiBKkZgWqDTCE X-IPAS-Result: ArQGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEVjMLNBIUGA2IMNIZF48BFoQiBKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="76888080" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Jul 2014 14:08:29 -0400 Received: by pastel.home (Postfix, from userid 20848) id DA5BD60337; Tue, 8 Jul 2014 14:08:29 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers Message-ID: References: Date: Tue, 08 Jul 2014 14:08:29 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 07 Jul 2014 22:35:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) severity 17970 important thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 03:09:29 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 07:09:29 +0000 Received: from localhost ([127.0.0.1]:47499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4m0O-0006jk-PH for submit@debbugs.gnu.org; Wed, 09 Jul 2014 03:09:29 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39938 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4m0L-0006jY-Ae for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 03:09:27 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4m0J-000688-Mm; Wed, 09 Jul 2014 03:09:23 -0400 From: Glenn Morris To: 17970@debbugs.gnu.org Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers References: X-Spook: propaganda underground cryptographic nitrate top secret X-Ran: +^I'<`%5:s0!e!C,w)R:~+b5dC.1UU@FJZ^kn`7O~p5!3c7kY_:tC[LU{XJ{01j*C\5f)1 X-Hue: red X-Attribution: GM Date: Wed, 09 Jul 2014 03:09:23 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 07 Jul 2014 22:35:39 -0400") Message-ID: <9u61j79ffg.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17970 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Glenn Morris wrote: > C-x v v [...] > -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer. It looks like this has the same cause as http://debbugs.gnu.org/17884, namely the fact that vc-next-action now calls log-edit with SETUP = t. This runs log-edit-hook, which runs log-edit-insert-changelog, which ends up running log-edit-changelog-entries, which visits the ChangeLog files, even if they don't exist. Perhaps log-edit-changelog-entries should not bother visiting non-existent files. (Could it use invisible buffers?) From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 09:55:39 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 13:55:40 +0000 Received: from localhost ([127.0.0.1]:47854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4sLS-0003L5-IY for submit@debbugs.gnu.org; Wed, 09 Jul 2014 09:55:39 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:51834) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4sLM-0003Jk-Ns for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 09:55:34 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0N8G00I0069SWS00@mtaout28.012.net.il> for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 16:54:55 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8G00GXB6NJPU30@mtaout28.012.net.il>; Wed, 09 Jul 2014 16:54:55 +0300 (IDT) Date: Wed, 09 Jul 2014 16:55:24 +0300 From: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers In-reply-to: <9u61j79ffg.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il To: Glenn Morris Message-id: <83d2ded4c3.fsf@gnu.org> References: <9u61j79ffg.fsf@fencepost.gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Glenn Morris > Date: Wed, 09 Jul 2014 03:09:23 -0400 > > Perhaps log-edit-changelog-entries should not bother visiting > non-existent files. That wouldn't be TRT when starting a new repository, or a new directory in an existing one. It sounds like a user option is in order. In addition, if the ignore file mentions ChangeLog, the command could deduce automatically what is TRT. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 11:41:39 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 15:41:39 +0000 Received: from localhost ([127.0.0.1]:47978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4u03-0000V0-46 for submit@debbugs.gnu.org; Wed, 09 Jul 2014 11:41:39 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:47817 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4u00-0000Us-5q for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 11:41:36 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4tzz-00024o-7D; Wed, 09 Jul 2014 11:41:35 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> X-Spook: assassinate UMTS JFK lock picking CID Mole enigma Fedayeen X-Ran: WY?hEJ&sP6du{0$2-&{lL9ZPQka=Gz=%wux6zu]a.E0M0"Vv2CPO*#mt1k{waY!f?=c;4T X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 09 Jul 2014 11:41:35 -0400 In-Reply-To: <83d2ded4c3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Jul 2014 16:55:24 +0300") Message-ID: <16r41uh74g.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Eli Zaretskii wrote: >> Perhaps log-edit-changelog-entries should not bother visiting >> non-existent files. > > That wouldn't be TRT when starting a new repository, or a new > directory in an existing one. What benefit is there to vc-next-action creating empty ChangeLog buffers in such cases? > In addition, if the ignore file mentions ChangeLog, the command could > deduce automatically what is TRT. (Then we need an ignore-file parser.) Why would you have an unversioned ChangeLog, and why would this matter to vc-next-action? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 12:28:21 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 16:28:22 +0000 Received: from localhost ([127.0.0.1]:47985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4ujB-0001ur-A4 for submit@debbugs.gnu.org; Wed, 09 Jul 2014 12:28:21 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:49633) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4uj8-0001uR-5k for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 12:28:15 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0N8G00300DB0OU00@mtaout28.012.net.il> for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 19:27:37 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8G000GGDQ1NT40@mtaout28.012.net.il>; Wed, 09 Jul 2014 19:27:37 +0300 (IDT) Date: Wed, 09 Jul 2014 19:28:07 +0300 From: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers In-reply-to: <16r41uh74g.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il To: Glenn Morris Message-id: <8361j6cx9k.fsf@gnu.org> References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <16r41uh74g.fsf@fencepost.gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Glenn Morris > Cc: 17970@debbugs.gnu.org > Date: Wed, 09 Jul 2014 11:41:35 -0400 > > Eli Zaretskii wrote: > > >> Perhaps log-edit-changelog-entries should not bother visiting > >> non-existent files. > > > > That wouldn't be TRT when starting a new repository, or a new > > directory in an existing one. > > What benefit is there to vc-next-action creating empty ChangeLog buffers > in such cases? To let me _create_ one. > > In addition, if the ignore file mentions ChangeLog, the command could > > deduce automatically what is TRT. > > (Then we need an ignore-file parser.) With one file name per line, I wouldn't call it a "parser", really. > Why would you have an unversioned ChangeLog I didn't say I would. What I meant was that if ChangeLog is in the ignore file, that's a sign that a non-existent ChangeLog file should not be visited, since this repository doesn't want such files. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 12:39:43 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 16:39:43 +0000 Received: from localhost ([127.0.0.1]:47995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4uu9-0002Jw-IP for submit@debbugs.gnu.org; Wed, 09 Jul 2014 12:39:43 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:49121 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4uu0-0002Je-VW for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 12:39:34 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4uu0-0003r6-4r; Wed, 09 Jul 2014 12:39:28 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <16r41uh74g.fsf@fencepost.gnu.org> <8361j6cx9k.fsf@gnu.org> X-Spook: NSA high security warfare BLU-114/B industrial espionage X-Ran: "5O%IUOa~tW+gO.5):87JcP&74X3)!6E_w}Y{Bc{ChO<_mS5r,<:$e$bqCHy{|{b@`SuV? X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 09 Jul 2014 12:39:28 -0400 In-Reply-To: <8361j6cx9k.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Jul 2014 19:28:07 +0300") Message-ID: <00k37m32rj.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.9 (----) Eli Zaretskii wrote: >> What benefit is there to vc-next-action creating empty ChangeLog buffers >> in such cases? > > To let me _create_ one. The point of this stuff is to prepopulate the vc log buffer with the relevant ChangeLog entries. If the ChangeLog does not exist, then obviously it is not going to find any. It does not show you the ChangeLog buffer that it creates or in any way notify you, so I do not see how this would help you in the scenario that you meant to write a ChangeLog entry but forgot, which I presume is what you were referring to. Could you give an example? >> (Then we need an ignore-file parser.) > > With one file name per line, I wouldn't call it a "parser", really. They contain wildcards, ! and ** patterns, etc. >> Why would you have an unversioned ChangeLog > > I didn't say I would. What I meant was that if ChangeLog is in the > ignore file, that's a sign that a non-existent ChangeLog file should > not be visited, since this repository doesn't want such files. Why would you ignore a file that it not expected to exist in your repo? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 12:54:27 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 16:54:27 +0000 Received: from localhost ([127.0.0.1]:47999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4v8U-0002lh-AD for submit@debbugs.gnu.org; Wed, 09 Jul 2014 12:54:26 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:34974) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4v8R-0002lG-An for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 12:54:24 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N8G00M00ER2F800@a-mtaout23.012.net.il> for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 19:54:16 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8G00M3UEYGE530@a-mtaout23.012.net.il>; Wed, 09 Jul 2014 19:54:16 +0300 (IDT) Date: Wed, 09 Jul 2014 19:54:16 +0300 From: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers In-reply-to: <00k37m32rj.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il To: Glenn Morris Message-id: <831ttucw1z.fsf@gnu.org> References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <16r41uh74g.fsf@fencepost.gnu.org> <8361j6cx9k.fsf@gnu.org> <00k37m32rj.fsf@fencepost.gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Glenn Morris > Cc: 17970@debbugs.gnu.org > Date: Wed, 09 Jul 2014 12:39:28 -0400 > > The point of this stuff is to prepopulate the vc log buffer with the > relevant ChangeLog entries. If the ChangeLog does not exist, then > obviously it is not going to find any. It does not show you the > ChangeLog buffer that it creates or in any way notify you, so I do not > see how this would help you in the scenario that you meant to write a > ChangeLog entry but forgot, which I presume is what you were referring > to. Could you give an example? > > >> (Then we need an ignore-file parser.) > > > > With one file name per line, I wouldn't call it a "parser", really. > > They contain wildcards, ! and ** patterns, etc. > > >> Why would you have an unversioned ChangeLog > > > > I didn't say I would. What I meant was that if ChangeLog is in the > > ignore file, that's a sign that a non-existent ChangeLog file should > > not be visited, since this repository doesn't want such files. > > Why would you ignore a file that it not expected to exist in your repo? I don't really know what else to say. I've written everything I could about this, and it sounds pretty clear to me. If none of that makes sense, feel free to ignore. I will know to keep my mouth shut next time. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 14:55:28 2014 Received: (at 17970-done) by debbugs.gnu.org; 9 Jul 2014 18:55:28 +0000 Received: from localhost ([127.0.0.1]:48077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4x1a-0006UL-MK for submit@debbugs.gnu.org; Wed, 09 Jul 2014 14:55:27 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:39539) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4x1X-0006UC-Al for 17970-done@debbugs.gnu.org; Wed, 09 Jul 2014 14:55:23 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 39E3984E39; Wed, 9 Jul 2014 14:55:22 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 515731E5B74; Wed, 9 Jul 2014 14:54:57 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 1AB62B4167; Wed, 9 Jul 2014 14:54:57 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers Message-ID: References: Date: Wed, 09 Jul 2014 14:54:57 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 07 Jul 2014 22:35:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17970-done Cc: 17970-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > C-x C-b -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer. I installed the patch below which seems to fix this problem. Stefan === modified file 'lisp/vc/log-edit.el' --- lisp/vc/log-edit.el 2014-07-01 15:15:03 +0000 +++ lisp/vc/log-edit.el 2014-07-09 18:52:47 +0000 @@ -905,6 +905,7 @@ ;; that memoizing which is undesired here. (setq change-log-default-name nil) (find-change-log))))) + (when (file-exists-p changelog-file-name) (with-current-buffer (find-file-noselect changelog-file-name) (unless (eq major-mode 'change-log-mode) (change-log-mode)) (goto-char (point-min)) @@ -942,7 +943,7 @@ (setq pos (max (1+ pos) (elt entry 1))) (goto-char pos))) - (cons (current-buffer) texts)))))))) + (cons (current-buffer) texts))))))))) (defun log-edit-changelog-insert-entries (buffer beg end &rest files) "Insert the text from BUFFER between BEG and END. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 16:17:23 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 20:17:23 +0000 Received: from localhost ([127.0.0.1]:48129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4yIt-0001do-7A for submit@debbugs.gnu.org; Wed, 09 Jul 2014 16:17:23 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:52867 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4yIr-0001dh-6c for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 16:17:21 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4yIq-0003J1-A6; Wed, 09 Jul 2014 16:17:20 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <16r41uh74g.fsf@fencepost.gnu.org> <8361j6cx9k.fsf@gnu.org> <00k37m32rj.fsf@fencepost.gnu.org> <831ttucw1z.fsf@gnu.org> X-Spook: underground clandestine World Trade Center Ansar al-Islam X-Ran: >d"#vdg%I9Ve[.`o%3:V>DJ&2/Eoh*MHNWoyJ4fhY`k~N|$L!;2~TQN41(EQ1mse>e7,w' X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 09 Jul 2014 16:17:20 -0400 In-Reply-To: <831ttucw1z.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Jul 2014 19:54:16 +0300") Message-ID: <19simae17z.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Eli Zaretskii wrote: > I don't really know what else to say. I've written everything I could > about this, and it sounds pretty clear to me. If none of that makes > sense, feel free to ignore. I will know to keep my mouth shut next > time. Sorry, but it basically made no sense to me. It didn't seem to bear any relation to what this report was (IMO) about. I wasn't trying to be difficult or anything like that. Never mind! :) From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 16:19:24 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 20:19:24 +0000 Received: from localhost ([127.0.0.1]:48133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4yKp-0001hn-PH for submit@debbugs.gnu.org; Wed, 09 Jul 2014 16:19:24 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:52902 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4yKm-0001hb-Ej for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 16:19:21 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4yKl-0003WW-SE; Wed, 09 Jul 2014 16:19:19 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers References: X-Spook: Legion of Doom enigma White Water bomb Defcon Lon X-Ran: vVZ5#[BJ_<$iDo/]~g]hy0Nq5m`i/FgC7C)UQ?@.@mT&2"ObO[2Zvb,llL4&}AK4*S!~)0 X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 09 Jul 2014 16:19:19 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Jul 2014 14:54:57 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Stefan Monnier wrote: > I installed the patch below which seems to fix this problem. Thanks. I'm still going to find it a bit irritating when the file _does_ exist. Why can't it use hidden buffers? Is it in case you have edited but not saved the ChangeLog? If so, could it use (or (find-buffer-visiting ...) )? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 18:22:21 2014 Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 22:22:21 +0000 Received: from localhost ([127.0.0.1]:48222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X50Fo-0005dK-QT for submit@debbugs.gnu.org; Wed, 09 Jul 2014 18:22:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:32717) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X50Fm-0005d6-P4 for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 18:22:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77013626" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 09 Jul 2014 18:22:12 -0400 Received: by pastel.home (Postfix, from userid 20848) id 8D36A60A86; Wed, 9 Jul 2014 18:22:12 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers Message-ID: References: Date: Wed, 09 Jul 2014 18:22:12 -0400 In-Reply-To: (Glenn Morris's message of "Wed, 09 Jul 2014 16:19:19 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17970 Cc: 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> I installed the patch below which seems to fix this problem. > Thanks. > I'm still going to find it a bit irritating when the file _does_ exist. Indeed for those very projects that don't use a ChangeLog but do auto-generate one, it could be a bit annoying. But I don't think it's a very serious issue. > Why can't it use hidden buffers? > Is it in case you have edited but not saved the ChangeLog? Yes. > If so, could it use (or (find-buffer-visiting ...) )? It could do that, indeed. Or it could kill the buffer at the end if the buffer didn't exist earlier. It seems more trouble than it's worth, tho. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 09 23:09:11 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 03:09:11 +0000 Received: from localhost ([127.0.0.1]:51531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X54jO-0006la-C7 for submit@debbugs.gnu.org; Wed, 09 Jul 2014 23:09:11 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:16109) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X54jL-0006lK-S7 for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 23:09:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77034901" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 09 Jul 2014 23:09:02 -0400 Received: by pastel.home (Postfix, from userid 20848) id 25C2260A86; Wed, 9 Jul 2014 23:09:02 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers Message-ID: References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> Date: Wed, 09 Jul 2014 23:09:02 -0400 In-Reply-To: <83d2ded4c3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Jul 2014 16:55:24 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17970 Cc: Glenn Morris , 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Perhaps log-edit-changelog-entries should not bother visiting >> non-existent files. > That wouldn't be TRT when starting a new repository, or a new > directory in an existing one. Of course it's correct. You misunderstand the purpose of log-edit-changelog-entries: it's not there to fill the ChangeLog but to extract pre-existing text from it to fill the *VC-Log* buffer. So if the file doesn't exist, there's nothing to get from it and we might as well not visit the file. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 10:59:57 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 14:59:57 +0000 Received: from localhost ([127.0.0.1]:52287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5FpB-0005O9-4g for submit@debbugs.gnu.org; Thu, 10 Jul 2014 10:59:56 -0400 Received: from mtaout29.012.net.il ([80.179.55.185]:56628) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Fp5-0005Nj-G7 for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 10:59:51 -0400 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N8I00N0043M7C00@mtaout29.012.net.il> for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 17:59:39 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8I00NVN4BEHQ00@mtaout29.012.net.il>; Thu, 10 Jul 2014 17:59:39 +0300 (IDT) Date: Thu, 10 Jul 2014 17:59:43 +0300 From: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83wqblb6ow.fsf@gnu.org> References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17970 Cc: rgm@gnu.org, 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: Glenn Morris , 17970@debbugs.gnu.org > Date: Wed, 09 Jul 2014 23:09:02 -0400 > > You misunderstand the purpose of log-edit-changelog-entries No, I don't misunderstand. > So if the file doesn't exist, there's nothing to get from it and we > might as well not visit the file. What if I already did "C-x 4 a", which visited a non-existing ChangeLog, and wrote my entry, but didn't yet save that buffer? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 12:46:07 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 16:46:07 +0000 Received: from localhost ([127.0.0.1]:52399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HTt-0000VB-UZ for submit@debbugs.gnu.org; Thu, 10 Jul 2014 12:46:06 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39055) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HTn-0000UX-HE for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 12:46:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77080661" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jul 2014 12:45:49 -0400 Received: by pastel.home (Postfix, from userid 20848) id 6C64B604AF; Thu, 10 Jul 2014 12:45:49 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers Message-ID: References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <83wqblb6ow.fsf@gnu.org> Date: Thu, 10 Jul 2014 12:45:49 -0400 In-Reply-To: <83wqblb6ow.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Jul 2014 17:59:43 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17970 Cc: rgm@gnu.org, 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> So if the file doesn't exist, there's nothing to get from it and we >> might as well not visit the file. > What if I already did "C-x 4 a", which visited a non-existing > ChangeLog, and wrote my entry, but didn't yet save that buffer? I guess that would make sense, indeed. Could you refine my patch so as to handle that case? Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 12:54:57 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 16:54:57 +0000 Received: from localhost ([127.0.0.1]:52414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HcR-0000nU-Pz for submit@debbugs.gnu.org; Thu, 10 Jul 2014 12:54:57 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:48058 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HcK-0000nC-Ge for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 12:54:49 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X5HcJ-0003h0-I0; Thu, 10 Jul 2014 12:54:43 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <83wqblb6ow.fsf@gnu.org> X-Spook: Belknap Albanian explosion SEAL Team 6 Vince Foster X-Ran: ,ty#/Wyo#kNUo7;*.a]%CnIh$zr1?^V"hmH4N)aCG7n~nhG,MVk`l1[4q>roz*CS.et401 X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 10 Jul 2014 12:54:43 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 10 Jul 2014 12:45:49 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17970 Cc: Eli Zaretskii , 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Stefan Monnier wrote: >> What if I already did "C-x 4 a", which visited a non-existing >> ChangeLog, and wrote my entry, but didn't yet save that buffer? Then you get punished for not committing your ChangeLog at the same time as the associated commit. ;) > I guess that would make sense, indeed. Could you refine my patch so > as to handle that case? (or (find-buffer-visiting changelog-file-name) (file-exists-p changelog-file-name)) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 13:18:15 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 17:18:15 +0000 Received: from localhost ([127.0.0.1]:52441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Hz4-0002nf-0d for submit@debbugs.gnu.org; Thu, 10 Jul 2014 13:18:14 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:2388) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Hz2-0002nT-9l for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 13:18:12 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77086572" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jul 2014 13:18:05 -0400 Received: by pastel.home (Postfix, from userid 20848) id 458CE604AF; Thu, 10 Jul 2014 13:18:05 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers Message-ID: References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <83wqblb6ow.fsf@gnu.org> Date: Thu, 10 Jul 2014 13:18:05 -0400 In-Reply-To: (Glenn Morris's message of "Thu, 10 Jul 2014 12:54:43 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17970 Cc: Eli Zaretskii , 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >>> What if I already did "C-x 4 a", which visited a non-existing >>> ChangeLog, and wrote my entry, but didn't yet save that buffer? > Then you get punished for not committing your ChangeLog at the same time > as the associated commit. ;) But this case is actually interesting because for repositories such as `elpa' which don't use ChangeLogs but do want to use the ChangeLog conventions in the commit message, a way to do that is to use C-x 4 a to fill the ChangeLog buffer but you won't want to save this buffer. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 13:22:59 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 17:22:59 +0000 Received: from localhost ([127.0.0.1]:52445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5I3e-0002xr-Bq for submit@debbugs.gnu.org; Thu, 10 Jul 2014 13:22:58 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:56169) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5I3b-0002xR-AF for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 13:22:57 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0N8I00I00ACRL900@mtaout28.012.net.il> for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 20:22:21 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8I00HOCAX9XF20@mtaout28.012.net.il>; Thu, 10 Jul 2014 20:22:21 +0300 (IDT) Date: Thu, 10 Jul 2014 20:22:51 +0300 From: Eli Zaretskii Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83ion5b02c.fsf@gnu.org> References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <83wqblb6ow.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17970 Cc: rgm@gnu.org, 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: Eli Zaretskii , 17970@debbugs.gnu.org > Date: Thu, 10 Jul 2014 13:18:05 -0400 > > >>> What if I already did "C-x 4 a", which visited a non-existing > >>> ChangeLog, and wrote my entry, but didn't yet save that buffer? > > Then you get punished for not committing your ChangeLog at the same time > > as the associated commit. ;) > > But this case is actually interesting because for repositories such as > `elpa' which don't use ChangeLogs but do want to use the ChangeLog > conventions in the commit message, a way to do that is to use C-x 4 a to > fill the ChangeLog buffer but you won't want to save this buffer. Not just elpa, but other projects as well. Guile and Coreutils, for example. That's how I bumped into this use case. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 13:46:13 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 17:46:13 +0000 Received: from localhost ([127.0.0.1]:52461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5IQ4-0003hf-48 for submit@debbugs.gnu.org; Thu, 10 Jul 2014 13:46:13 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:49030 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5IPx-0003h1-Jv for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 13:46:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X5IPw-0004wk-Jy; Thu, 10 Jul 2014 13:46:00 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <83wqblb6ow.fsf@gnu.org> X-Spook: genetic SWAT cybercash nuclear SSL Lexis-Nexis SDI IMF X-Ran: O0E,;_)R.77+8FmqKuJYn4snUYXK)-Y4!u,1iq+`hL~1h},jbdO X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 10 Jul 2014 13:46:00 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 10 Jul 2014 13:18:05 -0400") Message-ID: <3afvi9150n.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17970 Cc: Eli Zaretskii , 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Stefan Monnier wrote: > But this case is actually interesting because for repositories such as > `elpa' which don't use ChangeLogs but do want to use the ChangeLog > conventions in the commit message, a way to do that is to use C-x 4 a to > fill the ChangeLog buffer but you won't want to save this buffer. Sounds like Emacs should provide a better mechanism for this, rather than one that could eg leave unwanted auto-saves around. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 10 14:20:12 2014 Received: (at 17970) by debbugs.gnu.org; 10 Jul 2014 18:20:12 +0000 Received: from localhost ([127.0.0.1]:52491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Iwx-0004lW-E2 for submit@debbugs.gnu.org; Thu, 10 Jul 2014 14:20:12 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:15022) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Iwq-0004kn-Qg for 17970@debbugs.gnu.org; Thu, 10 Jul 2014 14:20:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77092008" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jul 2014 14:19:54 -0400 Received: by pastel.home (Postfix, from userid 20848) id 79A23613BA; Thu, 10 Jul 2014 14:19:54 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#17970: log-edit creates unwanted ChangeLog buffers Message-ID: References: <9u61j79ffg.fsf@fencepost.gnu.org> <83d2ded4c3.fsf@gnu.org> <83wqblb6ow.fsf@gnu.org> <3afvi9150n.fsf@fencepost.gnu.org> Date: Thu, 10 Jul 2014 14:19:54 -0400 In-Reply-To: <3afvi9150n.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu, 10 Jul 2014 13:46:00 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17970 Cc: Eli Zaretskii , 17970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Sounds like Emacs should provide a better mechanism for this, > rather than one that could eg leave unwanted auto-saves around. Indeed it should. Stefan From unknown Fri Jun 20 07:20:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Aug 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator