GNU bug report logs - #17958
SHR: base handling broken (shr-parse-base, shr-expand-url)

Previous Next

Package: emacs;

Reported by: Ivan Shmakov <ivan <at> siamics.net>

Date: Sun, 6 Jul 2014 18:47:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 25.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #15 received at 17958 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 17958 <at> debbugs.gnu.org
Subject: Re: bug#17958: SHR: base handling broken (shr-parse-base,
 shr-expand-url)
Date: Tue, 04 Nov 2014 11:44:07 -0500

On Thu, 14 Aug 2014 18:50:20 +0000 Ivan Shmakov <ivan <at> siamics.net> wrote: 

>> Thus, I suggest changing shr-expand-url to return not the 0th element
>> of the (parsed) ‘base’ (see below), but the 3rd.

...

IS> 	With the patch MIMEd (which also fixes the issue described in my
IS> 	initial bug report), it instead gives what I deem to be the
IS> 	correct result:

IS> (let ((shr-base (shr-parse-base "http://example.org/")))
IS>   (shr-tag-base '((:href . "/relative")))
IS>   shr-base)
IS> ;; ⇒
IS> ("http://example.org" "/" "http" "http://example.org/relative")

This seems reasonable to me as far as usability but Lars will have to
review the patch for correctness.

Ted
This bug report was last modified 10 years and 248 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.