GNU bug report logs - #17947
24.3; ruby-mode sets require-final-newline unconditionally

Previous Next

Full log

View this message in rfc822 format

From: Ethan <ethan.glasser.camp <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 17947 <at> debbugs.gnu.org
Subject: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally
Date: Sat, 5 Jul 2014 14:19:06 -0400

[Message part 1 (text/plain, inline)]

The idea behind the package is that bad whitespace is highlighted, not
automatically cleaned up. So if the file doesn't have a final newline when
it is first loaded, no final newline will be added without explicit user
action -- instead a red "eof" marker is placed where the final newline
ought to be.

require-final-newline obviously interferes with this. ethan-wspace could
therefore set it to nil when it is operating, unconditionally. However, I
added functionality to complain if require-final-newline was set -- not
because *users* set it, but because *modes* do, and I wanted to get notice
when that happened. So if you really think ruby-mode should unconditionally
set require-final-newline, it's easy to remove the warning, make it
optional, override require-final-newline on a buffer-local basis, etc.

Ethan



On Sat, Jul 5, 2014 at 2:11 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Ethan Glasser-Camp <ethan.glasser.camp <at> gmail.com>
> > Date: Sat, 05 Jul 2014 14:07:16 -0400
> >
> > If ethan-wspace discovers that require-final-newline is set to t, it
> > admonishes the user.
>
> Why does ethan-wspace need to admonish users for setting
> require-final-newline?  Can this be avoided?
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.