From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 14:08:16 2014 Received: (at submit) by debbugs.gnu.org; 5 Jul 2014 18:08:16 +0000 Received: from localhost ([127.0.0.1]:44314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UNk-0004zI-1b for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32954) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UNh-0004z0-P5 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3UNX-0007uf-L0 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UNX-0007ub-IN for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:08:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UNS-0003Fc-AU for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:08:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3UNN-0007tY-Gc for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:07:58 -0400 Received: from mail-qa0-x22c.google.com ([2607:f8b0:400d:c00::22c]:56567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UNN-0007tN-Bp for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:07:53 -0400 Received: by mail-qa0-f44.google.com with SMTP id hw13so2241551qab.31 for ; Sat, 05 Jul 2014 11:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=/uPs9wKK59E/KRvtwYBCf5XOZnJHAXFtXcfPOg76a8g=; b=Wp0fQROhSxRQSksjnsE+KGEYpY3w+jNseDEaSEsXaUwObHTGzENSUaBnW+0AeEo4qB xXdNNOslEJ4oAgbtitatFDrzBOZjsmMFUglKSk6hVG2J30Yg+vjSZTtFoc6/Hksr01VU CvVUl6ePMbbMzUomdZkF8qmt2ZCRswqYXZJDweCCSw1LUfulNb6pTBQUscYB7PjrdbGR bAvTxzP7b6s6EpXWQ5ktNJH0r7JE9Qxnw0SND6smRQc9SDc0ByTnj2QOWmKOgzeiKPQD Et2gnOwIFoSqa4OTbIs4E4EdrP5wa5lfRwpPJNyLmaw14pVCI9qahfusLjdHR83E6GxQ dsTw== X-Received: by 10.224.51.18 with SMTP id b18mr31677588qag.81.1404583669839; Sat, 05 Jul 2014 11:07:49 -0700 (PDT) Received: from silver ([66.114.71.21]) by mx.google.com with ESMTPSA id t3sm63086848qai.28.2014.07.05.11.07.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 05 Jul 2014 11:07:49 -0700 (PDT) From: Ethan Glasser-Camp X-Google-Original-From: Ethan Glasser-Camp To: bug-gnu-emacs@gnu.org Subject: 24.3; ruby-mode sets require-final-newline unconditionally Date: Sat, 05 Jul 2014 14:07:16 -0400 Message-ID: <87wqbrllwr.fsf@betacantrips.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I am the maintainer of a package called emacs-wspace, available at github at https://github.com/glasserc/ethan-wspace/. The goal of the package is to help keep whitespace in files clean without introducing spurious whitespace changes. In order to do this, the package requires users to turn off require-final-newline and sometimes mode-require-final-newline. If ethan-wspace discovers that require-final-newline is set to t, it admonishes the user. One user reported that ruby-mode triggers this warning. Sure enough, in ruby-mode.el at line 287, I see: (set (make-local-variable 'require-final-newline) t) There is some precedent for doing this sort of thing with the variable mode-require-final-newline. Is it possible for ruby-mode to respect this variable? More discussion can be found at this bug report for cucumber.el, another mode which seems to borrow the pattern from ruby-mode: https://github.com/michaelklishin/cucumber.el/pull/51 Thank you for your time. Ethan In GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.7) of 2014-03-07 on lamiak, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04 LTS Configured using: `configure '--build' 'x86_64-linux-gnu' '--build' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3/site-lisp:/usr/share/emacs/site-lisp' '--with-crt-dir=/usr/lib/x86_64-linux-gnu' '--with-x=yes' '--with-x-toolkit=gtk3' '--with-toolkit-scroll-bars' 'build_alias=x86_64-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro' 'CPPFLAGS=-D_FORTIFY_SOURCE=2'' Important settings: value of $LC_MONETARY: en_US.UTF-8 value of $LC_NUMERIC: en_US.UTF-8 value of $LC_TIME: en_US.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x C-x o r e p o r t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 14:12:08 2014 Received: (at 17947) by debbugs.gnu.org; 5 Jul 2014 18:12:08 +0000 Received: from localhost ([127.0.0.1]:44319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3URT-00055M-AM for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:12:08 -0400 Received: from mtaout29.012.net.il ([80.179.55.185]:60467) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3URQ-00054n-3u for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 14:12:05 -0400 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N8900G003FZUL00@mtaout29.012.net.il> for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 21:11:58 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8900FSK3VX4S30@mtaout29.012.net.il>; Sat, 05 Jul 2014 21:11:58 +0300 (IDT) Date: Sat, 05 Jul 2014 21:11:46 +0300 From: Eli Zaretskii Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally In-reply-to: <87wqbrllwr.fsf@betacantrips.com> X-012-Sender: halo1@inter.net.il To: Ethan Glasser-Camp Message-id: <83ionbekv1.fsf@gnu.org> References: <87wqbrllwr.fsf@betacantrips.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17947 Cc: 17947@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ethan Glasser-Camp > Date: Sat, 05 Jul 2014 14:07:16 -0400 > > If ethan-wspace discovers that require-final-newline is set to t, it > admonishes the user. Why does ethan-wspace need to admonish users for setting require-final-newline? Can this be avoided? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 14:19:35 2014 Received: (at 17947) by debbugs.gnu.org; 5 Jul 2014 18:19:35 +0000 Received: from localhost ([127.0.0.1]:44326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UYh-0005GF-2A for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:19:35 -0400 Received: from mail-vc0-f179.google.com ([209.85.220.179]:45019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UYe-0005G2-0h for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 14:19:32 -0400 Received: by mail-vc0-f179.google.com with SMTP id id10so2504070vcb.24 for <17947@debbugs.gnu.org>; Sat, 05 Jul 2014 11:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=i3YZaZ1js7QV2Jq9j3ADkLO76AMu2b8QLK4iyQDrj9c=; b=t2ZJFxmAROpK71gksuw3cF53UttmQ+1DNXfQR1PVu4LOXWlJMMJvaj+EFFHw5XTibf kAfsRsSftbza6S4jFpo+sCHD+9KTXSrNxaSkc33+vKkWKVfSVN91b+LYUmnmdkHlpTTu 3XB1BfuwxMwWHW3JvFc3LgjX3GMAWw+Vznl6BO0EmUYHxa+GN4n1b5ilYWLrBPVAJxs0 F9VqlMY45AAL7vI50DveW0THXSbt8PNMUKpcECc2APktn0dY0PCiu63AZHBGKKXOM+nN unj58nR0TFreEYMUBOINr3G1wHdyg5y4GQmNDKFhAlLQgn+ayix2kghrVCUxE3jDbqEZ MGPQ== X-Received: by 10.58.149.170 with SMTP id ub10mr4019523veb.0.1404584366514; Sat, 05 Jul 2014 11:19:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.142.3 with HTTP; Sat, 5 Jul 2014 11:19:06 -0700 (PDT) In-Reply-To: <83ionbekv1.fsf@gnu.org> References: <87wqbrllwr.fsf@betacantrips.com> <83ionbekv1.fsf@gnu.org> From: Ethan Date: Sat, 5 Jul 2014 14:19:06 -0400 Message-ID: Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally To: Eli Zaretskii Content-Type: multipart/alternative; boundary=047d7b6760023929b504fd7648bf X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17947 Cc: 17947@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b6760023929b504fd7648bf Content-Type: text/plain; charset=UTF-8 The idea behind the package is that bad whitespace is highlighted, not automatically cleaned up. So if the file doesn't have a final newline when it is first loaded, no final newline will be added without explicit user action -- instead a red "eof" marker is placed where the final newline ought to be. require-final-newline obviously interferes with this. ethan-wspace could therefore set it to nil when it is operating, unconditionally. However, I added functionality to complain if require-final-newline was set -- not because *users* set it, but because *modes* do, and I wanted to get notice when that happened. So if you really think ruby-mode should unconditionally set require-final-newline, it's easy to remove the warning, make it optional, override require-final-newline on a buffer-local basis, etc. Ethan On Sat, Jul 5, 2014 at 2:11 PM, Eli Zaretskii wrote: > > From: Ethan Glasser-Camp > > Date: Sat, 05 Jul 2014 14:07:16 -0400 > > > > If ethan-wspace discovers that require-final-newline is set to t, it > > admonishes the user. > > Why does ethan-wspace need to admonish users for setting > require-final-newline? Can this be avoided? > --047d7b6760023929b504fd7648bf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The idea behind the package is that bad whitespace is= highlighted, not automatically cleaned up. So if the file doesn't have= a final newline when it is first loaded, no final newline will be added wi= thout explicit user action -- instead a red "eof" marker is place= d where the final newline ought to be.

require-final-newline obviously interferes with this. ethan-wspac= e could therefore set it to nil when it is operating, unconditionally. Howe= ver, I added functionality to complain if require-final-newline was set -- = not because *users* set it, but because *modes* do, and I wanted to get not= ice when that happened. So if you really think ruby-mode should uncondition= ally set require-final-newline, it's easy to remove the warning, make i= t optional, override require-final-newline on a buffer-local basis, etc.

Ethan



On Sat, Jul 5, 2014 at 2:11 PM, = Eli Zaretskii <eliz@gnu.org> wrote:
> From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com><= br> > Date: Sat, 05 Jul 2014 14:07:16 -0400
>
> If ethan-wspace discovers that require-final-newline is set to t, it > admonishes the user.

Why does ethan-wspace need to admonish users for setting
require-final-newline? =C2=A0Can this be avoided?

--047d7b6760023929b504fd7648bf-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 14:38:49 2014 Received: (at 17947) by debbugs.gnu.org; 5 Jul 2014 18:38:50 +0000 Received: from localhost ([127.0.0.1]:44331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UrJ-0005l8-6g for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:38:49 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:54828) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UrF-0005kk-Vj for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 14:38:47 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N89005004CAAM00@mtaout25.012.net.il> for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 21:34:30 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N89000M04XIFL70@mtaout25.012.net.il>; Sat, 05 Jul 2014 21:34:30 +0300 (IDT) Date: Sat, 05 Jul 2014 21:38:28 +0300 From: Eli Zaretskii Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally In-reply-to: X-012-Sender: halo1@inter.net.il To: Ethan Message-id: <83ha2vejmj.fsf@gnu.org> References: <87wqbrllwr.fsf@betacantrips.com> <83ionbekv1.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17947 Cc: 17947@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ethan > Date: Sat, 5 Jul 2014 14:19:06 -0400 > Cc: 17947@debbugs.gnu.org > > The idea behind the package is that bad whitespace is highlighted, not > automatically cleaned up. So if the file doesn't have a final newline when > it is first loaded, no final newline will be added without explicit user > action -- instead a red "eof" marker is placed where the final newline > ought to be. > > require-final-newline obviously interferes with this. ethan-wspace could > therefore set it to nil when it is operating, unconditionally. However, I > added functionality to complain if require-final-newline was set -- not > because *users* set it, but because *modes* do, and I wanted to get notice > when that happened. So if you really think ruby-mode should unconditionally > set require-final-newline, it's easy to remove the warning, make it > optional, override require-final-newline on a buffer-local basis, etc. It seems to me that if the buffer being checked has require-final-newline set to a non-nil value, ethan-wspace should simply refrain from checking the final newline, because obviously the user and/or the mode took control of that issue. Wouldn't this be better than bitching at users for setting this option? And I don't think introducing yet another option would solve it. If the user or mode set require-final-newline, IMO that is a clear declaration that the final newline issue is that user's or mode's responsibility; no further options are needed to make that clear. Don't you agree? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 14:38:59 2014 Received: (at 17947-done) by debbugs.gnu.org; 5 Jul 2014 18:38:59 +0000 Received: from localhost ([127.0.0.1]:44334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UrS-0005lY-Tw for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:38:59 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:50150) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UrQ-0005lI-7K for 17947-done@debbugs.gnu.org; Sat, 05 Jul 2014 14:38:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="76490043" Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Jul 2014 14:38:50 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 1B41D66090; Sat, 5 Jul 2014 14:38:45 -0400 (EDT) From: Stefan Monnier To: Ethan Glasser-Camp Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally Message-ID: References: <87wqbrllwr.fsf@betacantrips.com> Date: Sat, 05 Jul 2014 14:38:45 -0400 In-Reply-To: <87wqbrllwr.fsf@betacantrips.com> (Ethan Glasser-Camp's message of "Sat, 05 Jul 2014 14:07:16 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17947-done Cc: 17947-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > One user reported that ruby-mode triggers this warning. Sure enough, in > ruby-mode.el at line 287, I see: > (set (make-local-variable 'require-final-newline) t) Removed in the `emacs-24' branch. It was a remnant from before ruby-mode was made to inherit from prog-mode. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 15:23:51 2014 Received: (at 17947) by debbugs.gnu.org; 5 Jul 2014 19:23:51 +0000 Received: from localhost ([127.0.0.1]:44349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3VYt-0006q6-CP for submit@debbugs.gnu.org; Sat, 05 Jul 2014 15:23:51 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:38795) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3VYq-0006pr-Ai for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 15:23:49 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N89004006JBS900@a-mtaout23.012.net.il> for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 22:23:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N89004K777GQF60@a-mtaout23.012.net.il>; Sat, 05 Jul 2014 22:23:41 +0300 (IDT) Date: Sat, 05 Jul 2014 22:23:30 +0300 From: Eli Zaretskii Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83fvifehjh.fsf@gnu.org> References: <87wqbrllwr.fsf@betacantrips.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17947 Cc: 17947@debbugs.gnu.org, ethan.glasser.camp@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Date: Sat, 05 Jul 2014 14:38:45 -0400 > Cc: 17947-done@debbugs.gnu.org > > > One user reported that ruby-mode triggers this warning. Sure enough, in > > ruby-mode.el at line 287, I see: > > (set (make-local-variable 'require-final-newline) t) > > Removed in the `emacs-24' branch. Regardless of what this or that mode does, I think it's wrong for ethan-wspace to annoy users for having require-final-newline set non-nil. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 19:02:24 2014 Received: (at 17947) by debbugs.gnu.org; 5 Jul 2014 23:02:25 +0000 Received: from localhost ([127.0.0.1]:44391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3YyJ-0003n5-VP for submit@debbugs.gnu.org; Sat, 05 Jul 2014 19:02:24 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20895) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3YyC-0003mc-3y for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 19:02:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMQCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="76505149" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Jul 2014 19:02:05 -0400 Received: by pastel.home (Postfix, from userid 20848) id 401A266F86; Sat, 5 Jul 2014 19:02:05 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally Message-ID: References: <87wqbrllwr.fsf@betacantrips.com> <83fvifehjh.fsf@gnu.org> Date: Sat, 05 Jul 2014 19:02:05 -0400 In-Reply-To: <83fvifehjh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Jul 2014 22:23:30 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17947 Cc: 17947@debbugs.gnu.org, ethan.glasser.camp@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> > One user reported that ruby-mode triggers this warning. Sure enough, in >> > ruby-mode.el at line 287, I see: >> > (set (make-local-variable 'require-final-newline) t) >> Removed in the `emacs-24' branch. > Regardless of what this or that mode does, I think it's wrong for > ethan-wspace to annoy users for having require-final-newline set > non-nil. It's his package and he's free to do what he wants with it, I think. Maybe I'd find it annoying as well, but in any case the setting was erroneous since there is no justification to ignore the mode-require-final-newline setting. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 22:45:40 2014 Received: (at 17947) by debbugs.gnu.org; 6 Jul 2014 02:45:40 +0000 Received: from localhost ([127.0.0.1]:44443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3cSQ-0001Vk-RX for submit@debbugs.gnu.org; Sat, 05 Jul 2014 22:45:39 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:36881) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3cSM-0001VT-V2 for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 22:45:36 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N8900A00RKV6Y00@a-mtaout22.012.net.il> for 17947@debbugs.gnu.org; Sun, 06 Jul 2014 05:45:28 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8900971RNRUQ70@a-mtaout22.012.net.il>; Sun, 06 Jul 2014 05:45:28 +0300 (IDT) Date: Sun, 06 Jul 2014 05:45:18 +0300 From: Eli Zaretskii Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83egxzdx35.fsf@gnu.org> References: <87wqbrllwr.fsf@betacantrips.com> <83fvifehjh.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17947 Cc: 17947@debbugs.gnu.org, ethan.glasser.camp@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: 17947@debbugs.gnu.org, ethan.glasser.camp@gmail.com > Date: Sat, 05 Jul 2014 19:02:05 -0400 > > >> > One user reported that ruby-mode triggers this warning. Sure enough, in > >> > ruby-mode.el at line 287, I see: > >> > (set (make-local-variable 'require-final-newline) t) > >> Removed in the `emacs-24' branch. > > Regardless of what this or that mode does, I think it's wrong for > > ethan-wspace to annoy users for having require-final-newline set > > non-nil. > > It's his package and he's free to do what he wants with it, I think. Yes, he is. Which is why I said "I think". It's an opinion of an Emacs user who has this variable customized since about forever, and would find it annoying to be annoyed by such warnings. User who customized this variables clearly tell that they want to be in control of the final newline, so packages that look at that shouldn't. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 06 00:28:08 2014 Received: (at 17947) by debbugs.gnu.org; 6 Jul 2014 04:28:08 +0000 Received: from localhost ([127.0.0.1]:44453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3e3c-0004I9-0H for submit@debbugs.gnu.org; Sun, 06 Jul 2014 00:28:08 -0400 Received: from mail-vc0-f176.google.com ([209.85.220.176]:58086) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3e3Y-0004He-R6 for 17947@debbugs.gnu.org; Sun, 06 Jul 2014 00:28:05 -0400 Received: by mail-vc0-f176.google.com with SMTP id ik5so2720423vcb.35 for <17947@debbugs.gnu.org>; Sat, 05 Jul 2014 21:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=l9MWsg3ZickHYPzQbrWfAe7s5+PuOjL/uhHt+EO0nsI=; b=pxk8Q8WP7YteYySvkn+jPZbBjsBPq4tbmoT4wytp/BXXZhbLJt0etnoZL6c8BraWDo 6Pabpqnyez0m6nJHnLtOVrPLeNKxeerdVJLaLiBFQujAJSDgE7XTQW+OceJNgo79FtcO dgQ/kKl72OVzuWX37l0aU8uX0K+LuzebNtoWCjEr3Un1vQoh23YAbAspiMtsaS/ohMxU hhYO6IOkOJhMGvrHgKjNM/MhAHshih90LAAaBA5FOUkQtQsfM2PZUWOvrXY51RXIQSOK GBUE7Z+OqvdHEKih0LGxswsOnCT5MYGq6SALxoNsUM0MXqVxM63pZSGVw6N/NmLcBWXt s1Ew== X-Received: by 10.58.12.73 with SMTP id w9mr19622828veb.13.1404620879069; Sat, 05 Jul 2014 21:27:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.142.3 with HTTP; Sat, 5 Jul 2014 21:27:39 -0700 (PDT) In-Reply-To: <83egxzdx35.fsf@gnu.org> References: <87wqbrllwr.fsf@betacantrips.com> <83fvifehjh.fsf@gnu.org> <83egxzdx35.fsf@gnu.org> From: Ethan Date: Sun, 6 Jul 2014 00:27:39 -0400 Message-ID: Subject: Re: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally To: Eli Zaretskii Content-Type: multipart/alternative; boundary=047d7b4184418a8afb04fd7ec820 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17947 Cc: 17947@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b4184418a8afb04fd7ec820 Content-Type: text/plain; charset=UTF-8 Hi Eli, if you are happy with the behavior of require-final-newline, then that's fine and I don't believe you are likely to want to use ethan-wspace. The point of the warning is to make it clear to a user that you can use ethan-wspace, or require-final-newline, but not both. The point of the bug report is merely to ask that if a user wants to use ethan-wspace and not require-final-newline, that they be able to do so. Thanks Stefan for the quick turnaround on the patch and the context for why the code is the way it is! Ethan On Sat, Jul 5, 2014 at 10:45 PM, Eli Zaretskii wrote: > > From: Stefan Monnier > > Cc: 17947@debbugs.gnu.org, ethan.glasser.camp@gmail.com > > Date: Sat, 05 Jul 2014 19:02:05 -0400 > > > > >> > One user reported that ruby-mode triggers this warning. Sure > enough, in > > >> > ruby-mode.el at line 287, I see: > > >> > (set (make-local-variable 'require-final-newline) t) > > >> Removed in the `emacs-24' branch. > > > Regardless of what this or that mode does, I think it's wrong for > > > ethan-wspace to annoy users for having require-final-newline set > > > non-nil. > > > > It's his package and he's free to do what he wants with it, I think. > > Yes, he is. Which is why I said "I think". It's an opinion of an > Emacs user who has this variable customized since about forever, and > would find it annoying to be annoyed by such warnings. User who > customized this variables clearly tell that they want to be in control > of the final newline, so packages that look at that shouldn't. > --047d7b4184418a8afb04fd7ec820 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Eli, if you are happy with the behavior of require-fina= l-newline, then that's fine and I don't believe you are likely to w= ant to use ethan-wspace. The point of the warning is to make it clear to a = user that you can use ethan-wspace, or require-final-newline, but not both.= The point of the bug report is merely to ask that if a user wants to use e= than-wspace and not require-final-newline, that they be able to do so.

Thanks Stefan for the quick turnaround on the patch and the context for= why the code is the way it is!

Ethan



On Sat, Jul 5, 2014 at 10:45 P= M, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: 17947@debbugs.gnu.org= , =C2=A0ethan.glasser.camp@= gmail.com
> Date: Sat, 05 Jul 2014 19:02:05 -0400
>
> >> > One user reported that ruby-mode triggers this warning. = Sure enough, in
> >> > ruby-mode.el at line 287, I see:
> >> > =C2=A0 (set (make-local-variable 'require-final-newl= ine) t)
> >> Removed in the `emacs-24' branch.
> > Regardless of what this or that mode does, I think it's wrong= for
> > ethan-wspace to annoy users for having require-final-newline set<= br> > > non-nil.
>
> It's his package and he's free to do what he wants with it, I = think.

Yes, he is. =C2=A0Which is why I said "I think". =C2=A0It&#= 39;s an opinion of an
Emacs user who has this variable customized since about forever, and
would find it annoying to be annoyed by such warnings. =C2=A0User who
customized this variables clearly tell that they want to be in control
of the final newline, so packages that look at that shouldn't.

--047d7b4184418a8afb04fd7ec820-- From unknown Sun Jun 22 00:55:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Aug 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator