From unknown Sun Jun 22 00:35:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17946: Try LOGNAME in addition to USER Resent-From: Taylan Ulrich Bayirli/Kammer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 05 Jul 2014 12:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17946 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 17946@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140456386320381 (code B ref -1); Sat, 05 Jul 2014 12:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jul 2014 12:37:43 +0000 Received: from localhost ([127.0.0.1]:43477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3PDp-0005Ia-M2 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59722) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3PDl-0005IJ-Ix for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3PDX-0001k7-Db for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3PDX-0001k3-Ae for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3PDO-0003XL-8Z for bug-guix@gnu.org; Sat, 05 Jul 2014 08:37:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3PDF-0001fB-5u for bug-guix@gnu.org; Sat, 05 Jul 2014 08:37:14 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:52953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3PDE-0001dA-V8 for bug-guix@gnu.org; Sat, 05 Jul 2014 08:37:05 -0400 Received: by mail-wi0-f176.google.com with SMTP id n3so13924934wiv.3 for ; Sat, 05 Jul 2014 05:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:from:to:subject; bh=WK07+J2B89ob8M9XQF6ZySL2VNE3pKwWUjtplkxin5U=; b=X2cyziN699Jim9C/Rl57s7mpA6EummRo08Jdf/uKX31YpyGtGn3Xpi6RLZer30g+xJ UAEbFx+MY6Lg4b7gw1NF5NVR2VbW545x7kn7rE63QbJn1A0e83AdTnflKoaxrVewws6q uMqv94Mslp1xxHgm9CtLL2+Jw57rL3vTeikvkZszEaO+3kLZyP0ZACOeDQ0eJbJHU8Ux t2c76bYxV4ot8XDvW20n+1XvjmaoOXgVcWbW92gSGxe67PelyWWdRPHN+mmynZNTS7sN jy4dVIPFlkbCLlbSGHMZapXHWCYrorbrlprUyKu9a332NmwmuetFmNx1m0d9G5KI2hBR SSkA== X-Received: by 10.194.63.77 with SMTP id e13mr2644137wjs.104.1404563823969; Sat, 05 Jul 2014 05:37:03 -0700 (PDT) Received: from taylan.uni.cx ([85.100.205.21]) by mx.google.com with ESMTPSA id l5sm90690009wif.22.2014.07.05.05.37.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jul 2014 05:37:03 -0700 (PDT) Date: Sat, 05 Jul 2014 15:36:44 +0300 Message-Id: <87wqbsc78j.fsf@taylan.uni.cx> From: Taylan Ulrich Bayirli/Kammer X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Cron jobs may set the LOGNAME environment variable but no USER, e.g. under Debian 7 (wheezy). In that case 'guix package' fails to use $localstatedir/guix/profiles/per-user/$user. From a quick grep I couldn't find more places in Guix where USER is used, so here's a patch that just does it straightforwardly in two places in scripts/package.scm, but perhaps a more generic solution would be good for the future. ===File /home/tub/media/src/guix/0001-Try-LOGNAME-in-addition-to-USER.patch=== >From 902267cf99aacaea994cc95b77551f0d2bd35836 Mon Sep 17 00:00:00 2001 From: Taylan Ulrich B Date: Sat, 5 Jul 2014 15:28:50 +0300 Subject: [PATCH] Try LOGNAME in addition to USER. Notoriously, cron jobs may set LOGNAME only and not USER. See e.g. crontab(5) under Debian 7 (wheezy). * guix/scripts/package.scm (%profile-directory) (guix-package): Also try LOGNAME if USER is unset. --- guix/scripts/package.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm index f930b00..2e626f3 100644 --- a/guix/scripts/package.scm +++ b/guix/scripts/package.scm @@ -59,7 +59,8 @@ (define %profile-directory (string-append %state-directory "/profiles/" - (or (and=> (getenv "USER") + (or (and=> (or (getenv "USER") + (getenv "LOGNAME")) (cut string-append "per-user/" <>)) "default"))) @@ -797,7 +798,9 @@ more information.~%")) %profile-directory) (format (current-error-port) (_ "Please change the owner of `~a' to user ~s.~%") - %profile-directory (or (getenv "USER") (getuid))) + %profile-directory (or (getenv "USER") + (getenv "LOGNAME") + (getuid))) (rtfm)))) (define (process-actions opts) -- 1.8.4 ============================================================ Taylan From unknown Sun Jun 22 00:35:08 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Taylan Ulrich Bayirli/Kammer Subject: bug#17946: closed (Re: bug#17946: Try LOGNAME in addition to USER) Message-ID: References: <877g3suey7.fsf@gnu.org> <87wqbsc78j.fsf@taylan.uni.cx> X-Gnu-PR-Message: they-closed 17946 X-Gnu-PR-Package: guix Reply-To: 17946@debbugs.gnu.org Date: Sat, 05 Jul 2014 13:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1404565982-23714-1" This is a multi-part message in MIME format... ------------=_1404565982-23714-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17946: Try LOGNAME in addition to USER which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17946@debbugs.gnu.org. --=20 17946: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17946 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1404565982-23714-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17946-done) by debbugs.gnu.org; 5 Jul 2014 13:12:53 +0000 Received: from localhost ([127.0.0.1]:43510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3Pls-0006A9-AP for submit@debbugs.gnu.org; Sat, 05 Jul 2014 09:12:52 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:34527) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3Plq-00069z-5P for 17946-done@debbugs.gnu.org; Sat, 05 Jul 2014 09:12:50 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 4CA6530EC; Sat, 5 Jul 2014 15:12:49 +0200 (CEST) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XHNDRQCd8KcY; Sat, 5 Jul 2014 15:12:49 +0200 (CEST) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id EE7F021AF; Sat, 5 Jul 2014 15:12:48 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Taylan Ulrich Bayirli/Kammer Subject: Re: bug#17946: Try LOGNAME in addition to USER References: <87wqbsc78j.fsf@taylan.uni.cx> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 Messidor an 222 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Sat, 05 Jul 2014 15:12:48 +0200 In-Reply-To: <87wqbsc78j.fsf@taylan.uni.cx> (Taylan Ulrich Bayirli's message of "Sat, 05 Jul 2014 15:36:44 +0300") Message-ID: <877g3suey7.fsf@gnu.org> User-Agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17946-done Cc: 17946-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Taylan Ulrich Bayirli/Kammer skribis: > Cron jobs may set the LOGNAME environment variable but no USER, > e.g. under Debian 7 (wheezy). In that case 'guix package' fails to > use $localstatedir/guix/profiles/per-user/$user. From a quick grep I > couldn't find more places in Guix where USER is used, so here's a > patch that just does it straightforwardly in two places in > scripts/package.scm, but perhaps a more generic solution would be good > for the future. Good catch. I agree we=E2=80=99ll need to factorize that eventually. > From 902267cf99aacaea994cc95b77551f0d2bd35836 Mon Sep 17 00:00:00 2001 > From: Taylan Ulrich B > Date: Sat, 5 Jul 2014 15:28:50 +0300 > Subject: [PATCH] Try LOGNAME in addition to USER. > > Notoriously, cron jobs may set LOGNAME only and not USER. See > e.g. crontab(5) under Debian 7 (wheezy). > > * guix/scripts/package.scm (%profile-directory) > (guix-package): Also try LOGNAME if USER is unset. Pushed after tweaking the commit log. Thanks! Ludo=E2=80=99. ------------=_1404565982-23714-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Jul 2014 12:37:43 +0000 Received: from localhost ([127.0.0.1]:43477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3PDp-0005Ia-M2 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59722) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3PDl-0005IJ-Ix for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3PDX-0001k7-Db for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3PDX-0001k3-Ae for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:37:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3PDO-0003XL-8Z for bug-guix@gnu.org; Sat, 05 Jul 2014 08:37:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3PDF-0001fB-5u for bug-guix@gnu.org; Sat, 05 Jul 2014 08:37:14 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:52953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3PDE-0001dA-V8 for bug-guix@gnu.org; Sat, 05 Jul 2014 08:37:05 -0400 Received: by mail-wi0-f176.google.com with SMTP id n3so13924934wiv.3 for ; Sat, 05 Jul 2014 05:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:from:to:subject; bh=WK07+J2B89ob8M9XQF6ZySL2VNE3pKwWUjtplkxin5U=; b=X2cyziN699Jim9C/Rl57s7mpA6EummRo08Jdf/uKX31YpyGtGn3Xpi6RLZer30g+xJ UAEbFx+MY6Lg4b7gw1NF5NVR2VbW545x7kn7rE63QbJn1A0e83AdTnflKoaxrVewws6q uMqv94Mslp1xxHgm9CtLL2+Jw57rL3vTeikvkZszEaO+3kLZyP0ZACOeDQ0eJbJHU8Ux t2c76bYxV4ot8XDvW20n+1XvjmaoOXgVcWbW92gSGxe67PelyWWdRPHN+mmynZNTS7sN jy4dVIPFlkbCLlbSGHMZapXHWCYrorbrlprUyKu9a332NmwmuetFmNx1m0d9G5KI2hBR SSkA== X-Received: by 10.194.63.77 with SMTP id e13mr2644137wjs.104.1404563823969; Sat, 05 Jul 2014 05:37:03 -0700 (PDT) Received: from taylan.uni.cx ([85.100.205.21]) by mx.google.com with ESMTPSA id l5sm90690009wif.22.2014.07.05.05.37.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jul 2014 05:37:03 -0700 (PDT) Date: Sat, 05 Jul 2014 15:36:44 +0300 Message-Id: <87wqbsc78j.fsf@taylan.uni.cx> From: Taylan Ulrich Bayirli/Kammer To: bug-guix@gnu.org Subject: Try LOGNAME in addition to USER X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Cron jobs may set the LOGNAME environment variable but no USER, e.g. under Debian 7 (wheezy). In that case 'guix package' fails to use $localstatedir/guix/profiles/per-user/$user. From a quick grep I couldn't find more places in Guix where USER is used, so here's a patch that just does it straightforwardly in two places in scripts/package.scm, but perhaps a more generic solution would be good for the future. ===File /home/tub/media/src/guix/0001-Try-LOGNAME-in-addition-to-USER.patch=== >From 902267cf99aacaea994cc95b77551f0d2bd35836 Mon Sep 17 00:00:00 2001 From: Taylan Ulrich B Date: Sat, 5 Jul 2014 15:28:50 +0300 Subject: [PATCH] Try LOGNAME in addition to USER. Notoriously, cron jobs may set LOGNAME only and not USER. See e.g. crontab(5) under Debian 7 (wheezy). * guix/scripts/package.scm (%profile-directory) (guix-package): Also try LOGNAME if USER is unset. --- guix/scripts/package.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm index f930b00..2e626f3 100644 --- a/guix/scripts/package.scm +++ b/guix/scripts/package.scm @@ -59,7 +59,8 @@ (define %profile-directory (string-append %state-directory "/profiles/" - (or (and=> (getenv "USER") + (or (and=> (or (getenv "USER") + (getenv "LOGNAME")) (cut string-append "per-user/" <>)) "default"))) @@ -797,7 +798,9 @@ more information.~%")) %profile-directory) (format (current-error-port) (_ "Please change the owner of `~a' to user ~s.~%") - %profile-directory (or (getenv "USER") (getuid))) + %profile-directory (or (getenv "USER") + (getenv "LOGNAME") + (getuid))) (rtfm)))) (define (process-actions opts) -- 1.8.4 ============================================================ Taylan ------------=_1404565982-23714-1--