GNU bug report logs - #17945
24.4.50; vc-git-annotate-command is too slow

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Óscar Fuentes <ofv <at> wanadoo.es>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17945: closed (24.4.50; vc-git-annotate-command is too slow)
Date: Thu, 26 Feb 2015 14:57:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 26 Feb 2015 15:56:05 +0100
with message-id <877fv490xm.fsf <at> wanadoo.es>
and subject line Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow
has caused the debbugs.gnu.org bug report #17945,
regarding 24.4.50; vc-git-annotate-command is too slow
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17945: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17945
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: William Xu <william.xwl <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; vc-git-annotate-command is too slow
Date: Sat, 5 Jul 2014 20:28:37 +0800

[Message part 3 (text/plain, inline)]

C-x v g on a git file is very slow, compare this:

    $ time git --no-pager  blame  -- vc-annotate.el 1>/dev/null

    real    0m1.432s
    user    0m1.364s
    sys    0m0.063s


    $ time git --no-pager  blame -C -C  -- vc-annotate.el 1>/dev/null

    real    0m23.477s
    user    0m22.058s
    sys    0m1.405s

It seems the -C -C options would slow down git hugely, making this
command almost useless.  Can we remove it from default option list?

-William

git version 1.9.3

In GNU Emacs 24.4.50.1 (i386-apple-darwin13.1.0, NS apple-appkit-1265.19)
 of 2014-04-16 on tokyolove.local
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns CC=clang'

Configured features:
ACL GNUTLS LIBXML2 ZLIB

Important settings:
  locale-coding-system: utf-8-unix

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17945-done <at> debbugs.gnu.org
Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow
Date: Thu, 26 Feb 2015 15:56:05 +0100

Glenn Morris <rgm <at> gnu.org> writes:

> Óscar Fuentes wrote:
>
>> So what about this patch?
>
> Looks, right, except vc-annotate-switches does not exist and would also
> need to be added. And for consistency, presumably all backends should
> get the same treatment. Thanks.

Implemented on b5a0603eb41c7a350c16a1b3ec5c1b8d8c84a4eb.

I'm neutral about the existence of vc-annotate-switches, so if anyone
wants to remove it (including mentions on the docstrings of
vc-BACKEND-annotate-switches) it's fine with me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.