From unknown Wed Jun 18 23:13:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17945 <17945@debbugs.gnu.org> To: bug#17945 <17945@debbugs.gnu.org> Subject: Status: 24.4.50; vc-git-annotate-command is too slow Reply-To: bug#17945 <17945@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:20 +0000 retitle 17945 24.4.50; vc-git-annotate-command is too slow reassign 17945 emacs submitter 17945 William Xu severity 17945 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 08:28:51 2014 Received: (at submit) by debbugs.gnu.org; 5 Jul 2014 12:28:51 +0000 Received: from localhost ([127.0.0.1]:43472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3P5G-00053A-Ur for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:28:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58066) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3P5D-00052x-UW for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3P57-0007Jf-MS for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:28:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3P57-0007Ja-Ix for submit@debbugs.gnu.org; Sat, 05 Jul 2014 08:28:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3P56-00022M-Ke for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 08:28:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3P55-0007JK-QF for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 08:28:40 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:51021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3P55-0007JC-Is for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 08:28:39 -0400 Received: by mail-wi0-f169.google.com with SMTP id hi2so13077247wib.2 for ; Sat, 05 Jul 2014 05:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=8Zz0N3pHAIMz+UwVV6ba9kFWqC6Ix2J+2Uk1rhzbWxw=; b=UVmCiZrKOmmS8hBDmRi8fx6bc/Zh/NbE5ShdXSAG3yQkeWwYx/zD1NuEgmPh0IUjxl r8IciJhCEFfCeYNyXpx6HuMZYn5yPnSHKoAiTjix41bURK5xp6RJXq8ZEgquAZC7BLpO Ot738b9ZS+DXuepo58FJxb6S9PM3Q0Aubm+toT4PoCDYAJtzfsUE0VbzNLF2X8jnejH4 FF/tHCV6Q10B6z/AQROhXXGJeu8OLvy1MVPuTRIOs/Hn3Sv7RHbFzaJWP/fq4KLQKwtz 2M1rwDi36YyBPcnf+GvSeysQQ2mULOtKENhM355vKtsuAtTXaZ+Cvi1hE1yWuBnrf8rv WfYQ== MIME-Version: 1.0 X-Received: by 10.195.12.97 with SMTP id ep1mr3155452wjd.26.1404563318033; Sat, 05 Jul 2014 05:28:38 -0700 (PDT) Received: by 10.217.180.74 with HTTP; Sat, 5 Jul 2014 05:28:37 -0700 (PDT) Date: Sat, 5 Jul 2014 20:28:37 +0800 Message-ID: Subject: 24.4.50; vc-git-annotate-command is too slow From: William Xu To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=047d7bfceb40a2d29c04fd716185 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --047d7bfceb40a2d29c04fd716185 Content-Type: text/plain; charset=UTF-8 C-x v g on a git file is very slow, compare this: $ time git --no-pager blame -- vc-annotate.el 1>/dev/null real 0m1.432s user 0m1.364s sys 0m0.063s $ time git --no-pager blame -C -C -- vc-annotate.el 1>/dev/null real 0m23.477s user 0m22.058s sys 0m1.405s It seems the -C -C options would slow down git hugely, making this command almost useless. Can we remove it from default option list? -William git version 1.9.3 In GNU Emacs 24.4.50.1 (i386-apple-darwin13.1.0, NS apple-appkit-1265.19) of 2014-04-16 on tokyolove.local Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --with-ns CC=clang' Configured features: ACL GNUTLS LIBXML2 ZLIB Important settings: locale-coding-system: utf-8-unix --047d7bfceb40a2d29c04fd716185 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
C-x v g on a git file is very slow, compare this:

= =C2=A0=C2=A0=C2=A0 $ time git --no-pager=C2=A0 blame=C2=A0 -- vc-annotate.e= l 1>/dev/null

=C2=A0=C2=A0=C2=A0 real=C2=A0=C2=A0 =C2=A00m1.432s<= br>=C2=A0=C2=A0=C2=A0 user=C2=A0=C2=A0 =C2=A00m1.364s
=C2=A0=C2=A0=C2=A0= sys=C2=A0=C2=A0 =C2=A00m0.063s


=C2=A0=C2=A0=C2=A0 $ time git --no-pager=C2=A0 blame -C -C=C2=A0 -- vc-anno= tate.el 1>/dev/null

=C2=A0=C2=A0=C2=A0 real=C2=A0=C2=A0 =C2=A00m2= 3.477s
=C2=A0=C2=A0=C2=A0 user=C2=A0=C2=A0 =C2=A00m22.058s
=C2=A0=C2= =A0=C2=A0 sys=C2=A0=C2=A0 =C2=A00m1.405s

It seems the -C -C options = would slow down git hugely, making this
command almost useless.=C2=A0 Can we remove it from default option list?
-William

git version 1.9.3

In GNU Emacs 24.4.50.1 (i386-= apple-darwin13.1.0, NS apple-appkit-1265.19)
=C2=A0of 2014-04-16 on toky= olove.local
Windowing system distributor `Apple', version 10.3.1265
Configured u= sing:
=C2=A0`configure --with-ns CC=3Dclang'

Configured featu= res:
ACL GNUTLS LIBXML2 ZLIB

Important settings:
=C2=A0 locale= -coding-system: utf-8-unix

--047d7bfceb40a2d29c04fd716185-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 09:34:33 2014 Received: (at 17945) by debbugs.gnu.org; 5 Jul 2014 13:34:33 +0000 Received: from localhost ([127.0.0.1]:43523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3Q6q-0006fs-P3 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 09:34:33 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:57771) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3Q6o-0006fc-PO for 17945@debbugs.gnu.org; Sat, 05 Jul 2014 09:34:31 -0400 Received: by mail-we0-f169.google.com with SMTP id t60so2603611wes.28 for <17945@debbugs.gnu.org>; Sat, 05 Jul 2014 06:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=8ed3bjKMTmk86CjXNIx89GuvsPCuwDi5CkIDKXcPuG0=; b=fKWlJBFHYFdqiX2YK9j4blbDPHxFGufnoHfJ1tad17rhYuqb/bUUWvqL96zyEbgy71 fQQRnJEzkpAmS/55lOQ7cISf6vqZBbfNnsok6M+ZNE83rpNfduRtPsT5WyX5T/VPwbTe bFn12UImvorBHRD3slw1yPWXWxp/GAIOluDvfjbUfv+l/WY+ytPuZcUEHjnSGzkIhrrN 6y3A+cK5WHG8XCZ6aaitaT76LVrGqtmta5noPeB3akebPxWjQYMEO32CqbodZkmSD2RD v6ZdoG7tkfpKGV6XRy4rDvIkpMJ27MAx3HngtkONvCmH2L/YC63C4Fr9pqceKcHXiApt ZoeQ== X-Received: by 10.194.133.42 with SMTP id oz10mr13076240wjb.40.1404567264857; Sat, 05 Jul 2014 06:34:24 -0700 (PDT) Received: from axl (v-2-eu19-d3962-07.webazilla.com. [78.140.151.7]) by mx.google.com with ESMTPSA id lk5sm27700840wic.18.2014.07.05.06.34.23 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 05 Jul 2014 06:34:24 -0700 (PDT) From: Dmitry To: William Xu Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: Date: Sat, 05 Jul 2014 16:34:20 +0300 In-Reply-To: (William Xu's message of "Sat, 5 Jul 2014 20:28:37 +0800") Message-ID: <8638egylnn.fsf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) William Xu writes: > C-x v g on a git file is very slow, compare this: What kind of repository are you doing this in? For me, it always works quite fast (usually <1 s). > It seems the -C -C options would slow down git hugely, making this > command almost useless. Can we remove it from default option list? These options provide a feature, so we shouldn't simply remove them. Maybe we should provide a user option. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 11:16:33 2014 Received: (at 17945) by debbugs.gnu.org; 5 Jul 2014 15:16:33 +0000 Received: from localhost ([127.0.0.1]:44246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3RhZ-0000tL-00 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 11:16:33 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:46047) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3RhW-0000t7-2H for 17945@debbugs.gnu.org; Sat, 05 Jul 2014 11:16:31 -0400 Received: by mail-we0-f177.google.com with SMTP id u56so2610027wes.8 for <17945@debbugs.gnu.org>; Sat, 05 Jul 2014 08:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zSAkHxcaVTSwdUCofJeDOdWbbuE7pZWCP+GZfa8r0Uw=; b=yzafbam+ByYevBWD3eEEY2mG8so8cCV3DrWVFInCEmc5X4gnnbH1B2+jp5D8tcQEjL zJSLTsi6lMOOwqPrycF5KvLP9oqqvhwXUAEIDgXHi629L044bXWKJG97gRohdagOlKya 5NqyLhip4qYRgkpVWDT9/CHei9gASwoYhC9jx+CycRvpPQl8ZE9um+v1x655E5vRk3bZ tfpVh/vJ4WBExm4ok527kBEnj+UZ7CaILX6DibOV/UNb7bvrIlwy36AyQBufLFjjDPzr fZjHVmNl3l8mGmeowbudvYbPccTSpj3HGxW1SiEiri4iPM3Nh5lNdPt+4+JPdh5eplTm n3rQ== MIME-Version: 1.0 X-Received: by 10.194.89.138 with SMTP id bo10mr19746223wjb.22.1404573384111; Sat, 05 Jul 2014 08:16:24 -0700 (PDT) Received: by 10.217.180.74 with HTTP; Sat, 5 Jul 2014 08:16:24 -0700 (PDT) In-Reply-To: <8638egylnn.fsf@yandex.ru> References: <8638egylnn.fsf@yandex.ru> Date: Sat, 5 Jul 2014 23:16:24 +0800 Message-ID: Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow From: William Xu To: Dmitry Content-Type: multipart/alternative; boundary=047d7bf10b3c9efec104fd73b9e3 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: "17945@debbugs.gnu.org" <17945@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bf10b3c9efec104fd73b9e3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dmitry =E4=BA=8E2014=E5=B9=B47=E6=9C=885=E6=97=A5=E6=98= =9F=E6=9C=9F=E5=85=AD=E5=86=99=E9=81=93=EF=BC=9A > William Xu > writes: > > > C-x v g on a git file is very slow, compare this: > > What kind of repository are you doing this in? > > For me, it always works quite fast (usually <1 s) As you can see, I ran it on the emacs git mirror(git:// git.savannah.org/emacs.git). I can see this slowness on my several git repos where there are many files. I often fall back on running shell-command with 'git blame'. > > It seems the -C -C options would slow down git hugely, making this > > command almost useless. Can we remove it from default option list? > > These options provide a feature, so we shouldn't simply remove them. There are many features, the question is whether this is good for default setup. -William --=20 -William --047d7bf10b3c9efec104fd73b9e3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Dmitry <dgutov@yandex.ru= >=E4=BA=8E2014=E5=B9=B47=E6=9C=885=E6=97=A5=E6=98=9F=E6=9C=9F=E5=85=AD= =E5=86=99=E9=81=93=EF=BC=9A
William Xu &l= t;william.xwl@gmail.com> writes:

> C-x v g on a git file is very slow, compare this:

What kind of repository are you doing this in?

For me, it always works quite fast (usually <1 s)

As you can see, I ran= it on the emacs git mirror(git://git.savannah.org/emacs.git). =C2=A0I can see this slowness on my s= everal git repos where there are many files. =C2=A0I often fall back on run= ning shell-command with 'git blame'.=C2=A0

=C2=A0
> It seems the -C -C options would slow down git hugely, making this
> command almost useless. =C2=A0Can we remove it from default option lis= t?

These options provide a feature, so we shouldn't simply remove them.

There are many features, the question is whether this is good for default s= etup.

=C2=A0
-William

= =C2=A0


--
-William

--047d7bf10b3c9efec104fd73b9e3-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 05 12:16:02 2014 Received: (at 17945) by debbugs.gnu.org; 5 Jul 2014 16:16:02 +0000 Received: from localhost ([127.0.0.1]:44256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3Sd7-0002IJ-Kh for submit@debbugs.gnu.org; Sat, 05 Jul 2014 12:16:01 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:38237) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3Sd5-0002I1-3J for 17945@debbugs.gnu.org; Sat, 05 Jul 2014 12:16:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="76483179" Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Jul 2014 12:15:50 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 511E666172; Sat, 5 Jul 2014 12:15:40 -0400 (EDT) From: Stefan Monnier To: Dmitry Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow Message-ID: References: <8638egylnn.fsf@yandex.ru> Date: Sat, 05 Jul 2014 12:15:40 -0400 In-Reply-To: <8638egylnn.fsf@yandex.ru> (Dmitry's message of "Sat, 05 Jul 2014 16:34:20 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17945 Cc: William Xu , 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> It seems the -C -C options would slow down git hugely, making this >> command almost useless. Can we remove it from default option list? > These options provide a feature, so we shouldn't simply remove them. I think it makes sense to follow Git's defaults. > Maybe we should provide a user option. Indeed, vc-git-annotate-command should use (vc-switches 'git annotate). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 14:09:48 2015 Received: (at control) by debbugs.gnu.org; 17 Feb 2015 19:09:49 +0000 Received: from localhost ([127.0.0.1]:46553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNnWm-0001GE-LD for submit@debbugs.gnu.org; Tue, 17 Feb 2015 14:09:48 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:43481 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNnWk-0001G3-RQ for control@debbugs.gnu.org; Tue, 17 Feb 2015 14:09:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YNnWk-0005BF-AZ for control@debbugs.gnu.org; Tue, 17 Feb 2015 14:09:46 -0500 Date: Tue, 17 Feb 2015 14:09:46 -0500 Message-Id: Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 17945 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 02:39:38 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 07:39:38 +0000 Received: from localhost ([127.0.0.1]:56039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQA5i-0006sq-3r for submit@debbugs.gnu.org; Tue, 24 Feb 2015 02:39:38 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:33139 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQA5g-0006sj-V7 for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 02:39:37 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YQA5g-0002fM-Gf; Tue, 24 Feb 2015 02:39:36 -0500 From: Glenn Morris To: 17945@debbugs.gnu.org Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> X-Spook: Downing Street plutonium nuclear SSL Israel Delta Force X-Ran: %}(uES7oI(=>6W0QxhuhF*#;Yod1+ijOjew}jz":YQ99K^>zGj/]pfnN+fbg#EUI"=|+Sb X-Hue: yellow X-Attribution: GM Date: Tue, 24 Feb 2015 02:39:36 -0500 In-Reply-To: (Stefan Monnier's message of "Sat, 05 Jul 2014 12:15:40 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17945 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I find vc-annotate _unusably_ slow on the Emacs repo thanks to these -"C"s. Eg for rmailsum.el: 4 sec versus 5.5 minutes. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 10:32:05 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 15:32:05 +0000 Received: from localhost ([127.0.0.1]:56894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQHSq-0003Am-Mi for submit@debbugs.gnu.org; Tue, 24 Feb 2015 10:32:05 -0500 Received: from smtp11.acens.net ([86.109.99.135]:54983 helo=smtp.movistar.es) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQHSj-0003AT-Pz for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 10:31:58 -0500 Received: from qcore (88.10.128.129) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 54615F2D034FE752 for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 15:31:47 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: 17945@debbugs.gnu.org Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> Date: Tue, 24 Feb 2015 16:31:45 +0100 In-Reply-To: (Glenn Morris's message of "Tue, 24 Feb 2015 02:39:36 -0500") Message-ID: <87oaojuxzy.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17945 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) So what about this patch? Modified lisp/vc/vc-git.el diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index a31c121..07ff083 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -120,6 +120,16 @@ (defcustom vc-git-diff-switches t :version "23.1" :group 'vc-git) +(defcustom vc-git-annotate-switches t + "String or list of strings specifying switches for Git blame under VC. +If nil, use the value of `vc-annotate-switches'. If t, use no switches." + :type '(choice (const :tag "Unspecified" nil) + (const :tag "None" t) + (string :tag "Argument String") + (repeat :tag "Argument List" :value ("") string)) + :version "25.1" + :group 'vc-git) + (defcustom vc-git-program "git" "Name of the Git executable (excluding any arguments)." :version "24.1" @@ -1013,7 +1023,9 @@ (defun vc-git-revision-completion-table (files) (defun vc-git-annotate-command (file buf &optional rev) (let ((name (file-relative-name file))) - (vc-git-command buf 'async nil "blame" "--date=iso" "-C" "-C" rev "--" name))) + (apply #'vc-git-command buf 'async nil "blame" "--date=iso" + (append (vc-switches 'git 'annotate) + (list rev "--" name))))) (declare-function vc-annotate-convert-time "vc-annotate" (time)) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 11:12:36 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 16:12:36 +0000 Received: from localhost ([127.0.0.1]:56903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQI68-00044w-HB for submit@debbugs.gnu.org; Tue, 24 Feb 2015 11:12:36 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:38702) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQI65-00044f-Ud for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 11:12:35 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NKA00300A25WH00@a-mtaout23.012.net.il> for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 18:12:26 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKA003V3ACQVJ20@a-mtaout23.012.net.il>; Tue, 24 Feb 2015 18:12:26 +0200 (IST) Date: Tue, 24 Feb 2015 18:12:35 +0200 From: Eli Zaretskii Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow In-reply-to: <87oaojuxzy.fsf@wanadoo.es> X-012-Sender: halo1@inter.net.il To: =?iso-8859-1?Q?=D3scar?= Fuentes Message-id: <83lhjn70gc.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 8BIT References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Óscar Fuentes > Date: Tue, 24 Feb 2015 16:31:45 +0100 > > So what about this patch? Why not a prefix argument? It's easier to set once when one needs it, and is the usual way in Emacs to provide minor variations of commands. Or maybe do both, for those who might want this optional behavior always (although given the massive slow-down, and the general dismissal of the issue among git users, I doubt that such a person exists). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 11:36:55 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 16:36:55 +0000 Received: from localhost ([127.0.0.1]:56908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQITe-0004dD-Mp for submit@debbugs.gnu.org; Tue, 24 Feb 2015 11:36:54 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:55959) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQITc-0004cz-BT for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 11:36:52 -0500 Received: by mail-wi0-f174.google.com with SMTP id em10so26879815wid.1 for <17945@debbugs.gnu.org>; Tue, 24 Feb 2015 08:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=vaRr0sWEVWI+GEivwbZz+/U3TiNXL9wsRDhu3rVnc/c=; b=g+e48dseu7wpzA7xt7ZwCj0z8PaTlBYl1frZ79qXQdOS/5pu6dBg/HC5VWo3ocaWwV xtVbG/r1XAgTYt55NgQAd+clR0xoplZXfcSY0n+cXTb32WjmurzWLkqzSm2gQCKqpFkn lbHfgIgHNknQSfd7pvZRVhbbTnCmi4WnzICXEFUGaKlY1OZJ7ojIjLbwT6QG6ryWXAif ovnu9DHsnrI3RWAdK1EVt65EowbHWIUARwGcI2nmd3UN8nplGyST34y+GTLNT5SEkt3O fuzVObe2YpUhaqHO4RRFXGY3dSrIGzT1i4dXsJocODUfwF73HIBZWtYQangX8ZZMhvKf TVZA== X-Received: by 10.194.133.68 with SMTP id pa4mr34536970wjb.26.1424795806395; Tue, 24 Feb 2015 08:36:46 -0800 (PST) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id l4sm21236173wiw.9.2015.02.24.08.36.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 08:36:45 -0800 (PST) Message-ID: <54ECA89B.5060301@yandex.ru> Date: Tue, 24 Feb 2015 18:36:43 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Eli Zaretskii , =?UTF-8?Q?=c3=93scar_Fuentes?= Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <83lhjn70gc.fsf@gnu.org> In-Reply-To: <83lhjn70gc.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/24/2015 06:12 PM, Eli Zaretskii wrote: > Why not a prefix argument? It's easier to set once when one needs it, > and is the usual way in Emacs to provide minor variations of commands. I'm pretty sure `vc-switches' is the usual way to provide invocation arguments variations in VC, or else there would be no such function. > Or maybe do both, for those who might want this optional behavior > always (although given the massive slow-down, and the general > dismissal of the issue among git users, I doubt that such a person > exists). I believe you should rather customize the new variable once and for all for your preference, or set it on by-project basis, in .dir-locals.el. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 11:47:21 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 16:47:22 +0000 Received: from localhost ([127.0.0.1]:56916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQIdl-0004sp-2h for submit@debbugs.gnu.org; Tue, 24 Feb 2015 11:47:21 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:35480) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQIdi-0004sc-MH for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 11:47:19 -0500 Received: by wggz12 with SMTP id z12so6533988wgg.2 for <17945@debbugs.gnu.org>; Tue, 24 Feb 2015 08:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=+GuwI6p+1VwI8UzTZ3vHxfFYxJFHgauJpNjsT7BLorc=; b=rX7G0nTt1It9tuKRKU2T6xdyPdLncuJlBgFxVAMYhzaSlFDOigxVcRW2gbtqKZ90eb 0+9nySUeUjc5NFp1Ft/5ZZKD7qMXbCplLd8v2FgFRKR9qojKwzypMq6UKgFYRxYyt4+N K2cJ2202ewsyoUGPjTO7EnBveQuUJFYN0mqiEoq9Uzdd94lBz2CmzIIlyaP5X/wcw5ZN jBdkxjzlS7A51TWy9UMKUMkEorf0JEZPixcOvtyKouy3cGmp03F/zDNlFQbyLuiUqnBr SiPO3/taGkAauZFW9dL+g5339zoGUEF8C6ASnyibAIw7ufzk9PwFubi6X20+yB9tCGrI 0PPw== X-Received: by 10.194.2.75 with SMTP id 11mr33868963wjs.78.1424796432602; Tue, 24 Feb 2015 08:47:12 -0800 (PST) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id x6sm60975517wjf.24.2015.02.24.08.47.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 08:47:12 -0800 (PST) Message-ID: <54ECAB0E.2080109@yandex.ru> Date: Tue, 24 Feb 2015 18:47:10 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Glenn Morris , 17945@debbugs.gnu.org Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/24/2015 09:39 AM, Glenn Morris wrote: > > I find vc-annotate _unusably_ slow on the Emacs repo thanks to these -"C"s. > Eg for rmailsum.el: 4 sec versus 5.5 minutes. It takes ~40 sec with '-C -C' (as opposed to <1 sec) on my machine, with a fast SSD and Git 2.1.0. So it'd say it's usable. The difference, I agree, is pretty striking, but rmailsum.el seems to be one of the worst cases. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 12:56:04 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 17:56:04 +0000 Received: from localhost ([127.0.0.1]:56959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQJiG-0006e8-AZ for submit@debbugs.gnu.org; Tue, 24 Feb 2015 12:56:04 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:33969 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQJiE-0006e0-G1 for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 12:56:02 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YQJiD-0002OB-PQ; Tue, 24 Feb 2015 12:56:01 -0500 From: Glenn Morris To: Dmitry Gutov Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <54ECAB0E.2080109@yandex.ru> X-Spook: Ansar al-Islam BLU-97 A/B FIPS140 InfoSec president X-Ran: YoH6MVmv_@.)Q:k7q/tEmfVrIJ2Qrob&/nXF0#k|)kz}*MuAf*Fe]=]]a"gJm]Kh1QB-!I X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 24 Feb 2015 12:56:01 -0500 In-Reply-To: <54ECAB0E.2080109@yandex.ru> (Dmitry Gutov's message of "Tue, 24 Feb 2015 18:47:10 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Dmitry Gutov wrote: > On 02/24/2015 09:39 AM, Glenn Morris wrote: >> >> I find vc-annotate _unusably_ slow on the Emacs repo thanks to these -"C"s. >> Eg for rmailsum.el: 4 sec versus 5.5 minutes. > > It takes ~40 sec with '-C -C' (as opposed to <1 sec) on my machine, > with a fast SSD and Git 2.1.0. So it'd say it's usable. Great, please send me your machine by soonest post. :) It's unusable for me, and as Stefan said earlier, Emacs should follow git's defaults. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 12:58:00 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 17:58:00 +0000 Received: from localhost ([127.0.0.1]:56963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQJk7-0006gs-O7 for submit@debbugs.gnu.org; Tue, 24 Feb 2015 12:58:00 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:34067 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQJk6-0006gl-57 for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 12:57:58 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YQJk5-0006CB-5K; Tue, 24 Feb 2015 12:57:57 -0500 From: Glenn Morris To: =?utf-8?Q?=C3=93scar?= Fuentes Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> X-Spook: offensive information warfare SWAT Watergate hackers X-Ran: d>7=?4^KSls4O|nsUI!KCZ_mfMRF9X^[_!j~+/_|X",.kL3^.S+(,!32Iu[yipOp/VuOsl X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 24 Feb 2015 12:57:57 -0500 In-Reply-To: <87oaojuxzy.fsf@wanadoo.es> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Tue, 24 Feb 2015 16:31:45 +0100") Message-ID: <3i385vur8a.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) =C3=93scar Fuentes wrote: > So what about this patch? Looks, right, except vc-annotate-switches does not exist and would also need to be added. And for consistency, presumably all backends should get the same treatment. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 13:05:03 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 18:05:03 +0000 Received: from localhost ([127.0.0.1]:56976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQJqw-0006tU-3T for submit@debbugs.gnu.org; Tue, 24 Feb 2015 13:05:02 -0500 Received: from mail-we0-f171.google.com ([74.125.82.171]:35760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQJqt-0006sx-59 for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 13:04:59 -0500 Received: by wevl61 with SMTP id l61so22709111wev.2 for <17945@debbugs.gnu.org>; Tue, 24 Feb 2015 10:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=eDoVViJkByp2MgC1lnfbQeVaNZ5i7f7ieJpoS3fFX9Q=; b=1FWk12QaXpW/6gVT81apIHqLv4lxVNDfRZr2yqSILKYqq2G5WH2z+35vdlwNhurH1n bZqWFySIehqLJMrFGAXOQu6ssBRhvqwSA7SalHdEMXjPPB4hOgE9wurTzdtG9qTxIJoU 2s4Pi3x/n0rHM6PWj9wCzti8bKFmYonT/p9PmQmh+09rS25Eo07N3kuTerKKD26exGp0 h8B4SM1i+MVd18H4TBpeUJEq0zEnVY9ONqDIu92rSe/MUdxubHxrEZi6jmG25hL+GGMq /cK1CZNF6MRs588zRP9DvUeaqg7ntmsMwqxubCFRQrJGUmtZZxGKh0yR6mXpJ96DTSS7 3SDA== X-Received: by 10.180.188.41 with SMTP id fx9mr32247077wic.93.1424801093236; Tue, 24 Feb 2015 10:04:53 -0800 (PST) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id k1sm61241488wjn.9.2015.02.24.10.04.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 10:04:52 -0800 (PST) Message-ID: <54ECBD41.3060809@yandex.ru> Date: Tue, 24 Feb 2015 20:04:49 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <54ECAB0E.2080109@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/24/2015 07:56 PM, Glenn Morris wrote: > Great, please send me your machine by soonest post. :) I'll get right on that. :) > It's unusable for me, Maybe you could also benefit from upgrading your Git, you've never mentioned the version. > and as Stefan said earlier, Emacs should follow > git's defaults. Anyway, no argument from me here. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 15:55:31 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 20:55:31 +0000 Received: from localhost ([127.0.0.1]:57045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQMVu-0007uX-P5 for submit@debbugs.gnu.org; Tue, 24 Feb 2015 15:55:30 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:36041) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQMVs-0007uI-JB for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 15:55:29 -0500 Received: by wevk48 with SMTP id k48so27790449wev.3 for <17945@debbugs.gnu.org>; Tue, 24 Feb 2015 12:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=7e3ozquyVIqAw8ZzG9Qwdm67dSOlaejzkDcRgNT0sxg=; b=MlfoS5rXg/RtMJPxUcFDLxHAFrW8q/XKEq74c4RhRx6rMrGXgn+JLBJqB9TKBjB1M1 Zb3WGu53plqIf50FQPpH18zNFMWx03egidrNIAo3mDtncavA42+gv1OFHRF1OUMq4TbU wdZ5N0ffdYflKQ1rOWgxpuyNY2TDnXITIdCgLD5PKaZY7HPEFj64BuR2G/E3HKoRwszt qdZLGi+VfQbpVgQ/hj0Y61z4gTv3SaldB/CIaj7CNgM7fT4UdVXwQEVKxtMNi4w1Ho7r rCh1kwHEskl8YnZmIh9Q57ZYyyXYyhQ4IW1wUgg9958ReIYEIbScm2NOCiqe9TOfFOYg frag== X-Received: by 10.180.77.196 with SMTP id u4mr34632204wiw.6.1424811322593; Tue, 24 Feb 2015 12:55:22 -0800 (PST) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id s19sm22081059wik.18.2015.02.24.12.55.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 12:55:21 -0800 (PST) Message-ID: <54ECE538.1070601@yandex.ru> Date: Tue, 24 Feb 2015 22:55:20 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Glenn Morris , =?UTF-8?Q?=c3=93scar_Fuentes?= Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> In-Reply-To: <3i385vur8a.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/24/2015 07:57 PM, Glenn Morris wrote: > except vc-annotate-switches does not exist and would also > need to be added. I think this is only justified if we expect different backends' annotate command to receive the same options. So far, only '-w' looks a likely candidate, albeit its descriptions are a bit different between Git and Hg. And it's not in e.g. Bzr. What if the user sets `vc-annotate-switches' to '-w', and then calls `vc-annotate' in a Bazaar repository, where it'll obviously lead to failure? > And for consistency, presumably all backends should > get the same treatment. Thanks. Probably. But I'd rather the present patch gets installed without too much delay. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 24 17:25:20 2015 Received: (at 17945) by debbugs.gnu.org; 24 Feb 2015 22:25:20 +0000 Received: from localhost ([127.0.0.1]:57087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQNup-0001Ye-5d for submit@debbugs.gnu.org; Tue, 24 Feb 2015 17:25:19 -0500 Received: from relaycp04.dominioabsoluto.net ([217.116.26.100]:53999) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQNul-0001YM-IA for 17945@debbugs.gnu.org; Tue, 24 Feb 2015 17:25:17 -0500 Received: from smtp.movistar.es (smtp09.acens.net [86.109.99.133]) by relaycp04.dominioabsoluto.net (Postfix) with ESMTP id 3AE67D0208D; Tue, 24 Feb 2015 23:25:09 +0100 (CET) X-CTCH-RefID: str=0001.0A0B020A.54ECFA45.0022, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-Spam: Unknown Received: from qcore (88.10.128.129) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 54CEB59A00C22549; Tue, 24 Feb 2015 22:25:09 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: Dmitry Gutov Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> <54ECE538.1070601@yandex.ru> Date: Tue, 24 Feb 2015 23:25:07 +0100 In-Reply-To: <54ECE538.1070601@yandex.ru> (Dmitry Gutov's message of "Tue, 24 Feb 2015 22:55:20 +0200") Message-ID: <87k2z7uev0.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: Glenn Morris , 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > On 02/24/2015 07:57 PM, Glenn Morris wrote: > >> except vc-annotate-switches does not exist and would also >> need to be added. > > I think this is only justified if we expect different backends' > annotate command to receive the same options. Actually, I implemented vc-annotate-switches too, but at the end excluded it from the patch for the reason you mentioned. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 25 12:46:24 2015 Received: (at 17945) by debbugs.gnu.org; 25 Feb 2015 17:46:24 +0000 Received: from localhost ([127.0.0.1]:58037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQg2R-0007o2-By for submit@debbugs.gnu.org; Wed, 25 Feb 2015 12:46:23 -0500 Received: from relaycp04.dominioabsoluto.net ([217.116.26.100]:54586) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQg2O-0007no-Ab for 17945@debbugs.gnu.org; Wed, 25 Feb 2015 12:46:21 -0500 Received: from smtp.movistar.es (smtp08.acens.net [86.109.99.132]) by relaycp04.dominioabsoluto.net (Postfix) with ESMTP id C1BC064495; Wed, 25 Feb 2015 18:46:13 +0100 (CET) X-CTCH-RefID: str=0001.0A0B020D.54EE0A65.00F2, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-Spam: Unknown Received: from qcore (88.10.128.129) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 549C742B01FAA3B7; Wed, 25 Feb 2015 17:46:13 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: Dmitry Gutov Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> <54ECE538.1070601@yandex.ru> Date: Wed, 25 Feb 2015 18:46:12 +0100 In-Reply-To: <54ECE538.1070601@yandex.ru> (Dmitry Gutov's message of "Tue, 24 Feb 2015 22:55:20 +0200") Message-ID: <87wq35yjdn.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: Glenn Morris , 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > On 02/24/2015 07:57 PM, Glenn Morris wrote: > >> except vc-annotate-switches does not exist and would also >> need to be added. > > I think this is only justified if we expect different backends' > annotate command to receive the same options. As the docstrings of vc-BACKEND-annotate-switches mention vc-annotate-switches *and* vc-switches checks vc-annotate-switches, I changed my mind again and implemented vc-annotate-switches with a caveat on the docstring. Please review and suggest a better wording, if necessary: (defcustom vc-annotate-switches nil "A string or list of strings specifying switches for annotate under VC. When running annotate under a given BACKEND, VC uses the first non-nil value of `vc-BACKEND-annotate-switches', `vc-annotate-switches', and `annotate-switches', in that order. Since nil means to check the next variable in the sequence, either of the first two may use the value t to mean no switches at all. `vc-annotate-switches' should contain switches that are specific to version control, but not specific to any particular backend. As very few switches (if any) are used across different VC tools, please consider using the specific `vc-BACKEND-annotate-switches' for the backend you use." :type '(choice (const :tag "Unspecified" nil) (const :tag "None" t) (string :tag "Argument String") (repeat :tag "Argument List" :value ("") string)) :group 'vc :version "25.1") > So far, only '-w' looks a likely candidate, albeit its descriptions > are a bit different between Git and Hg. And it's not in e.g. Bzr. > > What if the user sets `vc-annotate-switches' to '-w', and then calls > `vc-annotate' in a Bazaar repository, where it'll obviously lead to > failure? > >> And for consistency, presumably all backends should >> get the same treatment. Thanks. > > Probably. But I'd rather the present patch gets installed without too > much delay. I extended the vc-switches support to the rest of backends that implement `vc-BACKEND-annotate-command', except rcs, that does some complicated things (and I have no easy way of testing it.) Once we agree on the resolution of the vc-annotate-switches issue, I'll commit the changes. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 25 12:58:48 2015 Received: (at 17945) by debbugs.gnu.org; 25 Feb 2015 17:58:48 +0000 Received: from localhost ([127.0.0.1]:58045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQgES-00085V-DY for submit@debbugs.gnu.org; Wed, 25 Feb 2015 12:58:48 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:37454) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQgEQ-00085G-J6 for 17945@debbugs.gnu.org; Wed, 25 Feb 2015 12:58:47 -0500 Received: by wesw55 with SMTP id w55so5251755wes.4 for <17945@debbugs.gnu.org>; Wed, 25 Feb 2015 09:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=YpSCOc4N5lDsE+BPH+q9JDoEkiILqVJBU3ZEZxh0Rew=; b=IrMzaEg1wldNqGnyrX0Y1c3wc8/zqWnySIFjOUh29ljToXMU712rPAWUyV32WRKv4Y sL/tlJRf0EILl53+4vwM+P0aKbsZdkyzr8e8pW6Y5jfn6mTkY0AQT9nxh+4JsdQwpdWK rCBDzcjuJ6GiiI1Xpo0LcAIQ/et62C/3UtfcTFgLeowLCPUprlMlbNAwyxkIdIK3pQl9 6AgevpEymin3SOl1sYO107rCPC4X1Q1mAX4gbpxdLDG4OCBwyWIiDcuXCnNW597Ss2zR S4BeyYL8DtCBrlBHT09MccQlwA67zc5DwPdFN/6M0q3kRcnYLwhBtBQYuy3N3OqapqvK DSWQ== X-Received: by 10.180.77.196 with SMTP id u4mr43366030wiw.6.1424887119931; Wed, 25 Feb 2015 09:58:39 -0800 (PST) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id gf11sm459258wic.18.2015.02.25.09.58.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2015 09:58:39 -0800 (PST) Message-ID: <54EE0D4C.7020309@yandex.ru> Date: Wed, 25 Feb 2015 19:58:36 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: =?UTF-8?Q?=c3=93scar_Fuentes?= Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> <54ECE538.1070601@yandex.ru> <87wq35yjdn.fsf@wanadoo.es> In-Reply-To: <87wq35yjdn.fsf@wanadoo.es> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: Glenn Morris , 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/25/2015 07:46 PM, Óscar Fuentes wrote: > As the docstrings of vc-BACKEND-annotate-switches mention > vc-annotate-switches *and* vc-switches checks vc-annotate-switches, How about avoiding the mention of `vc-annotate-switches' in those docstrings instead? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 25 13:06:34 2015 Received: (at 17945) by debbugs.gnu.org; 25 Feb 2015 18:06:34 +0000 Received: from localhost ([127.0.0.1]:58049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQgLx-0008Hr-9C for submit@debbugs.gnu.org; Wed, 25 Feb 2015 13:06:33 -0500 Received: from relaycp04.dominioabsoluto.net ([217.116.26.100]:56483) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQgLu-0008Hd-MF for 17945@debbugs.gnu.org; Wed, 25 Feb 2015 13:06:31 -0500 Received: from smtp.movistar.es (smtp20.acens.net [86.109.99.144]) by relaycp04.dominioabsoluto.net (Postfix) with ESMTP id 2EBD1640E4; Wed, 25 Feb 2015 19:06:25 +0100 (CET) X-CTCH-RefID: str=0001.0A0B0207.54EE0F21.004A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-Spam: Unknown Received: from qcore (88.10.128.129) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 54472CB7041512FF; Wed, 25 Feb 2015 18:06:25 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: Dmitry Gutov Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> <54ECE538.1070601@yandex.ru> <87wq35yjdn.fsf@wanadoo.es> <54EE0D4C.7020309@yandex.ru> Date: Wed, 25 Feb 2015 19:06:23 +0100 In-Reply-To: <54EE0D4C.7020309@yandex.ru> (Dmitry Gutov's message of "Wed, 25 Feb 2015 19:58:36 +0200") Message-ID: <87bnkh9880.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: Glenn Morris , 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > On 02/25/2015 07:46 PM, =C3=93scar Fuentes wrote: > >> As the docstrings of vc-BACKEND-annotate-switches mention >> vc-annotate-switches *and* vc-switches checks vc-annotate-switches, > > How about avoiding the mention of `vc-annotate-switches' in those > docstrings instead? vc-switches does check `vc-annotate-switches' (as it checks vc-OP-switches for any other OP and BACKEND), so we are hiding information from the user. The whole problem consists on a generic approach (vc-OP-switches) that doesn't play nice for some (all?) OPs. So we either get rid of `vc-OP-switches' entirely or warn the user about its pitfalls. (Is there an OP where `vc-OP-switches' works well across more than two supported backends?) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 25 15:37:24 2015 Received: (at 17945) by debbugs.gnu.org; 25 Feb 2015 20:37:24 +0000 Received: from localhost ([127.0.0.1]:58079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQihv-0003Le-HP for submit@debbugs.gnu.org; Wed, 25 Feb 2015 15:37:23 -0500 Received: from mail-we0-f177.google.com ([74.125.82.177]:34771) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQihr-0003LL-FT for 17945@debbugs.gnu.org; Wed, 25 Feb 2015 15:37:20 -0500 Received: by wesq59 with SMTP id q59so6096048wes.1 for <17945@debbugs.gnu.org>; Wed, 25 Feb 2015 12:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=aR9QNpXrpr7wN53legD+4IeqPGpmlsdB2KxXIur+9vw=; b=CDFOAPeSEDibyJWnuLrn6wMSyxAjJYdrFREAhsZ+/1RxfVcjIb9lp/+bh1igMqeOKk j7QK1nrHlyMgnmq8t40KPOKM4lfL8xX6nOPyWTJALoJzGbM4FX1K+Vgt1p8nBikKFh0L qKcK0Cy25D3M5r4Jm9jfF3/0kXK09MKVvFUJBJtzdsSbR46XczKbS45ytA/TD9ICeuUk wNRKb4qS3jbiHWBdsEbh8d0bW9YgnE/llj6Oy3K8DBGY5G+K8WnEJItU54Z4ouxNAhPk QJ3FYpgHMMfYVB6aFwzGhZIKbV+LcUuJ8waApbs1rQwwbdPZOOeyPxJqktkQV8yMWE/s ytxQ== X-Received: by 10.180.75.108 with SMTP id b12mr3024959wiw.44.1424896633787; Wed, 25 Feb 2015 12:37:13 -0800 (PST) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id h11sm26670443wic.14.2015.02.25.12.37.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2015 12:37:13 -0800 (PST) Message-ID: <54EE3275.6050402@yandex.ru> Date: Wed, 25 Feb 2015 22:37:09 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: =?UTF-8?Q?=c3=93scar_Fuentes?= Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> <54ECE538.1070601@yandex.ru> <87wq35yjdn.fsf@wanadoo.es> <54EE0D4C.7020309@yandex.ru> <87bnkh9880.fsf@wanadoo.es> In-Reply-To: <87bnkh9880.fsf@wanadoo.es> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945 Cc: 17945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/25/2015 08:06 PM, Óscar Fuentes wrote: > vc-switches does check `vc-annotate-switches' (as it checks > vc-OP-switches for any other OP and BACKEND), so we are hiding > information from the user. But there's no such user option. And if a variable with that name is created, well, the user stepped on something nobody asked them too. > The whole problem consists on a generic approach (vc-OP-switches) that > doesn't play nice for some (all?) OPs. So we either get rid of > `vc-OP-switches' entirely or warn the user about its pitfalls. I think in this case we can just as well avoid using `vc-switches' and reference `vc-git-annotate-switches' directly. > (Is there an OP where `vc-OP-switches' works well across more than two > supported backends?) vc-diff-switches works pretty well. The rest of -switches variables, though, look similarly suspicious to me. That's vc-checkin-switches, vc-checkout-switches and vc-register-switches. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 26 09:56:15 2015 Received: (at 17945-done) by debbugs.gnu.org; 26 Feb 2015 14:56:15 +0000 Received: from localhost ([127.0.0.1]:58832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQzrL-0005w4-HJ for submit@debbugs.gnu.org; Thu, 26 Feb 2015 09:56:15 -0500 Received: from relaycp03.dominioabsoluto.net ([217.116.26.84]:57791) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQzrJ-0005vw-7f for 17945-done@debbugs.gnu.org; Thu, 26 Feb 2015 09:56:14 -0500 Received: from smtp.movistar.es (smtp09.acens.net [86.109.99.133]) by relaycp03.dominioabsoluto.net (Postfix) with ESMTP id 8C7B2BFA356; Thu, 26 Feb 2015 15:56:06 +0100 (CET) X-CTCH-RefID: str=0001.0A0B0203.54EF3406.011C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-Spam: Unknown Received: from qcore (88.10.128.129) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 54CEB59A00D0AD3E; Thu, 26 Feb 2015 14:56:06 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: Glenn Morris Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow References: <8638egylnn.fsf@yandex.ru> <87oaojuxzy.fsf@wanadoo.es> <3i385vur8a.fsf@fencepost.gnu.org> Date: Thu, 26 Feb 2015 15:56:05 +0100 In-Reply-To: <3i385vur8a.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 24 Feb 2015 12:57:57 -0500") Message-ID: <877fv490xm.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17945-done Cc: 17945-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Glenn Morris writes: > =C3=93scar Fuentes wrote: > >> So what about this patch? > > Looks, right, except vc-annotate-switches does not exist and would also > need to be added. And for consistency, presumably all backends should > get the same treatment. Thanks. Implemented on b5a0603eb41c7a350c16a1b3ec5c1b8d8c84a4eb. I'm neutral about the existence of vc-annotate-switches, so if anyone wants to remove it (including mentions on the docstrings of vc-BACKEND-annotate-switches) it's fine with me. From unknown Wed Jun 18 23:13:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Mar 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator