GNU bug report logs - #179
23.0.60; Menu separators are not displayed

Previous Next

Package: emacs;

Reported by: David Kastrup <dak <at> gnu.org>

Date: Thu, 1 May 2008 22:05:07 UTC

Severity: normal

Tags: moreinfo, patch

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 179 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 179 <at> debbugs.gnu.org
Subject: Menu separators are not displayed
Date: Mon, 05 May 2008 03:00:00 -0400
Does the patch below fix it?


        Stefan


--- subr.el.~1.594.~	2008-05-02 12:47:05.000000000 -0400
+++ subr.el	2008-05-05 02:58:00.000000000 -0400
@@ -571,10 +571,14 @@
       (let* ((key (car binding))
              (item (cdr binding))
              (oldbind (assq key bindings)))
+        (if (null key)
+            ;; nil keys are/were used by easy-menu for "separator lines and
+            ;; separator titles".  Merging them makes no sense.
+            (push binding bindings)
         ;; Newer bindings override older.
         (if oldbind (setq bindings (delq oldbind bindings)))
         (when item                      ;nil bindings just hide older ones.
-          (push binding bindings))))
+            (push binding bindings)))))
     (nconc map bindings)))
 
 (put 'keyboard-translate-table 'char-table-extra-slots 0)




This bug report was last modified 16 years and 338 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.