From unknown Sat Aug 09 09:35:47 2025 X-Loop: don@donarmstrong.com Subject: bug#179: 23.0.60; Menu separators are not displayed Reply-To: David Kastrup , 179@debbugs.gnu.org Resent-From: David Kastrup Original-Sender: emacs-devel-bounces+monnier=iro.umontreal.ca@gnu.org Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 01 May 2008 22:05:07 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.120967901421532 (code B ref -1); Thu, 01 May 2008 22:05:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 1 May 2008 21:56:54 +0000 Received: from mercure.iro.umontreal.ca (mercure.iro.umontreal.ca [132.204.24.67]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m41LuoLc021526 for ; Thu, 1 May 2008 14:56:51 -0700 Received: by mercure.iro.umontreal.ca (Postfix, from userid 20848) id C93EA2CFC9B; Thu, 1 May 2008 17:56:49 -0400 (EDT) X-Original-To: monnier@iro.umontreal.ca Delivered-To: monnier@iro.umontreal.ca Received: from pinpin.iro.umontreal.ca (pinpin.iro.umontreal.ca [132.204.24.52]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 844372CFC96 for ; Thu, 1 May 2008 17:56:49 -0400 (EDT) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by pinpin.iro.umontreal.ca (Postfix) with ESMTP id 2B7153B8B43 for ; Thu, 1 May 2008 17:56:45 -0400 (EDT) Received: from localhost ([127.0.0.1]:48189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jrglg-0001ch-Rg for monnier@iro.umontreal.ca; Thu, 01 May 2008 17:56:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JrglP-0001cc-Q7 for emacs-devel@gnu.org; Thu, 01 May 2008 17:56:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JrglO-0001cQ-MX for emacs-devel@gnu.org; Thu, 01 May 2008 17:56:26 -0400 Received: from [199.232.76.173] (port=56872 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JrglO-0001cN-HP for emacs-devel@gnu.org; Thu, 01 May 2008 17:56:26 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JrglO-0000WR-9Y for emacs-devel@gnu.org; Thu, 01 May 2008 17:56:26 -0400 Received: from localhost ([127.0.0.1]:33413 helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Jrgl1-0004hf-Ri for emacs-pretest-bug@gnu.org; Thu, 01 May 2008 17:56:04 -0400 Received: by lola.goethe.zz (Postfix, from userid 1002) id EBA401C4F903; Thu, 1 May 2008 23:56:23 +0200 (CEST) From: David Kastrup To: emacs-pretest-bug@gnu.org Date: Thu, 01 May 2008 23:56:22 +0200 Message-ID: <85hcdhadtl.fsf@lola.goethe.zz> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Cc: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-devel-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: emacs-devel-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.94, requis 5, BAYES_00 -2.60, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: emacs-devel-bounces+monnier=iro.umontreal.ca@gnu.org Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I have a menu looking like preview-menu's value is shown below. Documentation: This is the menu for preview-latex. Value: (keymap "Preview" (nil menu-item "Generate previews") (\(or\ toggle\)\ at\ point menu-item "(or toggle) at point" preview-at-point ([3 16 16] . " C-c C-p C-p")) (for\ environment menu-item "for environment" preview-environment ([3 16 5] . " C-c C-p C-e")) (for\ section menu-item "for section" preview-section ([3 16 19] . " C-c C-p C-s")) (for\ region menu-item "for region" preview-region ([3 16 18] . " C-c C-p C-r") :enable (preview-mark-active)) (for\ buffer menu-item "for buffer" preview-buffer ([3 16 2] . " C-c C-p C-b")) (for\ document menu-item "for document" preview-document ([3 16 4] . " C-c C-p C-d")) (nil menu-item "---") (nil menu-item "Remove previews") (at\ point menu-item "at point" preview-clearout-at-point ([3 16 3 16] . " C-c C-p C-c C-p")) (from\ section menu-item "from section" preview-clearout-section ([3 16 3 19] . " C-c C-p C-c C-s")) (from\ region menu-item "from region" preview-clearout ([3 16 3 18] . " C-c C-p C-c C-r") :enable (preview-mark-active)) (from\ buffer menu-item "from buffer" preview-clearout-buffer ([3 16 3 2] . " C-c C-p C-c C-b")) (from\ document menu-item "from document" preview-clearout-document ([3 16 3 4] . " C-c C-p C-c C-d")) (nil menu-item "---") (nil menu-item "Turn preamble cache") (on menu-item "on" preview-cache-preamble ([3 16 6] . " C-c C-p C-f")) (off menu-item "off" preview-cache-preamble-off ([3 16 3 6] . " C-c C-p C-c C-f")) (nil menu-item "---") (Customize menu-item "Customize" (keymap "Customize" (Browse\ options menu-item "Browse options" menu-function-194 (nil) :key-sequence nil) (Extend\ this\ menu menu-item "Extend this menu" menu-function-195 (nil) :key-sequence nil))) (Read\ documentation menu-item "Read documentation" preview-goto-info-page ([3 16 9] . " C-c C-p TAB")) (Report\ Bug menu-item "Report Bug" preview-report-bug (nil))) [back] and neither the separator lines nor the separator titles are shown. This menu was generated using (easy-menu-define preview-menu LaTeX-mode-map "This is the menu for preview-latex." '("Preview" "Generate previews" ["(or toggle) at point" preview-at-point] ["for environment" preview-environment] ["for section" preview-section] ["for region" preview-region (preview-mark-active)] ["for buffer" preview-buffer] ["for document" preview-document] "---" "Remove previews" ["at point" preview-clearout-at-point] ["from section" preview-clearout-section] ["from region" preview-clearout (preview-mark-active)] ["from buffer" preview-clearout-buffer] ["from document" preview-clearout-document] "---" "Turn preamble cache" ["on" preview-cache-preamble] ["off" preview-cache-preamble-off] "---" ("Customize" ["Browse options" (customize-group 'preview)] ["Extend this menu" (easy-menu-add-item nil '("Preview") (customize-menu-create 'preview))]) ["Read documentation" preview-goto-info-page] ["Report Bug" preview-report-bug])) In GNU Emacs 23.0.60.8 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2008-05-01 on lola Windowing system distributor `The X.Org Foundation', version 11.0.10400090 configured using `configure '--prefix=/usr/local/emacs-21' '--without-toolkit-scroll-bars' 'CFLAGS=-g -O2 -fno-crossjumping'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: LaTeX Minor modes in effect: reftex-mode: t desktop-save-mode: t minibuffer-electric-default-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x k C-x b b o g i f g o f o < C-/ < C-s h y p p e r r e f C-s C-s C-s C-x b p r e v C-g C-x o C-x C-f / h o m e p / t m p / a u c t e x / p r e v i e w / p r v - e m C-x 1 C-g C-s o n C-s m e n u C-s C-s C-s C-x b C-g C-x C-f m e n p r e v i e w . e l C-s m e n u C-s C-s C-s C-s C-s C-s C-h v p r e v i e w - m e n C-x o C-x b b i g f o o t . t e d i s s . t e x Recent messages: Quit Note: file is write protected Undo! Mark set Mark saved where search started Quit [2 times] Mark saved where search started [2 times] Quit Mark saved where search started Type C-x 1 to delete the help window, C-M-v to scroll help. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum From unknown Sat Aug 09 09:35:47 2025 X-Loop: don@donarmstrong.com Subject: bug#179: Menu separators are not displayed Reply-To: Stefan Monnier , 179@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 05 May 2008 07:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 179-submit@emacsbugs.donarmstrong.com id=B179.120997081818654 (code B ref 179); Mon, 05 May 2008 07:10:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.5 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 179) by emacsbugs.donarmstrong.com; 5 May 2008 07:00:18 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m4570A5F018254 for <179@emacsbugs.donarmstrong.com>; Mon, 5 May 2008 00:00:12 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhQDAIpNHkjO+JghdGdsb2JhbACBU5AiASeXYA X-IronPort-AV: E=Sophos;i="4.27,436,1204520400"; d="scan'208";a="19913369" Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 05 May 2008 03:00:05 -0400 Received: from pastel.home ([206.248.152.33]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id LMF03905; Mon, 05 May 2008 03:00:05 -0400 Received: by pastel.home (Postfix, from userid 20848) id AF317856B; Mon, 5 May 2008 03:00:00 -0400 (EDT) From: Stefan Monnier To: 179@debbugs.gnu.org Message-ID: Date: Mon, 05 May 2008 03:00:00 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Does the patch below fix it? Stefan --- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400 +++ subr.el 2008-05-05 02:58:00.000000000 -0400 @@ -571,10 +571,14 @@ (let* ((key (car binding)) (item (cdr binding)) (oldbind (assq key bindings))) + (if (null key) + ;; nil keys are/were used by easy-menu for "separator lines and + ;; separator titles". Merging them makes no sense. + (push binding bindings) ;; Newer bindings override older. (if oldbind (setq bindings (delq oldbind bindings))) (when item ;nil bindings just hide older ones. - (push binding bindings)))) + (push binding bindings))))) (nconc map bindings))) (put 'keyboard-translate-table 'char-table-extra-slots 0) From unknown Sat Aug 09 09:35:47 2025 X-Loop: don@donarmstrong.com Subject: bug#179: 23.0.60; Menu separators are not displayed Reply-To: Chong Yidong , 179@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 05 Aug 2008 22:00:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: moreinfo patch Received: via spool by 179-submit@emacsbugs.donarmstrong.com id=B179.12179732656699 (code B ref 179); Tue, 05 Aug 2008 22:00:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 179) by emacsbugs.donarmstrong.com; 5 Aug 2008 21:54:25 +0000 Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m75LsM0t006690 for <179@emacsbugs.donarmstrong.com>; Tue, 5 Aug 2008 14:54:23 -0700 Received: by cyd (Postfix, from userid 1000) id 422DA57E338; Tue, 5 Aug 2008 17:54:49 -0400 (EDT) From: Chong Yidong To: David Kastrup Cc: 179@debbugs.gnu.org Date: Tue, 05 Aug 2008 17:54:49 -0400 Message-ID: <87vdyf86vq.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Hello David, Did you ever get the chance to try Stefan's patch from May? Stefan Monnier wrote: > Does the patch below fix it? > > Stefan --- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400 +++ subr.el 2008-05-05 02:58:00.000000000 -0400 @@ -571,10 +571,14 @@ (let* ((key (car binding)) (item (cdr binding)) (oldbind (assq key bindings))) + (if (null key) + ;; nil keys are/were used by easy-menu for "separator lines and + ;; separator titles". Merging them makes no sense. + (push binding bindings) ;; Newer bindings override older. (if oldbind (setq bindings (delq oldbind bindings))) (when item ;nil bindings just hide older ones. - (push binding bindings)))) + (push binding bindings))))) (nconc map bindings))) (put 'keyboard-translate-table 'char-table-extra-slots 0) From unknown Sat Aug 09 09:35:47 2025 X-Loop: don@donarmstrong.com Subject: bug#179: 23.0.60; Menu separators are not displayed Reply-To: David Kastrup , 179@debbugs.gnu.org Resent-From: David Kastrup Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 05 Aug 2008 22:20:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: moreinfo patch Received: via spool by 179-submit@emacsbugs.donarmstrong.com id=B179.121797421514463 (code B ref 179); Tue, 05 Aug 2008 22:20:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 179) by emacsbugs.donarmstrong.com; 5 Aug 2008 22:10:15 +0000 Received: from mail-in-07.arcor-online.net (mail-in-07.arcor-online.net [151.189.21.47]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m75MABSU014218 for <179@emacsbugs.donarmstrong.com>; Tue, 5 Aug 2008 15:10:12 -0700 Received: from mail-in-16-z2.arcor-online.net (mail-in-16-z2.arcor-online.net [151.189.8.33]) by mail-in-07.arcor-online.net (Postfix) with ESMTP id C1DBF24ADDC; Wed, 6 Aug 2008 00:10:09 +0200 (CEST) Received: from mail-in-13.arcor-online.net (mail-in-13.arcor-online.net [151.189.21.53]) by mail-in-16-z2.arcor-online.net (Postfix) with ESMTP id B003425410B; Wed, 6 Aug 2008 00:10:09 +0200 (CEST) Received: from lola.goethe.zz (dslb-084-061-012-041.pools.arcor-ip.net [84.61.12.41]) by mail-in-13.arcor-online.net (Postfix) with ESMTP id 4F36523D1E1; Wed, 6 Aug 2008 00:10:09 +0200 (CEST) Received: by lola.goethe.zz (Postfix, from userid 1002) id 44B391CD01DC; Wed, 6 Aug 2008 00:10:07 +0200 (CEST) From: David Kastrup To: Chong Yidong Cc: 179@debbugs.gnu.org References: <87vdyf86vq.fsf@stupidchicken.com> Date: Wed, 06 Aug 2008 00:10:07 +0200 In-Reply-To: <87vdyf86vq.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 05 Aug 2008 17:54:49 -0400") Message-ID: <85ljzb8668.fsf@lola.goethe.zz> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV 0.93.3/7949/Tue Aug 5 21:13:13 2008 on mail-in-13.arcor-online.net X-Virus-Status: Clean Chong Yidong writes: > Did you ever get the chance to try Stefan's patch from May? > > > Stefan Monnier wrote: > >> Does the patch below fix it? >> >> Stefan > > --- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400 > +++ subr.el 2008-05-05 02:58:00.000000000 -0400 > @@ -571,10 +571,14 @@ > (let* ((key (car binding)) > (item (cdr binding)) > (oldbind (assq key bindings))) > + (if (null key) > + ;; nil keys are/were used by easy-menu for "separator lines and > + ;; separator titles". Merging them makes no sense. > + (push binding bindings) > ;; Newer bindings override older. > (if oldbind (setq bindings (delq oldbind bindings))) > (when item ;nil bindings just hide older ones. > - (push binding bindings)))) > + (push binding bindings))))) > (nconc map bindings))) > > (put 'keyboard-translate-table 'char-table-extra-slots 0) > My current Emacs does not have this patch applied (or include the equivalent) and does show menu separators. So at least the problem I reported would appear to be fixed (I am judging from the subject line of the bug report, don't have the report itself here). However, that does not mean that Stefan might not have unrelatedly detected some special case not covered by the current code. So while the particular problem I have reported might no longer be present in the code base, you should perhaps ask Stefan what case he had been thinking about when creating the patch. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum From unknown Sat Aug 09 09:35:47 2025 X-Loop: don@donarmstrong.com Subject: bug#179: 23.0.60; Menu separators are not displayed Reply-To: Stefan Monnier , 179@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 11 Aug 2008 23:10:09 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: moreinfo patch Received: via spool by 179-submit@emacsbugs.donarmstrong.com id=B179.12184957099530 (code B ref 179); Mon, 11 Aug 2008 23:10:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.2 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 179) by emacsbugs.donarmstrong.com; 11 Aug 2008 23:01:49 +0000 Received: from smtp-05.arnet.com.ar (smtp-05.arnet.com.ar [200.45.191.5]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m7BN1euU009468 for <179@emacsbugs.donarmstrong.com>; Mon, 11 Aug 2008 16:01:42 -0700 Received: (qmail 2771 invoked from network); 11 Aug 2008 16:59:44 -0000 Received: from unknown (HELO ceviche.home) (190.30.131.157) by 0 with SMTP; 11 Aug 2008 16:59:43 -0000 Received: by ceviche.home (Postfix, from userid 20848) id 6878DB41C7; Fri, 8 Aug 2008 14:31:36 -0400 (EDT) From: Stefan Monnier To: David Kastrup Cc: 179@debbugs.gnu.org, Chong Yidong Message-ID: References: <87vdyf86vq.fsf@stupidchicken.com> <85ljzb8668.fsf@lola.goethe.zz> Date: Fri, 08 Aug 2008 14:31:36 -0400 In-Reply-To: <85ljzb8668.fsf@lola.goethe.zz> (David Kastrup's message of "Wed, 06 Aug 2008 00:10:07 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Did you ever get the chance to try Stefan's patch from May? >> >> >> Stefan Monnier wrote: >> >>> Does the patch below fix it? >>> >>> Stefan >> >> --- subr.el.~1.594.~ 2008-05-02 12:47:05.000000000 -0400 >> +++ subr.el 2008-05-05 02:58:00.000000000 -0400 >> @@ -571,10 +571,14 @@ >> (let* ((key (car binding)) >> (item (cdr binding)) >> (oldbind (assq key bindings))) >> + (if (null key) >> + ;; nil keys are/were used by easy-menu for "separator lines and >> + ;; separator titles". Merging them makes no sense. >> + (push binding bindings) >> ;; Newer bindings override older. >> (if oldbind (setq bindings (delq oldbind bindings))) >> (when item ;nil bindings just hide older ones. >> - (push binding bindings)))) >> + (push binding bindings))))) >> (nconc map bindings))) >> >> (put 'keyboard-translate-table 'char-table-extra-slots 0) >> > My current Emacs does not have this patch applied (or include the > equivalent) and does show menu separators. So at least the problem I > reported would appear to be fixed (I am judging from the subject line of > the bug report, don't have the report itself here). Indeed, IIRC I installed a different patch for this problem. It turns out that the nil binding is actually not special in any way and that most separators use other names than nil, so I changed easy-menu to not use nil either, which makes the above patch unneeded (and probably undesirable either). Stefan