GNU bug report logs - #17887
Regression: mouse-1 click on link does mouse-2 instead

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17887 in the body.
You can then email your comments to 17887 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Barry OReilly <gundaetiapo <at> gmail.com>
To: emacs bugs <bug-gnu-emacs <at> gnu.org>
Subject: Regression: mouse-1 click on link does mouse-2 instead
Date: Mon, 30 Jun 2014 15:13:45 -0700

[Message part 1 (text/plain, inline)]

To reproduce on latest emacs-24 branch:

  mkdir /tmp/foo.d
  emacs -Q /tmp

Dired mode creates links out of the directory names, such as foo.d.
C-h k then mouse-1 (ie left) click on a link. See:

  <mouse-2> (translated from <down-mouse-2> <mouse-2>) at that spot runs
  the command mouse-yank-primary, which is an interactive compiled Lisp

But if you C-h k then mouse-1 click where there is no link, see:

  <down-mouse-1> (translated from <down-mouse-1> <down-mouse-1>) at that
  spot runs the command mouse-drag-region, which is an interactive

Though this doesn't create an issue in Dired, it is causing another
Emacs package I use (unreleased) to paste text instead of doing what
it used to do in Emacs 24.3, which is to show its own context menu.

Why would C-h k mouse-1 say anything about mouse-2?

In GNU Emacs 24.3.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10)
 of 2014-06-27 on REDACTED
Windowing system distributor `The X.Org Foundation', version 11.0.11405000
System Description:    Ubuntu 12.04.4 LTS

[Message part 2 (text/html, inline)]

Message #8 received at 17887 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 17887 <at> debbugs.gnu.org
Subject: Re: bug#17887: Regression: mouse-1 click on link does mouse-2 instead
Date: Tue, 01 Jul 2014 00:34:00 +0200

Hi Barry,

I'm not sure whether there was any change related to that, but AFAIK,
what you describe is expected.  See (info "(elisp) Clickable Text"), and
especially `mouse-1-click-follows-link`.

Would it solve your problem when your mode (locally) binds
`mouse-1-click-follows-link` to nil?

Michael.

Message #11 received at 17887 <at> debbugs.gnu.org (full text, mbox):

From: Barry OReilly <gundaetiapo <at> gmail.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 17887 <at> debbugs.gnu.org
Subject: Re: bug#17887: Regression: mouse-1 click on link does mouse-2 instead
Date: Mon, 30 Jun 2014 16:27:06 -0700

[Message part 1 (text/plain, inline)]

> Would it solve your problem when your mode (locally) binds
> `mouse-1-click-follows-link` to nil?

No, in this case mouse-1 does nothing but relocate point.

I Git bisected the regression to:

25573f61f9eaf1631c03d16486ffc17fd9b18503 is the first bad commit
commit 25573f61f9eaf1631c03d16486ffc17fd9b18503
Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Fri Mar 8 23:15:53 2013 -0500

    Separate mouse-1-click-follows-link from mouse-drag-region.
    * lisp/mouse.el (mouse--down-1-maybe-follows-link): New function.
    (key-translation-map): Use it to implement mouse-1-click-follows-link.
    (mouse-drag-line, mouse-drag-track): Remove mouse-1-click-follows-link
code.
    (mouse--remap-link-click-p): Remove.
    * src/keyboard.c (access_keymap_keyremap): Accept nil return value from
    functions to mean "no change".
    * src/keyboard.h (EVENT_START, EVENT_END, POSN_WINDOW, POSN_POSN)
    (POSN_WINDOW_POSN, POSN_TIMESTAMP): Be careful since events may come
    from Elisp via unread-command-events.

[Message part 2 (text/html, inline)]

Message #14 received at 17887 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 17887 <at> debbugs.gnu.org
Subject: Re: bug#17887: Regression: mouse-1 click on link does mouse-2 instead
Date: Tue, 01 Jul 2014 01:42:48 +0200

Barry OReilly <gundaetiapo <at> gmail.com> writes:

> > Would it solve your problem when your mode (locally) binds
> > `mouse-1-click-follows-link` to nil?
>
> No, in this case mouse-1 does nothing but relocate point.

Which is what mouse-1 normally does.  I don't understand where there is
a bug.

Michael.

Message #17 received at 17887 <at> debbugs.gnu.org (full text, mbox):

From: Barry OReilly <gundaetiapo <at> gmail.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 17887 <at> debbugs.gnu.org
Subject: Re: bug#17887: Regression: mouse-1 click on link does mouse-2 instead
Date: Mon, 30 Jun 2014 16:54:11 -0700

[Message part 1 (text/plain, inline)]

> I don't understand where there is a bug.

In Emacs 24.3:

  Left click: brings up the minor mode's context menu
  Middle click: pastes ("yanks" in Emacs terminology)

In Emacs 24.3.90:

  Left click: pastes ("yanks" in Emacs terminology)
  Middle click: pastes ("yanks" in Emacs terminology)

[Message part 2 (text/html, inline)]

Message #20 received at 17887 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 17887 <at> debbugs.gnu.org
Subject: Re: bug#17887: Regression: mouse-1 click on link does mouse-2 instead
Date: Mon, 30 Jun 2014 21:24:35 -0400

> Though this doesn't create an issue in Dired, it is causing another
> Emacs package I use (unreleased) to paste text instead of doing what
> it used to do in Emacs 24.3, which is to show its own context menu.

The translation from mouse-1 to mouse-2 (controlled on the user-side by
mouse-1-click-follows-link) depends on the presence of a follow-link
property or binding (see Elisp manual for details).

> Why would C-h k mouse-1 say anything about mouse-2?

Because the place where the mouse-1 click happened has a `follow-link'
property or binding which tells Emacs that this is a place where mouse-1
could be turned into a mouse-2 (depending on
mouse-1-click-follows-link).

So you should try and figure out why there is such a `follow-link'
property or binding at a place where you don't want the
mouse-1-to-mouse-2 translation to take place.

And yes, the implementation of the feature was changed, so your problem
was apparently masked in previous versions of Emacs and is now exposed.


        Stefan

Message #27 received at 17887-done <at> debbugs.gnu.org (full text, mbox):

From: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 17887-done <at> debbugs.gnu.org
Subject: Re: bug#17887: Regression: mouse-1 click on link does mouse-2 instead
Date: Wed, 20 Aug 2014 18:45:35 -0700

[Message part 1 (text/plain, inline)]

This problem went away at some point between emacs-24.3.92 and today's head
of the emacs-24 branch. debbugs.gnu.org/18212 ? Closing.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.