GNU bug report logs - #17884
24.3.92; `vc-next-action' discards commit message

Previous Next

Package: emacs;

Reported by: Richard Copley <rcopley <at> gmail.com>

Date: Mon, 30 Jun 2014 15:24:01 UTC

Severity: important

Found in version 24.3.92

Fixed in version 24.3.93

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: rcopley <at> gmail.com, 17884 <at> debbugs.gnu.org
Subject: bug#17884: 24.3.92; `vc-next-action' discards commit message
Date: Sat, 12 Jul 2014 16:25:20 -0400
Paul Eggert wrote:

> bzr 117371 didn't use log-edit-empty-buffer-p, as its module might not
> be loaded and I didn't want to introduce an unnecessary dependency.
> But perhaps the dependency is necessary after all.

I don't see the issue.
We are talking about vc-dispatcher calling log-edit, which is defined in
log-edit.el, which is also where log-edit-empty-buffer-p is defined.
So just make vc-log-edit explicitly require log-edit?

For the other thing I mentioned, I think checking whether there is an
existing local value of vc-log-fileset that matches the new one should
cover it.




This bug report was last modified 11 years and 7 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.