From unknown Sat Aug 16 21:02:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17884 <17884@debbugs.gnu.org> To: bug#17884 <17884@debbugs.gnu.org> Subject: Status: 24.3.92; `vc-next-action' discards commit message Reply-To: bug#17884 <17884@debbugs.gnu.org> Date: Sun, 17 Aug 2025 04:02:24 +0000 retitle 17884 24.3.92; `vc-next-action' discards commit message reassign 17884 emacs submitter 17884 Richard Copley severity 17884 important thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 30 11:23:43 2014 Received: (at submit) by debbugs.gnu.org; 30 Jun 2014 15:23:43 +0000 Received: from localhost ([127.0.0.1]:38069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1dQk-0002CJ-Gn for submit@debbugs.gnu.org; Mon, 30 Jun 2014 11:23:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57098) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1dQi-0002C7-EG for submit@debbugs.gnu.org; Mon, 30 Jun 2014 11:23:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1dQY-0005Za-3N for submit@debbugs.gnu.org; Mon, 30 Jun 2014 11:23:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1dQY-0005ZQ-07 for submit@debbugs.gnu.org; Mon, 30 Jun 2014 11:23:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1dQW-0005S8-SC for bug-gnu-emacs@gnu.org; Mon, 30 Jun 2014 11:23:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1dQU-0005Y0-Nl for bug-gnu-emacs@gnu.org; Mon, 30 Jun 2014 11:23:28 -0400 Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:58981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1dQU-0005Xb-Ii for bug-gnu-emacs@gnu.org; Mon, 30 Jun 2014 11:23:26 -0400 Received: by mail-qc0-f175.google.com with SMTP id i8so7112068qcq.6 for ; Mon, 30 Jun 2014 08:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=C6ZqeRnUQSMe+3IAMSkSV+GNPuXT7fqb3b82PySaB1I=; b=UVTLSsXGGuhLSY3O74u/l/W0x/CXamdaVOjAA8IyYUqoMIVybBLaWc2PTWTlL+fafw lEQZ9eG8DfVY/ng2Zdw2lNGWKLPixUbfwmxFuxhVzRsqEquPjKznm7gq601B1eN/rOvh fufsNiu5kRuf0HK+uHjp0KZ6juZMm6FHvwW0C0ELoqB+PV/D3Mt8ohMUU1caTI3kgK5h GFGFJf3tx2iY2NcR92QVVc7UsvXJaDERn3jxLkVq7voySrCFns5y82s0qRYitq4pIaPM JVnmA3KUIPTu2gx1+juR9LG/YGTIBFKtnmaN0J/jixZfBN6ivMa2iejUJBf3rqei5KCO OQlg== MIME-Version: 1.0 X-Received: by 10.140.41.202 with SMTP id z68mr57828723qgz.37.1404141805581; Mon, 30 Jun 2014 08:23:25 -0700 (PDT) Received: by 10.229.220.5 with HTTP; Mon, 30 Jun 2014 08:23:25 -0700 (PDT) Date: Mon, 30 Jun 2014 16:23:25 +0100 Message-ID: Subject: 24.3.92; `vc-next-action' discards commit message From: Richard Copley To: "bug-gnu-emacs@gnu.org" Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It used to be that if you typed "C-v v" from a file buffer for which you had already started to compose a commit message, you would be taken to your message so that you could continue composing it. In recent builds the message gets clobbered by the (unwanted!) text "Summary: ^J". That's not very nice. In GNU Emacs 24.3.92.1 (x86_64-w64-mingw32) of 2014-06-30 on 80461UHB Repository revision: 117326 schwab@linux-m68k.org-20140629204855-6i3r3pi3ls4e4c6q Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix c:/emacs/emacs-117326 --disable-dependency-tracking --enable-locallisppath=%emacs_dir%/../site-lisp --with-wide-int --build=x86_64-w64-mingw32 'CPPFLAGS=-I G:/usr/include -I C:/GnuWin32/include' 'LDFLAGS=-L G:/usr/lib -L C:/GnuWin32/lib'' Important settings: value of $LANG: ENG locale-coding-system: cp1252 Major mode: Log-Edit Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x C-f \ t e m p \ t e s t \ t e s t . t x t C-x v v T h i s SPC t o o k SPC m e SPC a g e s . C-x v v O h ! M-x r - e - b Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. (New file) Mark set Press C-c C-c when you are done editing. Enter a change comment. Type C-c C-c when done Mark set Press C-c C-c when you are done editing. Enter a change comment. Type C-c C-c when done Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug sendmail log-edit easy-mmode message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mailabbrev mail-utils gmm-utils mailheader ring pcvs-util add-log vc vc-dispatcher vc-rcs time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32notify w32 multi-tty emacs) Memory information: ((conses 16 79005 8573) (symbols 56 18045 0) (miscs 48 49 159) (strings 32 12796 4781) (string-bytes 1 329463) (vectors 16 9811) (vector-slots 8 383011 9074) (floats 8 62 207) (intervals 56 246 0) (buffers 960 16)) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 30 11:39:14 2014 Received: (at 17884) by debbugs.gnu.org; 30 Jun 2014 15:39:14 +0000 Received: from localhost ([127.0.0.1]:38083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1dfh-0002aq-2p for submit@debbugs.gnu.org; Mon, 30 Jun 2014 11:39:14 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:42501 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1dfa-0002ad-Pg for 17884@debbugs.gnu.org; Mon, 30 Jun 2014 11:39:07 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X1dfY-0001fk-V6; Mon, 30 Jun 2014 11:39:01 -0400 From: Glenn Morris To: Richard Copley Subject: Re: bug#17884: 24.3.92; `vc-next-action' discards commit message References: X-Spook: constitution electronic surveillance dictionary Area 51 X-Ran: L;O%v]Zdo!rNogx7``up|v_Pai'keP&&:vK|7!PF#fI!(o8s[aSOT`!78.Pq^fVIF9jc8E X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 30 Jun 2014 11:39:00 -0400 In-Reply-To: (Richard Copley's message of "Mon, 30 Jun 2014 16:23:25 +0100") Message-ID: <3k38emiezv.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17884 Cc: 17884@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Richard Copley wrote: > It used to be that if you typed "C-v v" from a file buffer for which you > had already started to compose a commit message, you would be taken to > your message so that you could continue composing it. In recent builds > the message gets clobbered by the (unwanted!) text "Summary: ^J". > That's not very nice. No, it's not; but as a workaround I find M-x undo brings the text back. > In GNU Emacs 24.3.92.1 (x86_64-w64-mingw32) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 30 13:35:49 2014 Received: (at 17884) by debbugs.gnu.org; 30 Jun 2014 17:35:49 +0000 Received: from localhost ([127.0.0.1]:38159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1fUX-0005WZ-8q for submit@debbugs.gnu.org; Mon, 30 Jun 2014 13:35:49 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:47964) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1fUR-0005WG-1A for 17884@debbugs.gnu.org; Mon, 30 Jun 2014 13:35:43 -0400 Received: by mail-qg0-f51.google.com with SMTP id z60so2310778qgd.10 for <17884@debbugs.gnu.org>; Mon, 30 Jun 2014 10:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=F3wu1GsEmkgugjmxoYQa3q6/tgq3odIL4V6OWlnkD2o=; b=XovYkuERgFouO9VBJXoMczFERKgeFu/225m/JLcUts296M7wY+DGupAXaZ+9nHpXMA NYp03wKIaRTxHOG09zNmeoXWiqDOqTXYIc37OPykzQF9UTUp1Ns7oKo3IQT03G1pqSnI jWTp9D1mhfRk0BnJXjHWP6vAGSSwiadHneVm/y2QpD8H1k+G3dWPP28PVkY2ipvqUI5J LP6tbxj9mADKHO/ZLF09f7+7dRLS3LqxhSaHxjb0MeHrGMufywZnAZuj4Ev6oRSCxI2b jdgvAanUI42AaTL+VNpg2Hj27K2U8EuinyWb8pw3nUClftg2pqlJlHLfKF0wJaHklfe7 x9og== MIME-Version: 1.0 X-Received: by 10.224.147.80 with SMTP id k16mr19354674qav.99.1404149733530; Mon, 30 Jun 2014 10:35:33 -0700 (PDT) Received: by 10.229.220.5 with HTTP; Mon, 30 Jun 2014 10:35:33 -0700 (PDT) In-Reply-To: <3k38emiezv.fsf@fencepost.gnu.org> References: <3k38emiezv.fsf@fencepost.gnu.org> Date: Mon, 30 Jun 2014 18:35:33 +0100 Message-ID: Subject: Re: bug#17884: 24.3.92; `vc-next-action' discards commit message From: Richard Copley To: Glenn Morris Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17884 Cc: 17884@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 30 June 2014 16:39, Glenn Morris wrote: >> That's not very nice. > > No, it's not; but as a workaround I find M-x undo brings the text back. > That's good to know. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 30 15:33:39 2014 Received: (at 17884) by debbugs.gnu.org; 30 Jun 2014 19:33:39 +0000 Received: from localhost ([127.0.0.1]:38235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1hKY-0001BF-QI for submit@debbugs.gnu.org; Mon, 30 Jun 2014 15:33:38 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:47973 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1hKT-0001B3-3n for 17884@debbugs.gnu.org; Mon, 30 Jun 2014 15:33:33 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X1hKS-0005nF-Ca; Mon, 30 Jun 2014 15:33:28 -0400 From: Glenn Morris To: 17884@debbugs.gnu.org Subject: Re: bug#17884: 24.3.92; `vc-next-action' discards commit message References: <3k38emiezv.fsf@fencepost.gnu.org> X-Spook: Capricorn Gazprom Leuken-Baden Hamas Europol UOP SRI Nazi X-Ran: =,%XPERj[c,/sQOO*T6!n\]73\9,3/7N9M07sA:kRk5wT*c,[L(jVOd>e#"B"A&c&Ms+F; X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 30 Jun 2014 15:33:28 -0400 In-Reply-To: <3k38emiezv.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 30 Jun 2014 11:39:00 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 17884 Cc: Richard Copley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) I think this is due to: 2013-11-28 Stefan Monnier * vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. log-edit with non-nil SETUP first erases the log buffer, thus defeating the purpose of log-edit-empty-buffer-p. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 22:25:55 2014 Received: (at 17884-done) by debbugs.gnu.org; 12 Jul 2014 02:25:55 +0000 Received: from localhost ([127.0.0.1]:40288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5n0d-0000rr-Cf for submit@debbugs.gnu.org; Fri, 11 Jul 2014 22:25:55 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:54638) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5n0a-0000rQ-8U for 17884-done@debbugs.gnu.org; Fri, 11 Jul 2014 22:25:53 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 14E9339E801C; Fri, 11 Jul 2014 19:25:46 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SjhLwistngGx; Fri, 11 Jul 2014 19:25:37 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 36E3039E801B; Fri, 11 Jul 2014 19:25:37 -0700 (PDT) Message-ID: <53C09C9C.1040302@cs.ucla.edu> Date: Fri, 11 Jul 2014 19:25:32 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Richard Copley Subject: Re: 24.3.92; `vc-next-action' discards commit message Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17884-done Cc: 17884-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Thanks for reporting that. I installed a fix in emacs-24 bzr 117371. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 22:56:09 2014 Received: (at 17884) by debbugs.gnu.org; 12 Jul 2014 02:56:09 +0000 Received: from localhost ([127.0.0.1]:40320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5nTt-0001oZ-31 for submit@debbugs.gnu.org; Fri, 11 Jul 2014 22:56:09 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:51689 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5nTr-0001oO-1d for 17884@debbugs.gnu.org; Fri, 11 Jul 2014 22:56:07 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X5nTl-000831-Hp; Fri, 11 Jul 2014 22:56:01 -0400 From: Glenn Morris To: 17884@debbugs.gnu.org Subject: Re: bug#17884: 24.3.92; `vc-next-action' discards commit message References: <53C09C9C.1040302@cs.ucla.edu> X-Spook: AK-47 ammunition gamma underground COSCO AVN propaganda X-Ran: "6rc%SxzM3>7+9,;Sm?:[^/uycdYr1#,{zL_$]vm\+L1W>m0D'Ax$V+lv*[c\mK5)`"n3! X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 11 Jul 2014 22:56:01 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17884 Cc: rcopley@gmail.com, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Paul Eggert wrote: > I installed a fix in emacs-24 bzr 117371. I'm not sure this is 100% right. If the *vc-log* buffer that exists corresponds to a different set of files than the ones being committed now, then the old contents should be replaced, even if the buffer is not empty. Or if the buffer contains just the header template (log-edit-empty-buffer-p), then the contents should always be replaced, in case a proper log is available now. From unknown Sat Aug 16 21:02:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sat, 12 Jul 2014 03:04:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 11 23:09:21 2014 Received: (at 17884) by debbugs.gnu.org; 12 Jul 2014 03:09:21 +0000 Received: from localhost ([127.0.0.1]:40330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5nge-0003Nv-9U for submit@debbugs.gnu.org; Fri, 11 Jul 2014 23:09:20 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:55778) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5ngc-0003Ng-Rw for 17884@debbugs.gnu.org; Fri, 11 Jul 2014 23:09:19 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 3D08539E801B; Fri, 11 Jul 2014 20:09:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BIr+HbUS+zeo; Fri, 11 Jul 2014 20:09:04 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9943C39E801C; Fri, 11 Jul 2014 20:09:04 -0700 (PDT) Message-ID: <53C0A6D0.3060806@cs.ucla.edu> Date: Fri, 11 Jul 2014 20:09:04 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Glenn Morris , 17884@debbugs.gnu.org Subject: Re: bug#17884: 24.3.92; `vc-next-action' discards commit message References: <53C09C9C.1040302@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17884 Cc: rcopley@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Glenn Morris wrote: > I'm not sure this is 100% right. No doubt you're right, so I'm reopening the bug. I think emacs-24 bzr 117371 is a step forward though, as it handles the use case in the original bug report, and it's easier for a novice to delete text than to recreate deleted text. bzr 117371 didn't use log-edit-empty-buffer-p, as its module might not be loaded and I didn't want to introduce an unnecessary dependency. But perhaps the dependency is necessary after all. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 12 16:25:25 2014 Received: (at 17884) by debbugs.gnu.org; 12 Jul 2014 20:25:25 +0000 Received: from localhost ([127.0.0.1]:40963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X63rI-00006S-Us for submit@debbugs.gnu.org; Sat, 12 Jul 2014 16:25:25 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:44377 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X63rG-00006J-2G for 17884@debbugs.gnu.org; Sat, 12 Jul 2014 16:25:22 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X63rF-0006co-5K; Sat, 12 Jul 2014 16:25:21 -0400 From: Glenn Morris To: Paul Eggert Subject: Re: bug#17884: 24.3.92; `vc-next-action' discards commit message References: <53C09C9C.1040302@cs.ucla.edu> <53C0A6D0.3060806@cs.ucla.edu> X-Spook: Becker Ermes RSA Etacs Albanian Soviet Iran [Hello to all X-Ran: ~K-yX2YoED&Y-rB_HPM|k.'CHLiV4*CwtAqHN%T"0KSoJ=bY\y9/x=[Lldw'O1Wjdd*d'Q X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 12 Jul 2014 16:25:20 -0400 In-Reply-To: <53C0A6D0.3060806@cs.ucla.edu> (Paul Eggert's message of "Fri, 11 Jul 2014 20:09:04 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17884 Cc: rcopley@gmail.com, 17884@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Paul Eggert wrote: > bzr 117371 didn't use log-edit-empty-buffer-p, as its module might not > be loaded and I didn't want to introduce an unnecessary dependency. > But perhaps the dependency is necessary after all. I don't see the issue. We are talking about vc-dispatcher calling log-edit, which is defined in log-edit.el, which is also where log-edit-empty-buffer-p is defined. So just make vc-log-edit explicitly require log-edit? For the other thing I mentioned, I think checking whether there is an existing local value of vc-log-fileset that matches the new one should cover it. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 14 15:31:27 2014 Received: (at 17884) by debbugs.gnu.org; 14 Jul 2014 19:31:27 +0000 Received: from localhost ([127.0.0.1]:54937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X6ly5-0005XB-NU for submit@debbugs.gnu.org; Mon, 14 Jul 2014 15:31:26 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:33279 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X6lxy-0005Wv-Em for 17884@debbugs.gnu.org; Mon, 14 Jul 2014 15:31:19 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X6lxw-0001mi-Rb; Mon, 14 Jul 2014 15:31:12 -0400 From: Glenn Morris To: Paul Eggert Subject: Re: bug#17884: 24.3.92; `vc-next-action' discards commit message References: <53C09C9C.1040302@cs.ucla.edu> <53C0A6D0.3060806@cs.ucla.edu> X-Spook: CDMA Saddam Hussein spy War on Terrorism Mafia e-cash X-Ran: Wg\D",1iyEe"RdfT|U%o]\IPF+d1+6@1(v^2b+7PRgeNnbOMXc-Td{;W'%9]884>,%v)9W X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 14 Jul 2014 15:31:12 -0400 In-Reply-To: (Glenn Morris's message of "Sat, 12 Jul 2014 16:25:20 -0400") Message-ID: <6rr41nivpb.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17884 Cc: rcopley@gmail.com, 17884@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I applied this, which hopefully covers it. --- a/lisp/vc/vc-dispatcher.el 2014-07-12 02:24:02 +0000 +++ b/lisp/vc/vc-dispatcher.el 2014-07-14 19:29:29 +0000 @@ -591,12 +591,19 @@ ;; Set up key bindings for use while editing log messages +(declare-function log-edit-empty-buffer-p "log-edit" ()) + (defun vc-log-edit (fileset mode backend) "Set up `log-edit' for use on FILE." (setq default-directory (buffer-local-value 'default-directory vc-parent-buffer)) + (require 'log-edit) (log-edit 'vc-finish-logentry - (= (point-min) (point-max)) + ;; Setup a new log message if the log buffer is "empty", + ;; or was previously used for a different set of files. + (or (log-edit-empty-buffer-p) + (and (local-variable-p 'vc-log-fileset) + (not (equal vc-log-fileset fileset)))) `((log-edit-listfun . (lambda () ;; FIXME: Should expand the list ;; for directories. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 14 15:31:40 2014 Received: (at control) by debbugs.gnu.org; 14 Jul 2014 19:31:40 +0000 Received: from localhost ([127.0.0.1]:54940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X6lyJ-0005Xf-2X for submit@debbugs.gnu.org; Mon, 14 Jul 2014 15:31:40 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:33283 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X6lyG-0005XU-7b for control@debbugs.gnu.org; Mon, 14 Jul 2014 15:31:33 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X6lyF-0002qZ-Pq for control@debbugs.gnu.org; Mon, 14 Jul 2014 15:31:31 -0400 Date: Mon, 14 Jul 2014 15:31:31 -0400 Message-Id: Subject: control message for bug 17884 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 17884 24.3.93 From unknown Sat Aug 16 21:02:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 12 Aug 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator