GNU bug report logs - #17839
24.4.50; read-passwd echoes password input in non-interactive sessions

Previous Next

Full log

Message #64 received at 17839 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: schwab <at> suse.de, 17839 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca,
 swiesner <at> lunaryorn.com
Subject: Re: bug#17839: 24.4.50;
 read-passwd echoes password input in non-interactive sessions
Date: Fri, 11 Jul 2014 12:45:14 +0300

> From: Michael Albinus <michael.albinus <at> gmx.de>
> Date: Fri, 11 Jul 2014 11:15:14 +0200
> Cc: Andreas Schwab <schwab <at> suse.de>, 17839 <at> debbugs.gnu.org,
> 	Sebastian Wiesner <swiesner <at> lunaryorn.com>
> 
> OK. There is now `read-hide-char', which triggers it. Users can let-bind
> it to the character they prefer for hiding. This will be used in
> `read-passwd', choosing the default ?. if it is not let-bound already.
> 
> >> +      else if (hide_chars && (c == 127)) /* DEL */
> >> +	{
> >> +	  /* Unfortunately, we cannot edit stdout.  */
> >> +	  // fprintf (stdout, "%c", c);
> >> +	  /* Hmm, this doesn't work for multi-byte characters.  */
> >> +	  (len > 0) && len--;
> >> +	}
> >
> > I don't think that's worth the trouble.
> 
> I've removed this.
> 
> The patch is committed to the trunk as revision 117510.

Which breaks the MS-Windows build, of course, since Windows doesn't
have termios.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.