From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jun 2014 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17839@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14035378084799 (code B ref -1); Mon, 23 Jun 2014 15:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2014 15:36:48 +0000 Received: from localhost ([127.0.0.1]:58365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz6IV-0001FD-HM for submit@debbugs.gnu.org; Mon, 23 Jun 2014 11:36:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34299) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz4fS-0006i3-5A for submit@debbugs.gnu.org; Mon, 23 Jun 2014 09:52:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz4fD-0003Rj-UK for submit@debbugs.gnu.org; Mon, 23 Jun 2014 09:52:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz4fD-0003Re-Ro for submit@debbugs.gnu.org; Mon, 23 Jun 2014 09:52:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz4f6-0005SR-5q for bug-gnu-emacs@gnu.org; Mon, 23 Jun 2014 09:52:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz4ey-0003LL-NP for bug-gnu-emacs@gnu.org; Mon, 23 Jun 2014 09:51:56 -0400 Received: from vega.uberspace.de ([95.143.172.245]:48045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz4ey-0003L7-DO for bug-gnu-emacs@gnu.org; Mon, 23 Jun 2014 09:51:48 -0400 Received: (qmail 8393 invoked from network); 23 Jun 2014 13:51:45 -0000 Received: from localhost (HELO lunaryorn-air) (127.0.0.1) by vega.uberspace.de with SMTP; 23 Jun 2014 13:51:45 -0000 From: Sebastian Wiesner Date: Mon, 23 Jun 2014 15:51:37 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Mon, 23 Jun 2014 11:36:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In a non-interactive session, i.e. "emacs -Q --batch =E2=80=A6", `read-pass= wd' currently echoes the password input on the TTY. I would expect `read-passwd' to suppress input echo while reading a password, like suo, sudo, SSH, GPG and similar programs do. In my opinion, the current behaviour is harmful, because from their experience with these programs user will likely expect that input following a "Password: " prompt is hidden, and thus may accidentally expose their password, being unaware that Emacs behaves differently. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jun 2014 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Wiesner Cc: 17839@debbugs.gnu.org Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14035384276029 (code B ref 17839); Mon, 23 Jun 2014 15:48:02 +0000 Received: (at 17839) by debbugs.gnu.org; 23 Jun 2014 15:47:07 +0000 Received: from localhost ([127.0.0.1]:58385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz6SU-0001Z6-SN for submit@debbugs.gnu.org; Mon, 23 Jun 2014 11:47:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57843 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz6SO-0001Yd-I4 for 17839@debbugs.gnu.org; Mon, 23 Jun 2014 11:47:00 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id ACDACAC03; Mon, 23 Jun 2014 15:46:55 +0000 (UTC) From: Andreas Schwab References: X-Yow: A dwarf is passing out somewhere in Detroit! Date: Mon, 23 Jun 2014 17:46:55 +0200 In-Reply-To: (Sebastian Wiesner's message of "Mon, 23 Jun 2014 15:51:37 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Sebastian Wiesner writes: > In a non-interactive session, i.e. "emacs -Q --batch …", `read-passwd' > currently echoes the password input on the TTY. Batch mode isn't designed for interaction. It uses standard I/O, oblivious to who is consuming the input. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jun 2014 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 17839@debbugs.gnu.org Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140354237013617 (code B ref 17839); Mon, 23 Jun 2014 16:53:01 +0000 Received: (at 17839) by debbugs.gnu.org; 23 Jun 2014 16:52:50 +0000 Received: from localhost ([127.0.0.1]:58437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz7U5-0003XS-2H for submit@debbugs.gnu.org; Mon, 23 Jun 2014 12:52:50 -0400 Received: from vega.uberspace.de ([95.143.172.245]:49292) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz7Tx-0003X9-Nr for 17839@debbugs.gnu.org; Mon, 23 Jun 2014 12:52:43 -0400 Received: (qmail 14475 invoked from network); 23 Jun 2014 16:52:36 -0000 Received: from localhost (HELO ?IPv6:2001:a60:1685:3d01:8c41:4f8a:2b26:3e3c?) (127.0.0.1) by vega.uberspace.de with SMTP; 23 Jun 2014 16:52:36 -0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) From: Sebastian Wiesner In-Reply-To: Date: Mon, 23 Jun 2014 18:52:34 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: X-Mailer: Apple Mail (2.1878.2) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am 23.06.2014 um 17:46 schrieb Andreas Schwab : > Sebastian Wiesner writes: >=20 >> In a non-interactive session, i.e. "emacs -Q --batch =85", = `read-passwd' >> currently echoes the password input on the TTY. >=20 > Batch mode isn't designed for interaction. It uses standard I/O, > oblivious to who is consuming the input. In this case `read-passwd=92 should at least signal an error when called = in non-interactive mode, and have a warning in its doctoring. =20 Currently it is simply insecure in non-interactive mode, and neither its = docstring nor the Emacs Lisp manual document that the password is = exposed when called in non-interactive mode.= From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jun 2014 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Wiesner Cc: Andreas Schwab , 17839@debbugs.gnu.org Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14036353173675 (code B ref 17839); Tue, 24 Jun 2014 18:42:02 +0000 Received: (at 17839) by debbugs.gnu.org; 24 Jun 2014 18:41:57 +0000 Received: from localhost ([127.0.0.1]:59588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzVfI-0000xC-D8 for submit@debbugs.gnu.org; Tue, 24 Jun 2014 14:41:56 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:35653 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzVfF-0000wz-3V for 17839@debbugs.gnu.org; Tue, 24 Jun 2014 14:41:53 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WzVfD-00075r-OO; Tue, 24 Jun 2014 14:41:51 -0400 From: Glenn Morris References: X-Spook: lynch hackers Dick Cheney infowar cryptographic Islam X-Ran: .k=QdL;OBybv1UV@(ZAZR(_UL3S:aR#{}NaE/#$p(`/?i)duZ$LQtJ,J@n&@!\MJuFv}Ke X-Hue: magenta X-Attribution: GM Date: Tue, 24 Jun 2014 14:41:51 -0400 In-Reply-To: (Sebastian Wiesner's message of "Mon, 23 Jun 2014 18:52:34 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Sebastian Wiesner wrote: >> Batch mode isn't designed for interaction. It uses standard I/O, >> oblivious to who is consuming the input. > > In this case `read-passwd' should at least signal an error when called > in non-interactive mode, I think that would be overkill. > and have a warning in its doctoring. A notice perhaps. > Currently it is simply insecure in non-interactive mode, and neither > its docstring nor the Emacs Lisp manual document that the password is > exposed when called in non-interactive mode. It's in the manual section on minibuffer input, and in batch mode there is no minibuffer. For example, read-file-name doesn't offer completion in batch-mode. It doesn't provide history. ctrl-k doesn't work. Etc. I see no point in mentioning these things in the doc-string of every function that uses the minibuffer. But yes, read-passwd is a slightly special case and could stand to mention batch mode in its doc. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jun 2014 22:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: Andreas Schwab , 17839@debbugs.gnu.org Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14036505691323 (code B ref 17839); Tue, 24 Jun 2014 22:57:02 +0000 Received: (at 17839) by debbugs.gnu.org; 24 Jun 2014 22:56:09 +0000 Received: from localhost ([127.0.0.1]:59733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzZdE-0000LB-HD for submit@debbugs.gnu.org; Tue, 24 Jun 2014 18:56:08 -0400 Received: from vega.uberspace.de ([95.143.172.245]:44861) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzZd8-0000Kd-3D for 17839@debbugs.gnu.org; Tue, 24 Jun 2014 18:56:02 -0400 Received: (qmail 20423 invoked from network); 24 Jun 2014 22:55:55 -0000 Received: from localhost (HELO lunaryorn-air.fritz.box) (127.0.0.1) by vega.uberspace.de with SMTP; 24 Jun 2014 22:55:55 -0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) From: Sebastian Wiesner In-Reply-To: Date: Wed, 25 Jun 2014 00:55:53 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> References: X-Mailer: Apple Mail (2.1878.2) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am 24.06.2014 um 20:41 schrieb Glenn Morris : > Sebastian Wiesner wrote: >=20 >>> Batch mode isn't designed for interaction. It uses standard I/O, >>> oblivious to who is consuming the input. >>=20 >> In this case `read-passwd' should at least signal an error when = called >> in non-interactive mode, >=20 > I think that would be overkill. I think that `read-passwd=92 is a special case, because it *leaks a = secret* when used in non-interactive mode, and the fact that it does is = not immediately obvious. To learn this *in advance*, that is, before = actually using this function in non-interactive code, one has to = conclude from some rather abstract descriptions of Emacs=92 behavior in = the Emacs manual. >> Currently it is simply insecure in non-interactive mode, and neither >> its docstring nor the Emacs Lisp manual document that the password is >> exposed when called in non-interactive mode. >=20 > It's in the manual section on minibuffer input, and in batch mode = there > is no minibuffer. For example, read-file-name doesn't offer completion > in batch-mode. It doesn't provide history. ctrl-k doesn't work. Etc. > I see no point in mentioning these things in the doc-string of every > function that uses the mini buffer. There is a difference, I think. Completion, history, C-k, etc. are not = crucial for entering a file name, but hiding input is absolutely crucial = to entering a password securely. I can perfectly enter a file name = without history or completion, but I cannot securely enter a password if = it is shown during input. =20 So `read-file-name=92 works in non-interactive mode, albeit less = conveniently, but `read-passwd=92 arguably does not. Pointing out that non-interactive mode isn=92t designed for interaction = is right, probably, but misses the point imho. Besides, =93non-interactive=94 is a little vague. It=92s obvious that = `--batch=92 is non-interactive, but is `--script=92 as well? In other = languages, e.g. Python or Perl, scripts regularly do interaction, = including reading passwords. I think it=92s only natural that Emacs users will try to do the same in = Emacs Lisp, encouraged by the existence of `--script=92, so they=92ll = sooner or later hit this issue.= From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 07:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Wiesner Cc: Glenn Morris , 17839@debbugs.gnu.org Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140368247929087 (code B ref 17839); Wed, 25 Jun 2014 07:48:01 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 07:47:59 +0000 Received: from localhost ([127.0.0.1]:59891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wzhvz-0007Z5-FM for submit@debbugs.gnu.org; Wed, 25 Jun 2014 03:47:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37782 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wzhvx-0007Yu-2H for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 03:47:58 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EF189AC05; Wed, 25 Jun 2014 07:47:55 +0000 (UTC) From: Andreas Schwab References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> X-Yow: Here I am in the POSTERIOR OLFACTORY LOBULE but I don't see CARL SAGAN anywhere!! Date: Wed, 25 Jun 2014 09:47:55 +0200 In-Reply-To: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> (Sebastian Wiesner's message of "Wed, 25 Jun 2014 00:55:53 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Sebastian Wiesner writes: > Besides, “non-interactive” is a little vague. It’s obvious that `--batch’ is non-interactive, but is `--script’ as well? In other languages, e.g. Python or Perl, scripts regularly do interaction, including reading passwords. Emacs is an editor, not a script language. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140368333130739 (code B ref 17839); Wed, 25 Jun 2014 08:03:01 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 08:02:11 +0000 Received: from localhost ([127.0.0.1]:59895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wzi9e-0007zc-SG for submit@debbugs.gnu.org; Wed, 25 Jun 2014 04:02:10 -0400 Received: from mout.gmx.net ([212.227.15.15]:53628) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wzi9Z-0007yv-8l for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 04:02:05 -0400 Received: from detlef.gmx.de ([87.146.42.128]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MTSrf-1X9RYu20Qh-00SR5c; Wed, 25 Jun 2014 10:01:51 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> Date: Wed, 25 Jun 2014 10:01:46 +0200 In-Reply-To: (Andreas Schwab's message of "Wed, 25 Jun 2014 09:47:55 +0200") Message-ID: <87d2dx5set.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:sHif5lhOjMNR1t1XIRIWjrn6/tRgtZT6Yt86YK9ZRYYogt9nmFq DtzBslfrzboX8txYX+3kYh5FmeIbf4Kc6C++8iARhQE6dhii8e9mcWeJ5X/XEE2dfiQFSQD k5MArEJ8AA4KbX0iYkhNdVD9098/uEkxodrenw5/f38pzIH0Cr/0ANpMcAaHMmHd7X64uxa 7vVgC1wcxiZYU4oRiaKlA== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Andreas Schwab writes: > Sebastian Wiesner writes: > >> Besides, =E2=80=9Cnon-interactive=E2=80=9D is a little vague. It=E2=80= =99s obvious that >> `--batch=E2=80=99 is non-interactive, but is `--script=E2=80=99 as well?= In other >> languages, e.g. Python or Perl, scripts regularly do interaction, >> including reading passwords. > > Emacs is an editor, not a script language. An example where cleartext passwords are annoying me for a while is running the test suite. Use another remote host for Tramp tests, like this: # env REMOTE_TEMPORARY_FILE_DIRECTORY=3D/sudo::/tmp make check > Andreas. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 08:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140368413332284 (code B ref 17839); Wed, 25 Jun 2014 08:16:01 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 08:15:33 +0000 Received: from localhost ([127.0.0.1]:59901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WziMb-0008OZ-0M for submit@debbugs.gnu.org; Wed, 25 Jun 2014 04:15:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38561 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WziMV-0008OM-4h for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 04:15:27 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 77E3275011; Wed, 25 Jun 2014 08:15:22 +0000 (UTC) From: Andreas Schwab References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87d2dx5set.fsf@gmx.de> X-Yow: Bo Derek ruined my life! Date: Wed, 25 Jun 2014 10:15:22 +0200 In-Reply-To: <87d2dx5set.fsf@gmx.de> (Michael Albinus's message of "Wed, 25 Jun 2014 10:01:46 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Michael Albinus writes: > An example where cleartext passwords are annoying me for a while is > running the test suite. Use another remote host for Tramp tests, like > this: > > # env REMOTE_TEMPORARY_FILE_DIRECTORY=/sudo::/tmp make check So use a method that does not need to ask for a password. Both sudo and ssh can be configured like this. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 09:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14036880657364 (code B ref 17839); Wed, 25 Jun 2014 09:22:01 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 09:21:05 +0000 Received: from localhost ([127.0.0.1]:59952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzjO3-0001uh-Vr for submit@debbugs.gnu.org; Wed, 25 Jun 2014 05:21:04 -0400 Received: from mout.gmx.net ([212.227.17.21]:56850) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzjNy-0001tv-C5 for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 05:21:02 -0400 Received: from detlef.gmx.de ([87.146.42.128]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LjeWC-1WOCm92xB2-00bY3K; Wed, 25 Jun 2014 11:20:49 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87d2dx5set.fsf@gmx.de> Date: Wed, 25 Jun 2014 11:20:45 +0200 In-Reply-To: (Andreas Schwab's message of "Wed, 25 Jun 2014 10:15:22 +0200") Message-ID: <878uol5or6.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:QspUYfz2QLb733iuVKfzPu3PFtT7oBk71sfxixLO70mVAzPjZbz 1Xn//yYZEr4pIFYkIefU4aECZWO4qu+oegYeUMI7B+fx8yKOxVnh0X+FWa2ujVZg/cq/3Uc v+KzEBDUod8GxqI+Z1USYVqe4cU0kngyV8OFWhyyREOQpOSVkMBPhf2K8PRaAdu83RWIxi7 V5gciKDGZO4LDSk4752Rw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Andreas Schwab writes: > Michael Albinus writes: > >> An example where cleartext passwords are annoying me for a while is >> running the test suite. Use another remote host for Tramp tests, like >> this: >> >> # env REMOTE_TEMPORARY_FILE_DIRECTORY=/sudo::/tmp make check > > So use a method that does not need to ask for a password. Both sudo and > ssh can be configured like this. That's not the problem, I know how to configure them. I gave sudo just as an example you could reproduce yourself. When preparing a Tramp release, I run the Tramp test suite for about 20 different remote file names. This includes connection methods like smb, dav(s), telnet, nc, adb. Not all of them can be configured to work password-less. And sometimes I also want to test the case of providing a wrong password. > Andreas. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 09:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14036883817966 (code B ref 17839); Wed, 25 Jun 2014 09:27:01 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 09:26:21 +0000 Received: from localhost ([127.0.0.1]:59956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzjT7-00024K-8O for submit@debbugs.gnu.org; Wed, 25 Jun 2014 05:26:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40089 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzjT0-000245-Tl for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 05:26:15 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F0858AC05; Wed, 25 Jun 2014 09:26:09 +0000 (UTC) From: Andreas Schwab References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87d2dx5set.fsf@gmx.de> <878uol5or6.fsf@gmx.de> X-Yow: My BIOLOGICAL ALARM CLOCK just went off.. It has noiseless DOZE FUNCTION and full kitchen!! Date: Wed, 25 Jun 2014 11:26:09 +0200 In-Reply-To: <878uol5or6.fsf@gmx.de> (Michael Albinus's message of "Wed, 25 Jun 2014 11:20:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Michael Albinus writes: > When preparing a Tramp release, I run the Tramp test suite for about 20 > different remote file names. This includes connection methods like smb, > dav(s), telnet, nc, adb. Not all of them can be configured to work > password-less. So provide it on stdin. You want to automate your tests anyway, don't you? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 09:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: Glenn Morris , 17839@debbugs.gnu.org Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140368995815640 (code B ref 17839); Wed, 25 Jun 2014 09:53:01 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 09:52:38 +0000 Received: from localhost ([127.0.0.1]:59975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzjsY-000448-FX for submit@debbugs.gnu.org; Wed, 25 Jun 2014 05:52:38 -0400 Received: from vega.uberspace.de ([95.143.172.245]:53662) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzjsS-00043v-Gd for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 05:52:32 -0400 Received: (qmail 21987 invoked from network); 25 Jun 2014 09:52:26 -0000 Received: from localhost (HELO lunaryorn-air.fritz.box) (127.0.0.1) by vega.uberspace.de with SMTP; 25 Jun 2014 09:52:26 -0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) From: Sebastian Wiesner In-Reply-To: Date: Wed, 25 Jun 2014 11:52:24 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <574953C5-5926-4AED-A49A-1941ED8E0097@lunaryorn.com> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> X-Mailer: Apple Mail (2.1878.2) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am 25.06.2014 um 09:47 schrieb Andreas Schwab : > Sebastian Wiesner writes: >=20 >> Besides, =93non-interactive=94 is a little vague. It=92s obvious = that `--batch=92 is non-interactive, but is `--script=92 as well? In = other languages, e.g. Python or Perl, scripts regularly do interaction, = including reading passwords. >=20 > Emacs is an editor, not a script language. I=92m sorry to see that you are stuck with this view, and I am = disappointed that this prevents an important issue from being addressed. = =20 The community has gone beyond that, and uses Emacs Lisp for other = purposes as well. Anyhow, seeing that there is no interest in fixing this issue, I see no = point in continuing this discussion. How can I unsubscribe from bugs?= From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 10:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140369063817026 (code B ref 17839); Wed, 25 Jun 2014 10:04:02 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 10:03:58 +0000 Received: from localhost ([127.0.0.1]:59979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wzk3W-0004QN-Nu for submit@debbugs.gnu.org; Wed, 25 Jun 2014 06:03:58 -0400 Received: from mout.gmx.net ([212.227.15.18]:49532) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wzk3R-0004Q2-2z for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 06:03:53 -0400 Received: from detlef.gmx.de ([87.146.42.128]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MF4iR-1WssHT3OSh-00GHSx; Wed, 25 Jun 2014 12:03:37 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87d2dx5set.fsf@gmx.de> <878uol5or6.fsf@gmx.de> Date: Wed, 25 Jun 2014 12:03:31 +0200 In-Reply-To: (Andreas Schwab's message of "Wed, 25 Jun 2014 11:26:09 +0200") Message-ID: <874mz95mrw.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:yFTOnV1nSktlYbuoFyiQ825FbDWVQZW+m+CGnRH6cUnxz5qDZxu SP2HLCnzq6hVWHXtbPAOe4XVxyRqdr8nPRglnMzMT+sVvHn9U+TFtxkoa+EOMonr2FOuCuo kND4LuJQGVVuHeSwkgPa0yFzO1EAV34opGIODLw7VPPwAiSwL0JTN0ozSKFxeMX1GT/avQ3 jmqYIB4Pbv3YQ1e+Zwzgw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Andreas Schwab writes: > Michael Albinus writes: > >> When preparing a Tramp release, I run the Tramp test suite for about 20 >> different remote file names. This includes connection methods like smb, >> dav(s), telnet, nc, adb. Not all of them can be configured to work >> password-less. > > So provide it on stdin. You want to automate your tests anyway, don't > you? It depends on timing. Sometimes, during the test runs, the password expires and will be requested, again. And it isn't just me. (Tramp) users are encouraged to run the test suite in their local environment, when Tramp produces an error. > Andreas. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jun 2014 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140370677720998 (code B ref 17839); Wed, 25 Jun 2014 14:33:01 +0000 Received: (at 17839) by debbugs.gnu.org; 25 Jun 2014 14:32:57 +0000 Received: from localhost ([127.0.0.1]:60582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzoFs-0005Sc-Ge for submit@debbugs.gnu.org; Wed, 25 Jun 2014 10:32:56 -0400 Received: from relais.videotron.ca ([24.201.245.36]:54266) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzoFq-0005ST-0L for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 10:32:54 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Received: from ceviche.home ([24.201.170.218]) by VL-VM-MR005.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0N7Q00425B2S8S30@VL-VM-MR005.ip.videotron.ca> for 17839@debbugs.gnu.org; Wed, 25 Jun 2014 10:32:52 -0400 (EDT) Received: by ceviche.home (Postfix, from userid 20848) id 6D99266167; Wed, 25 Jun 2014 10:32:51 -0400 (EDT) From: Stefan Monnier Message-id: References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> Date: Wed, 25 Jun 2014 10:32:51 -0400 In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) Content-transfer-encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) >> Besides, =E2=80=9Cnon-interactive=E2=80=9D is a little vague. It=E2=80= =99s obvious that `--batch=E2=80=99 >> is non-interactive, but is `--script=E2=80=99 as well? In other languag= es, >> e.g. Python or Perl, scripts regularly do interaction, including >> reading passwords. > Emacs is an editor, not a script language. There are all kinds of reasons why the current behavior is "logical", but indeed, it's not desirable. Could someone install the obvious patch in read-passwd to emit a warning (right after the prompt, so the user will necessarily see it)? If someone is motivated, I would even accept a patch that turns echo off temporarily. Stefan From unknown Tue Jun 24 20:52:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sebastian Wiesner Subject: bug#17839: closed (Re: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions) Message-ID: References: X-Gnu-PR-Message: they-closed 17839 X-Gnu-PR-Package: emacs Reply-To: 17839@debbugs.gnu.org Date: Thu, 26 Jun 2014 19:03:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1403809383-26370-1" This is a multi-part message in MIME format... ------------=_1403809383-26370-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17839: 24.4.50; read-passwd echoes password input in non-interactive sessi= ons which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17839@debbugs.gnu.org. --=20 17839: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17839 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1403809383-26370-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17839-done) by debbugs.gnu.org; 26 Jun 2014 19:02:06 +0000 Received: from localhost ([127.0.0.1]:34029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X0Evp-0006ok-0a for submit@debbugs.gnu.org; Thu, 26 Jun 2014 15:02:06 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:58648 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X0Evi-0006oW-Cy for 17839-done@debbugs.gnu.org; Thu, 26 Jun 2014 15:01:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X0Evh-0002uE-NO; Thu, 26 Jun 2014 15:01:53 -0400 From: Glenn Morris To: 17839-done@debbugs.gnu.org Subject: Re: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> X-Spook: csystems S Box Nazi pink noise Geraldton doctrine X-Ran: *']R7<1_/9Zcos:;9$?JQ]M$J9"^(""c]2=QDPMMq{bf.,$JW]9c?NhcbP;0}X+c_VQUN\ X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 26 Jun 2014 15:01:53 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 25 Jun 2014 10:32:51 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 17839-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Version: 24.4 Stefan Monnier wrote: > but indeed, it's not desirable. Could someone install the obvious patch > in read-passwd to emit a warning (right after the prompt, so the user > will necessarily see it)? Done and documented. (Feel free to adjust wording.) ------------=_1403809383-26370-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Jun 2014 15:36:48 +0000 Received: from localhost ([127.0.0.1]:58365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz6IV-0001FD-HM for submit@debbugs.gnu.org; Mon, 23 Jun 2014 11:36:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34299) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wz4fS-0006i3-5A for submit@debbugs.gnu.org; Mon, 23 Jun 2014 09:52:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz4fD-0003Rj-UK for submit@debbugs.gnu.org; Mon, 23 Jun 2014 09:52:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz4fD-0003Re-Ro for submit@debbugs.gnu.org; Mon, 23 Jun 2014 09:52:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz4f6-0005SR-5q for bug-gnu-emacs@gnu.org; Mon, 23 Jun 2014 09:52:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz4ey-0003LL-NP for bug-gnu-emacs@gnu.org; Mon, 23 Jun 2014 09:51:56 -0400 Received: from vega.uberspace.de ([95.143.172.245]:48045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz4ey-0003L7-DO for bug-gnu-emacs@gnu.org; Mon, 23 Jun 2014 09:51:48 -0400 Received: (qmail 8393 invoked from network); 23 Jun 2014 13:51:45 -0000 Received: from localhost (HELO lunaryorn-air) (127.0.0.1) by vega.uberspace.de with SMTP; 23 Jun 2014 13:51:45 -0000 From: Sebastian Wiesner To: bug-gnu-emacs@gnu.org Subject: 24.4.50; read-passwd echoes password input in non-interactive sessions Date: Mon, 23 Jun 2014 15:51:37 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 23 Jun 2014 11:36:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In a non-interactive session, i.e. "emacs -Q --batch =E2=80=A6", `read-pass= wd' currently echoes the password input on the TTY. I would expect `read-passwd' to suppress input echo while reading a password, like suo, sudo, SSH, GPG and similar programs do. In my opinion, the current behaviour is harmful, because from their experience with these programs user will likely expect that input following a "Password: " prompt is hidden, and thus may accidentally expose their password, being unaware that Emacs behaves differently. ------------=_1403809383-26370-1-- From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jul 2014 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Andreas Schwab , 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140500302617963 (code B ref 17839); Thu, 10 Jul 2014 14:38:02 +0000 Received: (at 17839) by debbugs.gnu.org; 10 Jul 2014 14:37:06 +0000 Received: from localhost ([127.0.0.1]:52277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5FT4-0004e8-1J for submit@debbugs.gnu.org; Thu, 10 Jul 2014 10:37:06 -0400 Received: from mout.gmx.net ([212.227.17.21]:63020) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5FSx-0004dk-NX for 17839@debbugs.gnu.org; Thu, 10 Jul 2014 10:36:59 -0400 Received: from detlef.gmx.de ([93.202.59.34]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M7DVi-1WhXs80i0c-00x3VV; Thu, 10 Jul 2014 16:36:47 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> Date: Thu, 10 Jul 2014 16:36:43 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 25 Jun 2014 10:32:51 -0400") Message-ID: <87fvi9jn5w.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:iFaaDR4pvfJLFgmlwvmHUVyKmVJDo75bCTZA/JQTxOhFYXz33Zw urRSbt7pWIN9bD6LX7IDufnav/+wzgQ2oOOCMzZdhA7Fl1q4cl45ysLzY5eB9y8bNFGMoE6 BoyqH1gt3oRcrwxr+bDGBif6xwLGeR3Hwik42i0eMN38h6xWk042qB+PfID4DpG1QYZlgAv lcRf4ZwqvvjL3SNOLd71g== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Stefan Monnier writes: > If someone is motivated, I would even accept a patch that turns echo off > temporarily. Well, I've tried this 'cos I believe it is important. The idea is to give the prompt in read-passwd the text property 'hide-chars. In noninteractive mode, emacs writes "." instead of echoing the password while typing. You can test it with # emacs -batch -eval '(progn (message (read-string "Prompt1: ")) (message (read-passwd "Prompt2: ")) (message (read-string "Prompt3: ")))' The patch is not perfect (it doesn't handled multi-byte chars, and I have tested it only under Gnu/Linux), but it is a first step. Comments? > Stefan Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=diff === modified file 'lisp/subr.el' --- lisp/subr.el 2014-06-28 17:27:29 +0000 +++ lisp/subr.el 2014-07-10 13:53:13 +0000 @@ -2058,7 +2058,7 @@ (let ((enable-recursive-minibuffers t)) (read-string (if noninteractive - (format "%s[INPUT WILL NOT BE HIDDEN!] " prompt) ; bug#17839 + (propertize prompt 'hide-chars t) ; bug#17839 prompt) nil t default)) ; t = "no history" (when (buffer-live-p minibuf) === modified file 'src/minibuf.c' --- src/minibuf.c 2014-05-26 02:28:09 +0000 +++ src/minibuf.c 2014-07-10 14:19:50 +0000 @@ -35,6 +35,10 @@ #include "keymap.h" #include "termhooks.h" +#include "systty.h" +extern void emacs_get_tty (int, struct emacs_tty *); +extern int emacs_set_tty (int, struct emacs_tty *, bool); + /* List of buffers for use as minibuffers. The first element of the list is used for the outermost minibuffer invocation, the next element is used for a recursive minibuffer @@ -209,6 +213,8 @@ } +static Lisp_Object Qhide_chars; + /* Like read_minibuf but reading from stdin. This function is called from read_minibuf to do the job if noninteractive. */ @@ -224,6 +230,20 @@ char *line; Lisp_Object val; int c; + bool hide_chars; + struct emacs_tty old, new; + + /* Check, whether we need to suppress echoing. */ + hide_chars = ! (NILP (Fget_text_property + (make_number (0), Qhide_chars, prompt))); + if (hide_chars) + { + emacs_get_tty (fileno (stdin), &old); + new = old; + new.main.c_lflag &= ~ICANON; /* Disable buffering */ + new.main.c_lflag &= ~ECHO; /* Disable echoing */ + emacs_set_tty (fileno (stdin), &new, 0); + } fprintf (stdout, "%s", SDATA (prompt)); fflush (stdout); @@ -240,8 +260,17 @@ if (errno != EINTR) break; } + else if (hide_chars && (c == 127)) /* DEL */ + { + /* Unfortunately, we cannot edit stdout. */ + // fprintf (stdout, "%c", c); + /* Hmm, this doesn't work for multi-byte characters. */ + (len > 0) && len--; + } else { + if (hide_chars) + fprintf (stdout, "."); if (len == size) { if (STRING_BYTES_BOUND / 2 < size) @@ -253,6 +282,13 @@ } } + /* Reset tty. */ + if (hide_chars) + { + fprintf (stdout, "\n"); + emacs_set_tty (fileno (stdin), &old, 0); + } + if (len || c == '\n') { val = make_string (line, len); @@ -1935,6 +1971,7 @@ DEFSYM (Qactivate_input_method, "activate-input-method"); DEFSYM (Qcase_fold_search, "case-fold-search"); DEFSYM (Qmetadata, "metadata"); + DEFSYM (Qhide_chars, "hide-chars"); DEFVAR_LISP ("read-expression-history", Vread_expression_history, doc: /* A history list for arguments that are Lisp expressions to evaluate. === modified file 'src/sysdep.c' --- src/sysdep.c 2014-06-09 14:50:57 +0000 +++ src/sysdep.c 2014-07-10 10:07:05 +0000 @@ -105,8 +105,8 @@ #include "syssignal.h" #include "systime.h" -static void emacs_get_tty (int, struct emacs_tty *); -static int emacs_set_tty (int, struct emacs_tty *, bool); +void emacs_get_tty (int, struct emacs_tty *) EXTERNALLY_VISIBLE; +int emacs_set_tty (int, struct emacs_tty *, bool) EXTERNALLY_VISIBLE; /* ULLONG_MAX is missing on Red Hat Linux 7.3; see Bug#11781. */ #ifndef ULLONG_MAX @@ -779,7 +779,7 @@ /* Set *TC to the parameters associated with the terminal FD, or clear it if the parameters are not available. */ -static void +void emacs_get_tty (int fd, struct emacs_tty *settings) { /* Retrieve the primary parameters - baud rate, character size, etcetera. */ @@ -795,7 +795,7 @@ *SETTINGS. If FLUSHP, discard input. Return 0 if all went well, and -1 (setting errno) if anything failed. */ -static int +int emacs_set_tty (int fd, struct emacs_tty *settings, bool flushp) { /* Set the primary parameters - baud rate, character size, etcetera. */ --=-=-=-- From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jul 2014 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Andreas Schwab , 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050106431542 (code B ref 17839); Thu, 10 Jul 2014 16:45:02 +0000 Received: (at 17839) by debbugs.gnu.org; 10 Jul 2014 16:44:03 +0000 Received: from localhost ([127.0.0.1]:52395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HRu-0000O8-R5 for submit@debbugs.gnu.org; Thu, 10 Jul 2014 12:44:03 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:59826) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HRo-0000Nn-Pk for 17839@debbugs.gnu.org; Thu, 10 Jul 2014 12:43:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzAEEhQYDSSIBAjSGReOegcYhCAElB6Ue4FqgXGBWyE X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzAEEhQYDSSIBAjSGReOegcYhCAElB6Ue4FqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77080473" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jul 2014 12:43:46 -0400 Received: by pastel.home (Postfix, from userid 20848) id AFD37604AF; Thu, 10 Jul 2014 12:43:46 -0400 (EDT) From: Stefan Monnier Message-ID: References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> Date: Thu, 10 Jul 2014 12:43:46 -0400 In-Reply-To: <87fvi9jn5w.fsf@gmx.de> (Michael Albinus's message of "Thu, 10 Jul 2014 16:36:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Well, I've tried this 'cos I believe it is important. The idea is to > give the prompt in read-passwd the text property 'hide-chars. In > noninteractive mode, emacs writes "." instead of echoing the password > while typing. You can test it with I think a more idiomatic way to do that would be to use a global Lisp var that's let-bound in read-passwd. > + else if (hide_chars && (c == 127)) /* DEL */ > + { > + /* Unfortunately, we cannot edit stdout. */ > + // fprintf (stdout, "%c", c); > + /* Hmm, this doesn't work for multi-byte characters. */ > + (len > 0) && len--; > + } I don't think that's worth the trouble. Stefan From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jul 2014 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Andreas Schwab , 17839@debbugs.gnu.org, Stefan Monnier Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140502880210707 (code B ref 17839); Thu, 10 Jul 2014 21:47:02 +0000 Received: (at 17839) by debbugs.gnu.org; 10 Jul 2014 21:46:42 +0000 Received: from localhost ([127.0.0.1]:52620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5MAr-0002mc-G6 for submit@debbugs.gnu.org; Thu, 10 Jul 2014 17:46:41 -0400 Received: from vega.uberspace.de ([95.143.172.245]:45479) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5MAo-0002mJ-6A for 17839@debbugs.gnu.org; Thu, 10 Jul 2014 17:46:39 -0400 Received: (qmail 4353 invoked from network); 10 Jul 2014 21:46:38 -0000 Received: from localhost (HELO hostname.fritz.box) (127.0.0.1) by vega.uberspace.de with SMTP; 10 Jul 2014 21:46:38 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) From: Sebastian Wiesner In-Reply-To: <87fvi9jn5w.fsf@gmx.de> Date: Thu, 10 Jul 2014 23:46:33 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> X-Mailer: Apple Mail (2.1878.2) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am 10.07.2014 um 16:36 schrieb Michael Albinus : > Stefan Monnier writes: > >> If someone is motivated, I would even accept a patch that turns echo off >> temporarily. > > Well, I've tried this 'cos I believe it is important. Many thanks! Sebastian From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 09:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Andreas Schwab , 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140507013827841 (code B ref 17839); Fri, 11 Jul 2014 09:16:01 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 09:15:38 +0000 Received: from localhost ([127.0.0.1]:52948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5WvV-0007Ev-MU for submit@debbugs.gnu.org; Fri, 11 Jul 2014 05:15:37 -0400 Received: from mout.gmx.net ([212.227.15.18]:53752) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5WvO-0007EX-CP for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 05:15:30 -0400 Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M86PB-1WjCkh0vGD-00vgXV; Fri, 11 Jul 2014 11:15:18 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> Date: Fri, 11 Jul 2014 11:15:14 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 10 Jul 2014 12:43:46 -0400") Message-ID: <87vbr48del.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:12wgEVug0he3eh/gQYH+IKwGlIbtvdv+sXq0+yrezPZB/ATAkeP gAopH7FwejPZSsYLSiRawrFdUWIhtx5Xcgjf83htOI+XBip+GE6xkdqZOjsc3dIe5GhKL8O FBYxlk1kPXxe/eKSt8PPVFT+d5SLbq66fvyZJu1Dqu2Hx6u6N5Bm1HhvkDB//44KxyQB6sp M5XyOCrGD4BilrKEucVWw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> Well, I've tried this 'cos I believe it is important. The idea is to >> give the prompt in read-passwd the text property 'hide-chars. In >> noninteractive mode, emacs writes "." instead of echoing the password >> while typing. You can test it with > > I think a more idiomatic way to do that would be to use a global Lisp > var that's let-bound in read-passwd. OK. There is now `read-hide-char', which triggers it. Users can let-bind it to the character they prefer for hiding. This will be used in `read-passwd', choosing the default ?. if it is not let-bound already. >> + else if (hide_chars && (c == 127)) /* DEL */ >> + { >> + /* Unfortunately, we cannot edit stdout. */ >> + // fprintf (stdout, "%c", c); >> + /* Hmm, this doesn't work for multi-byte characters. */ >> + (len > 0) && len--; >> + } > > I don't think that's worth the trouble. I've removed this. The patch is committed to the trunk as revision 117510. > Stefan Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 09:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Andreas Schwab , 17839@debbugs.gnu.org, Sebastian Wiesner Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140507168330914 (code B ref 17839); Fri, 11 Jul 2014 09:42:01 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 09:41:23 +0000 Received: from localhost ([127.0.0.1]:53012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5XKU-00082X-94 for submit@debbugs.gnu.org; Fri, 11 Jul 2014 05:41:22 -0400 Received: from mout.gmx.net ([212.227.17.21]:54874) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5XKR-00082B-Pj for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 05:41:20 -0400 Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MF5C3-1WpGpi1qEF-00GJus; Fri, 11 Jul 2014 11:41:09 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> Date: Fri, 11 Jul 2014 11:41:05 +0200 In-Reply-To: <87vbr48del.fsf@gmx.de> (Michael Albinus's message of "Fri, 11 Jul 2014 11:15:14 +0200") Message-ID: <87r41s8c7i.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:neTt/R11WI3PdB9MZNOj6Z4Z2fcuiLIfbenymE74nvF2t6gF6+e utpPa4/q+SWzHTH3WkDH5BHuH7TloqEjGQM761uUBAS3AM1aWbx0cfYSGNUz3V6sGkjxwav rBCGVuCtASpGJkDh2Whv6q9/CfbKVPfGuEZySZI0tDQdjfIh0jvEuT4ucpHWvlmSqPsqxyQ mpJgGo43HP9GnKrv6UpRw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Michael Albinus writes: > The patch is committed to the trunk as revision 117510. Grrrr. 117511, of course. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 09:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Reply-To: Eli Zaretskii Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140507192731393 (code B ref 17839); Fri, 11 Jul 2014 09:46:01 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 09:45:27 +0000 Received: from localhost ([127.0.0.1]:53016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5XON-0008A8-Ep for submit@debbugs.gnu.org; Fri, 11 Jul 2014 05:45:27 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:47201) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5XOH-00089k-2H for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 05:45:21 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N8J00500JVYM400@a-mtaout23.012.net.il> for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 12:45:10 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8J005FBKF9NF00@a-mtaout23.012.net.il>; Fri, 11 Jul 2014 12:45:10 +0300 (IDT) Date: Fri, 11 Jul 2014 12:45:14 +0300 From: Eli Zaretskii In-reply-to: <87vbr48del.fsf@gmx.de> X-012-Sender: halo1@inter.net.il Message-id: <834myob55h.fsf@gnu.org> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Albinus > Date: Fri, 11 Jul 2014 11:15:14 +0200 > Cc: Andreas Schwab , 17839@debbugs.gnu.org, > Sebastian Wiesner > > OK. There is now `read-hide-char', which triggers it. Users can let-bind > it to the character they prefer for hiding. This will be used in > `read-passwd', choosing the default ?. if it is not let-bound already. > > >> + else if (hide_chars && (c == 127)) /* DEL */ > >> + { > >> + /* Unfortunately, we cannot edit stdout. */ > >> + // fprintf (stdout, "%c", c); > >> + /* Hmm, this doesn't work for multi-byte characters. */ > >> + (len > 0) && len--; > >> + } > > > > I don't think that's worth the trouble. > > I've removed this. > > The patch is committed to the trunk as revision 117510. Which breaks the MS-Windows build, of course, since Windows doesn't have termios. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.1405072759358 (code B ref 17839); Fri, 11 Jul 2014 10:00:02 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 09:59:19 +0000 Received: from localhost ([127.0.0.1]:53021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xbn-00005Y-6O for submit@debbugs.gnu.org; Fri, 11 Jul 2014 05:59:19 -0400 Received: from mout.gmx.net ([212.227.17.21]:51202) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xbg-00005D-UL for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 05:59:13 -0400 Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LtJ5T-1Wc1aU3WV1-012lcr; Fri, 11 Jul 2014 11:58:58 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> Date: Fri, 11 Jul 2014 11:58:51 +0200 In-Reply-To: <834myob55h.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Jul 2014 12:45:14 +0300") Message-ID: <87mwcg8bdw.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:RuQVcxHESwcGIamcrTjD9MUccdwIKpb3LnjVPcDesUCu3e6vvdh MT5aDed/2lnuO1PgHFY+QT4GrEsNgJHB41sFU71g7zBlpJmcQuRk1Ab5PXpoinOfmPlvooN NBwEkDiyzuabV97TGw+Q5Ef+gE9cyf1u36JD5UFPdvoLuY8lwq9S0KUroDJHNsdvKqQTPBL F1yUOiRPnBWuIj0rTBW1Q== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > Which breaks the MS-Windows build, of course, since Windows doesn't > have termios. That's what I have said my first message: I could test it for Gnu/Linux only. Shall I add "#ifndef WINDOWSNT" at the usual places? Alternatively, shall we add (disable|enable)_echo functions to sysdep.c? While looking for the tty solution, I have also seen that there are Windows specific functions for that. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 10:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: michael.albinus@gmx.de Cc: schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com Reply-To: Eli Zaretskii Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.1405073005889 (code B ref 17839); Fri, 11 Jul 2014 10:04:02 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 10:03:25 +0000 Received: from localhost ([127.0.0.1]:53025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xfl-0000ED-Nf for submit@debbugs.gnu.org; Fri, 11 Jul 2014 06:03:25 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:50453) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xfg-0000Dw-Kv for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 06:03:20 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0N8J00800KSCLG00@a-mtaout21.012.net.il> for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 13:03:10 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8J00806L99LI20@a-mtaout21.012.net.il>; Fri, 11 Jul 2014 13:03:10 +0300 (IDT) Date: Fri, 11 Jul 2014 13:03:14 +0300 From: Eli Zaretskii In-reply-to: <834myob55h.fsf@gnu.org> X-012-Sender: halo1@inter.net.il Message-id: <83zjgg9pr1.fsf@gnu.org> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 11 Jul 2014 12:45:14 +0300 > From: Eli Zaretskii > Cc: schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com > > > From: Michael Albinus > > Date: Fri, 11 Jul 2014 11:15:14 +0200 > > Cc: Andreas Schwab , 17839@debbugs.gnu.org, > > Sebastian Wiesner > > > > OK. There is now `read-hide-char', which triggers it. Users can let-bind > > it to the character they prefer for hiding. This will be used in > > `read-passwd', choosing the default ?. if it is not let-bound already. > > > > >> + else if (hide_chars && (c == 127)) /* DEL */ > > >> + { > > >> + /* Unfortunately, we cannot edit stdout. */ > > >> + // fprintf (stdout, "%c", c); > > >> + /* Hmm, this doesn't work for multi-byte characters. */ > > >> + (len > 0) && len--; > > >> + } > > > > > > I don't think that's worth the trouble. > > > > I've removed this. > > > > The patch is committed to the trunk as revision 117510. > > Which breaks the MS-Windows build, of course, since Windows doesn't > have termios. I installed a temporary fix, to allow the build to succeed, but it means that currently `read-hide-char' is a no-op on MS-Windows. Stay tuned. Btw, I think it's a mistake to expose termios bowels of struct emacs_tty in minibuf.c. I think we should move that code to a separate function in sysdep.c, which will be called from minibuf.c. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Reply-To: Eli Zaretskii Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050736422111 (code B ref 17839); Fri, 11 Jul 2014 10:15:02 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 10:14:02 +0000 Received: from localhost ([127.0.0.1]:53032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xq3-0000XV-83 for submit@debbugs.gnu.org; Fri, 11 Jul 2014 06:14:02 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:41054) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xpy-0000X8-6N for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 06:13:57 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N8J00J00LDVUC00@a-mtaout20.012.net.il> for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 13:13:47 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8J00JK1LQZOO50@a-mtaout20.012.net.il>; Fri, 11 Jul 2014 13:13:47 +0300 (IDT) Date: Fri, 11 Jul 2014 13:13:51 +0300 From: Eli Zaretskii In-reply-to: <87mwcg8bdw.fsf@gmx.de> X-012-Sender: halo1@inter.net.il Message-id: <83y4w09p9c.fsf@gnu.org> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Albinus > Cc: monnier@iro.umontreal.ca, schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com > Date: Fri, 11 Jul 2014 11:58:51 +0200 > > Eli Zaretskii writes: > > > Which breaks the MS-Windows build, of course, since Windows doesn't > > have termios. > > That's what I have said my first message: I could test it for Gnu/Linux only. Testing on GNU/Linux is not the same as installing Posix-only code in a function that is compiled on non-Posix platforms. > Shall I add "#ifndef WINDOWSNT" at the usual places? I already did that. > Alternatively, shall we add (disable|enable)_echo functions to sysdep.c? Yes, please. This will make emulating termios for Windows easier. Thanks. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 10:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050737442316 (code B ref 17839); Fri, 11 Jul 2014 10:16:01 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 10:15:44 +0000 Received: from localhost ([127.0.0.1]:53036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xrg-0000b3-1Z for submit@debbugs.gnu.org; Fri, 11 Jul 2014 06:15:44 -0400 Received: from mout.gmx.net ([212.227.15.15]:61129) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5XrY-0000af-H4 for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 06:15:36 -0400 Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LanoO-1WLATi0R56-00kOvM; Fri, 11 Jul 2014 12:15:22 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <83zjgg9pr1.fsf@gnu.org> Date: Fri, 11 Jul 2014 12:15:19 +0200 In-Reply-To: <83zjgg9pr1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Jul 2014 13:03:14 +0300") Message-ID: <87tx6o5hhk.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:47ZZiUyBZBXYsUvbHytsBBPCYz0H7rV4sr60Lei9vREO0od5goI UmBSOWc9mDHNZTV5WOlzlGRLKJN4rcujVZR9pjA6z67FoVSblxi2QUt/sNgDqd6sTN0PnU2 Fsen8r/8vWg/bJnSjSVAMerFyQHVsmcIgdNpTH8eT2QUPbrJnyFge32bP2c/2oag4pJwktD TV8sEJfPH4Ou22eV02GCw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > I installed a temporary fix, to allow the build to succeed, but it > means that currently `read-hide-char' is a no-op on MS-Windows. Stay > tuned. Not fully a no-op. As side effect, you could apply your own hiding character even in interactive mode. ?* instead of ?. as you like ... > Btw, I think it's a mistake to expose termios bowels of struct > emacs_tty in minibuf.c. I think we should move that code to a > separate function in sysdep.c, which will be called from minibuf.c. ... as I have proposed the other message as well. I will work on this; unfortunately too much pressure on work these days. It might take some days. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140507838716030 (code B ref 17839); Fri, 11 Jul 2014 11:34:01 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 11:33:07 +0000 Received: from localhost ([127.0.0.1]:53063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Z4d-0004AU-4a for submit@debbugs.gnu.org; Fri, 11 Jul 2014 07:33:07 -0400 Received: from mout.gmx.net ([212.227.15.15]:63699) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Z4a-00049w-To for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 07:33:05 -0400 Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LkfdE-1WV8O90IDM-00aUWT; Fri, 11 Jul 2014 13:32:53 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> Date: Fri, 11 Jul 2014 13:32:47 +0200 In-Reply-To: <83y4w09p9c.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Jul 2014 13:13:51 +0300") Message-ID: <87pphc5dwg.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:qJ1c0AL1uBmhgq+kKuXmEF3UL1MghR0hJ0TLPzWLNbieEbQRwfj 1W2VIU4sHxrV0OMNJiOVDeYLKVa6n5qDCSmvG85xck4LvDPLhH6jH5y7L1euURblSZz6OAo Gwcj2Ja1Ha7Gg8hi+uBSZxdw8m2k+57ODiAokWhced462i3/v9hzQ2zwgRuZ1CtbwJt8dG1 bFNERsFDxRH4zAa3bFM3A== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> That's what I have said my first message: I could test it for Gnu/Linux only. > > Testing on GNU/Linux is not the same as installing Posix-only code in > a function that is compiled on non-Posix platforms. At least it forces answers to my "Comments?" question ... Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140508262324176 (code B ref 17839); Fri, 11 Jul 2014 12:44:02 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 12:43:43 +0000 Received: from localhost ([127.0.0.1]:53093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5aAs-0006Hm-Of for submit@debbugs.gnu.org; Fri, 11 Jul 2014 08:43:42 -0400 Received: from mout.gmx.net ([212.227.17.21]:57106) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5aAl-0006HJ-JI for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 08:43:35 -0400 Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MV6PJ-1X6Llb2C1V-00YPCy; Fri, 11 Jul 2014 14:43:18 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> Date: Fri, 11 Jul 2014 14:43:10 +0200 In-Reply-To: <83y4w09p9c.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Jul 2014 13:13:51 +0300") Message-ID: <87k37k5an5.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:mXTSUn0/xlOD6O0Q+KO7zG0uN9D95lcXceLMAJj4buBLi8OHlkM QHAM4auJ9Y93sgJBn3qwlTp95+LaDdHM6ixa9I8qgJFfOiaIyhs4tiW9taPv4yj0FE7RHsE KCfdRpviXgRqoJVPwfSohc0/vnL0G6CtmlCMNcV7tuj9VQSw1+4FaV6+fnLnqzHIKI/eiho tdzVVUKEQOp0bAQiVU/MQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> Alternatively, shall we add (disable|enable)_echo functions to sysdep.c? > > Yes, please. This will make emulating termios for Windows easier. I've moved the code to the new function suppress_echo_on_tty of sysdep.c. For resetting the tty, no new function was necessary. > Thanks. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Reply-To: Eli Zaretskii Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050873801588 (code B ref 17839); Fri, 11 Jul 2014 14:03:02 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 14:03:00 +0000 Received: from localhost ([127.0.0.1]:53573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5bPc-0000PR-Gn for submit@debbugs.gnu.org; Fri, 11 Jul 2014 10:03:00 -0400 Received: from mtaout29.012.net.il ([80.179.55.185]:55124) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5bPX-0000P2-0D for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 10:02:54 -0400 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N8J00500W4JGT00@mtaout29.012.net.il> for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 17:02:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8J0002RWCHJY50@mtaout29.012.net.il>; Fri, 11 Jul 2014 17:02:41 +0300 (IDT) Date: Fri, 11 Jul 2014 17:02:48 +0300 From: Eli Zaretskii In-reply-to: <87k37k5an5.fsf@gmx.de> X-012-Sender: halo1@inter.net.il Message-id: <83tx6o9enr.fsf@gnu.org> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> <87k37k5an5.fsf@gmx.de> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Albinus > Cc: monnier@iro.umontreal.ca, schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com > Date: Fri, 11 Jul 2014 14:43:10 +0200 > > Eli Zaretskii writes: > > >> Alternatively, shall we add (disable|enable)_echo functions to sysdep.c? > > > > Yes, please. This will make emulating termios for Windows easier. > > I've moved the code to the new function suppress_echo_on_tty of > sysdep.c. For resetting the tty, no new function was necessary. Thanks. I added implementation for MS-Windows. The result is not 100% satisfactory, as one needs to press RET twice to finish the input, and it looks like some garbage is left in the input buffer, since the following (normal) input gets something strange. A workaround is to press C-z, which produces EOF, instead of RET, when password entry is finished. I also needed a change in minibuf.c to end the reading loop on CR, not just a newline. If this is bad news for Posix platforms, we can make that code conditional on Windows. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050906898555 (code B ref 17839); Fri, 11 Jul 2014 14:59:02 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 14:58:09 +0000 Received: from localhost ([127.0.0.1]:53594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5cGz-0002Dp-6j for submit@debbugs.gnu.org; Fri, 11 Jul 2014 10:58:09 -0400 Received: from mout.gmx.net ([212.227.17.22]:57363) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5cGs-0002DA-K9 for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 10:58:02 -0400 Received: from detlef.gmx.de ([87.146.57.149]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LqE5k-1WRrfm2G5g-00dkoi; Fri, 11 Jul 2014 16:57:46 +0200 From: Michael Albinus References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> <87k37k5an5.fsf@gmx.de> <83tx6o9enr.fsf@gnu.org> Date: Fri, 11 Jul 2014 16:57:40 +0200 In-Reply-To: <83tx6o9enr.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Jul 2014 17:02:48 +0300") Message-ID: <87a98g54ez.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:5lPh9M/g4xYu0AVxrsq3yVIQm5yVkvv4E4a8itubqwrXXnPYCDJ 5dHx2NIEpEk2L2qT8StuUDUA2BfBdoskNZSJO4KtyTyPpy5RFjhXQETYT3NxpmMJn91Z9qE 813mqY367R40JQi06n0AsJmrcrlmjbHor85dfJKfOvdxYqYHudcwOa3b62gD0xQnjCB94Kf kMAkHJll0R0frfLJsrf1A== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > The result is not 100% satisfactory, as one needs to press RET twice > to finish the input, and it looks like some garbage is left in the > input buffer, since the following (normal) input gets something > strange. A workaround is to press C-z, which produces EOF, instead of > RET, when password entry is finished. Maybe because just "\n" is sent by fprintf()? In the Windows case, "\r\n" might be the better choice? And maybe we must handle the case, that RET sends 2 characters, which must be handled by a double call of getchar()? > I also needed a change in minibuf.c to end the reading loop on CR, not > just a newline. If this is bad news for Posix platforms, we can make > that code conditional on Windows. That's OK, I've just tested. When I've read the code of read_minibuf_noninteractive for the first time, I've seen that just CR was used for finishing input, and I've thought that nobody ever used this for MS Windows. This is one of the reasons I was somehow Windows agnostic during my work. Best regards, Michael. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 15:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: schwab@suse.de, 17839@debbugs.gnu.org, monnier@iro.umontreal.ca, swiesner@lunaryorn.com Reply-To: Eli Zaretskii Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140509358714249 (code B ref 17839); Fri, 11 Jul 2014 15:47:01 +0000 Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 15:46:27 +0000 Received: from localhost ([127.0.0.1]:53639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5d1j-0003hh-Ld for submit@debbugs.gnu.org; Fri, 11 Jul 2014 11:46:27 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:36985) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5d1e-0003hM-6z for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 11:46:21 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N8K00O000KAC900@mtaout24.012.net.il> for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 18:42:28 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8K00IPE0YSA670@mtaout24.012.net.il>; Fri, 11 Jul 2014 18:42:28 +0300 (IDT) Date: Fri, 11 Jul 2014 18:46:16 +0300 From: Eli Zaretskii In-reply-to: <87a98g54ez.fsf@gmx.de> X-012-Sender: halo1@inter.net.il Message-id: <83sim7aofr.fsf@gnu.org> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> <87k37k5an5.fsf@gmx.de> <83tx6o9enr.fsf@gnu.org> <87a98g54ez.fsf@gmx.de> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Albinus > Cc: monnier@iro.umontreal.ca, schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com > Date: Fri, 11 Jul 2014 16:57:40 +0200 > > Eli Zaretskii writes: > > > The result is not 100% satisfactory, as one needs to press RET twice > > to finish the input, and it looks like some garbage is left in the > > input buffer, since the following (normal) input gets something > > strange. A workaround is to press C-z, which produces EOF, instead of > > RET, when password entry is finished. > > Maybe because just "\n" is sent by fprintf()? In the Windows case, > "\r\n" might be the better choice? I don't think so. The problem is not what is printed, the problem is that the loop is not exited on the 1st RET, and in fact it looks like nothing is returned by getchar until you press the 2nd RET. > And maybe we must handle the case, that RET sends 2 characters, which > must be handled by a double call of getchar()? It doesn't look like it sends 2 characters: the next call to getchar after exiting the loop waits for more input. > When I've read the code of read_minibuf_noninteractive for the first > time, I've seen that just CR was used for finishing input You mean, just the newline, right? > and I've thought that nobody ever used this for MS Windows. That code worked perfectly well with cooked input mode, since then RET is converted to a newline by the stdio machinery (as it uses text mode). And that just gave me an idea: switch stdin to binary when not echoing input. Which solved the problem of double RET (and now it's clear why it was being eaten up). Thanks. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Aug 2014 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@suse.de, 17839@debbugs.gnu.org, Michael Albinus , monnier@iro.umontreal.ca Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140727033413495 (code B ref 17839); Tue, 05 Aug 2014 20:26:02 +0000 Received: (at 17839) by debbugs.gnu.org; 5 Aug 2014 20:25:34 +0000 Received: from localhost ([127.0.0.1]:59234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XElIb-0003Va-3O for submit@debbugs.gnu.org; Tue, 05 Aug 2014 16:25:33 -0400 Received: from vega.uberspace.de ([95.143.172.245]:52393) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XElIX-0003VN-OW for 17839@debbugs.gnu.org; Tue, 05 Aug 2014 16:25:31 -0400 Received: (qmail 31899 invoked from network); 5 Aug 2014 20:25:27 -0000 Received: from localhost (HELO ?IPv6:2001:a60:16d9:601:1d72:393d:add3:12da?) (127.0.0.1) by vega.uberspace.de with SMTP; 5 Aug 2014 20:25:27 -0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Wiesner In-Reply-To: <83sim7aofr.fsf@gnu.org> Date: Tue, 5 Aug 2014 22:25:25 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> <87k37k5an5.fsf@gmx.de> <83tx6o9enr.fsf@gnu.org> <87a98g54ez.fsf@gmx.de> <83sim7aofr.fsf@gnu.org> X-Mailer: Apple Mail (2.1878.6) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I=92m sorry to bring this issue up again, but I noticed that the patch = that hides input was only committed to Emacs trunk. Would it be = possible to backport this patch to the Emacs 24 branch as well, so that = it the patch is also included Emacs 24.4? =20 I know, Emacs is in feature freeze, and I understand that this patch = required some changes to Emacs=92 internals, but considering the = security implications I think it=92d be important to include this patch = in Emacs 24.4 as well, to bring it downstream as soon as possible. Greetings, Sebastian Wiesner= From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Aug 2014 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Wiesner Cc: schwab@suse.de, Eli Zaretskii , 17839@debbugs.gnu.org, Michael Albinus Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140734678826026 (code B ref 17839); Wed, 06 Aug 2014 17:40:01 +0000 Received: (at 17839) by debbugs.gnu.org; 6 Aug 2014 17:39:48 +0000 Received: from localhost ([127.0.0.1]:60630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XF5Bj-0006li-Qf for submit@debbugs.gnu.org; Wed, 06 Aug 2014 13:39:48 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:47462) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XF5Bh-0006la-QF for 17839@debbugs.gnu.org; Wed, 06 Aug 2014 13:39:46 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 6F85A84F3C; Wed, 6 Aug 2014 13:39:45 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 13C5B1E5B74; Wed, 6 Aug 2014 13:39:22 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id C90D2B40CD; Wed, 6 Aug 2014 13:39:21 -0400 (EDT) From: Stefan Monnier Message-ID: References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> <83y4w09p9c.fsf@gnu.org> <87k37k5an5.fsf@gmx.de> <83tx6o9enr.fsf@gnu.org> <87a98g54ez.fsf@gmx.de> <83sim7aofr.fsf@gnu.org> Date: Wed, 06 Aug 2014 13:39:21 -0400 In-Reply-To: (Sebastian Wiesner's message of "Tue, 5 Aug 2014 22:25:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > I know, Emacs is in feature freeze, and I understand that this patch > required some changes to Emacs=E2=80=99 internals, but considering the se= curity > implications I think it=E2=80=99d be important to include this patch in E= macs 24.4 > as well, to bring it downstream as soon as possible. AFAIK, this problem is far from new, so there's no real hurry. At least emacs23 -Q --batch --eval '(read-passwd "hello: ")' does not hide the password for me. Stefan From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Aug 2014 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: schwab@suse.de, Eli Zaretskii , 17839@debbugs.gnu.org, Michael Albinus Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14074100025238 (code B ref 17839); Thu, 07 Aug 2014 11:14:02 +0000 Received: (at 17839) by debbugs.gnu.org; 7 Aug 2014 11:13:22 +0000 Received: from localhost ([127.0.0.1]:33361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFLdK-0001MP-5T for submit@debbugs.gnu.org; Thu, 07 Aug 2014 07:13:22 -0400 Received: from vega.uberspace.de ([95.143.172.245]:46138) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFLdH-0001MF-P2 for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 07:13:20 -0400 Received: (qmail 31981 invoked from network); 7 Aug 2014 11:13:18 -0000 Received: from localhost (HELO lunaryorn.localnet) (127.0.0.1) by vega.uberspace.de with SMTP; 7 Aug 2014 11:13:18 -0000 From: Sebastian Wiesner Date: Thu, 07 Aug 2014 13:12:59 +0200 Message-ID: <1990658.6gzIWbjLAl@lunaryorn> User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am Mittwoch, 6. August 2014, 13:39:21 schrieb Stefan Monnier: > > I know, Emacs is in feature freeze, and I understand that this patc= h > > required some changes to Emacs=E2=80=99 internals, but considering = the security > > implications I think it=E2=80=99d be important to include this patc= h in Emacs 24.4 > > as well, to bring it downstream as soon as possible. >=20 > AFAIK, this problem is far from new, so there's no real hurry. I know, but I'd argue that since it's kind of a security issue, albeit = small,=20 it deserves a timely fix. YMMV, though, and I'm ok with either decisio= n you=20 make. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Aug 2014 13:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Wiesner Cc: schwab@suse.de, Eli Zaretskii , 17839@debbugs.gnu.org, Michael Albinus Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140741651920554 (code B ref 17839); Thu, 07 Aug 2014 13:02:01 +0000 Received: (at 17839) by debbugs.gnu.org; 7 Aug 2014 13:01:59 +0000 Received: from localhost ([127.0.0.1]:33504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFNKQ-0005LR-EP for submit@debbugs.gnu.org; Thu, 07 Aug 2014 09:01:59 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47079) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFNKO-0005LE-7d for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 09:01:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4iBBIUGA0kiAQI0hkXjnoHGIQgBKsDgXGBWyE X-IPAS-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4iBBIUGA0kiAQI0hkXjnoHGIQgBKsDgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="82366612" Received: from 192-171-34-171.cpe.pppoe.ca (HELO pastel.home) ([192.171.34.171]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Aug 2014 09:01:49 -0400 Received: by pastel.home (Postfix, from userid 20848) id 2D47A60787; Thu, 7 Aug 2014 09:01:49 -0400 (EDT) From: Stefan Monnier Message-ID: References: <1990658.6gzIWbjLAl@lunaryorn> Date: Thu, 07 Aug 2014 09:01:49 -0400 In-Reply-To: <1990658.6gzIWbjLAl@lunaryorn> (Sebastian Wiesner's message of "Thu, 07 Aug 2014 13:12:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I know, but I'd argue that since it's kind of a security issue, albeit > small, it deserves a timely fix. YMMV, though, and I'm ok with > either decision you make. I'm OK with installing a fix for it in emacs-24, but the fix we have in trunk is not "obviously safe" enough to be appropriate for emacs-24. And I think the warning we added to emacs-24 is a sufficient (tho not ideal) stop-gap for emacs-24. IOW feel free to send a safer patch (with corresponding copyright paperwork, of course), Stefan From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Aug 2014 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: schwab@suse.de, Eli Zaretskii , 17839@debbugs.gnu.org, Michael Albinus Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140741715721628 (code B ref 17839); Thu, 07 Aug 2014 13:13:01 +0000 Received: (at 17839) by debbugs.gnu.org; 7 Aug 2014 13:12:37 +0000 Received: from localhost ([127.0.0.1]:33516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFNUj-0005cm-6i for submit@debbugs.gnu.org; Thu, 07 Aug 2014 09:12:37 -0400 Received: from vega.uberspace.de ([95.143.172.245]:38983) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFNUb-0005cX-W8 for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 09:12:35 -0400 Received: (qmail 13075 invoked from network); 7 Aug 2014 13:12:28 -0000 Received: from localhost (HELO hostname.fritz.box) (127.0.0.1) by vega.uberspace.de with SMTP; 7 Aug 2014 13:12:28 -0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Wiesner In-Reply-To: Date: Thu, 7 Aug 2014 15:12:27 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <0BFC2B2F-DF0B-41AE-B0E1-AD67E3C2086A@lunaryorn.com> References: <1990658.6gzIWbjLAl@lunaryorn> X-Mailer: Apple Mail (2.1878.6) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am 07.08.2014 um 15:01 schrieb Stefan Monnier = : >> I know, but I'd argue that since it's kind of a security issue, = albeit >> small, it deserves a timely fix. YMMV, though, and I'm ok with >> either decision you make. >=20 > I'm OK with installing a fix for it in emacs-24, but the fix we have = in > trunk is not "obviously safe" enough to be appropriate for emacs-24. I know. > And I think the warning we added to emacs-24 is a sufficient (tho not > ideal) stop-gap for emacs-24. Ok. >=20 > IOW feel free to send a safer patch (with corresponding copyright > paperwork, of course), I don=92t think that I=92m competent enough to do that. If I understand = correctly, Windows support is the main issue, and I do not use Windows. Besides, you know my opinion of your copyright paperwork, and it hasn=92t = changed lately. I won=92t contribute to Emacs.= From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Aug 2014 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Wiesner Cc: schwab@suse.de, 17839@debbugs.gnu.org, michael.albinus@gmx.de, monnier@iro.umontreal.ca Reply-To: Eli Zaretskii Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14074254273148 (code B ref 17839); Thu, 07 Aug 2014 15:31:01 +0000 Received: (at 17839) by debbugs.gnu.org; 7 Aug 2014 15:30:27 +0000 Received: from localhost ([127.0.0.1]:34153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFPe6-0000oh-4A for submit@debbugs.gnu.org; Thu, 07 Aug 2014 11:30:26 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:53052) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFPe3-0000oO-Bb for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 11:30:24 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N9Y00J000CCX000@a-mtaout22.012.net.il> for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 18:30:17 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9Y00JGG0EGWY00@a-mtaout22.012.net.il>; Thu, 07 Aug 2014 18:30:17 +0300 (IDT) Date: Thu, 07 Aug 2014 18:30:31 +0300 From: Eli Zaretskii In-reply-to: <0BFC2B2F-DF0B-41AE-B0E1-AD67E3C2086A@lunaryorn.com> X-012-Sender: halo1@inter.net.il Message-id: <83bnrwnwq0.fsf@gnu.org> References: <1990658.6gzIWbjLAl@lunaryorn> <0BFC2B2F-DF0B-41AE-B0E1-AD67E3C2086A@lunaryorn.com> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Sebastian Wiesner > Date: Thu, 7 Aug 2014 15:12:27 +0200 > Cc: Eli Zaretskii , > Michael Albinus , > schwab@suse.de, > 17839@debbugs.gnu.org > > If I understand correctly, Windows support is the main issue ??? No, it isn't. Once Michael added the code to do this on Posix platforms, the Windows code was added to follow suit. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Aug 2014 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Andreas Schwab , 17839@debbugs.gnu.org, Michael Albinus , Stefan Monnier Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14074277217002 (code B ref 17839); Thu, 07 Aug 2014 16:09:01 +0000 Received: (at 17839) by debbugs.gnu.org; 7 Aug 2014 16:08:41 +0000 Received: from localhost ([127.0.0.1]:34175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFQF6-0001oq-8E for submit@debbugs.gnu.org; Thu, 07 Aug 2014 12:08:40 -0400 Received: from vega.uberspace.de ([95.143.172.245]:33887) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFQF0-0001ob-4P for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 12:08:38 -0400 Received: (qmail 19207 invoked from network); 7 Aug 2014 16:08:32 -0000 Received: from localhost (HELO lunaryorn-air.fritz.box) (127.0.0.1) by vega.uberspace.de with SMTP; 7 Aug 2014 16:08:32 -0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Wiesner In-Reply-To: <83bnrwnwq0.fsf@gnu.org> Date: Thu, 7 Aug 2014 18:08:28 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <83229A29-AFA5-49A4-B502-2E10D31C5CB5@lunaryorn.com> References: <1990658.6gzIWbjLAl@lunaryorn> <0BFC2B2F-DF0B-41AE-B0E1-AD67E3C2086A@lunaryorn.com> <83bnrwnwq0.fsf@gnu.org> X-Mailer: Apple Mail (2.1878.6) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Am 07.08.2014 um 17:30 schrieb Eli Zaretskii : >> From: Sebastian Wiesner >> Date: Thu, 7 Aug 2014 15:12:27 +0200 >> Cc: Eli Zaretskii , >> Michael Albinus , >> schwab@suse.de, >> 17839@debbugs.gnu.org >>=20 >> If I understand correctly, Windows support is the main issue >=20 > ??? No, it isn't. Once Michael added the code to do this on Posix > platforms, the Windows code was added to follow suit. I=92m sorry. I did not follow the entire discussion, since I couldn=92t = comment on the implementation anyway. All that I read was that there = was some Windows-specific discussion, and from Stefan=92s comment I = presumed that Windows was still an issue. But if it isn=92t, I don=92t see why this patch shouldn=92t be =93safe=94 = for Emacs 24? I=92m sorry if I=92m asking a stupid question, but I=92m = not familiar with Emacs=92 policies. From unknown Tue Jun 24 20:52:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Aug 2014 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sebastian Wiesner Cc: schwab@suse.de, 17839@debbugs.gnu.org, michael.albinus@gmx.de, monnier@iro.umontreal.ca Reply-To: Eli Zaretskii Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.140742952510028 (code B ref 17839); Thu, 07 Aug 2014 16:39:02 +0000 Received: (at 17839) by debbugs.gnu.org; 7 Aug 2014 16:38:45 +0000 Received: from localhost ([127.0.0.1]:34184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFQiC-0002bf-4W for submit@debbugs.gnu.org; Thu, 07 Aug 2014 12:38:44 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:46616) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFQi6-0002bK-H0 for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 12:38:39 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N9Y00C003A4FB00@mtaout25.012.net.il> for 17839@debbugs.gnu.org; Thu, 07 Aug 2014 19:33:38 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9Y008OH3C2U830@mtaout25.012.net.il>; Thu, 07 Aug 2014 19:33:38 +0300 (IDT) Date: Thu, 07 Aug 2014 19:38:46 +0300 From: Eli Zaretskii In-reply-to: <83229A29-AFA5-49A4-B502-2E10D31C5CB5@lunaryorn.com> X-012-Sender: halo1@inter.net.il Message-id: <83wqakmezt.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 8BIT References: <1990658.6gzIWbjLAl@lunaryorn> <0BFC2B2F-DF0B-41AE-B0E1-AD67E3C2086A@lunaryorn.com> <83bnrwnwq0.fsf@gnu.org> <83229A29-AFA5-49A4-B502-2E10D31C5CB5@lunaryorn.com> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Sebastian Wiesner > Date: Thu, 7 Aug 2014 18:08:28 +0200 > Cc: Stefan Monnier , > Michael Albinus , > Andreas Schwab , > 17839@debbugs.gnu.org > > >> If I understand correctly, Windows support is the main issue > > > > ??? No, it isn't. Once Michael added the code to do this on Posix > > platforms, the Windows code was added to follow suit. > > Im sorry. I did not follow the entire discussion, since I couldnt comment on the implementation anyway. All that I read was that there was some Windows-specific discussion, and from Stefans comment I presumed that Windows was still an issue. The Windows-specific discussion was because implementing the same feature on Windows had some subtle issues. > But if it isnt, I dont see why this patch shouldnt be safe for Emacs 24? I guess because the code changes are not entirely trivial.