GNU bug report logs - #17822
bs-show with mulitbyte characters doesn't work well

Previous Next

Package: emacs;

Reported by: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>

Date: Fri, 20 Jun 2014 17:27:01 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 26.2

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17822 in the body.
You can then email your comments to 17822 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#17822; Package emacs. (Fri, 20 Jun 2014 17:27:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Shigeru Fukaya <shigeru.fukaya <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 20 Jun 2014 17:27:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: bs-show with mulitbyte characters doesn't work well
Date: Sat, 21 Jun 2014 02:25:20 +0900

`bs-show' displays buffer information on incorrect column position.
It is because `bs-show' calculates column using `length' for multibyte
strings.

Just changing `length' to `string-width' in `bs-show-in-buffer' and
`bs--insert-one-entry' will solve the problem.

Regards,
Shigeru
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17822; Package emacs. (Fri, 20 Jun 2014 19:17:01 GMT) Full text and rfc822 format available.

Message #8 received at 17822 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
Cc: 17822 <at> debbugs.gnu.org
Subject: Re: bug#17822: bs-show with mulitbyte characters doesn't work well
Date: Fri, 20 Jun 2014 15:16:08 -0400

> `bs-show' displays buffer information on incorrect column position.
> It is because `bs-show' calculates column using `length' for multibyte
> strings.

> Just changing `length' to `string-width' in `bs-show-in-buffer' and
> `bs--insert-one-entry' will solve the problem.

Indeed (tho this is not a "multibyte" problem, but a problem with
double-width chars).
Can you provide a patch?


        Stefan
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17822; Package emacs. (Sat, 21 Jun 2014 03:37:01 GMT) Full text and rfc822 format available.

Message #11 received at 17822 <at> debbugs.gnu.org (full text, mbox):

From: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 17822 <at> debbugs.gnu.org
Subject: Re: bug#17822: bs-show with mulitbyte characters doesn't work well
Date: Sat, 21 Jun 2014 12:35:55 +0900

[Message part 1 (text/plain, inline)]
>> `bs-show' displays buffer information on incorrect column position.
>> It is because `bs-show' calculates column using `length' for multibyte
>> strings.
>
>> Just changing `length' to `string-width' in `bs-show-in-buffer' and
>> `bs--insert-one-entry' will solve the problem.
>
>Indeed (tho this is not a "multibyte" problem, but a problem with
>double-width chars).
Oh, I'll remember the term.

>Can you provide a patch?
OK

Shigeru

[bs.diff (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17822; Package emacs. (Wed, 19 Sep 2018 23:03:01 GMT) Full text and rfc822 format available.

Message #14 received at 17822 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 17822 <at> debbugs.gnu.org
Subject: Re: bug#17822: bs-show with mulitbyte characters doesn't work well
Date: Wed, 19 Sep 2018 19:02:51 -0400

tags 17822 fixed
close 17822 26.2
quit

Shigeru Fukaya <shigeru.fukaya <at> gmail.com> writes:

>>Can you provide a patch?
> OK
>
> Shigeru
>
> --- orig/bs.el	2014-03-21 14:34:40.000000000 +0900
> +++ ./bs.el	2014-06-21 12:26:39.114537800 +0900

Pushed to emacs-26.

[1: 98544ea3ea]: 2018-09-19 18:48:07 -0400
  Fix bs-show with wide characters (Bug#17822)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=98544ea3ea1638228db48c5ff993caded470d9c1
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 19 Sep 2018 23:03:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 26.2, send any further explanations to 17822 <at> debbugs.gnu.org and Shigeru Fukaya <shigeru.fukaya <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 19 Sep 2018 23:03:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 18 Oct 2018 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 246 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.