GNU bug report logs - #17808
24.4.50; vc-annotate colors

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> jurta.org>

Date: Thu, 19 Jun 2014 07:12:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 24.4.50

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 17808 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 17808 <at> debbugs.gnu.org
Subject: Re: bug#17808: 24.4.50; vc-annotate colors
Date: Thu, 03 Jul 2014 02:31:03 +0300
>> > Currently vc-annotate uses dark background even when the default
>> > background is light.  Would be nicer to have another option similar
>> > to the existing `vc-annotate-background' that will define the
>> > default foreground (instead of the default background) and put
>> > colors from color-map on the background instead of the foreground:
>>
>> Actually much cleaner would be to add a dedicated user option
>> that will define whether to apply the color map to the background
>> or to the foreground.  When applied to the background with the
>> default light background, colors need to be less saturated,
>> so the saturation is decreased from 75% to 20% for light backgrounds.
>> Also `vc-annotate-background' doesn't need the default value "black"
>> because the background will be dark on dark environments anyway.
>
> Did anyone think of just using the current default background color?
> If not, why not?

Some colors from the current `vc-annotate-color-map' are
illegible when used for a foreground on a light background
(white by default).

But the last patch provides a palette where color saturation
is reduced from 75% to 20%, so the output looks nicely
for light backgrounds where related lines are grouped
using the same backgrounds like in the table from this post :-)

https://plus.google.com/+BrunoOliveira/posts/1mnVJcJqzVD




This bug report was last modified 10 years and 321 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.