From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 19 03:11:41 2014 Received: (at submit) by debbugs.gnu.org; 19 Jun 2014 07:11:41 +0000 Received: from localhost ([127.0.0.1]:52412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxWVZ-0004qL-20 for submit@debbugs.gnu.org; Thu, 19 Jun 2014 03:11:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46221) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxWVX-0004py-5h for submit@debbugs.gnu.org; Thu, 19 Jun 2014 03:11:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxWVI-0002l6-0J for submit@debbugs.gnu.org; Thu, 19 Jun 2014 03:11:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxWVH-0002kx-TI for submit@debbugs.gnu.org; Thu, 19 Jun 2014 03:11:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxWVA-0003Dz-BW for bug-gnu-emacs@gnu.org; Thu, 19 Jun 2014 03:11:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxWV2-0002jM-Fp for bug-gnu-emacs@gnu.org; Thu, 19 Jun 2014 03:11:16 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:57239 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxWV2-0002jH-9q for bug-gnu-emacs@gnu.org; Thu, 19 Jun 2014 03:11:08 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id D14C7375AE06ED for ; Thu, 19 Jun 2014 00:11:03 -0700 (PDT) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 24.4.50; vc-annotate colors Organization: JURTA Date: Thu, 19 Jun 2014 09:54:44 +0300 Message-ID: <87bntpl77v.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Severity: wishlist Tags: patch Currently vc-annotate uses dark background even when the default background is light. Would be nicer to have another option similar to the existing `vc-annotate-background' that will define the default foreground (instead of the default background) and put colors from color-map on the background instead of the foreground: === modified file 'lisp/vc/vc-annotate.el' --- lisp/vc/vc-annotate.el 2014-02-10 01:34:22 +0000 +++ lisp/vc/vc-annotate.el 2014-06-19 06:52:59 +0000 @@ -109,6 +109,16 @@ (defcustom vc-annotate-background "black :type '(choice (const :tag "Default background" nil) (color)) :group 'vc) +(defcustom vc-annotate-foreground nil + "Foreground color for \\[vc-annotate]. +When non-nil, the color range from `vc-annotate-color-map' +is applied to background, and the color from this definition +is applied to foreground. +This option is in effect only when `vc-annotate-background' is nil." + :type '(choice (const :tag "Default foreground" nil) (color)) + :version "24.5" + :group 'vc) + (defcustom vc-annotate-menu-elements '(2 0.5 0.1 0.01) "Menu elements for the mode-specific menu of VC-Annotate mode. List of factors, used to expand/compress the time scale. See `vc-annotate'." @@ -347,7 +357,9 @@ (defun vc-annotate (file rev &optional d `vc-annotate-menu-elements' customizes the menu elements of the mode-specific menu. `vc-annotate-color-map' and `vc-annotate-very-old-color' define the mapping of time to colors. -`vc-annotate-background' specifies the background color." +`vc-annotate-background' specifies the background color. +`vc-annotate-foreground' specifies the foreground color +when `vc-annotate-background' is nil." (interactive (save-current-buffer (vc-ensure-vc-buffer) @@ -666,10 +678,15 @@ (defun vc-annotate-lines (limit) ;; Make the face if not done. (face (or (intern-soft face-name) (let ((tmp-face (make-face (intern face-name)))) - (set-face-foreground tmp-face (cdr color)) - (when vc-annotate-background - (set-face-background tmp-face - vc-annotate-background)) + (cond + (vc-annotate-background + (set-face-foreground tmp-face (cdr color)) + (set-face-background tmp-face vc-annotate-background)) + (vc-annotate-foreground + (set-face-foreground tmp-face vc-annotate-foreground) + (set-face-background tmp-face (cdr color))) + (t + (set-face-foreground tmp-face (cdr color)))) tmp-face)))) ; Return the face (put-text-property start end 'face face))))) ;; Pretend to font-lock there were no matches. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 01 20:18:21 2014 Received: (at 17808) by debbugs.gnu.org; 2 Jul 2014 00:18:21 +0000 Received: from localhost ([127.0.0.1]:39704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X28Ff-00048e-Q9 for submit@debbugs.gnu.org; Tue, 01 Jul 2014 20:18:21 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:58344 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X28Fc-00048S-4B for 17808@debbugs.gnu.org; Tue, 01 Jul 2014 20:18:17 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id DE77B348328E39 for <17808@debbugs.gnu.org>; Tue, 1 Jul 2014 17:18:13 -0700 (PDT) From: Juri Linkov To: 17808@debbugs.gnu.org Subject: Re: bug#17808: 24.4.50; vc-annotate colors Organization: JURTA References: <87bntpl77v.fsf@mail.jurta.org> Date: Wed, 02 Jul 2014 02:18:27 +0300 In-Reply-To: <87bntpl77v.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 19 Jun 2014 09:54:44 +0300") Message-ID: <87vbrg8vvo.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Currently vc-annotate uses dark background even when the default background > is light. Would be nicer to have another option similar to the existing > `vc-annotate-background' that will define the default foreground > (instead of the default background) and put colors from color-map > on the background instead of the foreground: [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 17808 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Currently vc-annotate uses dark background even when the default background > is light. Would be nicer to have another option similar to the existing > `vc-annotate-background' that will define the default foreground > (instead of the default background) and put colors from color-map > on the background instead of the foreground: [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] > Currently vc-annotate uses dark background even when the default background > is light. Would be nicer to have another option similar to the existing > `vc-annotate-background' that will define the default foreground > (instead of the default background) and put colors from color-map > on the background instead of the foreground: Actually much cleaner would be to add a dedicated user option that will define whether to apply the color map to the background or to the foreground. When applied to the background with the default light background, colors need to be less saturated, so the saturation is decreased from 75% to 20% for light backgrounds. Also `vc-annotate-background' doesn't need the default value "black" because the background will be dark on dark environments anyway. === modified file 'lisp/vc/vc-annotate.el' --- lisp/vc/vc-annotate.el 2014-02-10 01:34:22 +0000 +++ lisp/vc/vc-annotate.el 2014-07-01 23:17:33 +0000 @@ -40,6 +40,22 @@ (defcustom vc-annotate-display-mode 'ful :value "20.5")) :group 'vc) +(defcustom vc-annotate-background-mode + (not (or (eq (or frame-background-mode + (frame-parameter nil 'background-mode)) 'dark) + (and (tty-display-color-p) (<= (display-color-cells) 8)))) + "Non-nil means `vc-annotate-color-map' is applied to the background. + +When non-nil, the color range from `vc-annotate-color-map' is applied +to the background, while the foreground remains default. + +When nil, the color range from `vc-annotate-color-map' is applied +to the foreground, and the color from the option `vc-annotate-background' +is applied to the background." + :type 'boolean + :version "24.5" + :group 'vc) + (defcustom vc-annotate-color-map (if (and (tty-display-color-p) (<= (display-color-cells) 8)) ;; A custom sorted TTY colormap @@ -71,25 +87,49 @@ (defcustom vc-annotate-color-map (prog1 (cons date x) (setq date (+ date delta)))) colors)) - ;; Normal colormap: hue stepped from 0-240deg, value=1., saturation=0.75 - '(( 20. . "#FF3F3F") - ( 40. . "#FF6C3F") - ( 60. . "#FF993F") - ( 80. . "#FFC63F") - (100. . "#FFF33F") - (120. . "#DDFF3F") - (140. . "#B0FF3F") - (160. . "#83FF3F") - (180. . "#56FF3F") - (200. . "#3FFF56") - (220. . "#3FFF83") - (240. . "#3FFFB0") - (260. . "#3FFFDD") - (280. . "#3FF3FF") - (300. . "#3FC6FF") - (320. . "#3F99FF") - (340. . "#3F6CFF") - (360. . "#3F3FFF"))) + (cond + ;; Normal colormap for background colors with dark foreground: + ;; hue stepped from 0-240deg, value=1., saturation=0.20 + (vc-annotate-background-mode + '(( 20. . "#FFCCCC") + ( 40. . "#FFD8CC") + ( 60. . "#FFE4CC") + ( 80. . "#FFF0CC") + (100. . "#FFFCCC") + (120. . "#F6FFCC") + (140. . "#EAFFCC") + (160. . "#DEFFCC") + (180. . "#D2FFCC") + (200. . "#CCFFD2") + (220. . "#CCFFDE") + (240. . "#CCFFEA") + (260. . "#CCFFF6") + (280. . "#CCFCFF") + (300. . "#CCF0FF") + (320. . "#CCE4FF") + (340. . "#CCD8FF") + (360. . "#CCCCFF"))) + ;; Normal colormap for foreground colors on dark background: + ;; hue stepped from 0-240deg, value=1., saturation=0.75 + (t + '(( 20. . "#FF3F3F") + ( 40. . "#FF6C3F") + ( 60. . "#FF993F") + ( 80. . "#FFC63F") + (100. . "#FFF33F") + (120. . "#DDFF3F") + (140. . "#B0FF3F") + (160. . "#83FF3F") + (180. . "#56FF3F") + (200. . "#3FFF56") + (220. . "#3FFF83") + (240. . "#3FFFB0") + (260. . "#3FFFDD") + (280. . "#3FF3FF") + (300. . "#3FC6FF") + (320. . "#3F99FF") + (340. . "#3F6CFF") + (360. . "#3F3FFF"))))) "Association list of age versus color, for \\[vc-annotate]. Ages are given in units of fractional days. Default is eighteen steps using a twenty day increment, from red to blue. For TTY @@ -98,12 +138,12 @@ (defcustom vc-annotate-color-map :type 'alist :group 'vc) -(defcustom vc-annotate-very-old-color "#3F3FFF" +(defcustom vc-annotate-very-old-color (if vc-annotate-background-mode "#CCCCFF" "#3F3FFF") "Color for lines older than the current color range in \\[vc-annotate]." :type 'string :group 'vc) -(defcustom vc-annotate-background "black" +(defcustom vc-annotate-background nil "Background color for \\[vc-annotate]. Default color is used if nil." :type '(choice (const :tag "Default background" nil) (color)) @@ -347,7 +387,9 @@ (defun vc-annotate (file rev &optional d `vc-annotate-menu-elements' customizes the menu elements of the mode-specific menu. `vc-annotate-color-map' and `vc-annotate-very-old-color' define the mapping of time to colors. -`vc-annotate-background' specifies the background color." +`vc-annotate-background' specifies the background color. +`vc-annotate-background-mode' specifies whether the color map +should be applied to the background or foreground." (interactive (save-current-buffer (vc-ensure-vc-buffer) @@ -666,10 +708,13 @@ (defun vc-annotate-lines (limit) ;; Make the face if not done. (face (or (intern-soft face-name) (let ((tmp-face (make-face (intern face-name)))) - (set-face-foreground tmp-face (cdr color)) - (when vc-annotate-background - (set-face-background tmp-face - vc-annotate-background)) + (cond + (vc-annotate-background-mode + (set-face-background tmp-face (cdr color))) + (t + (set-face-foreground tmp-face (cdr color)) + (when vc-annotate-background + (set-face-background tmp-face vc-annotate-background)))) tmp-face)))) ; Return the face (put-text-property start end 'face face))))) ;; Pretend to font-lock there were no matches. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 01 22:48:06 2014 Received: (at 17808) by debbugs.gnu.org; 2 Jul 2014 02:48:06 +0000 Received: from localhost ([127.0.0.1]:39775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2Aab-0000kd-HY for submit@debbugs.gnu.org; Tue, 01 Jul 2014 22:48:06 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:46075) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2AaW-0000k2-S6 for 17808@debbugs.gnu.org; Tue, 01 Jul 2014 22:48:02 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N8200C00CCBUT00@a-mtaout20.012.net.il> for 17808@debbugs.gnu.org; Wed, 02 Jul 2014 05:47:53 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8200C9PD3TX720@a-mtaout20.012.net.il>; Wed, 02 Jul 2014 05:47:53 +0300 (IDT) Date: Wed, 02 Jul 2014 05:47:51 +0300 From: Eli Zaretskii Subject: Re: bug#17808: 24.4.50; vc-annotate colors In-reply-to: <87vbrg8vvo.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <8361jg4gtk.fsf@gnu.org> References: <87bntpl77v.fsf@mail.jurta.org> <87vbrg8vvo.fsf@mail.jurta.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17808 Cc: 17808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Juri Linkov > Date: Wed, 02 Jul 2014 02:18:27 +0300 > > > Currently vc-annotate uses dark background even when the default background > > is light. Would be nicer to have another option similar to the existing > > `vc-annotate-background' that will define the default foreground > > (instead of the default background) and put colors from color-map > > on the background instead of the foreground: > > Actually much cleaner would be to add a dedicated user option > that will define whether to apply the color map to the background > or to the foreground. When applied to the background with the > default light background, colors need to be less saturated, > so the saturation is decreased from 75% to 20% for light backgrounds. > Also `vc-annotate-background' doesn't need the default value "black" > because the background will be dark on dark environments anyway. Did anyone think of just using the current default background color? If not, why not? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 02 20:21:38 2014 Received: (at 17808) by debbugs.gnu.org; 3 Jul 2014 00:21:38 +0000 Received: from localhost ([127.0.0.1]:40871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2UmO-0003JJ-D8 for submit@debbugs.gnu.org; Wed, 02 Jul 2014 20:21:37 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:38954 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X2UmM-0003J7-Os for 17808@debbugs.gnu.org; Wed, 02 Jul 2014 20:21:35 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id BDA4A30A1CBAA9; Wed, 2 Jul 2014 17:21:32 -0700 (PDT) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#17808: 24.4.50; vc-annotate colors Organization: JURTA References: <87bntpl77v.fsf@mail.jurta.org> <87vbrg8vvo.fsf@mail.jurta.org> <8361jg4gtk.fsf@gnu.org> Date: Thu, 03 Jul 2014 02:31:03 +0300 In-Reply-To: <8361jg4gtk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Jul 2014 05:47:51 +0300") Message-ID: <87tx6zwdnk.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> > Currently vc-annotate uses dark background even when the default >> > background is light. Would be nicer to have another option similar >> > to the existing `vc-annotate-background' that will define the >> > default foreground (instead of the default background) and put >> > colors from color-map on the background instead of the foreground: >> >> Actually much cleaner would be to add a dedicated user option >> that will define whether to apply the color map to the background >> or to the foreground. When applied to the background with the >> default light background, colors need to be less saturated, >> so the saturation is decreased from 75% to 20% for light backgrounds. >> Also `vc-annotate-background' doesn't need the default value "black" >> because the background will be dark on dark environments anyway. > > Did anyone think of just using the current default background color? > If not, why not? [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17808 Cc: 17808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> > Currently vc-annotate uses dark background even when the default >> > background is light. Would be nicer to have another option similar >> > to the existing `vc-annotate-background' that will define the >> > default foreground (instead of the default background) and put >> > colors from color-map on the background instead of the foreground: >> >> Actually much cleaner would be to add a dedicated user option >> that will define whether to apply the color map to the background >> or to the foreground. When applied to the background with the >> default light background, colors need to be less saturated, >> so the saturation is decreased from 75% to 20% for light backgrounds. >> Also `vc-annotate-background' doesn't need the default value "black" >> because the background will be dark on dark environments anyway. > > Did anyone think of just using the current default background color? > If not, why not? [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> > Currently vc-annotate uses dark background even when the default >> > background is light. Would be nicer to have another option similar >> > to the existing `vc-annotate-background' that will define the >> > default foreground (instead of the default background) and put >> > colors from color-map on the background instead of the foreground: >> >> Actually much cleaner would be to add a dedicated user option >> that will define whether to apply the color map to the background >> or to the foreground. When applied to the background with the >> default light background, colors need to be less saturated, >> so the saturation is decreased from 75% to 20% for light backgrounds. >> Also `vc-annotate-background' doesn't need the default value "black" >> because the background will be dark on dark environments anyway. > > Did anyone think of just using the current default background color? > If not, why not? Some colors from the current `vc-annotate-color-map' are illegible when used for a foreground on a light background (white by default). But the last patch provides a palette where color saturation is reduced from 75% to 20%, so the output looks nicely for light backgrounds where related lines are grouped using the same backgrounds like in the table from this post :-) https://plus.google.com/+BrunoOliveira/posts/1mnVJcJqzVD From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 04 19:52:32 2014 Received: (at 17808) by debbugs.gnu.org; 4 Jul 2014 23:52:32 +0000 Received: from localhost ([127.0.0.1]:43222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3DHL-0000wf-FX for submit@debbugs.gnu.org; Fri, 04 Jul 2014 19:52:31 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:57317 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3DHJ-0000wW-Sx for 17808@debbugs.gnu.org; Fri, 04 Jul 2014 19:52:30 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 6D7B030A17C3BB; Fri, 4 Jul 2014 16:52:28 -0700 (PDT) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#17808: 24.4.50; vc-annotate colors Organization: JURTA References: <87bntpl77v.fsf@mail.jurta.org> <87vbrg8vvo.fsf@mail.jurta.org> <8361jg4gtk.fsf@gnu.org> <87tx6zwdnk.fsf@mail.jurta.org> Date: Sat, 05 Jul 2014 02:48:35 +0300 In-Reply-To: <87tx6zwdnk.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 03 Jul 2014 02:31:03 +0300") Message-ID: <87oax4vg6k.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > But the last patch provides a palette where color saturation > is reduced from 75% to 20%, so the output looks nicely > for light backgrounds where related lines are grouped > using the same backgrounds like in the table from this post :-) > > https://plus.google.com/+BrunoOliveira/posts/1mnVJcJqzVD [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17808 Cc: 17808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > But the last patch provides a palette where color saturation > is reduced from 75% to 20%, so the output looks nicely > for light backgrounds where related lines are grouped > using the same backgrounds like in the table from this post :-) > > https://plus.google.com/+BrunoOliveira/posts/1mnVJcJqzVD [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] > But the last patch provides a palette where color saturation > is reduced from 75% to 20%, so the output looks nicely > for light backgrounds where related lines are grouped > using the same backgrounds like in the table from this post :-) > > https://plus.google.com/+BrunoOliveira/posts/1mnVJcJqzVD To reduce saturation from 75% to 20% it was helpful to use the function `color-hsv-to-rgb' that I found in the list archives. There are several proposed versions: http://lists.gnu.org/archive/html/emacs-devel/2010-11/msg00897.html http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg00738.html http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14074 http://lists.gnu.org/archive/html/emacs-devel/2014-01/msg01272.html It seems that the latest produces the most exact results. I wounder why this useful function still is not installed in color.el? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 08 04:52:38 2014 Received: (at 17808-done) by debbugs.gnu.org; 8 Jul 2014 08:52:38 +0000 Received: from localhost ([127.0.0.1]:46533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4R8f-0001mn-Gc for submit@debbugs.gnu.org; Tue, 08 Jul 2014 04:52:37 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:47349 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4R8c-0001mc-Gw for 17808-done@debbugs.gnu.org; Tue, 08 Jul 2014 04:52:35 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 222573475EAD08 for <17808-done@debbugs.gnu.org>; Tue, 8 Jul 2014 01:52:32 -0700 (PDT) From: Juri Linkov To: 17808-done@debbugs.gnu.org Subject: Re: bug#17808: 24.4.50; vc-annotate colors Organization: JURTA References: <87bntpl77v.fsf@mail.jurta.org> <87vbrg8vvo.fsf@mail.jurta.org> <8361jg4gtk.fsf@gnu.org> <87tx6zwdnk.fsf@mail.jurta.org> <87oax4vg6k.fsf@mail.jurta.org> Date: Tue, 08 Jul 2014 11:51:43 +0300 In-Reply-To: <87oax4vg6k.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 05 Jul 2014 02:48:35 +0300") Message-ID: <8761j844io.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Version: 24.4.50 > To reduce saturation from 75% to 20% it was helpful to use > the function `color-hsv-to-rgb' that I found in the list archives. Installed in the trunk. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 17808-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Version: 24.4.50 > To reduce saturation from 75% to 20% it was helpful to use > the function `color-hsv-to-rgb' that I found in the list archives. Installed in the trunk. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] Version: 24.4.50 > To reduce saturation from 75% to 20% it was helpful to use > the function `color-hsv-to-rgb' that I found in the list archives. Installed in the trunk. PS: this code shows how `color-hsv-to-rgb' could be used to reduce saturation: (pp (mapcar (lambda (pair) (cons (car pair) (let ((hsv (apply 'color-rgb-to-hsv (color-name-to-rgb (cdr pair))))) (apply 'color-rgb-to-hex (color-hsv-to-rgb (nth 0 hsv) 0.20 (nth 2 hsv)))))) '(( 20. . "#FF3F3F") ( 40. . "#FF6C3F") ( 60. . "#FF993F") ( 80. . "#FFC63F") (100. . "#FFF33F") (120. . "#DDFF3F") (140. . "#B0FF3F") (160. . "#83FF3F") (180. . "#56FF3F") (200. . "#3FFF56") (220. . "#3FFF83") (240. . "#3FFFB0") (260. . "#3FFFDD") (280. . "#3FF3FF") (300. . "#3FC6FF") (320. . "#3F99FF") (340. . "#3F6CFF") (360. . "#3F3FFF")))) From unknown Thu Jun 19 14:29:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 05 Aug 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator