From unknown Sun Jun 22 07:51:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17798: [PATCH] build: don't make output files read-only Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Tue, 17 Jun 2014 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17798 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: 17798@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140303197720808 (code B ref -1); Tue, 17 Jun 2014 19:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Jun 2014 19:06:17 +0000 Received: from localhost ([127.0.0.1]:50881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwyi0-0005PX-Ev for submit@debbugs.gnu.org; Tue, 17 Jun 2014 15:06:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50007) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwyhw-0005PE-J0 for submit@debbugs.gnu.org; Tue, 17 Jun 2014 15:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwyhl-0002Wr-Gc for submit@debbugs.gnu.org; Tue, 17 Jun 2014 15:06:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwyhl-0002Wn-Ef for submit@debbugs.gnu.org; Tue, 17 Jun 2014 15:06:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwyhg-0007sf-CT for bug-grep@gnu.org; Tue, 17 Jun 2014 15:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwyha-0002W4-SK for bug-grep@gnu.org; Tue, 17 Jun 2014 15:05:55 -0400 Received: from kiwi.cs.ucla.edu ([131.179.128.19]:40964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwyha-0002Vz-Kt for bug-grep@gnu.org; Tue, 17 Jun 2014 15:05:50 -0400 Received: from kiwi.cs.ucla.edu (localhost.cs.ucla.edu [127.0.0.1]) by kiwi.cs.ucla.edu (8.14.5+Sun/8.14.5/UCLACS-6.0) with ESMTP id s5HJ5nPB026622 for ; Tue, 17 Jun 2014 12:05:49 -0700 (PDT) Received: (from eggert@localhost) by kiwi.cs.ucla.edu (8.14.5+Sun/8.14.5/Submit) id s5HJ5mdY026621 for bug-grep@gnu.org; Tue, 17 Jun 2014 12:05:48 -0700 (PDT) Message-Id: <201406171905.s5HJ5mdY026621@kiwi.cs.ucla.edu> From: Paul Eggert Date: Tue, 17 Jun 2014 12:02:01 -0700 X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This led to problems, such as the prompt "mv: try to overwrite 'egrep', overriding mode 0555 (r-xr-xr-x)? " during a build. It can be worked around, but the cure is worse than the disease; making output files read-only is more trouble than it's worth. * doc/Makefile.am (grep.1, egrep.1, fgrep.1): * lib/Makefile.am (colorize.c): * src/Makefile.am (egrep fgrep): Don't make output files read-only. Prefer separate commands to '&&' when either will do. --- doc/Makefile.am | 11 +++++------ lib/Makefile.am | 2 -- src/Makefile.am | 5 ++--- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 810e916..9a50434 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -25,11 +25,10 @@ EXTRA_DIST = grep.in.1 CLEANFILES = grep.1 egrep.1 fgrep.1 grep.1: grep.in.1 - $(AM_V_GEN)rm -f $@ $@-t - $(AM_V_at)sed 's/@''VERSION@/$(VERSION)/' \ - < $(srcdir)/grep.in.1 > $@-t && chmod 444 $@-t && mv $@-t $@ + $(AM_V_GEN)sed 's/@''VERSION@/$(VERSION)/' < $(srcdir)/grep.in.1 > $@-t + $(AM_V_at)mv $@-t $@ egrep.1 fgrep.1: Makefile.am - $(AM_V_GEN)rm -f $@ $@-t - $(AM_V_at)inst=`echo grep | sed '$(transform)'`.1 \ - && echo ".so man1/$$inst" > $@-t && chmod 444 $@-t && mv $@-t $@ + $(AM_V_GEN)inst=`echo grep | sed '$(transform)'`.1 \ + && echo ".so man1/$$inst" > $@-t + $(AM_V_at)mv $@-t $@ diff --git a/lib/Makefile.am b/lib/Makefile.am index 9bd7b0d..79d582b 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -34,9 +34,7 @@ libgreputils_a_SOURCES += colorize.h EXTRA_DIST += colorize-posix.c colorize-w32.c CLEANFILES += colorize.c colorize.c: - $(AM_V_GEN)rm -f $@-t $(AM_V_at)echo '#include <$(COLORIZE_SOURCE)>' >$@-t - $(AM_V_at)chmod a=rx $@-t $(AM_V_at)mv $@-t $@ libgreputils_a_LIBADD += $(LIBOBJS) $(ALLOCA) diff --git a/src/Makefile.am b/src/Makefile.am index 0697c63..11acdb1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -45,8 +45,7 @@ AM_CPPFLAGS = -I$(top_builddir)/lib -I$(top_srcdir)/lib EXTRA_DIST = dosbuf.c egrep.sh egrep fgrep: egrep.sh Makefile - $(AM_V_GEN)rm -f $@-t - $(AM_V_at)grep=`echo grep | sed -e '$(transform)'` && \ + $(AM_V_GEN)grep=`echo grep | sed -e '$(transform)'` && \ case $@ in egrep) option=-E;; fgrep) option=-F;; esac && \ shell_does_substrings='set x/y && d=$${1%/*} && test "$$d" = x' && \ if $(SHELL) -c "$$shell_does_substrings" 2>/dev/null; then \ @@ -58,7 +57,7 @@ egrep fgrep: egrep.sh Makefile -e "$$edit_substring" \ -e "s|[@]grep@|$$grep|g" \ -e "s|[@]option@|$$option|g" <$(srcdir)/egrep.sh >$@-t - $(AM_V_at)chmod a=rx $@-t + $(AM_V_at)chmod +x $@-t $(AM_V_at)mv $@-t $@ CLEANFILES = egrep fgrep *-t -- 1.9.3 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 15:22:48 2014 Received: (at control) by debbugs.gnu.org; 17 Jun 2014 19:22:48 +0000 Received: from localhost ([127.0.0.1]:50891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwyy0-0005of-HD for submit@debbugs.gnu.org; Tue, 17 Jun 2014 15:22:48 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:51401) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwyxy-0005oO-Kf for control@debbugs.gnu.org; Tue, 17 Jun 2014 15:22:47 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 93B3C39E8008 for ; Tue, 17 Jun 2014 12:22:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IHRmKSsovFlG for ; Tue, 17 Jun 2014 12:22:32 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id ECADB39E8012 for ; Tue, 17 Jun 2014 12:22:31 -0700 (PDT) Message-ID: <53A09577.3030803@cs.ucla.edu> Date: Tue, 17 Jun 2014 12:22:31 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: 17798 is done Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 17798