GNU bug report logs -
#17793
Gentoo gcc 4.8.3 build problem: -fstack-protector [also, Re: bug#17754]
Previous Next
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#17793: Gentoo gcc 4.8.3 build problem: -fstack-protector [also, Re: bug#17754]
which was filed against the grep package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 17793 <at> debbugs.gnu.org.
--
17793: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17793
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
[Message part 3 (text/plain, inline)]
behoffski wrote:
> In file included from mbsstr.c:32:0:
> str-kmp.h: In function 'knuth_morris_pratt':
> str-kmp.h:35:1: error: stack protector not protecting local
> variables: variable length buffer [-Werror=stack-protector]
> knuth_morris_pratt (const UNIT *haystack,
> ^
These warnings don't indicate any bugs in the code; they're merely about
incomplete run-time checking in the underlying implementation. I was
particularly amused by a refusal to compile a function on the grounds
that its code doesn't use the stack!
So let's just disable the warnings. I pushed the attached patch.
> Valgrind and -fsanitize=address are incompatible
Thanks, I didn't know that. Too bad, but understandable. Neither tool
dominates the other, so I guess we'll have to use them separately.
[0001-build-avoid-Wstack-protector.patch (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
G'day,
[Re: bug#17754: There is a bugfix in 4.8.3 regarding code flow analysis
that covers the reported case. Now that Gentoo has added gcc 4.8.3 to
its package database, I've rebuilt, and the compiler now correctly
detects that the variable will always be initialised before it is used.
The unwanted behaviour in gcc 4.8.2 was part of the new "-Og" feature.]
----
New potential portability problem: When Gentoo released their
repackaged gcc 4.8.3 (in the last 48 hours or so), they also released a
warning NEWS item regarding gcc 4.8.3 defaulting to -fstack-protector,
and gcc 4.9 onwards defaulting to -fstack-protector-strong:
2014-06-15-gcc48_ssp
Title GCC 4.8.3 defaults to -fstack-protector
Author Ryan Hill <rhill <at> gentoo.org>
Posted 2014-06-15
Revision 1
Beginning with GCC 4.8.3, Stack Smashing Protection (SSP) will be
enabled by default. The 4.8 series will enable -fstack-protector
while 4.9 and later enable -fstack-protector-strong. [...]
[...] these features [...] can be disabled with -fno-stack-protector.
I've just installed gcc 4.8.3, and have found that the -fstack-protector
feature results in a compilation error in lib/mbsstr.c:
In file included from mbsstr.c:32:0:
str-kmp.h: In function 'knuth_morris_pratt':
str-kmp.h:35:1: error: stack protector not protecting local variables: variable length buffer [-Werror=stack-protector]
knuth_morris_pratt (const UNIT *haystack,
^
mbsstr.c: In function 'knuth_morris_pratt_multibyte':
mbsstr.c:40:1: error: stack protector not protecting local variables: variable length buffer [-Werror=stack-protector]
knuth_morris_pratt_multibyte (const char *haystack, const char *needle,
^
cc1: all warnings being treated as errors
Re-running './configure CFLAGS="-Og -fsanitize=address -fno-stack-protector"
results in a clean build, and "make check" passes.
On a slightly-related note, Valgrind and -fsanitize=address are incompatible
(overlapping memory space usage). Configuring with
"CFLAGS=-Og -fno-stack-protector" (no "-fsanitize=address") lets "make check"
run successfully with Jim's Valgrind scripts referencing built images in
grep/src/.vg-tmp/.
cheers,
behoffski (Brenton Hoff)
Programmer, Grouse Software
This bug report was last modified 11 years and 34 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.