From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 14 07:27:27 2014 Received: (at submit) by debbugs.gnu.org; 14 Jun 2014 11:27:27 +0000 Received: from localhost ([127.0.0.1]:47223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvm7K-0000oT-Mo for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41201) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvm7I-0000oC-09 for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wvm77-00032j-Mv for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvm77-00032d-JV for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvm72-0000VJ-Ju for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 07:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wvm6x-00031d-QH for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 07:27:08 -0400 Received: from byebi.wara.tw ([128.199.200.93]:39536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvm6x-0002U1-Ec for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 07:27:03 -0400 Received: from 114-32-24-38.hinet-ip.hinet.net ([114.32.24.38] helo=isil.kanru.info) by byebi.wara.tw with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Wvm5R-0006Pq-53 for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 19:25:29 +0800 Received: from hgw ([127.0.0.1] helo=isil.kanru.info) by isil.kanru.info with esmtp (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1Wvm7G-0000xI-8L for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 19:27:22 +0800 From: =?utf-8?B?S2FuLVJ1IENoZW4gKOmZs+S+g+Wmgik=?= To: bug-gnu-emacs@gnu.org Subject: 24.4.50; rcirc-omit-mode should only call `recenter' if `current-buffer' is equal to `window-buffer' Date: Sat, 14 Jun 2014 19:27:22 +0800 Message-ID: <87lhszbujp.fsf@isil.kanru.info> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Step to reproduce: (add-hook 'rcirc-mode-hook 'rcirc-omit-mode) When rcirc trys auto-connect to channels, emacs will show (error "`recenter'ing a window that does not display current-buffer.") Patch attached In GNU Emacs 24.4.50.6 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2014-06-14 on isil Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Debian GNU/Linux unstable (sid) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-net-rcirc.el-Only-call-recenter-if-current-buffer-is.patch >From 901b38e1f17def0b4ee64f78f54d04e3295eb6db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kan-Ru=20Chen=20=28=E9=99=B3=E4=BE=83=E5=A6=82=29?= Date: Sat, 14 Jun 2014 19:21:00 +0800 Subject: [PATCH] net/rcirc.el: Only call `recenter' if `current-buffer' is equal to `window-buffer' --- lisp/ChangeLog | 5 +++++ lisp/net/rcirc.el | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 1df12d4..8317393 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2014-06-14 Kan-Ru Chen + + * net/rcirc.el (rcirc-omit-mode): Only call `recenter' if + `current-buffer' is equal to `window-buffer'. + 2014-06-13 Glenn Morris * Makefile.in ($(lisp)/cus-load.el, $(lisp)/finder-inf.el) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..1e3ee32 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1903,7 +1903,9 @@ Uninteresting lines are those whose responses are listed in (message "Rcirc-Omit mode enabled")) (remove-from-invisibility-spec '(rcirc-omit . nil)) (message "Rcirc-Omit mode disabled")) - (recenter (when (> (point) rcirc-prompt-start-marker) -1))) + (when (and (eq (current-buffer) (window-buffer)) + (> (point) rcirc-prompt-start-marker)) + (recenter -1))) (defun rcirc-switch-to-server-buffer () "Switch to the server buffer associated with current channel buffer." -- 2.0.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 14 08:50:32 2014 Received: (at 17778) by debbugs.gnu.org; 14 Jun 2014 12:50:32 +0000 Received: from localhost ([127.0.0.1]:47263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvnPj-0005ml-Io for submit@debbugs.gnu.org; Sat, 14 Jun 2014 08:50:31 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:45752) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvnPe-0005mR-UM for 17778@debbugs.gnu.org; Sat, 14 Jun 2014 08:50:27 -0400 Received: by mail-pb0-f47.google.com with SMTP id un15so2974297pbc.20 for <17778@debbugs.gnu.org>; Sat, 14 Jun 2014 05:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=vlTDe/KA24W8JwcrkrxxwBjE3DFjE/jANOoT8LdmGhY=; b=iV4H3QTFtz8MrDkryYh2jJM8VznuRYg0UFyWZdUezfPp6rbGqnf3n9NdR62RykgnW9 507X04A8THU8n8yeCap4M4yWKdS2qunQ/Sh9qUSgml7NPquiKos9rhI17iyvKFgWgeQU ZSsxqgnEW03r+93oi3axxFOH6hmqL2rN4rYg0GnKGiGBSi/9X8IpuwqVbUGpW5f6P1in X85ajCisePggixil5P15oP/bL7jFKrI+Jh7JwdceUZj2YmgNL8oojA3v/uVAEq1W6Y6r +ALaF/YU0AaiCKyyanl+rtt39ZtE3Hoapux5nBtiu6iS4KB77yY+iEQXN1JdUlz5gJY3 vuDA== X-Received: by 10.66.102.102 with SMTP id fn6mr10909415pab.6.1402750220645; Sat, 14 Jun 2014 05:50:20 -0700 (PDT) Received: from localhost (i118-21-141-133.s30.a048.ap.plala.or.jp. [118.21.141.133]) by mx.google.com with ESMTPSA id ir10sm8749867pbc.59.2014.06.14.05.50.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Jun 2014 05:50:19 -0700 (PDT) From: Daimrod To: Kan-Ru Chen (=?utf-8?B?6Zmz5L6D5aaC?=) Subject: Re: bug#17778: 24.4.50; rcirc-omit-mode should only call `recenter' if `current-buffer' is equal to `window-buffer' References: <87lhszbujp.fsf@isil.kanru.info> Date: Sat, 14 Jun 2014 21:50:16 +0900 In-Reply-To: <87lhszbujp.fsf@isil.kanru.info> ("Kan-Ru Chen =?utf-8?B?KA==?= =?utf-8?B?6Zmz5L6D5aaCKSIncw==?= message of "Sat, 14 Jun 2014 19:27:22 +0800") Message-ID: <87sin78xkn.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17778 Cc: 17778@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Kan-Ru Chen (=E9=99=B3=E4=BE=83=E5=A6=82) writes: > Step to reproduce: > > (add-hook 'rcirc-mode-hook 'rcirc-omit-mode) > > When rcirc trys auto-connect to channels, emacs will show > > (error "`recenter'ing a window that does not display current-buffer.") I've reported this issue yesterday, see bug#17769. Best, --=20 Daimrod/Greg From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 14 09:18:54 2014 Received: (at control) by debbugs.gnu.org; 14 Jun 2014 13:18:55 +0000 Received: from localhost ([127.0.0.1]:47283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvnrC-0006fJ-D0 for submit@debbugs.gnu.org; Sat, 14 Jun 2014 09:18:54 -0400 Received: from byebi.wara.tw ([128.199.200.93]:47800) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvnr9-0006f7-W4 for control@debbugs.gnu.org; Sat, 14 Jun 2014 09:18:52 -0400 Received: from 114-32-24-38.hinet-ip.hinet.net ([114.32.24.38] helo=isil.kanru.info) by byebi.wara.tw with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Wvnr7-0006Tl-68 for control@debbugs.gnu.org; Sat, 14 Jun 2014 21:18:49 +0800 Received: from kanru by isil.kanru.info with local (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1Wvnsw-0001Si-4x for control@debbugs.gnu.org; Sat, 14 Jun 2014 21:20:42 +0800 From: Kan-Ru Chen =?UTF-8?Q?(=E9=99=B3=E4=BE=83=E5=A6=82)?= To: control@debbugs.gnu.org Subject: merging 17769 17778 Date: Sat, 14 Jun 2014 21:20:42 +0800 User-Agent: devscripts bts/2.14.5 Message-ID: <1402752042-37-bts-kanru@kanru.info> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) merge 17769 17778 thanks From unknown Mon Aug 18 18:01:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Jul 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator