From unknown Tue Aug 12 08:32:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17772: [PATCH] Dangling channels' buffer Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 17772@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140265614312090 (code B ref -1); Fri, 13 Jun 2014 10:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2014 10:42:23 +0000 Received: from localhost ([127.0.0.1]:46224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvOwA-00038u-3M for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57865) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvOw5-00038U-3i for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvOvy-00057k-Ru for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvOvy-00057d-PR for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvOvx-0006LB-SD for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 06:42:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvOvx-00056u-0c for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 06:42:09 -0400 Received: from mail-pb0-x234.google.com ([2607:f8b0:400e:c01::234]:45575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvOvw-00056U-On for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 06:42:08 -0400 Received: by mail-pb0-f52.google.com with SMTP id rr13so2050749pbb.25 for ; Fri, 13 Jun 2014 03:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=UejLSBeXJcyAbVhd5wyGY0LLG0PkYqq2wRhRW9DGVlE=; b=txrpjvbP6pMa3aV5YqDixi3SK7mksClTCvtahsqMJaLKn2sdZ8jPkcPJxj1P8A5UCJ gg83OCbdLktDwtEXfpU0uTbtPcdU9EajTISWtLGTlU2KkoS0RWmndvlqAXcy3JgWCDUh y0eY13l1RnlFhWTGcge41IlPOAOlJP1hb47pbb2G9sUAFQ9gjMv7OsQFgvj8wpA/l4sK WwOjRdM83+rg46rcQz46FiBHrhxBWh30eGp9TFnM4jPxvW0pn2Uz/ATVsdGG35mRuoY+ JpeQRVo5IEbBtrl7ZloGHv/vGic0RIpd/AmMmNCzQVAmrzP7YIokKe8zQ3+8oxr7tEf7 s0hw== X-Received: by 10.66.190.167 with SMTP id gr7mr2072499pac.75.1402656127307; Fri, 13 Jun 2014 03:42:07 -0700 (PDT) Received: from localhost ([2001:2f8:200:1:e206:e6ff:fecb:5a]) by mx.google.com with ESMTPSA id yv7sm19498744pac.33.2014.06.13.03.42.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 03:42:06 -0700 (PDT) From: Daimrod Date: Fri, 13 Jun 2014 19:41:55 +0900 Message-ID: <87k38lay6k.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, In the attached patch, I propose a fix for the recent change of the function `rcirc-buffer-process'. This function used to return the rcirc server process when it existed, or nil. However, since a78d87e7ed it raises an error. This is a problem if the user kills the server buffer before it kills the channels' buffer because it is not possible to kill them after that. (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook' and it calls `rcirc-buffer-process'.) WDYT? Regards, --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-clean-up-buffer-Explicitly-c.patch >From 2ce0be284dc8830c3153d60cb0b01e082ab1c5b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Fri, 13 Jun 2014 18:31:31 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-clean-up-buffer): Explicitly check for the `rcirc-server-buffer' Since a78d87e7ed, `rcirc-buffer-process' raises an error instead of returning nil when the `rcirc-server-buffer' doesn't exist. Because of this, it was impossible to delete channels' buffer once the `rcirc-server-buffer' has been deleted. --- lisp/net/rcirc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..57a90de 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1158,7 +1158,7 @@ with it." (defun rcirc-clean-up-buffer (reason) (let ((buffer (current-buffer))) (rcirc-clear-activity buffer) - (when (and (rcirc-buffer-process) + (when (and (buffer-live-p rcirc-server-buffer) (rcirc--connection-open-p (rcirc-buffer-process))) (with-rcirc-server-buffer (setq rcirc-buffer-alist -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=-- From unknown Tue Aug 12 08:32:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17772: [PATCH] Dangling channels' buffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daimrod Cc: Ryan Yeske , Leo Liu , 17772@debbugs.gnu.org Received: via spool by 17772-submit@debbugs.gnu.org id=B17772.140268458511958 (code B ref 17772); Fri, 13 Jun 2014 18:37:01 +0000 Received: (at 17772) by debbugs.gnu.org; 13 Jun 2014 18:36:25 +0000 Received: from localhost ([127.0.0.1]:46928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvWKv-00036n-99 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 14:36:25 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:62576) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvWKs-00036T-On for 17772@debbugs.gnu.org; Fri, 13 Jun 2014 14:36:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF4lMhS4HhDgEqRmBaoNMIQ X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF4lMhS4HhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="66800387" Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jun 2014 14:36:16 -0400 Received: by ceviche.home (Postfix, from userid 20848) id B27FD660D3; Fri, 13 Jun 2014 14:36:16 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k38lay6k.fsf@tanger.home> Date: Fri, 13 Jun 2014 14:36:16 -0400 In-Reply-To: <87k38lay6k.fsf@tanger.home> (daimrod@gmail.com's message of "Fri, 13 Jun 2014 19:41:55 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > server process when it existed, or nil. However, since a78d87e7ed it > raises an error. Please avoid using Git references until we actually switch to Git. Use dates, for example, instead. > This is a problem if the user kills the server buffer before it kills > the channels' buffer because it is not possible to kill them after that. > (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook' > and it calls `rcirc-buffer-process'.) Your patch doesn't look bad, but I wonder if a better option wouldn't be to try and better preserve the previous behavior. E.g. with the patch below. WDYT? Stefan === modified file 'lisp/net/rcirc.el' --- lisp/net/rcirc.el 2014-05-12 16:06:13 +0000 +++ lisp/net/rcirc.el 2014-06-13 18:34:01 +0000 @@ -803,9 +804,8 @@ "Return the process associated with channel BUFFER. With no argument or nil as argument, use the current buffer." (let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer) - rcirc-server-buffer - (error "Server buffer deleted"))))) - (or (with-current-buffer buffer rcirc-process) + rcirc-server-buffer)))) + (or (if buffer (with-current-buffer buffer rcirc-process)) rcirc-process))) (defun rcirc-server-name (process) From unknown Tue Aug 12 08:32:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17772: [PATCH] Dangling channels' buffer Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jun 2014 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Ryan Yeske , Leo Liu , 17772@debbugs.gnu.org Received: via spool by 17772-submit@debbugs.gnu.org id=B17772.140270785826310 (code B ref 17772); Sat, 14 Jun 2014 01:05:02 +0000 Received: (at 17772) by debbugs.gnu.org; 14 Jun 2014 01:04:18 +0000 Received: from localhost ([127.0.0.1]:47072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvcOH-0006qI-Pu for submit@debbugs.gnu.org; Fri, 13 Jun 2014 21:04:18 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:65318) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvcOF-0006pv-Cv for 17772@debbugs.gnu.org; Fri, 13 Jun 2014 21:04:16 -0400 Received: by mail-pd0-f181.google.com with SMTP id v10so1717630pde.26 for <17772@debbugs.gnu.org>; Fri, 13 Jun 2014 18:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=uIm3Ees+INYVLM9i3aHGIDwvq2xB6/97aSXffvLpADU=; b=KKIrAGK5UCQe2er/nJIY/h/xmevZmvJpF9TXdRki0e9cjc6JmXl+B/8rRmS6kNvBhh 1aTV9LuUUGAWw2bJepOATfMhBOJNaVQ4MZywbB3GnvfR7FTe04SeNRhRtm5bT/O2O5xf K/SJMNtIlILBM5QjQcQwV5cvKuTZytvB9muOIDPp6dQ0RdsvjEGFPnB1zGUw5Lt7SxsM x2rfrXjeodhka2tlJhKZ0V8fyf1bcA/Yq3fNgmmYm4MTjHs8hbYBugLdn3eUt4tdWIRp BZzMs1iqIXwT1+tIj8To0Y9d2C3D8lt8y7xS+nMeUD/hr1/WmUqiifIn8BeDVAjQ3FJ6 Q3xA== X-Received: by 10.68.173.1 with SMTP id bg1mr7128480pbc.13.1402707849229; Fri, 13 Jun 2014 18:04:09 -0700 (PDT) Received: from localhost (i118-21-141-133.s30.a048.ap.plala.or.jp. [118.21.141.133]) by mx.google.com with ESMTPSA id kn1sm5819947pbd.13.2014.06.13.18.04.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 18:04:08 -0700 (PDT) From: Daimrod References: <87k38lay6k.fsf@tanger.home> Date: Sat, 14 Jun 2014 10:04:04 +0900 In-Reply-To: (Stefan Monnier's message of "Fri, 13 Jun 2014 14:36:16 -0400") Message-ID: <878up0b8u3.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> server process when it existed, or nil. However, since a78d87e7ed it >> raises an error. > > Please avoid using Git references until we actually switch to Git. > Use dates, for example, instead. Ok, I'll keep this in mind. >> This is a problem if the user kills the server buffer before it kills >> the channels' buffer because it is not possible to kill them after that. >> (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook' >> and it calls `rcirc-buffer-process'.) > > Your patch doesn't look bad, but I wonder if a better option wouldn't be > to try and better preserve the previous behavior. E.g. with the > patch below. > > WDYT? Fine for me, but you don't need the `or'. > === modified file 'lisp/net/rcirc.el' > --- lisp/net/rcirc.el 2014-05-12 16:06:13 +0000 > +++ lisp/net/rcirc.el 2014-06-13 18:34:01 +0000 > @@ -803,9 +804,8 @@ > "Return the process associated with channel BUFFER. > With no argument or nil as argument, use the current buffer." > (let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer) > - rcirc-server-buffer > - (error "Server buffer deleted"))))) > - (or (with-current-buffer buffer rcirc-process) > + rcirc-server-buffer)))) + (if buffer + (with-current-buffer buffer rcirc-process) + rcirc-process))) > + (or (if buffer (with-current-buffer buffer rcirc-process)) > rcirc-process))) > > (defun rcirc-server-name (process) > -- Daimrod/Greg From unknown Tue Aug 12 08:32:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17772: [PATCH] Dangling channels' buffer Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jun 2014 01:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Ryan Yeske , Leo Liu , 17772@debbugs.gnu.org Received: via spool by 17772-submit@debbugs.gnu.org id=B17772.140270882128310 (code B ref 17772); Sat, 14 Jun 2014 01:21:01 +0000 Received: (at 17772) by debbugs.gnu.org; 14 Jun 2014 01:20:21 +0000 Received: from localhost ([127.0.0.1]:47076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvcdo-0007MV-Tt for submit@debbugs.gnu.org; Fri, 13 Jun 2014 21:20:21 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:64459) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvcdm-0007MD-5x for 17772@debbugs.gnu.org; Fri, 13 Jun 2014 21:20:19 -0400 Received: by mail-pa0-f52.google.com with SMTP id eu11so2675010pac.11 for <17772@debbugs.gnu.org>; Fri, 13 Jun 2014 18:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=UQ2G3yx7o+5+SjcUdnPJ6nY+UpOsAFBNxSOa1guSzI8=; b=XWCIRqglAQC/3feacRYzAeiglrpSKGxGAvkraEYgfT/prpBQ6bPdDCunFkl0XR8Gfu +umjSxSptOVdxENoJu6fByGp7/EbvEwQK33YU6KS6Jf6rUrF4ZSjAZNPujXFLh8Nd0tP rU8DkKwmbNgSisnxemCC6TJPQ5Bu6QP10fVTF+Ok3pAFg2rAZfIu0lyriYMs0623IWl2 tBSj3oNcJ9zgfS5NBNZ4o0Wq4Zx7aEthgZS99UEldPkVaLoAzFp3//0yASpQzT76NDbq S9GMS/FeX8tXk0j18o3TCsQjreH4bY9Gv84vF4X29pRlEcqU6W8RfcJ4SaVC0cViI5Hl rGdA== X-Received: by 10.68.94.225 with SMTP id df1mr7448915pbb.86.1402708812080; Fri, 13 Jun 2014 18:20:12 -0700 (PDT) Received: from localhost (i118-21-141-133.s30.a048.ap.plala.or.jp. [118.21.141.133]) by mx.google.com with ESMTPSA id iz2sm5825844pbb.95.2014.06.13.18.20.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 18:20:10 -0700 (PDT) From: Daimrod References: <87k38lay6k.fsf@tanger.home> <878up0b8u3.fsf@tanger.home> Date: Sat, 14 Jun 2014 10:20:07 +0900 In-Reply-To: <878up0b8u3.fsf@tanger.home> (daimrod@gmail.com's message of "Sat, 14 Jun 2014 10:04:04 +0900") Message-ID: <874mzob83c.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Daimrod writes: > Stefan Monnier writes: > >>> server process when it existed, or nil. However, since a78d87e7ed it >>> raises an error. >> >> Please avoid using Git references until we actually switch to Git. >> Use dates, for example, instead. > > Ok, I'll keep this in mind. Here is a new patch with your proposal: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-buffer-process-Return-the-pr.patch >From af9d16684d8449cfb006f70c4c2c1fe228e737fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Sat, 14 Jun 2014 10:10:59 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-buffer-process): Return the process associated with the channel, or nil if it doesn't exit. Since 2014-04-09, the current behavior was to raise an error if the process didn't exist. This restore the previous behavior. --- lisp/net/rcirc.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..73a6395 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -803,10 +803,10 @@ Function is called with PROCESS, COMMAND, SENDER, ARGS and LINE.") "Return the process associated with channel BUFFER. With no argument or nil as argument, use the current buffer." (let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer) - rcirc-server-buffer - (error "Server buffer deleted"))))) - (or (with-current-buffer buffer rcirc-process) - rcirc-process))) + rcirc-server-buffer)))) + (if buffer + (with-current-buffer buffer rcirc-process) + rcirc-process))) (defun rcirc-server-name (process) "Return PROCESS server name, given by the 001 response." -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=-- From unknown Tue Aug 12 08:32:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Daimrod Subject: bug#17772: closed (Re: bug#17772: [PATCH] Dangling channels' buffer) Message-ID: References: <87k38lay6k.fsf@tanger.home> X-Gnu-PR-Message: they-closed 17772 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 17772@debbugs.gnu.org Date: Mon, 30 Jun 2014 03:00:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1404097206-18612-1" This is a multi-part message in MIME format... ------------=_1404097206-18612-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17772: [PATCH] Dangling channels' buffer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17772@debbugs.gnu.org. --=20 17772: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17772 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1404097206-18612-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17772-done) by debbugs.gnu.org; 30 Jun 2014 02:59:46 +0000 Received: from localhost ([127.0.0.1]:37296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1Roo-0004pK-49 for submit@debbugs.gnu.org; Sun, 29 Jun 2014 22:59:46 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:55589) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1Rol-0004ow-3T for 17772-done@debbugs.gnu.org; Sun, 29 Jun 2014 22:59:43 -0400 Received: by mail-pa0-f50.google.com with SMTP id bj1so7819620pad.9 for <17772-done@debbugs.gnu.org>; Sun, 29 Jun 2014 19:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=m0x2tTTuP8ffN1rQ84BhafzwPrb112glHJwnGYcIQtk=; b=O0Jx322nEOFRnuaWlRiRKDxvwDtn7lgWwsTdzaBkTzuW28T/Rf/rn59BhAgchbcxSS dAayBWgjCfgBKNxscl+Il4w5oakVGUPGrGQdzuRazBAZcc9csoeLXBkB2DhpldvvGKpH ZR/tb0BLSOSL3PscfRIvcQDudG8nhIHKobC9lWg667N0KBS9QP/xrJMLwY/VBZs6s9NJ hzTd0rs20sopUUDLVvi7vjhwI5NACMjoaFdtd5yWoJJobS/B4JxMolmE1xq5KDm3yMOv en38V289OsfP22gFPjfR/DaqyQrsMncTwXoKrMmHFz56Q1AJOyOOsKgmaQWbySwQwK26 WZFA== X-Received: by 10.68.133.7 with SMTP id oy7mr48806993pbb.43.1404097176884; Sun, 29 Jun 2014 19:59:36 -0700 (PDT) Received: from fortuna ([221.222.159.223]) by mx.google.com with ESMTPSA id id10sm25174583pbc.35.2014.06.29.19.59.34 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Sun, 29 Jun 2014 19:59:36 -0700 (PDT) From: Leo Liu To: Daimrod Subject: Re: bug#17772: [PATCH] Dangling channels' buffer References: <87k38lay6k.fsf@tanger.home> <878up0b8u3.fsf@tanger.home> <874mzob83c.fsf@tanger.home> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Mon, 30 Jun 2014 10:59:32 +0800 In-Reply-To: <874mzob83c.fsf@tanger.home> (daimrod@gmail.com's message of "Sat, 14 Jun 2014 10:20:07 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17772-done Cc: 17772-done@debbugs.gnu.org, Ryan Yeske , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 24.5 On 2014-06-14 10:20 +0900, Daimrod wrote: > Here is a new patch with your proposal: Committed and thanks, Leo ------------=_1404097206-18612-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jun 2014 10:42:23 +0000 Received: from localhost ([127.0.0.1]:46224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvOwA-00038u-3M for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57865) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvOw5-00038U-3i for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvOvy-00057k-Ru for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvOvy-00057d-PR for submit@debbugs.gnu.org; Fri, 13 Jun 2014 06:42:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvOvx-0006LB-SD for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 06:42:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvOvx-00056u-0c for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 06:42:09 -0400 Received: from mail-pb0-x234.google.com ([2607:f8b0:400e:c01::234]:45575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvOvw-00056U-On for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 06:42:08 -0400 Received: by mail-pb0-f52.google.com with SMTP id rr13so2050749pbb.25 for ; Fri, 13 Jun 2014 03:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=UejLSBeXJcyAbVhd5wyGY0LLG0PkYqq2wRhRW9DGVlE=; b=txrpjvbP6pMa3aV5YqDixi3SK7mksClTCvtahsqMJaLKn2sdZ8jPkcPJxj1P8A5UCJ gg83OCbdLktDwtEXfpU0uTbtPcdU9EajTISWtLGTlU2KkoS0RWmndvlqAXcy3JgWCDUh y0eY13l1RnlFhWTGcge41IlPOAOlJP1hb47pbb2G9sUAFQ9gjMv7OsQFgvj8wpA/l4sK WwOjRdM83+rg46rcQz46FiBHrhxBWh30eGp9TFnM4jPxvW0pn2Uz/ATVsdGG35mRuoY+ JpeQRVo5IEbBtrl7ZloGHv/vGic0RIpd/AmMmNCzQVAmrzP7YIokKe8zQ3+8oxr7tEf7 s0hw== X-Received: by 10.66.190.167 with SMTP id gr7mr2072499pac.75.1402656127307; Fri, 13 Jun 2014 03:42:07 -0700 (PDT) Received: from localhost ([2001:2f8:200:1:e206:e6ff:fecb:5a]) by mx.google.com with ESMTPSA id yv7sm19498744pac.33.2014.06.13.03.42.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 03:42:06 -0700 (PDT) From: Daimrod To: bug-gnu-emacs@gnu.org Subject: [PATCH] Dangling channels' buffer Date: Fri, 13 Jun 2014 19:41:55 +0900 Message-ID: <87k38lay6k.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, In the attached patch, I propose a fix for the recent change of the function `rcirc-buffer-process'. This function used to return the rcirc server process when it existed, or nil. However, since a78d87e7ed it raises an error. This is a problem if the user kills the server buffer before it kills the channels' buffer because it is not possible to kill them after that. (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook' and it calls `rcirc-buffer-process'.) WDYT? Regards, --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-clean-up-buffer-Explicitly-c.patch >From 2ce0be284dc8830c3153d60cb0b01e082ab1c5b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Fri, 13 Jun 2014 18:31:31 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-clean-up-buffer): Explicitly check for the `rcirc-server-buffer' Since a78d87e7ed, `rcirc-buffer-process' raises an error instead of returning nil when the `rcirc-server-buffer' doesn't exist. Because of this, it was impossible to delete channels' buffer once the `rcirc-server-buffer' has been deleted. --- lisp/net/rcirc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..57a90de 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1158,7 +1158,7 @@ with it." (defun rcirc-clean-up-buffer (reason) (let ((buffer (current-buffer))) (rcirc-clear-activity buffer) - (when (and (rcirc-buffer-process) + (when (and (buffer-live-p rcirc-server-buffer) (rcirc--connection-open-p (rcirc-buffer-process))) (with-rcirc-server-buffer (setq rcirc-buffer-alist -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=-- ------------=_1404097206-18612-1-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 04 12:35:32 2014 Received: (at control) by debbugs.gnu.org; 4 Oct 2014 16:35:32 +0000 Received: from localhost ([127.0.0.1]:33183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaSIt-0002m9-8U for submit@debbugs.gnu.org; Sat, 04 Oct 2014 12:35:31 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:60039) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaSIr-0002lz-Gi for control@debbugs.gnu.org; Sat, 04 Oct 2014 12:35:29 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XaSIq-0005r2-MO; Sat, 04 Oct 2014 12:35:28 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21552.8656.554316.921175@gnu.org> Date: Sat, 4 Oct 2014 12:35:28 -0400 From: Glenn Morris To: GNU bug tracker automated control server Subject: Update Emacs archived fixed bugs for 24.5 version number change X-Debbugs-No-Ack: yes X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) unarchive 18304 fixed 18304 25.1 notfixed 18304 24.5 unarchive 12008 fixed 12008 25.1 notfixed 12008 24.5 unarchive 17110 fixed 17110 25.1 notfixed 17110 24.5 unarchive 17218 fixed 17218 25.1 notfixed 17218 24.5 unarchive 18222 fixed 18222 25.1 notfixed 18222 24.5 unarchive 18023 fixed 18023 25.1 notfixed 18023 24.5 unarchive 17225 fixed 17225 25.1 notfixed 17225 24.5 unarchive 16626 fixed 16626 25.1 notfixed 16626 24.5 unarchive 18326 fixed 18326 25.1 notfixed 18326 24.5 unarchive 18227 fixed 18227 25.1 notfixed 18227 24.5 unarchive 16328 fixed 16328 25.1 notfixed 16328 24.5 unarchive 17333 fixed 17333 25.1 notfixed 17333 24.5 unarchive 13837 fixed 13837 25.1 notfixed 13837 24.5 unarchive 17641 fixed 17641 25.1 notfixed 17641 24.5 unarchive 18341 fixed 18341 25.1 notfixed 18341 24.5 unarchive 18349 fixed 18349 25.1 notfixed 18349 24.5 unarchive 2151 fixed 2151 25.1 notfixed 2151 24.5 unarchive 5853 fixed 5853 25.1 notfixed 5853 24.5 unarchive 17857 fixed 17857 25.1 notfixed 17857 24.5 unarchive 17858 fixed 17858 25.1 notfixed 17858 24.5 unarchive 17859 fixed 17859 25.1 notfixed 17859 24.5 unarchive 17160 fixed 17160 25.1 notfixed 17160 24.5 unarchive 2263 fixed 2263 25.1 notfixed 2263 24.5 unarchive 18368 fixed 18368 25.1 notfixed 18368 24.5 unarchive 17772 fixed 17772 25.1 notfixed 17772 24.5 unarchive 17276 fixed 17276 25.1 notfixed 17276 24.5 unarchive 15991 fixed 15991 25.1 notfixed 15991 24.5 unarchive 17699 fixed 17699 25.1 notfixed 17699 24.5