GNU bug report logs - #17769
24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Daimrod <daimrod <at> gmail.com>
Subject: bug#17769: closed (Re: bug#17769: 24.4.50; [PATCH]
 rcirc-omit-mode: `recenter'ing a window that does not display
	current-buffer.)
Date: Thu, 19 Jun 2014 11:19:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17769 <at> debbugs.gnu.org.

-- 
17769: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17769
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Liu <sdl.web <at> gmail.com>
To: Daimrod <daimrod <at> gmail.com>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
 17769-done <at> debbugs.gnu.org
Subject: Re: bug#17769: 24.4.50;
 [PATCH] rcirc-omit-mode: `recenter'ing a window that does not
 display	current-buffer.
Date: Thu, 19 Jun 2014 19:18:12 +0800

Fixed in 24.5.

On 2014-06-14 01:08 +0900, Daimrod wrote:
> I see, thanks for inputs.
>
> Here is an updated patch.

Thanks for the patch.

Leo

[Message part 3 (message/rfc822, inline)]

From: Daimrod <daimrod <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50;
 [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display
 current-buffer.
Date: Fri, 13 Jun 2014 15:59:33 +0900

[Message part 4 (text/plain, inline)]

Hi,

The attached patch prevents `rcirc-omit-mode' to call `recenter' when
`window-buffer' isn't the same as `current-buffer'.


If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c
C-o) then it will do the right thing.

If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we
don't need to `recenter' the buffer, because it will be done the next
time the user switch to the buffer with `rcirc-next-active-buffer'.

I'm not an RCIRC expert, but I don't think anything else is required.
WDYT?

[0001-lisp-net-rcirc.el-rcirc-omit-mode-Do-not-recenter-if.patch (text/x-diff, attachment)]

[Message part 6 (text/plain, inline)]

--
Daimrod/Greg

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.