From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 17769@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140264279416584 (code B ref -1); Fri, 13 Jun 2014 07:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2014 06:59:54 +0000 Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvLSr-0004JP-F4 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45326) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvLSo-0004J4-F3 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvLSi-0007Ij-3j for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSi-0007Ie-1A for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSg-0005lk-UK for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvLSe-0007HK-UT for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:42 -0400 Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]:61766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSe-0007H4-NO for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:40 -0400 Received: by mail-pb0-f53.google.com with SMTP id uo5so1611569pbc.40 for ; Thu, 12 Jun 2014 23:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=34semi+MYdnDIWWvXA5s+ypPKFP1sIi3zeX0c3AbzLY=; b=BJu83IIx9kD3inw4Q32V8GxQONR0rvDPG/cb3K8IGVmwTTC0OBKj1qw5WxFx4a9t12 dpnYUpWtjQPtoW67gS+1apk7fIrCuQI0gbKCy1fQ804T1xmyDNZqMWKeC7YEe7b7Kst4 AlFp/Lo0fb5fZkRTrWCjkm1xz31PU8obtFvLqOEa83nwi/wXV9aZbSKcLw18ncj4Gpiq 8lywzXwjhzZS1/fan0xzZMn79UaSPMQvO2oqMoHwvCDjRP+6w/r0zSscIiFhVEblhM7h mpKBUh14xfdqvOOu7nB4tGM3XYOnS5V0OANYMQA7Uu1z8nqmMsrskvNRPPM0WZfGa1ZW SUBw== X-Received: by 10.66.226.172 with SMTP id rt12mr924349pac.101.1402642779667; Thu, 12 Jun 2014 23:59:39 -0700 (PDT) Received: from localhost ([2001:2f8:200:1:e206:e6ff:fecb:5a]) by mx.google.com with ESMTPSA id uj2sm16777668pab.14.2014.06.12.23.59.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jun 2014 23:59:38 -0700 (PDT) From: Daimrod Date: Fri, 13 Jun 2014 15:59:33 +0900 Message-ID: <87ioo5cn1m.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, The attached patch prevents `rcirc-omit-mode' to call `recenter' when `window-buffer' isn't the same as `current-buffer'. If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c C-o) then it will do the right thing. If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we don't need to `recenter' the buffer, because it will be done the next time the user switch to the buffer with `rcirc-next-active-buffer'. I'm not an RCIRC expert, but I don't think anything else is required. WDYT? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-omit-mode-Do-not-recenter-if.patch >From 7bb493830bb0aaebeab69851ed044a5562875641 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Fri, 13 Jun 2014 14:12:52 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-omit-mode): Do not `recenter' if the `current-buffer' isn't the buffer displayed by the selected window. --- lisp/net/rcirc.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..7bd7e93 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1903,7 +1903,8 @@ Uninteresting lines are those whose responses are listed in (message "Rcirc-Omit mode enabled")) (remove-from-invisibility-spec '(rcirc-omit . nil)) (message "Rcirc-Omit mode disabled")) - (recenter (when (> (point) rcirc-prompt-start-marker) -1))) + (when (eq (current-buffer) (window-buffer)) + (recenter (when (> (point) rcirc-prompt-start-marker) -1)))) (defun rcirc-switch-to-server-buffer () "Switch to the server buffer associated with current channel buffer." -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=-- From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 08:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daimrod Cc: 17769@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.140264820727586 (code B ref 17769); Fri, 13 Jun 2014 08:31:01 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 08:30:07 +0000 Received: from localhost ([127.0.0.1]:46148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvMsA-0007AK-V2 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 04:30:07 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:60071) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvMs7-000792-D3 for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 04:30:05 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N7300700M2VT300@a-mtaout23.012.net.il> for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 11:29:56 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N73007QXM9VQ170@a-mtaout23.012.net.il>; Fri, 13 Jun 2014 11:29:56 +0300 (IDT) Date: Fri, 13 Jun 2014 11:29:44 +0300 From: Eli Zaretskii In-reply-to: <87ioo5cn1m.fsf@tanger.home> X-012-Sender: halo1@inter.net.il Message-id: <8338f9xldz.fsf@gnu.org> References: <87ioo5cn1m.fsf@tanger.home> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Daimrod > Date: Fri, 13 Jun 2014 15:59:33 +0900 > > The attached patch prevents `rcirc-omit-mode' to call `recenter' when > `window-buffer' isn't the same as `current-buffer'. > > > If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c > C-o) then it will do the right thing. > > If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we > don't need to `recenter' the buffer, because it will be done the next > time the user switch to the buffer with `rcirc-next-active-buffer'. > > I'm not an RCIRC expert, but I don't think anything else is required. > WDYT? This doesn't sound like the right fix to me. Instead, the code should momentarily switch to the right window, and call recenter there. That's surely what the author of this code intended, AFAIU. Thanks. From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 17769@debbugs.gnu.org Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.1402650863658 (code B ref 17769); Fri, 13 Jun 2014 09:15:02 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 09:14:23 +0000 Received: from localhost ([127.0.0.1]:46174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvNZ0-0000AX-O2 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 05:14:23 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:59631) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvNYy-0000A1-2S for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 05:14:20 -0400 Received: by mail-pa0-f54.google.com with SMTP id et14so1928209pad.27 for <17769@debbugs.gnu.org>; Fri, 13 Jun 2014 02:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=bBIhxkn8eke4dbJ//Vou+oVOLppYNPsoc+qVh0LKhAg=; b=iowgKTHPkGBddNdFagFnZtzgIqPeeXIpDeVL/PzdGfPEExv7KcrU9nbRW1lzciAM+Q UADzZT7dUbaUxn2WI7hsVOyXg+ZV4tcJbNMgb6woxCxNCNDB7cElVVF/5CbCIsgbTVNh OtxGhpld4X3p9oVlMEeUxuW6vUCztdF2ZVCxJPXwyeMNFZDuhM2nEvQ7dUf1XRarIcfg ulbxe/gMZ+87Nc+puqhVFt4I1EUjnFVsmbj29uqaoS4y/oSsmS0aYfF6cI38sdK2Xm1T bivR3VOa8zJsgcCKXCNrYAEF0pXJJOL3UO12I18ubnYtPOim2yxMjavN/7/qzIJgRHNo hSNQ== X-Received: by 10.66.155.227 with SMTP id vz3mr1790212pab.26.1402650853957; Fri, 13 Jun 2014 02:14:13 -0700 (PDT) Received: from localhost ([2001:2f8:200:1:e206:e6ff:fecb:5a]) by mx.google.com with ESMTPSA id kh4sm2444180pbc.64.2014.06.13.02.14.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 02:14:13 -0700 (PDT) From: Daimrod References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> Date: Fri, 13 Jun 2014 18:14:09 +0900 In-Reply-To: <8338f9xldz.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Jun 2014 11:29:44 +0300") Message-ID: <8738f9cgta.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: Daimrod >> Date: Fri, 13 Jun 2014 15:59:33 +0900 >> >> The attached patch prevents `rcirc-omit-mode' to call `recenter' when >> `window-buffer' isn't the same as `current-buffer'. >> >> >> If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c >> C-o) then it will do the right thing. >> >> If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we >> don't need to `recenter' the buffer, because it will be done the next >> time the user switch to the buffer with `rcirc-next-active-buffer'. >> >> I'm not an RCIRC expert, but I don't think anything else is required. >> WDYT? > > This doesn't sound like the right fix to me. Instead, the code should > momentarily switch to the right window, and call recenter there. > That's surely what the author of this code intended, AFAIU. But the buffer might not be displayed in any window. For example, when one invoked `rcirc-connect' with some channels by default: : (rcirc-connect "localhost" 6667 nil nil nil '("#bar") nil) Then a buffer "#bar@localhost" will be created but not displayed. Regards, -- Daimrod/Greg From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daimrod Cc: 17769@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.14026523563802 (code B ref 17769); Fri, 13 Jun 2014 09:40:02 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 09:39:16 +0000 Received: from localhost ([127.0.0.1]:46200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvNx6-0000zF-0E for submit@debbugs.gnu.org; Fri, 13 Jun 2014 05:39:16 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:63500) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvNx3-0000yz-Ly for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 05:39:15 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N7300700PA1Z700@a-mtaout23.012.net.il> for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 12:39:06 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N73007S9PH6V780@a-mtaout23.012.net.il>; Fri, 13 Jun 2014 12:39:06 +0300 (IDT) Date: Fri, 13 Jun 2014 12:38:55 +0300 From: Eli Zaretskii In-reply-to: <8738f9cgta.fsf@tanger.home> X-012-Sender: halo1@inter.net.il Message-id: <83zjhhw3m8.fsf@gnu.org> References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Daimrod > Cc: 17769@debbugs.gnu.org > Date: Fri, 13 Jun 2014 18:14:09 +0900 > > > This doesn't sound like the right fix to me. Instead, the code should > > momentarily switch to the right window, and call recenter there. > > That's surely what the author of this code intended, AFAIU. > > But the buffer might not be displayed in any window. Then with-current-buffer is your friend, I think. From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 17769@debbugs.gnu.org Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.14026532605593 (code B ref 17769); Fri, 13 Jun 2014 09:55:02 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 09:54:20 +0000 Received: from localhost ([127.0.0.1]:46213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvOBe-0001S8-Ru for submit@debbugs.gnu.org; Fri, 13 Jun 2014 05:54:19 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:60885) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvOBc-0001Rk-7M for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 05:54:17 -0400 Received: by mail-pd0-f176.google.com with SMTP id p10so1947698pdj.7 for <17769@debbugs.gnu.org>; Fri, 13 Jun 2014 02:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=ToOoDRxUkdakt28nl3/1Y2h5eMkCUhZ5Qk8D9QXwOPA=; b=nfIBV2nEKx0IQZzIwPYhLYRPmfl7ABHbCD7GNMOQ+odyVeYem/gFCiqCTFskvngZOH 5eS2PUhL8z0Cv+lfJGE9Bw02yMl+ozTONcd2bkw3LDcNaF/uKs5B7JEi0KZRr5nLmuqP ZdUdAawVHV7WqS6Lq+R7qfeLcbrkr7rwOeiV/sth6vYF91AjtfSLBsoCeoJ8ZEmk+dHC YILZMRw9BheIYF85go4yLAOWC1Kq7gjugze081jzbZJFQPXAEjrExeE8erOzGjdmTVsq LYB+OmQ2Vzr4GuPKKJ2siEPXJ7m6A7RSmhgUAYRZwAO+fFTo5KxgJ/z9Yed9MxHd6BOa gDdQ== X-Received: by 10.66.227.33 with SMTP id rx1mr1747531pac.133.1402653249993; Fri, 13 Jun 2014 02:54:09 -0700 (PDT) Received: from localhost ([2001:2f8:200:1:e206:e6ff:fecb:5a]) by mx.google.com with ESMTPSA id gw8sm2663997pbc.28.2014.06.13.02.54.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 02:54:09 -0700 (PDT) From: Daimrod References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> Date: Fri, 13 Jun 2014 18:54:04 +0900 In-Reply-To: <83zjhhw3m8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Jun 2014 12:38:55 +0300") Message-ID: <87r42tb0eb.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> From: Daimrod >> Cc: 17769@debbugs.gnu.org >> Date: Fri, 13 Jun 2014 18:14:09 +0900 >> >> > This doesn't sound like the right fix to me. Instead, the code should >> > momentarily switch to the right window, and call recenter there. >> > That's surely what the author of this code intended, AFAIU. >> >> But the buffer might not be displayed in any window. > > Then with-current-buffer is your friend, I think. IIUC the goal isn't to recenter the window-buffer but the current-buffer, but that cannot be done because it is not displayed on any windows. So, I with-current-buffer won't help, I would need to use with-current-buffer-window. Or did I misundertand you? -- Daimrod/Greg From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 12:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daimrod Cc: 17769@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.140266210329169 (code B ref 17769); Fri, 13 Jun 2014 12:22:01 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 12:21:43 +0000 Received: from localhost ([127.0.0.1]:46270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvQUF-0007aH-3O for submit@debbugs.gnu.org; Fri, 13 Jun 2014 08:21:43 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:60791) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvQU8-0007Zn-8Y for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 08:21:36 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N7300300W91QN00@mtaout25.012.net.il> for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 15:17:46 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N730056QWTMVX10@mtaout25.012.net.il>; Fri, 13 Jun 2014 15:17:46 +0300 (IDT) Date: Fri, 13 Jun 2014 15:21:14 +0300 From: Eli Zaretskii In-reply-to: <87r42tb0eb.fsf@tanger.home> X-012-Sender: halo1@inter.net.il Message-id: <83sin9vw3p.fsf@gnu.org> References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Daimrod > Cc: 17769@debbugs.gnu.org > Date: Fri, 13 Jun 2014 18:54:04 +0900 > > IIUC the goal isn't to recenter the window-buffer but the > current-buffer, but that cannot be done because it is not displayed on > any windows. Then don't recenter if it is not displayed in any window on any frame. But if it is displayed in some window, recenter that window. From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daimrod Cc: Eli Zaretskii , 17769@debbugs.gnu.org Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.1402663897645 (code B ref 17769); Fri, 13 Jun 2014 12:52:02 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 12:51:37 +0000 Received: from localhost ([127.0.0.1]:46288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvQxA-0000A9-6z for submit@debbugs.gnu.org; Fri, 13 Jun 2014 08:51:37 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:41154) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvQx4-00009k-2H for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 08:51:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQHCxQYDSSIBAjSGReOegeEOAEDqRmBaoFxgVsh X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQHCxQYDSSIBAjSGReOegeEOAEDqRmBaoFxgVsh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="66766237" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jun 2014 08:51:20 -0400 Received: by pastel.home (Postfix, from userid 20848) id 2003860117; Fri, 13 Jun 2014 08:51:20 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> Date: Fri, 13 Jun 2014 08:51:20 -0400 In-Reply-To: <8738f9cgta.fsf@tanger.home> (daimrod@gmail.com's message of "Fri, 13 Jun 2014 18:14:09 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > But the buffer might not be displayed in any window. Then I guess it should check that get-buffer-window does return a window and do nothing if it doesn't. Stefan From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 12:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Daimrod Cc: 17769@debbugs.gnu.org Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.1402663939753 (code B ref 17769); Fri, 13 Jun 2014 12:53:01 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 12:52:19 +0000 Received: from localhost ([127.0.0.1]:46292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvQxq-0000Bw-I9 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 08:52:19 -0400 Received: from mout.gmx.net ([212.227.15.18]:52228) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvQxk-0000BL-3d for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 08:52:13 -0400 Received: from [188.22.108.18] ([188.22.108.18]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MUZG7-1XLRzO0Qrb-00RL0w; Fri, 13 Jun 2014 14:52:01 +0200 Message-ID: <539AF3E5.2060102@gmx.at> Date: Fri, 13 Jun 2014 14:51:49 +0200 From: martin rudalics MIME-Version: 1.0 References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> <83sin9vw3p.fsf@gnu.org> In-Reply-To: <83sin9vw3p.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:23YGbLy170TXP/mp4jwF7NSHuM163GRBfomOa3ZBJITiELcv67u CBeAX9cB1yMSYSKVnTrzLnturUWv6seLicYWPn+EozFfNvaCyLF3RZe8dpk1HLppKe6zpIV E0BEpn3qV73mYMr0u1UEqtHIHDwibSKm0s2cAxqhpmGneBgjIrGvSXoSMyCgwmg+Tq6zEJE vWukcZaVxY/Fl4IU/DtLQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > But if it is displayed in some window, recenter that window. Strictly spoken this should read "But if it is displayed in the selected window, recenter that window." martin From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 13:31:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics Cc: daimrod@gmail.com, 17769@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.14026662365728 (code B ref 17769); Fri, 13 Jun 2014 13:31:04 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 13:30:36 +0000 Received: from localhost ([127.0.0.1]:46313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvRYr-0001T8-Gm for submit@debbugs.gnu.org; Fri, 13 Jun 2014 09:30:33 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:33851) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvRYk-0001Sj-9o for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 09:30:26 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N7300L00ZXYXR00@a-mtaout22.012.net.il> for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 16:30:15 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7400LGV06FP540@a-mtaout22.012.net.il>; Fri, 13 Jun 2014 16:30:15 +0300 (IDT) Date: Fri, 13 Jun 2014 16:30:04 +0300 From: Eli Zaretskii In-reply-to: <539AF3E5.2060102@gmx.at> X-012-Sender: halo1@inter.net.il Message-id: <83oaxxvswz.fsf@gnu.org> References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> <83sin9vw3p.fsf@gnu.org> <539AF3E5.2060102@gmx.at> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 13 Jun 2014 14:51:49 +0200 > From: martin rudalics > CC: 17769@debbugs.gnu.org > > > But if it is displayed in some window, recenter that window. > > Strictly spoken this should read "But if it is displayed in the selected > window, recenter that window." No, because in that case it would already have been done by a normal call to recenter. From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: daimrod@gmail.com, 17769@debbugs.gnu.org Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.140266942912820 (code B ref 17769); Fri, 13 Jun 2014 14:24:02 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 14:23:49 +0000 Received: from localhost ([127.0.0.1]:46765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvSOO-0003Ka-Hi for submit@debbugs.gnu.org; Fri, 13 Jun 2014 10:23:49 -0400 Received: from mout.gmx.net ([212.227.17.21]:56963) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvSOI-0003KF-NM for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 10:23:43 -0400 Received: from [188.22.108.18] ([188.22.108.18]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Mcmmn-1XCqeJ2BCz-00HxRK; Fri, 13 Jun 2014 16:23:30 +0200 Message-ID: <539B0956.3060003@gmx.at> Date: Fri, 13 Jun 2014 16:23:18 +0200 From: martin rudalics MIME-Version: 1.0 References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> <83sin9vw3p.fsf@gnu.org> <539AF3E5.2060102@gmx.at> <83oaxxvswz.fsf@gnu.org> In-Reply-To: <83oaxxvswz.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:5z5o+ExePabsD/1gvTc4UH2O9iBKD9gzusy59E9afwoJWl090pM 2QJxEnb2m7C6iWKbx5y9Fnm4//VWM1TSFaC3u2m9DbvZgFpo1bsZHNi7Ze5sfJjEWVJVfko 3BDkxSGw1BspCY+kqe/Nb+eSag/f+VaWXsAFCvS/KJufY0v2rA2DXxoRPGz9Z/UmbzC2HVb 9zzTGyrn6dRvjlQ97ut0A== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> Strictly spoken this should read "But if it is displayed in the selected >> window, recenter that window." > > No, because in that case it would already have been done by a normal > call to recenter. Unless the selected window displayed another buffer. Then you probably mean something like (dolist (window (get-buffer-window-list buffer)) (with-selected-window window (recenter))) martin From unknown Sat Aug 16 13:51:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics Cc: Eli Zaretskii , 17769@debbugs.gnu.org Received: via spool by 17769-submit@debbugs.gnu.org id=B17769.140267575326011 (code B ref 17769); Fri, 13 Jun 2014 16:10:01 +0000 Received: (at 17769) by debbugs.gnu.org; 13 Jun 2014 16:09:13 +0000 Received: from localhost ([127.0.0.1]:46853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvU2O-0006lM-TH for submit@debbugs.gnu.org; Fri, 13 Jun 2014 12:09:12 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:45253) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvU2J-0006ki-G1 for 17769@debbugs.gnu.org; Fri, 13 Jun 2014 12:09:07 -0400 Received: by mail-pb0-f48.google.com with SMTP id rq2so200315pbb.35 for <17769@debbugs.gnu.org>; Fri, 13 Jun 2014 09:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=PVdKeIXElQXcTZYQCujgm7SODEv7sQEmQAJ9weY+MZo=; b=XvE/n96NfDSgq1jtQw79XZFoJzAkNeDb6EkNtiG4iA3DOGupVcTFqb0PlzMFOACaLw oggcJq/mumzpzewPg/cwL+eJ/iutcTY9M9dC+AKM3PUBfCu/VnRuXOFqzlzMT1Lkn1/S u4xYsUxFT3gJukGkIkggvqxuRvJyDNbW4Q6itRqcJKPEeWLCD6IjRVfCLJr/QCxyJTBd Avhr9fWU8fLV/+7iw8wnjG0Vg42HGYGNCe+J0mWzUK39R0bK+RQeNQY8vCoideFa29MX iH/w8d+AtMIvjf/ot35sEWvKu3LL+EOJ5/sPYfBhq/J+y41XZJRmXP5BDCkk7mv8uD2T yeoQ== X-Received: by 10.68.190.74 with SMTP id go10mr4735542pbc.16.1402675737463; Fri, 13 Jun 2014 09:08:57 -0700 (PDT) Received: from localhost (i118-21-141-133.s30.a048.ap.plala.or.jp. [118.21.141.133]) by mx.google.com with ESMTPSA id qf10sm4361887pbc.23.2014.06.13.09.08.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 09:08:55 -0700 (PDT) From: Daimrod References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> <83sin9vw3p.fsf@gnu.org> <539AF3E5.2060102@gmx.at> <83oaxxvswz.fsf@gnu.org> <539B0956.3060003@gmx.at> Date: Sat, 14 Jun 2014 01:08:52 +0900 In-Reply-To: <539B0956.3060003@gmx.at> (martin rudalics's message of "Fri, 13 Jun 2014 16:23:18 +0200") Message-ID: <87d2ecbxm3.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain martin rudalics writes: >>> Strictly spoken this should read "But if it is displayed in the selected >>> window, recenter that window." >> >> No, because in that case it would already have been done by a normal >> call to recenter. > > Unless the selected window displayed another buffer. Then you probably > mean something like > > (dolist (window (get-buffer-window-list buffer)) > (with-selected-window window (recenter))) I see, thanks for inputs. Here is an updated patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-omit-mode-recenter-the-corre.patch >From c9fb7786be4fd929ad81861b3ada47d8d2f385e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Sat, 14 Jun 2014 00:57:06 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-omit-mode): `recenter' the correct windows. --- lisp/net/rcirc.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..a0e72d1 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1903,7 +1903,9 @@ Uninteresting lines are those whose responses are listed in (message "Rcirc-Omit mode enabled")) (remove-from-invisibility-spec '(rcirc-omit . nil)) (message "Rcirc-Omit mode disabled")) - (recenter (when (> (point) rcirc-prompt-start-marker) -1))) + (dolist (window (get-buffer-window-list (current-buffer))) + (with-selected-window window + (recenter (when (> (point) rcirc-prompt-start-marker) -1))))) (defun rcirc-switch-to-server-buffer () "Switch to the server buffer associated with current channel buffer." -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 14 09:18:54 2014 Received: (at control) by debbugs.gnu.org; 14 Jun 2014 13:18:55 +0000 Received: from localhost ([127.0.0.1]:47283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvnrC-0006fJ-D0 for submit@debbugs.gnu.org; Sat, 14 Jun 2014 09:18:54 -0400 Received: from byebi.wara.tw ([128.199.200.93]:47800) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvnr9-0006f7-W4 for control@debbugs.gnu.org; Sat, 14 Jun 2014 09:18:52 -0400 Received: from 114-32-24-38.hinet-ip.hinet.net ([114.32.24.38] helo=isil.kanru.info) by byebi.wara.tw with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Wvnr7-0006Tl-68 for control@debbugs.gnu.org; Sat, 14 Jun 2014 21:18:49 +0800 Received: from kanru by isil.kanru.info with local (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1Wvnsw-0001Si-4x for control@debbugs.gnu.org; Sat, 14 Jun 2014 21:20:42 +0800 From: Kan-Ru Chen =?UTF-8?Q?(=E9=99=B3=E4=BE=83=E5=A6=82)?= To: control@debbugs.gnu.org Subject: merging 17769 17778 Date: Sat, 14 Jun 2014 21:20:42 +0800 User-Agent: devscripts bts/2.14.5 Message-ID: <1402752042-37-bts-kanru@kanru.info> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) merge 17769 17778 thanks From unknown Sat Aug 16 13:51:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Daimrod Subject: bug#17769: closed (Re: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer.) Message-ID: References: <87ioo5cn1m.fsf@tanger.home> X-Gnu-PR-Message: they-closed 17769 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 17769@debbugs.gnu.org Date: Thu, 19 Jun 2014 11:19:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1403176743-10886-1" This is a multi-part message in MIME format... ------------=_1403176743-10886-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does = not display current-buffer. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17769@debbugs.gnu.org. --=20 17769: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17769 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1403176743-10886-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17769-done) by debbugs.gnu.org; 19 Jun 2014 11:18:27 +0000 Received: from localhost ([127.0.0.1]:52506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxaMN-0002oo-JW for submit@debbugs.gnu.org; Thu, 19 Jun 2014 07:18:27 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:48360) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxaML-0002oW-Jt for 17769-done@debbugs.gnu.org; Thu, 19 Jun 2014 07:18:26 -0400 Received: by mail-pb0-f43.google.com with SMTP id um1so1613511pbc.16 for <17769-done@debbugs.gnu.org>; Thu, 19 Jun 2014 04:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=hMMwFewqEGSNtZ0LfwJX+EChF/CZBGKgNizEooX0lBs=; b=ReKfB1U0r34vbvmIbeJrKdLA35VgUIbOKcD+ChHOhzC2dPXdHr6p6fZEhegIwAs3Zd Mo3P+IHYdOV8MdNSZI4sOEKa9VrM74ZlTXzpTsVJ+/YT/sjSsFllv9U2K/c3sj8qMDeO ylFllAh0hUUSJVRVjL7NeoNRA+eWRfVAbUJtR8BMcgOLwaoJkmhZZNrURoa1H5zYKDJ/ 0ge2czxXnyCYLn35ks13VUZ6mgMAxFezVt/u6INTLA87c4dWgYsu+U6Bf+04aAD3nOTz +uV7lf2Sysjh/zgVaG3bK85uB9i6VfN/u71TEKB7U95ukAuu5u0slGWkSjS1t8q1v1Os PJeA== X-Received: by 10.67.14.231 with SMTP id fj7mr4620687pad.115.1403176699480; Thu, 19 Jun 2014 04:18:19 -0700 (PDT) Received: from fortuna ([221.222.152.215]) by mx.google.com with ESMTPSA id iz2sm8082954pbb.95.2014.06.19.04.18.16 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 19 Jun 2014 04:18:18 -0700 (PDT) From: Leo Liu To: Daimrod Subject: Re: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> <83sin9vw3p.fsf@gnu.org> <539AF3E5.2060102@gmx.at> <83oaxxvswz.fsf@gnu.org> <539B0956.3060003@gmx.at> <87d2ecbxm3.fsf@tanger.home> Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Thu, 19 Jun 2014 19:18:12 +0800 In-Reply-To: <87d2ecbxm3.fsf@tanger.home> (daimrod@gmail.com's message of "Sat, 14 Jun 2014 01:08:52 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17769-done Cc: martin rudalics , Eli Zaretskii , 17769-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in 24.5. On 2014-06-14 01:08 +0900, Daimrod wrote: > I see, thanks for inputs. > > Here is an updated patch. Thanks for the patch. Leo ------------=_1403176743-10886-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jun 2014 06:59:54 +0000 Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvLSr-0004JP-F4 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45326) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvLSo-0004J4-F3 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvLSi-0007Ij-3j for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSi-0007Ie-1A for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSg-0005lk-UK for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvLSe-0007HK-UT for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:42 -0400 Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]:61766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSe-0007H4-NO for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:40 -0400 Received: by mail-pb0-f53.google.com with SMTP id uo5so1611569pbc.40 for ; Thu, 12 Jun 2014 23:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=34semi+MYdnDIWWvXA5s+ypPKFP1sIi3zeX0c3AbzLY=; b=BJu83IIx9kD3inw4Q32V8GxQONR0rvDPG/cb3K8IGVmwTTC0OBKj1qw5WxFx4a9t12 dpnYUpWtjQPtoW67gS+1apk7fIrCuQI0gbKCy1fQ804T1xmyDNZqMWKeC7YEe7b7Kst4 AlFp/Lo0fb5fZkRTrWCjkm1xz31PU8obtFvLqOEa83nwi/wXV9aZbSKcLw18ncj4Gpiq 8lywzXwjhzZS1/fan0xzZMn79UaSPMQvO2oqMoHwvCDjRP+6w/r0zSscIiFhVEblhM7h mpKBUh14xfdqvOOu7nB4tGM3XYOnS5V0OANYMQA7Uu1z8nqmMsrskvNRPPM0WZfGa1ZW SUBw== X-Received: by 10.66.226.172 with SMTP id rt12mr924349pac.101.1402642779667; Thu, 12 Jun 2014 23:59:39 -0700 (PDT) Received: from localhost ([2001:2f8:200:1:e206:e6ff:fecb:5a]) by mx.google.com with ESMTPSA id uj2sm16777668pab.14.2014.06.12.23.59.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jun 2014 23:59:38 -0700 (PDT) From: Daimrod To: bug-gnu-emacs@gnu.org Subject: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Date: Fri, 13 Jun 2014 15:59:33 +0900 Message-ID: <87ioo5cn1m.fsf@tanger.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, The attached patch prevents `rcirc-omit-mode' to call `recenter' when `window-buffer' isn't the same as `current-buffer'. If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c C-o) then it will do the right thing. If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we don't need to `recenter' the buffer, because it will be done the next time the user switch to the buffer with `rcirc-next-active-buffer'. I'm not an RCIRC expert, but I don't think anything else is required. WDYT? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-omit-mode-Do-not-recenter-if.patch >From 7bb493830bb0aaebeab69851ed044a5562875641 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Fri, 13 Jun 2014 14:12:52 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-omit-mode): Do not `recenter' if the `current-buffer' isn't the buffer displayed by the selected window. --- lisp/net/rcirc.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..7bd7e93 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1903,7 +1903,8 @@ Uninteresting lines are those whose responses are listed in (message "Rcirc-Omit mode enabled")) (remove-from-invisibility-spec '(rcirc-omit . nil)) (message "Rcirc-Omit mode disabled")) - (recenter (when (> (point) rcirc-prompt-start-marker) -1))) + (when (eq (current-buffer) (window-buffer)) + (recenter (when (> (point) rcirc-prompt-start-marker) -1)))) (defun rcirc-switch-to-server-buffer () "Switch to the server buffer associated with current channel buffer." -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=-- ------------=_1403176743-10886-1-- From unknown Sat Aug 16 13:51:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kan-Ru Chen (=?UTF-8?Q?=E9=99=B3=E4=BE=83=E5=A6=82?=) Subject: bug#17778: closed (Re: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer.) Message-ID: References: <87lhszbujp.fsf@isil.kanru.info> X-Gnu-PR-Message: they-closed 17778 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 17778@debbugs.gnu.org Date: Thu, 19 Jun 2014 11:19:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1403176744-10886-3" This is a multi-part message in MIME format... ------------=_1403176744-10886-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17769: 24.4.50; rcirc-omit-mode should only call `recenter' if `current-bu= ffer' is equal to `window-buffer' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17778@debbugs.gnu.org. --=20 17769: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17769 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1403176744-10886-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17769-done) by debbugs.gnu.org; 19 Jun 2014 11:18:27 +0000 Received: from localhost ([127.0.0.1]:52506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxaMN-0002oo-JW for submit@debbugs.gnu.org; Thu, 19 Jun 2014 07:18:27 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:48360) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxaML-0002oW-Jt for 17769-done@debbugs.gnu.org; Thu, 19 Jun 2014 07:18:26 -0400 Received: by mail-pb0-f43.google.com with SMTP id um1so1613511pbc.16 for <17769-done@debbugs.gnu.org>; Thu, 19 Jun 2014 04:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=hMMwFewqEGSNtZ0LfwJX+EChF/CZBGKgNizEooX0lBs=; b=ReKfB1U0r34vbvmIbeJrKdLA35VgUIbOKcD+ChHOhzC2dPXdHr6p6fZEhegIwAs3Zd Mo3P+IHYdOV8MdNSZI4sOEKa9VrM74ZlTXzpTsVJ+/YT/sjSsFllv9U2K/c3sj8qMDeO ylFllAh0hUUSJVRVjL7NeoNRA+eWRfVAbUJtR8BMcgOLwaoJkmhZZNrURoa1H5zYKDJ/ 0ge2czxXnyCYLn35ks13VUZ6mgMAxFezVt/u6INTLA87c4dWgYsu+U6Bf+04aAD3nOTz +uV7lf2Sysjh/zgVaG3bK85uB9i6VfN/u71TEKB7U95ukAuu5u0slGWkSjS1t8q1v1Os PJeA== X-Received: by 10.67.14.231 with SMTP id fj7mr4620687pad.115.1403176699480; Thu, 19 Jun 2014 04:18:19 -0700 (PDT) Received: from fortuna ([221.222.152.215]) by mx.google.com with ESMTPSA id iz2sm8082954pbb.95.2014.06.19.04.18.16 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 19 Jun 2014 04:18:18 -0700 (PDT) From: Leo Liu To: Daimrod Subject: Re: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. References: <87ioo5cn1m.fsf@tanger.home> <8338f9xldz.fsf@gnu.org> <8738f9cgta.fsf@tanger.home> <83zjhhw3m8.fsf@gnu.org> <87r42tb0eb.fsf@tanger.home> <83sin9vw3p.fsf@gnu.org> <539AF3E5.2060102@gmx.at> <83oaxxvswz.fsf@gnu.org> <539B0956.3060003@gmx.at> <87d2ecbxm3.fsf@tanger.home> Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Thu, 19 Jun 2014 19:18:12 +0800 In-Reply-To: <87d2ecbxm3.fsf@tanger.home> (daimrod@gmail.com's message of "Sat, 14 Jun 2014 01:08:52 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17769-done Cc: martin rudalics , Eli Zaretskii , 17769-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in 24.5. On 2014-06-14 01:08 +0900, Daimrod wrote: > I see, thanks for inputs. > > Here is an updated patch. Thanks for the patch. Leo ------------=_1403176744-10886-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2014 11:27:27 +0000 Received: from localhost ([127.0.0.1]:47223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvm7K-0000oT-Mo for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41201) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvm7I-0000oC-09 for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wvm77-00032j-Mv for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvm77-00032d-JV for submit@debbugs.gnu.org; Sat, 14 Jun 2014 07:27:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvm72-0000VJ-Ju for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 07:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wvm6x-00031d-QH for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 07:27:08 -0400 Received: from byebi.wara.tw ([128.199.200.93]:39536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvm6x-0002U1-Ec for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 07:27:03 -0400 Received: from 114-32-24-38.hinet-ip.hinet.net ([114.32.24.38] helo=isil.kanru.info) by byebi.wara.tw with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Wvm5R-0006Pq-53 for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 19:25:29 +0800 Received: from hgw ([127.0.0.1] helo=isil.kanru.info) by isil.kanru.info with esmtp (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1Wvm7G-0000xI-8L for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 19:27:22 +0800 From: =?utf-8?B?S2FuLVJ1IENoZW4gKOmZs+S+g+Wmgik=?= To: bug-gnu-emacs@gnu.org Subject: 24.4.50; rcirc-omit-mode should only call `recenter' if `current-buffer' is equal to `window-buffer' Date: Sat, 14 Jun 2014 19:27:22 +0800 Message-ID: <87lhszbujp.fsf@isil.kanru.info> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Step to reproduce: (add-hook 'rcirc-mode-hook 'rcirc-omit-mode) When rcirc trys auto-connect to channels, emacs will show (error "`recenter'ing a window that does not display current-buffer.") Patch attached In GNU Emacs 24.4.50.6 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2014-06-14 on isil Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Debian GNU/Linux unstable (sid) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-net-rcirc.el-Only-call-recenter-if-current-buffer-is.patch >From 901b38e1f17def0b4ee64f78f54d04e3295eb6db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kan-Ru=20Chen=20=28=E9=99=B3=E4=BE=83=E5=A6=82=29?= Date: Sat, 14 Jun 2014 19:21:00 +0800 Subject: [PATCH] net/rcirc.el: Only call `recenter' if `current-buffer' is equal to `window-buffer' --- lisp/ChangeLog | 5 +++++ lisp/net/rcirc.el | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 1df12d4..8317393 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2014-06-14 Kan-Ru Chen + + * net/rcirc.el (rcirc-omit-mode): Only call `recenter' if + `current-buffer' is equal to `window-buffer'. + 2014-06-13 Glenn Morris * Makefile.in ($(lisp)/cus-load.el, $(lisp)/finder-inf.el) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..1e3ee32 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1903,7 +1903,9 @@ Uninteresting lines are those whose responses are listed in (message "Rcirc-Omit mode enabled")) (remove-from-invisibility-spec '(rcirc-omit . nil)) (message "Rcirc-Omit mode disabled")) - (recenter (when (> (point) rcirc-prompt-start-marker) -1))) + (when (and (eq (current-buffer) (window-buffer)) + (> (point) rcirc-prompt-start-marker)) + (recenter -1))) (defun rcirc-switch-to-server-buffer () "Switch to the server buffer associated with current channel buffer." -- 2.0.0 --=-=-=-- ------------=_1403176744-10886-3--