GNU bug report logs - #17746
24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message

Previous Next

Packages: emacs, org-mode;

Reported by: David Griffiths <dogriffiths <at> gmail.com>

Date: Tue, 10 Jun 2014 15:39:01 UTC

Severity: normal

Merged with 17724, 17794, 18401, 18430, 18594

Found in version 24.4.50

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #62 received at 17746 <at> debbugs.gnu.org (full text, mbox):

From: Daimrod <daimrod <at> gmail.com>
To: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>
Cc: Bastien <bzg <at> altern.org>, 17746 <at> debbugs.gnu.org,
 David Griffiths <dogriffiths <at> gmail.com>
Subject: Re: [O] bug#17746: 24.4.50;
 "byte-code: `recenter'ing a window that does not display
 current-buffer." when composing a message
Date: Thu, 12 Jun 2014 18:27:51 +0900
Daimrod <daimrod <at> gmail.com> writes:

> Nicolas Richard <theonewiththeevillook <at> yahoo.fr> writes:
>
>> Daimrod <daimrod <at> gmail.com> writes:
>>>> PS: The change about throwing an error when recentering a window
>>>> that does not display the current buffer breaks ~37 tests in Org
>>>> master branch, even with this fix.  I need to digg this further.
>>>
>>> Err, what's the rational behind this change?
>>
>> It is meant to catch cases where recenter acts on the wrong window.
>> Think of the cases where (recenter) is called from within a timer or a
>> process filter function.
>>
>> See the discussion entitled
>>> comint-preoutput-filter-functions and flickering redisplay in TTY
>> on emacs devel.
>
> Thanks!

Okay, so is there another fix than `(when (eq (current-buffer)
(window-buffer)))' or removing the call?

If not, why does it raise an error instead of doing nothing silently?

Best,

-- 
Daimrod/Greg




This bug report was last modified 10 years and 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.