From unknown Sat Aug 16 15:59:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17733: 24.4.50; [ruby-mode] Font-locking of true, false and nil Resent-From: Bozhidar Batsov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2014 06:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17733 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17733@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140220875225518 (code B ref -1); Sun, 08 Jun 2014 06:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jun 2014 06:25:52 +0000 Received: from localhost ([127.0.0.1]:40886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtWY9-0006dS-Ng for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40143) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtWY5-0006d4-Gr for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtWXr-0005jZ-9L for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_50, FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:59251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtWXq-0005jJ-I8 for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtWXh-0008La-61 for bug-gnu-emacs@gnu.org; Sun, 08 Jun 2014 02:25:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtWXY-0005cH-1V for bug-gnu-emacs@gnu.org; Sun, 08 Jun 2014 02:25:21 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:41347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtWXX-0005c5-LW for bug-gnu-emacs@gnu.org; Sun, 08 Jun 2014 02:25:11 -0400 Received: by mail-wg0-f41.google.com with SMTP id a1so955898wgh.0 for ; Sat, 07 Jun 2014 23:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Jp2OYjtwId5Lz3+rr9NF11NTmJ29fcdrKvAF7o/U+8U=; b=hkXo6A6OSeGLrmL8CTd0uWnJhqXB+5YreZQAak5y6SZAyou6CJF+C6X+ao7uY9K1Yc DacvOO1z+7P9IC8kTIwR/Wu8tuqg6PE0mdul4Ro0Gl+X4RZAwoB8pOGVm2I5GYPkPlPV m7slGN4gV75ObmmKGZSgtZ/K9JP9ulfU1OuM6p6hQdV3C8opiAyc8DQZP8BJsjSz0uPX Kg6sz8RDw5xwKpuP6QSFhf8e88WSTK67PAJnbTxHg39n2qTq9zNIIDZK/jbEmY8YCN8m rNd281zUUjICS+HDyMDkT/RpTNI2d6rAR6Gk9QVB4o7jAnH0ThQnx+f7eE/90Obp/nO0 HEBA== X-Received: by 10.194.62.176 with SMTP id z16mr2060557wjr.76.1402208710544; Sat, 07 Jun 2014 23:25:10 -0700 (PDT) Received: from bozhidar-mini.local ([93.123.71.105]) by mx.google.com with ESMTPSA id bj2sm7126689wib.3.2014.06.07.23.25.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 07 Jun 2014 23:25:09 -0700 (PDT) Received: by bozhidar-mini.local (Postfix, from userid 501) id 73BBD61172A; Sun, 8 Jun 2014 09:25:08 +0300 (EEST) From: Bozhidar Batsov Date: Sun, 08 Jun 2014 09:25:08 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) We've discussed with Dmitry before that the current use of font-lock-variable-name-face for things like `true`, `false` and `nil` is not correct semantically. Technically those are keywords in Ruby, but they are also constants (singleton instances of TrueClass, FalseClass, NilClass). In this respect they share a lot with symbols and I suggest using the `font-lock-constant-face` for them as well. I noticed that this is a practice adopted in several modes (rust-mode, swift-mode, clojure-mode, etc) and it seems pretty sensible to me. In GNU Emacs 24.4.50.1 (x86_64-apple-darwin13.1.0, NS apple-appkit-1265.19) of 2014-04-11 on bozhidar-mini.local Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --prefix=/usr/local/Cellar/emacs/HEAD --without-dbus --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/HEAD/share/info/emacs --with-gnutls --with-ns --disable-ns-self-contained' Configured features: ACL GNUTLS LIBXML2 ZLIB Important settings: locale-coding-system: utf-8-unix Major mode: Outline Minor modes in effect: goto-address-mode: t magit-auto-revert-mode: t erc-truncate-mode: t erc-spelling-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t global-flycheck-mode: t which-function-mode: t global-company-mode: t company-mode: t flx-ido-mode: t ido-ubiquitous-mode: t global-diff-hl-mode: t diff-hl-mode: t diff-auto-refine-mode: t winner-mode: t global-undo-tree-mode: t undo-tree-mode: t whitespace-mode: t global-anzu-mode: t anzu-mode: t projectile-global-mode: t projectile-mode: t flyspell-mode: t shell-dirtrack-mode: t volatile-highlights-mode: t global-hl-line-mode: t recentf-mode: t savehist-mode: t show-smartparens-global-mode: t show-smartparens-mode: t global-auto-revert-mode: t delete-selection-mode: t prelude-global-mode: t prelude-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t view-mode: t Recent input: M-< C-v C-n C-n C-n C-n C-n C-k C-x C-s C-x g C-n d q s c c R e m o v e SPC r e d u n d a t n SPC n t SPC r e q u i r e C-' e e a s y - m e n u s-/ SPC i s SPC a u t o l o a d e d . . C-c C-c P P s-g f o n t f o n t - l o c k - c o m m e n t C-l C-p = - ) _ C-+ ` 1 2 3 4 5 6 7 8 9 - = s-8 s-u 1 ` C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p M-f M-f M-b M-b C-b C-b C-b C-f C-f C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n M-x M-< C-g M-x r e p o r t Recent messages: [2014-06-08 01:00:09] `*magit-commit*' [42004 259200] [2014-06-08 01:00:09] `*Help*' [40565 3600] [2014-06-08 01:00:09] killing `*Help*' [2014-06-08 01:00:09] `*magit-log*' [40742 259200] [2014-06-08 01:00:09] `*magit-diff*' [40520 259200] [2014-06-08 01:00:09] `*Completions*' [39683 259200] (No files need saving) completing-read-default: Command attempted to use minibuffer while in minibuffer Quit (No files need saving) Load-path shadows: /Users/bozhidar/.emacs.d/elpa/tabulated-list-20120406.1351/tabulated-list hides /usr/local/Cellar/emacs/HEAD/share/emacs/24.4.50/lisp/emacs-lisp/tabulated-list Features: (tmm face-remap goto-addr crm clojure-test-mode cider-interaction arc-mode archive-mode cider-stacktrace cider-client nrepl-client cider-util clojure-mode-test clojure-mode-expansions clojure-mode inf-lisp find-dired cus-edit cus-start cus-load shadow sort mail-extr emacsbug sendmail jka-compr ielm cap-words superword subword ruby-tools inf-ruby ruby-mode-expansions smartparens-ruby ruby-mode eieio-opt speedbar sb-image ezimage dframe checkdoc hippie-exp make-mode ffap markdown-mode noutline outline mule-util misearch multi-isearch magit-key-mode magit view epa derived epg epg-config git-rebase-mode git-commit-mode server log-edit pcvs-util add-log easy-kill rainbow-mode color rainbow-delimiters elisp-slime-nav guru-mode prelude-xml nxml-mode-expansions html-mode-expansions sgml-mode smartparens-html rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok prelude-web prelude-shell sh-script smie executable prelude-scss prelude-scheme prelude-ruby prelude-perl prelude-org prelude-key-chord key-chord prelude-js prelude-erc erc-truncate erc-autoaway erc-spelling erc-notify erc-log erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat prelude-emacs-lisp prelude-css prelude-coffee prelude-clojure prelude-lisp prelude-c prelude-programming flycheck help-mode rx f which-func imenu prelude-company company-files company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-capf company-cmake company-ropemacs company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company prelude-ido smex flx-ido flx ido-ubiquitous ido prelude-osx exec-path-from-shell prelude-global-keybindings prelude-editor operate-on-number diff-hl vc-dir vc vc-dispatcher diff-mode winner undo-tree diff esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg eldoc esh-groups eshell esh-module esh-mode esh-util re-builder whitespace browse-kill-ring midnight ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff dired-x anzu projectile ibuf-ext ibuffer pkg-info grep s bookmark pp expand-region text-mode-expansions er-basic-expansions expand-region-core expand-region-custom flyspell ispell tramp tramp-compat tramp-loaddefs trampver shell pcomplete etags volatile-highlights hl-line windmove recentf tree-widget wid-edit savehist saveplace diminish smartparens-config smartparens autorevert filenotify delsel prelude-mode easy-mmode prelude-core epl pcase ov dash thingatpt prelude-custom prelude-ui zenburn-theme prelude-packages smartrep ert find-func ewoc debug tar-mode calc-bin calc-ext calc calc-loaddefs calc-macs makey edmacro kmacro warnings compile comint ansi-color ring ace-window ace-jump-mode advice autoload lisp-mnt vc-git mm-archive message dired format-spec rfc822 mml mml-sec mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils network-stream starttls url-http tls mail-parse rfc2231 rfc2047 rfc2045 ietf-drums url-gw url-cache url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source gnus-util mm-util help-fns mail-prsvr password-cache url-vars finder-inf eieio byte-opt bytecomp byte-compile cconv eieio-core info easymenu cl-macs gv package cl cl-loaddefs cl-lib time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 756046 603398) (symbols 48 50210 0) (miscs 40 5655 16177) (strings 32 118000 172997) (string-bytes 1 3236489) (vectors 16 107877) (vector-slots 8 3572504 257945) (floats 8 19156 7566) (intervals 56 39577 4539) (buffers 960 139)) From unknown Sat Aug 16 15:59:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bozhidar Batsov Subject: bug#17733: closed (Re: bug#17733: 24.4.50; [ruby-mode] Font-locking of true, false and nil) Message-ID: References: <86lhj79rkk.fsf@yandex.ru> X-Gnu-PR-Message: they-closed 17733 X-Gnu-PR-Package: emacs Reply-To: 17733@debbugs.gnu.org Date: Sun, 08 Mar 2015 20:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1425845582-12420-1" This is a multi-part message in MIME format... ------------=_1425845582-12420-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17733: 24.4.50; [ruby-mode] Font-locking of true, false and nil which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17733@debbugs.gnu.org. --=20 17733: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17733 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1425845582-12420-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17733-done) by debbugs.gnu.org; 8 Mar 2015 20:12:43 +0000 Received: from localhost ([127.0.0.1]:39785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUhZ4-0003Dn-HT for submit@debbugs.gnu.org; Sun, 08 Mar 2015 16:12:42 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35186) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YUhZ2-0003Da-Fq for 17733-done@debbugs.gnu.org; Sun, 08 Mar 2015 16:12:40 -0400 Received: by wibbs8 with SMTP id bs8so15313904wib.0 for <17733-done@debbugs.gnu.org>; Sun, 08 Mar 2015 13:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=UL9TeiO0NjFyliQCZ/A0vn4mskbb9AHySmteAvIYetE=; b=VASGkpLZqljJojXML73yALcZtDJtQTc9kC6qI72JJ/TbbJnmYNwNBcSPev3OAdYj1R UOUR/ab2JOL3zxG5WZm/m3+Fh58GXVxvkmb6HEiico3MotNzqCtBOzAEDPn9pg74Omom RumvbNZDlQ7TNdsH0KtR0y6u2Hm8BjUOvtNON+lOHPt7WzzkPOtQXAk+9HhR3GplP3U2 Har/4+1uOIumNd9r2OHrF4g8snrraEswdAkkZM6cLkQkUDh9z7xkCqCei5iHEalzhsHy fb9NTU9urzjWYyjUOXIDzJ+RH2yRG9W+WieAV9m5+GYvbkHIYBDbaCI2ECei+3gl/UTm P7tQ== X-Received: by 10.180.210.228 with SMTP id mx4mr86181304wic.71.1425845554888; Sun, 08 Mar 2015 13:12:34 -0700 (PDT) Received: from axl ([82.102.93.54]) by mx.google.com with ESMTPSA id gt4sm12370217wib.21.2015.03.08.13.12.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Mar 2015 13:12:34 -0700 (PDT) From: Dmitry Gutov To: Bozhidar Batsov Subject: Re: bug#17733: 24.4.50; [ruby-mode] Font-locking of true, false and nil References: Date: Sun, 08 Mar 2015 22:12:27 +0200 In-Reply-To: (Bozhidar Batsov's message of "Sun, 08 Jun 2014 09:25:08 +0300") Message-ID: <86lhj79rkk.fsf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17733-done Cc: 17733-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 25.1 Bozhidar Batsov writes: > In this respect they share a lot with symbols and I suggest > using the `font-lock-constant-face` for them as well. Pushed to master. Thanks. ------------=_1425845582-12420-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Jun 2014 06:25:52 +0000 Received: from localhost ([127.0.0.1]:40886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtWY9-0006dS-Ng for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40143) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtWY5-0006d4-Gr for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtWXr-0005jZ-9L for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_50, FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:59251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtWXq-0005jJ-I8 for submit@debbugs.gnu.org; Sun, 08 Jun 2014 02:25:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtWXh-0008La-61 for bug-gnu-emacs@gnu.org; Sun, 08 Jun 2014 02:25:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtWXY-0005cH-1V for bug-gnu-emacs@gnu.org; Sun, 08 Jun 2014 02:25:21 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:41347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtWXX-0005c5-LW for bug-gnu-emacs@gnu.org; Sun, 08 Jun 2014 02:25:11 -0400 Received: by mail-wg0-f41.google.com with SMTP id a1so955898wgh.0 for ; Sat, 07 Jun 2014 23:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Jp2OYjtwId5Lz3+rr9NF11NTmJ29fcdrKvAF7o/U+8U=; b=hkXo6A6OSeGLrmL8CTd0uWnJhqXB+5YreZQAak5y6SZAyou6CJF+C6X+ao7uY9K1Yc DacvOO1z+7P9IC8kTIwR/Wu8tuqg6PE0mdul4Ro0Gl+X4RZAwoB8pOGVm2I5GYPkPlPV m7slGN4gV75ObmmKGZSgtZ/K9JP9ulfU1OuM6p6hQdV3C8opiAyc8DQZP8BJsjSz0uPX Kg6sz8RDw5xwKpuP6QSFhf8e88WSTK67PAJnbTxHg39n2qTq9zNIIDZK/jbEmY8YCN8m rNd281zUUjICS+HDyMDkT/RpTNI2d6rAR6Gk9QVB4o7jAnH0ThQnx+f7eE/90Obp/nO0 HEBA== X-Received: by 10.194.62.176 with SMTP id z16mr2060557wjr.76.1402208710544; Sat, 07 Jun 2014 23:25:10 -0700 (PDT) Received: from bozhidar-mini.local ([93.123.71.105]) by mx.google.com with ESMTPSA id bj2sm7126689wib.3.2014.06.07.23.25.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 07 Jun 2014 23:25:09 -0700 (PDT) Received: by bozhidar-mini.local (Postfix, from userid 501) id 73BBD61172A; Sun, 8 Jun 2014 09:25:08 +0300 (EEST) From: Bozhidar Batsov To: bug-gnu-emacs@gnu.org Subject: 24.4.50; [ruby-mode] Font-locking of true, false and nil Date: Sun, 08 Jun 2014 09:25:08 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) We've discussed with Dmitry before that the current use of font-lock-variable-name-face for things like `true`, `false` and `nil` is not correct semantically. Technically those are keywords in Ruby, but they are also constants (singleton instances of TrueClass, FalseClass, NilClass). In this respect they share a lot with symbols and I suggest using the `font-lock-constant-face` for them as well. I noticed that this is a practice adopted in several modes (rust-mode, swift-mode, clojure-mode, etc) and it seems pretty sensible to me. In GNU Emacs 24.4.50.1 (x86_64-apple-darwin13.1.0, NS apple-appkit-1265.19) of 2014-04-11 on bozhidar-mini.local Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --prefix=/usr/local/Cellar/emacs/HEAD --without-dbus --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/HEAD/share/info/emacs --with-gnutls --with-ns --disable-ns-self-contained' Configured features: ACL GNUTLS LIBXML2 ZLIB Important settings: locale-coding-system: utf-8-unix Major mode: Outline Minor modes in effect: goto-address-mode: t magit-auto-revert-mode: t erc-truncate-mode: t erc-spelling-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t global-flycheck-mode: t which-function-mode: t global-company-mode: t company-mode: t flx-ido-mode: t ido-ubiquitous-mode: t global-diff-hl-mode: t diff-hl-mode: t diff-auto-refine-mode: t winner-mode: t global-undo-tree-mode: t undo-tree-mode: t whitespace-mode: t global-anzu-mode: t anzu-mode: t projectile-global-mode: t projectile-mode: t flyspell-mode: t shell-dirtrack-mode: t volatile-highlights-mode: t global-hl-line-mode: t recentf-mode: t savehist-mode: t show-smartparens-global-mode: t show-smartparens-mode: t global-auto-revert-mode: t delete-selection-mode: t prelude-global-mode: t prelude-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t view-mode: t Recent input: M-< C-v C-n C-n C-n C-n C-n C-k C-x C-s C-x g C-n d q s c c R e m o v e SPC r e d u n d a t n SPC n t SPC r e q u i r e C-' e e a s y - m e n u s-/ SPC i s SPC a u t o l o a d e d . . C-c C-c P P s-g f o n t f o n t - l o c k - c o m m e n t C-l C-p = - ) _ C-+ ` 1 2 3 4 5 6 7 8 9 - = s-8 s-u 1 ` C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p M-f M-f M-b M-b C-b C-b C-b C-f C-f C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n M-x M-< C-g M-x r e p o r t Recent messages: [2014-06-08 01:00:09] `*magit-commit*' [42004 259200] [2014-06-08 01:00:09] `*Help*' [40565 3600] [2014-06-08 01:00:09] killing `*Help*' [2014-06-08 01:00:09] `*magit-log*' [40742 259200] [2014-06-08 01:00:09] `*magit-diff*' [40520 259200] [2014-06-08 01:00:09] `*Completions*' [39683 259200] (No files need saving) completing-read-default: Command attempted to use minibuffer while in minibuffer Quit (No files need saving) Load-path shadows: /Users/bozhidar/.emacs.d/elpa/tabulated-list-20120406.1351/tabulated-list hides /usr/local/Cellar/emacs/HEAD/share/emacs/24.4.50/lisp/emacs-lisp/tabulated-list Features: (tmm face-remap goto-addr crm clojure-test-mode cider-interaction arc-mode archive-mode cider-stacktrace cider-client nrepl-client cider-util clojure-mode-test clojure-mode-expansions clojure-mode inf-lisp find-dired cus-edit cus-start cus-load shadow sort mail-extr emacsbug sendmail jka-compr ielm cap-words superword subword ruby-tools inf-ruby ruby-mode-expansions smartparens-ruby ruby-mode eieio-opt speedbar sb-image ezimage dframe checkdoc hippie-exp make-mode ffap markdown-mode noutline outline mule-util misearch multi-isearch magit-key-mode magit view epa derived epg epg-config git-rebase-mode git-commit-mode server log-edit pcvs-util add-log easy-kill rainbow-mode color rainbow-delimiters elisp-slime-nav guru-mode prelude-xml nxml-mode-expansions html-mode-expansions sgml-mode smartparens-html rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok prelude-web prelude-shell sh-script smie executable prelude-scss prelude-scheme prelude-ruby prelude-perl prelude-org prelude-key-chord key-chord prelude-js prelude-erc erc-truncate erc-autoaway erc-spelling erc-notify erc-log erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat prelude-emacs-lisp prelude-css prelude-coffee prelude-clojure prelude-lisp prelude-c prelude-programming flycheck help-mode rx f which-func imenu prelude-company company-files company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-capf company-cmake company-ropemacs company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company prelude-ido smex flx-ido flx ido-ubiquitous ido prelude-osx exec-path-from-shell prelude-global-keybindings prelude-editor operate-on-number diff-hl vc-dir vc vc-dispatcher diff-mode winner undo-tree diff esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg eldoc esh-groups eshell esh-module esh-mode esh-util re-builder whitespace browse-kill-ring midnight ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff dired-x anzu projectile ibuf-ext ibuffer pkg-info grep s bookmark pp expand-region text-mode-expansions er-basic-expansions expand-region-core expand-region-custom flyspell ispell tramp tramp-compat tramp-loaddefs trampver shell pcomplete etags volatile-highlights hl-line windmove recentf tree-widget wid-edit savehist saveplace diminish smartparens-config smartparens autorevert filenotify delsel prelude-mode easy-mmode prelude-core epl pcase ov dash thingatpt prelude-custom prelude-ui zenburn-theme prelude-packages smartrep ert find-func ewoc debug tar-mode calc-bin calc-ext calc calc-loaddefs calc-macs makey edmacro kmacro warnings compile comint ansi-color ring ace-window ace-jump-mode advice autoload lisp-mnt vc-git mm-archive message dired format-spec rfc822 mml mml-sec mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils network-stream starttls url-http tls mail-parse rfc2231 rfc2047 rfc2045 ietf-drums url-gw url-cache url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source gnus-util mm-util help-fns mail-prsvr password-cache url-vars finder-inf eieio byte-opt bytecomp byte-compile cconv eieio-core info easymenu cl-macs gv package cl cl-loaddefs cl-lib time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 756046 603398) (symbols 48 50210 0) (miscs 40 5655 16177) (strings 32 118000 172997) (string-bytes 1 3236489) (vectors 16 107877) (vector-slots 8 3572504 257945) (floats 8 19156 7566) (intervals 56 39577 4539) (buffers 960 139)) ------------=_1425845582-12420-1-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 00:14:33 2015 Received: (at control) by debbugs.gnu.org; 20 Mar 2015 04:14:33 +0000 Received: from localhost ([127.0.0.1]:58693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYoKP-0006ft-58 for submit@debbugs.gnu.org; Fri, 20 Mar 2015 00:14:33 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:33960) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYoKN-0006fg-MT for control@debbugs.gnu.org; Fri, 20 Mar 2015 00:14:32 -0400 Received: by wggv3 with SMTP id v3so79329552wgg.1 for ; Thu, 19 Mar 2015 21:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=v3h5n4dBgBxodMu2PAgOp6E9XyAxLBNjg6k+w+WO6tA=; b=sBTTzZFTenW6DB/CW4l1U+jsdKyHcOJFSdxg5+4Ju1s34SltcnCneAilxiQ5FWkMpI wqZtd9Mqq2iLMSvNo8cx9uZRxp5EQX+owERDVgy9L2tsFFbpavA2BwqtWOlRDX/5mxD7 QCUzNkMq370C9jUy1H+EAeJ6VXxPh9vKY4+8phi61oDdz1fyF5D5XfwTLRFxEn721anM o4k6Jzk0dOt4+m45qJH8qeQ5O2ONMLeh2a99kYdMpt33bFoCAZe0p3DKK0s2CmwydT1a o1wHrMN4IHwAsTykfQ0NTloIFGHKizFTuKLmkrSNAM8FfgwvNDx2x4r9MZdfAMaZoUAh 1iAA== X-Received: by 10.180.189.37 with SMTP id gf5mr21816513wic.86.1426824866052; Thu, 19 Mar 2015 21:14:26 -0700 (PDT) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id cf12sm4592654wjb.10.2015.03.19.21.14.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2015 21:14:25 -0700 (PDT) Message-ID: <550B9EA0.1030808@yandex.ru> Date: Fri, 20 Mar 2015 06:14:24 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: Change fixed-version Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 19285 24.5 close 17733 24.5 close 20026 24.5 thanks From unknown Sat Aug 16 15:59:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17733: Backported References: In-Reply-To: Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 04:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17733 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19285@debbugs.gnu.org, 17733@debbugs.gnu.org, 20026@debbugs.gnu.org Received: via spool by 17733-submit@debbugs.gnu.org id=B17733.142682511426105 (code B ref 17733); Fri, 20 Mar 2015 04:19:01 +0000 Received: (at 17733) by debbugs.gnu.org; 20 Mar 2015 04:18:34 +0000 Received: from localhost ([127.0.0.1]:58705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYoOI-0006ms-2q for submit@debbugs.gnu.org; Fri, 20 Mar 2015 00:18:34 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:35972) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYoOF-0006mU-DF; Fri, 20 Mar 2015 00:18:31 -0400 Received: by wibg7 with SMTP id g7so134651811wib.1; Thu, 19 Mar 2015 21:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=ol3hHFrpseWys97PWbaTkEyV7ElJf9D6FYAVJTiDKv8=; b=VC0Y8v5sIUlVpzRwBTbrwePKhJqPYDjhxbcq3ik9cF7Jt+5hniTcKx3vCcZK77hdbl fGVjPRxLc1/iBbTW2yFkSuHwlRe+id9oSeGfACyUYhTGa5q0ukFaTA2Z8b2bBzlJVDTX N/NGNXrnFflCuQtms6Rq+QHoZNMulfVD+TWkkxZ/wf9UKmjk+GqqGvXvAEHR11qP3w4o m4BV0M5L3lwcuwy51zJBnAhlhnTuaJNtSJHVSzpoPay/G0yJ+E6Ptfd/2q18fbVsT4Cw 8LtHqkjtQrTAOxiBLDfDXRtSVzlCuqAMMcYaUvQ7dgBcPijiMee9yIGxcolB6tbLUwiY Ld3g== X-Received: by 10.180.94.199 with SMTP id de7mr1977877wib.53.1426825105921; Thu, 19 Mar 2015 21:18:25 -0700 (PDT) Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id yr10sm4617205wjc.0.2015.03.19.21.18.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2015 21:18:25 -0700 (PDT) Message-ID: <550B9F90.6020603@yandex.ru> Date: Fri, 20 Mar 2015 06:18:24 +0200 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Also backported to emacs-24 (upcoming 24.5).