From unknown Mon Aug 18 14:26:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17722 <17722@debbugs.gnu.org> To: bug#17722 <17722@debbugs.gnu.org> Subject: Status: Makefile rule fix and cleanup patches Reply-To: bug#17722 <17722@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:26:23 +0000 retitle 17722 Makefile rule fix and cleanup patches reassign 17722 grep submitter 17722 Jim Meyering severity 17722 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 19:48:52 2014 Received: (at submit) by debbugs.gnu.org; 6 Jun 2014 23:48:52 +0000 Received: from localhost ([127.0.0.1]:39970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt3sR-0007JK-I4 for submit@debbugs.gnu.org; Fri, 06 Jun 2014 19:48:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57849) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt3sP-0007Iw-8g for submit@debbugs.gnu.org; Fri, 06 Jun 2014 19:48:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wt3sE-0001n7-QS for submit@debbugs.gnu.org; Fri, 06 Jun 2014 19:48:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wt3sE-0001mv-Md for submit@debbugs.gnu.org; Fri, 06 Jun 2014 19:48:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wt3sD-0007gH-Oa for bug-grep@gnu.org; Fri, 06 Jun 2014 19:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wt3sA-0001m7-Bk for bug-grep@gnu.org; Fri, 06 Jun 2014 19:48:37 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:39442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wt3sA-0001ll-1C for bug-grep@gnu.org; Fri, 06 Jun 2014 19:48:34 -0400 Received: by mail-wi0-f178.google.com with SMTP id cc10so1806905wib.5 for ; Fri, 06 Jun 2014 16:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=3VV7nF0uZb3xcMW2Tszdax+5PEQCpDDcuA3wWDQqFNQ=; b=QPV6UITzpm5x9YqhzO1oWUy4I5uqBiFRRt0oKstuQznsu287ChL+KcHwNcvM4EOF4F QJ+A2lD333QczbRW0JtcL4sMSRkYOLwoZJemtbIa9iWPSkKxzSdRVuebAXYUYcAZTocv BJURj2N7nEo9BRjDXQcedfppRba5HAm9J4va/JtNSEobbUXX9OXYPE/w704+qCtU5Yup ufemq5++2ssg83ktJgw+N/E2UmrJnOwlo2va7rDKKG+7FMgu6oTj/58V8u6kRp37Oiox hV/pORsC+TVR0crv5NUuBJ6QwWl2+671e+TWZqRtU3zQMUq75+amqD4bZmAui/x5Q+aq Qfrg== X-Received: by 10.194.21.103 with SMTP id u7mr11460814wje.14.1402098512187; Fri, 06 Jun 2014 16:48:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.34.226 with HTTP; Fri, 6 Jun 2014 16:48:12 -0700 (PDT) From: Jim Meyering Date: Fri, 6 Jun 2014 16:48:12 -0700 X-Google-Sender-Auth: GIm23hOdRplj3YqPsni_1bOaOZg Message-ID: Subject: Makefile rule fix and cleanup patches To: bug-grep@gnu.org Content-Type: multipart/mixed; boundary=047d7b5d571ec2698904fb337f91 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --047d7b5d571ec2698904fb337f91 Content-Type: text/plain; charset=ISO-8859-1 I nearly omitted the second, since using scripts for egrep and fgrep may be removed, but left it in on principle: set a good example. --047d7b5d571ec2698904fb337f91 Content-Type: application/octet-stream; name="0001-build-don-t-redirect-directly-to.patch" Content-Disposition: attachment; filename="0001-build-don-t-redirect-directly-to.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hw45720v0 RnJvbSBiOThjZjA2OWMzYjczMTFhNzI1NWUwM2MzYmM0OGVmZDc1MDBlOGRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCAyNCBNYXkgMjAxNCAyMjozNTowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBidWls ZDogZG9uJ3QgcmVkaXJlY3QgZGlyZWN0bHkgdG8gJEAKCiogbGliL01ha2VmaWxlLmFtIChjb2xv cml6ZS5jKTogRG9uJ3QgcmVkaXJlY3QgZGlyZWN0bHkgdG8gdGFyZ2V0LCAkQC4KT3RoZXJ3aXNl LCB3ZSBjb3VsZCBjcmVhdGUgYSBjb3JydXB0IGNvbG9yaXplLmMgZmlsZSB3aXRoIGEKdGltZXN0 YW1wIHRoYXQgaW5kaWNhdGVzIGl0IGlzIHVwIHRvIGRhdGUuCkFsc28sIG1ha2UgdGhlIGdlbmVy YXRlZCBmaWxlIHJlYWQtb25seS4KLS0tCiBsaWIvTWFrZWZpbGUuYW0gfCA1ICsrKystCiAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv bGliL01ha2VmaWxlLmFtIGIvbGliL01ha2VmaWxlLmFtCmluZGV4IGY5ZTU0NDQuLjliZDdiMGQg MTAwNjQ0Ci0tLSBhL2xpYi9NYWtlZmlsZS5hbQorKysgYi9saWIvTWFrZWZpbGUuYW0KQEAgLTM0 LDcgKzM0LDEwIEBAIGxpYmdyZXB1dGlsc19hX1NPVVJDRVMgKz0gY29sb3JpemUuaAogRVhUUkFf RElTVCArPSBjb2xvcml6ZS1wb3NpeC5jIGNvbG9yaXplLXczMi5jCiBDTEVBTkZJTEVTICs9IGNv bG9yaXplLmMKIGNvbG9yaXplLmM6Ci0JJChBTV9WX0dFTillY2hvICcjaW5jbHVkZSA8JChDT0xP UklaRV9TT1VSQ0UpPicgPiRACisJJChBTV9WX0dFTilybSAtZiAkQC10CisJJChBTV9WX2F0KWVj aG8gJyNpbmNsdWRlIDwkKENPTE9SSVpFX1NPVVJDRSk+JyA+JEAtdAorCSQoQU1fVl9hdCljaG1v ZCBhPXJ4ICRALXQKKwkkKEFNX1ZfYXQpbXYgJEAtdCAkQAoKIGxpYmdyZXB1dGlsc19hX0xJQkFE RCArPSAkKExJQk9CSlMpICQoQUxMT0NBKQogbGliZ3JlcHV0aWxzX2FfREVQRU5ERU5DSUVTICs9 ICQoTElCT0JKUykgJChBTExPQ0EpCi0tIAoyLjAuMC5yYzMKCg== --047d7b5d571ec2698904fb337f91 Content-Type: application/octet-stream; name="0002-build-improve-rule-to-generate-egrep-fgrep-scripts.patch" Content-Disposition: attachment; filename="0002-build-improve-rule-to-generate-egrep-fgrep-scripts.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hw4572181 RnJvbSA2ODViM2Y3M2Y3NWI1Y2U5NWVmNDY4ZGQ4MWQ0YTIzMDJlMmRlODJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCAyNCBNYXkgMjAxNCAyMjo0MToyMSAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBidWls ZDogaW1wcm92ZSBydWxlIHRvIGdlbmVyYXRlIGVncmVwK2ZncmVwIHNjcmlwdHMKCiogc3JjL01h a2VmaWxlLmFtIChlZ3JlcCBmZ3JlcCk6IGNobW9kIGE9cnggZ2VuZXJhdGVkIGZpbGVzLAphbmQg cmVtb3ZlICRALXQgYmVmb3JlIGF0dGVtcHRpbmcgdG8gcmVkaXJlY3QgdG8gaXQsIGluIGNhc2Ug aXQKaXMgcmVhZC1vbmx5LgotLS0KIHNyYy9NYWtlZmlsZS5hbSB8IDIxICsrKysrKysrKysrLS0t LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL3NyYy9NYWtlZmlsZS5hbSBiL3NyYy9NYWtlZmlsZS5hbQppbmRleCBl MmM4MmE0Li4wNjk3YzYzIDEwMDY0NAotLS0gYS9zcmMvTWFrZWZpbGUuYW0KKysrIGIvc3JjL01h a2VmaWxlLmFtCkBAIC00NSwxOSArNDUsMjAgQEAgQU1fQ1BQRkxBR1MgPSAtSSQodG9wX2J1aWxk ZGlyKS9saWIgLUkkKHRvcF9zcmNkaXIpL2xpYgogRVhUUkFfRElTVCA9IGRvc2J1Zi5jIGVncmVw LnNoCgogZWdyZXAgZmdyZXA6IGVncmVwLnNoIE1ha2VmaWxlCi0JJChBTV9WX0dFTilncmVwPWBl Y2hvIGdyZXAgfCBzZWQgLWUgJyQodHJhbnNmb3JtKSdgCSYmIFwKLQljYXNlICRAIGluIGVncmVw KSBvcHRpb249LUU7OyBmZ3JlcCkgb3B0aW9uPS1GOzsgZXNhYwkmJiBcCisJJChBTV9WX0dFTily bSAtZiAkQC10CisJJChBTV9WX2F0KWdyZXA9YGVjaG8gZ3JlcCB8IHNlZCAtZSAnJCh0cmFuc2Zv cm0pJ2AgJiYJCVwKKwljYXNlICRAIGluIGVncmVwKSBvcHRpb249LUU7OyBmZ3JlcCkgb3B0aW9u PS1GOzsgZXNhYyAmJglcCiAJc2hlbGxfZG9lc19zdWJzdHJpbmdzPSdzZXQgeC95ICYmIGQ9JCR7 MSUvKn0gJiYgdGVzdCAiJCRkIiA9IHgnICYmIFwKLQlpZiAkKFNIRUxMKSAtYyAiJCRzaGVsbF9k b2VzX3N1YnN0cmluZ3MiIDI+L2Rldi9udWxsOyB0aGVuIFwKLQkgIGVkaXRfc3Vic3RyaW5nPSdz LFgsWCwnOyBcCi0JZWxzZSBcCisJaWYgJChTSEVMTCkgLWMgIiQkc2hlbGxfZG9lc19zdWJzdHJp bmdzIiAyPi9kZXYvbnVsbDsgdGhlbglcCisJICBlZGl0X3N1YnN0cmluZz0ncyxYLFgsJzsJCQkJ CVwKKwllbHNlCQkJCQkJCQlcCiAJICBlZGl0X3N1YnN0cmluZz0ncyxcJCR7MCUvXCp9LGBleHBy ICJYJCQwIiA6ICdcJydYXFwoLipcXCkvJ1wnJ2AsZyc7IFwKLQlmaSAmJiBcCi0Jc2VkIC1lICdz fFtAXVNIRUxMQHwkKFNIRUxMKXxnJyBcCi0JICAgIC1lICIkJGVkaXRfc3Vic3RyaW5nIiBcCi0J ICAgIC1lICJzfFtAXWdyZXBAfCQkZ3JlcHxnIiBcCisJZmkgJiYJCQkJCQkJCVwKKwlzZWQgLWUg J3N8W0BdU0hFTExAfCQoU0hFTEwpfGcnCQkJCQlcCisJICAgIC1lICIkJGVkaXRfc3Vic3RyaW5n IgkJCQkJXAorCSAgICAtZSAic3xbQF1ncmVwQHwkJGdyZXB8ZyIJCQkJCVwKIAkgICAgLWUgInN8 W0Bdb3B0aW9uQHwkJG9wdGlvbnxnIiA8JChzcmNkaXIpL2VncmVwLnNoID4kQC10Ci0JJChBTV9W X2F0KWNobW9kICt4ICRALXQKKwkkKEFNX1ZfYXQpY2htb2QgYT1yeCAkQC10CiAJJChBTV9WX2F0 KW12ICRALXQgJEAKCiBDTEVBTkZJTEVTID0gZWdyZXAgZmdyZXAgKi10Ci0tIAoyLjAuMC5yYzMK Cg== --047d7b5d571ec2698904fb337f91-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 20:16:20 2014 Received: (at 17722) by debbugs.gnu.org; 7 Jun 2014 00:16:20 +0000 Received: from localhost ([127.0.0.1]:39977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt4J2-0008De-1q for submit@debbugs.gnu.org; Fri, 06 Jun 2014 20:16:20 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:36456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt4Iz-0008DO-Hw for 17722@debbugs.gnu.org; Fri, 06 Jun 2014 20:16:18 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id A9601A60014; Fri, 6 Jun 2014 17:16:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dLLJGgoEIlOi; Fri, 6 Jun 2014 17:16:03 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1EDD7A60003; Fri, 6 Jun 2014 17:16:03 -0700 (PDT) Message-ID: <539259C2.20009@cs.ucla.edu> Date: Fri, 06 Jun 2014 17:16:02 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Jim Meyering , 17722@debbugs.gnu.org Subject: Re: bug#17722: Makefile rule fix and cleanup patches References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17722 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Jim Meyering wrote: > using scripts for egrep and fgrep may be removed Let's not remove the scripts, as they're better on platforms where they're supported. Users of a script can more-easily understand and modify what it does, which is a better match for the GNU project's overarching goals. Instead, we should use scripts on GNUish platforms, and fall back on binary executables only on platforms that don't have a working shell. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 20:16:57 2014 Received: (at control) by debbugs.gnu.org; 7 Jun 2014 00:16:57 +0000 Received: from localhost ([127.0.0.1]:39980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt4Jc-0008F3-Lt for submit@debbugs.gnu.org; Fri, 06 Jun 2014 20:16:56 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:36470) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt4Ja-0008Ek-Po for control@debbugs.gnu.org; Fri, 06 Jun 2014 20:16:55 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 7A5C0A60014 for ; Fri, 6 Jun 2014 17:16:49 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZuVwyw9CBXW0 for ; Fri, 6 Jun 2014 17:16:41 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 00E80A60003 for ; Fri, 6 Jun 2014 17:16:40 -0700 (PDT) Message-ID: <539259E8.1070302@cs.ucla.edu> Date: Fri, 06 Jun 2014 17:16:40 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: close 17722 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) close 17722 thanks it's just an informative notice From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 21:56:20 2014 Received: (at 17722) by debbugs.gnu.org; 7 Jun 2014 01:56:20 +0000 Received: from localhost ([127.0.0.1]:39996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt5rn-0004GZ-Cq for submit@debbugs.gnu.org; Fri, 06 Jun 2014 21:56:19 -0400 Received: from mail-we0-f179.google.com ([74.125.82.179]:52485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt5rk-0004GC-A1 for 17722@debbugs.gnu.org; Fri, 06 Jun 2014 21:56:17 -0400 Received: by mail-we0-f179.google.com with SMTP id q59so3653687wes.10 for <17722@debbugs.gnu.org>; Fri, 06 Jun 2014 18:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=2P4NZQBrqhszDNIfa6clhcTfQ6R8UXpbHeK4gPvvBFc=; b=F8rvN9fjvsaBdajVFNSK6Rdz/QGPjWPePv4bg+8EiT092JqxNKvxqbWGE2VLNELwru 0tY0jAe/ThJBwpDrFKXdsNncLirnmuNhpsYNv6mCE+XajHnMFVDo/Swg4dmoZCFwNMG3 VCLmX/WWtVmvXLGvTtWY/Csi8s/Rd0bEfb6AyxB/Y1cTfVOp6rwm5FDLsXQx9KMQ1Ry4 2eHGPqxqCfg6+g18EFis5Nb4O6LW5YqLFFIHf3zmv8W/D8oT2YO1ULX/oDM+fWRrmqP4 ENqiK8EEvbjhScymibrXWFQV+aWynaFUSrT2srqvfsWilVXDXPaTt4MTaHO4nRwAPFk7 WeJw== X-Received: by 10.180.105.1 with SMTP id gi1mr9958936wib.30.1402106170350; Fri, 06 Jun 2014 18:56:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.34.226 with HTTP; Fri, 6 Jun 2014 18:55:49 -0700 (PDT) In-Reply-To: <539259C2.20009@cs.ucla.edu> References: <539259C2.20009@cs.ucla.edu> From: Jim Meyering Date: Fri, 6 Jun 2014 18:55:49 -0700 X-Google-Sender-Auth: 8nnENqOPtGbgGz7b5Y0aFlW4Nu8 Message-ID: Subject: Re: bug#17722: Makefile rule fix and cleanup patches To: Paul Eggert Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17722 Cc: 17722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Jun 6, 2014 at 5:16 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >> using scripts for egrep and fgrep may be removed > > > Let's not remove the scripts, as they're better on platforms where they're > supported. Users of a script can more-easily understand and modify what it > does, which is a better match for the GNU project's overarching goals. > > Instead, we should use scripts on GNUish platforms, and fall back on binary > executables only on platforms that don't have a working shell. That might fly: use the work-around (separate build rules) only where needed -- assuming the code changes end up being small and clean. Though if they're that small and clean, why wouldn't we want to keep the build rules simple and the same for everyone? IMHO, being able to look at the contents of obsolete wrapper scripts has no added value. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 07 02:57:01 2014 Received: (at 17722) by debbugs.gnu.org; 7 Jun 2014 06:57:01 +0000 Received: from localhost ([127.0.0.1]:40061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtAYm-00060x-Np for submit@debbugs.gnu.org; Sat, 07 Jun 2014 02:57:01 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:48070) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtAYk-00060j-0f for 17722@debbugs.gnu.org; Sat, 07 Jun 2014 02:56:59 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 980B2A60005; Fri, 6 Jun 2014 23:56:51 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f7Ced5UlZ8+0; Fri, 6 Jun 2014 23:56:46 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 8F9DFA60003; Fri, 6 Jun 2014 23:56:46 -0700 (PDT) Message-ID: <5392B7AE.4020502@cs.ucla.edu> Date: Fri, 06 Jun 2014 23:56:46 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#17722: Makefile rule fix and cleanup patches References: <539259C2.20009@cs.ucla.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17722 Cc: 17722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Jim Meyering wrote: > why wouldn't we want to keep the build rules simple and the same > for everyone? We wouldn't want to do that if it entailed bloated and opaque executables on all platforms, or if it entailed too-complicated C programs on all platforms. We should be able to avoid both problems. Perhaps we could supply a different build recipe for platforms that lack a working shell. Such platforms can't run shell scripts, after all, so maybe it would suffice to supply a text file or a comment containing build instructions for such platforms. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 07 07:15:17 2014 Received: (at 17722) by debbugs.gnu.org; 7 Jun 2014 11:15:17 +0000 Received: from localhost ([127.0.0.1]:40140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtEai-0006Fw-EK for submit@debbugs.gnu.org; Sat, 07 Jun 2014 07:15:17 -0400 Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:47356) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WtEaf-0006Fe-AP for 17722@debbugs.gnu.org; Sat, 07 Jun 2014 07:15:14 -0400 Received: from ppp14-2-27-84.lns21.adl2.internode.on.net (HELO [192.168.1.1]) ([14.2.27.84]) by ipmail05.adl6.internode.on.net with ESMTP; 07 Jun 2014 20:45:09 +0930 Message-ID: <5392F43A.20203@grouse.com.au> Date: Sat, 07 Jun 2014 20:45:06 +0930 From: behoffski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Paul Eggert , Jim Meyering Subject: Re: bug#17722: Makefile rule fix and cleanup patches References: <539259C2.20009@cs.ucla.edu> <5392B7AE.4020502@cs.ucla.edu> In-Reply-To: <5392B7AE.4020502@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17722 Cc: 17722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 06/07/14 16:26, Paul Eggert wrote: > Jim Meyering wrote: > >> why wouldn't we want to keep the build rules simple and the same >> for everyone? > > We wouldn't want to do that if it entailed bloated and opaque executables on all platforms, or if it entailed too-complicated C programs on all platforms. We should be able to avoid both problems. > > Perhaps we could supply a different build recipe for platforms that lack a working shell. Such platforms can't run shell scripts, after all, so maybe it would suffice to supply a text file or a comment containing build instructions for such platforms. > > I've already anticipated at least part of this in my untangle'd code, as the parser only knows about the lexer via two functions: lex () -- get the next lexical token; and exchange () -- Exchange information between the lexer and the parser, according to the opcodes defined in proto_lexparse.h: typedef enum proto_lexparse_opcode_enum { /* Possible future opcode: PROTO_LEXPARSE_OP_GET_LOCALE, entire locale from uselocale/duplocale */ PROTO_LEXPARSE_OP_GET_IS_MULTIBYTE_LOCALE, PROTO_LEXPARSE_OP_GET_REPMN_MIN, PROTO_LEXPARSE_OP_GET_REPMN_MAX, PROTO_LEXPARSE_OP_GET_WIDE_CHAR_LIST_MAX, PROTO_LEXPARSE_OP_GET_WIDE_CHARS, PROTO_LEXPARSE_OP_GET_DOTCLASS, PROTO_LEXPARSE_OP_GET_MBCSET, } proto_lexparse_opcode_t; The addresses of the lex and exchange functions are not known at link time; they are explicitly provided at runtime, via the function fsaparse_lexer in fsaparse.h. [The function description omits to mention the exchange parameter; this is a glitch on my part.] /* Receive a lexer function, plus lexer instance context pointer, for use by the parser. Although not needed initially, this plug-in architecture may be useful in the future, and it breaks up some of the intricate connections that made the original dfa.c code so daunting. */ extern void fsaparse_lexer (fsaparse_ctxt_t *parser, void *lexer_context, proto_lexparse_lex_fn_t *lex_fn, proto_lexparse_exchange_fn_t *lex_exchange_fn); It would be trivial to build a "fgrep-only" lexer module that merely fetches the next character in the input pattern (perhaps using mbrtowc), and return it as either a WCHAR list, as a "self-token", or as a charclass for case-folded unibyte chars. Some of the opcodes above (e.g. REPMN*, MBCSET) would become no-ops in the fgrep lexer, as it would never emit those tokens. At present, case folding for wide characters is handled via the WCHAR token allowing a list of equivalents to be specified alongside the original; the parser ORs these together in the parse tree. While the selection could be deferred until runtime (link both versions and bind when the parser/lexer link is established), the linker could be tailored to exclude the larger lexer (fsalex) in the fgrep version (including avoiding e.g. the parse_bracket_exp infrastructure). This leads to both easier-to-read code and a smaller executable. In the distant future, new tokens, such as: STRING STRING_CASE_INSENSITIVE WCHAR_STRING could be added as part of a rework of the token structure; in this case, the use of CAT in the parser could be reduced, and the work needed to extract "musts" from the tree could be reduced. However, I'd prefer to do this as part of a complete revamp of the token structure, not by tacking more options onto an existing structure. cheers, behoffski Programmer, Grouse Software From unknown Mon Aug 18 14:26:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Jul 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator