GNU bug report logs - #17720
24.3; EUDC LDAP duplicate mail handling broken.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17720 in the body.
You can then email your comments to 17720 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Raimund Berger" <raimund.berger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; EUDC LDAP duplicate mail handling broken.
Date: Fri, 06 Jun 2014 19:51:33 +0200

Hi there,

EUDC - and this seems to be a long standing issue - doesn't properly
recognize and handle LDAP entries that have multiple "mail" records.

Example: when having an LDAP entry with cn "John Doe" and two mail
records "john <at> a.com" "john <at> b.com" the corresponding inline expansion
LDAP call returns

 ((cn . "John Doe") (mail . "john <at> a.com") (mail . "john <at> b.com"))

given the setting
 (eudc-protocol-set 'eudc-inline-expansion-format '("%s <%s>" cn email) 'ldap)

and eudc-duplicate-attribute-handling-method having its default value
((email . duplicate)).

The above list is then passed into eudc-filter-duplicate-attributes,
which unfortunately fails to properly handle or even just recognize
those duplicate "mail" records. This failure then results into inline
expansion just inserting the first mail entry instead of offering a
selection between all available mail records, like it properly happens
with the bbdb backend for example.

Unfortunately, I don't know enough of elisp to maybe fix the issue
myself (all the mapcars, cdrs, etc make me dizzy). But it would be great
if this issue could be dealt with.

I've seen several complaints about this matter on the net btw, one
dating back to 2005. So it seems to be an old one.

Thanks, R.


In GNU Emacs 24.3.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10)
 of 2014-05-18 on gigli

Message #8 received at 17720 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>
To: "Raimund Berger" <raimund.berger <at> gmail.com>
Cc: 17720 <at> debbugs.gnu.org
Subject: Re: bug#17720: 24.3; EUDC LDAP duplicate mail handling broken.
Date: Wed, 24 Dec 2014 01:30:06 -0500

[Message part 1 (text/plain, inline)]

Hi Raimund,

Can you try this patch?

Thanks,
Thomas

[emacs-eudc-ldap-combine-mail-fields.patch (text/x-patch, attachment)]

Message #11 received at 17720 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>
To: "Raimund Berger" <raimund.berger <at> gmail.com>
Cc: 17720 <at> debbugs.gnu.org
Subject: Re: bug#17720: 24.3; EUDC LDAP duplicate mail handling broken.
Date: Thu, 05 Mar 2015 22:26:23 -0500

fixed 17720 25.1
thanks

I pushed a fix for this.

Thomas

Message #16 received at 17720-done <at> debbugs.gnu.org (full text, mbox):

From: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>
To: 17720-done <at> debbugs.gnu.org
Subject: 24.3; EUDC LDAP duplicate mail handling broken.
Date: Fri, 06 Mar 2015 03:05:46 -0500

This is fixed by the following commit:

commit bfebebbc72c6a6ea375c6e8ed7f8641b25439770
Author: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>
Date:   Thu Mar 5 21:53:37 2015 -0500

    Fix EUDC LDAP duplicate mail handling
    
    Fixes: debbugs:17720
    
    * net/eudcb-ldap.el (eudc-ldap-cleanup-record-simple): Mark as
    obsolete.
    (eudc-ldap-cleanup-record-filtering-addresses): Add docstring.
    Don't clean up postal addresses if ldap-ignore-attribute-codings
    is set.  Combine mail addresses into one field. (Bug#17720)
    (eudc-ldap-simple-query-internal): Call
    eudc-ldap-cleanup-record-filtering-addresses instead of
    eudc-ldap-cleanup-record-simple.
    (eudc-ldap-get-field-list): Likewise.

Closing.

Thomas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.