GNU bug report logs - #17715
[PATCH] dfa: build struct dfamust on demand

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: bug#17715: closed (Re: bug#17715: [PATCH] dfa: build struct
 dfamust on demand)
Date: Sun, 05 Jul 2015 00:19:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#17715: [PATCH] dfa: build struct dfamust on demand

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17715 <at> debbugs.gnu.org.

-- 
17715: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17715
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17715-done <at> debbugs.gnu.org, Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 4 Jul 2015 17:17:42 -0700

On Sat, Jul 4, 2015 at 2:51 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
>> Thanks for looking into this.
>>
>> One little thing I noticed while reading that patch.  dfaalloc could be
>> declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the
>> patch is applied.  I don't know if it's worth bothering to declaring it that
>> way, though, as I doubt it'd improve the quality of the generated code.
>> Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.
>
> Good idea. I prefer to add it, on principle.
> To permit that change, I'll move the inclusion of xalloc.h --
> the header that defines it -- from dfa.c to dfa.h.

Pushed with that change.

[Message part 3 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: build struct dfamust on demand
Date: Fri, 06 Jun 2014 22:36:31 +0900

[Message part 4 (text/plain, inline)]

If we don't use KWset, struct dfamust doesn't have to build.  This patch
make a change that it's built on demand.

[0001-dfa-build-struct-dfamust-on-demand.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.