GNU bug report logs - #17715
[PATCH] dfa: build struct dfamust on demand

Previous Next

Full log

Message #20 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17715 <at> debbugs.gnu.org, Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 4 Jul 2015 14:51:57 -0700

On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> Thanks for looking into this.
>
> One little thing I noticed while reading that patch.  dfaalloc could be
> declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the
> patch is applied.  I don't know if it's worth bothering to declaring it that
> way, though, as I doubt it'd improve the quality of the generated code.
> Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.

Good idea. I prefer to add it, on principle.
To permit that change, I'll move the inclusion of xalloc.h --
the header that defines it -- from dfa.c to dfa.h.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.