GNU bug report logs - #17715
[PATCH] dfa: build struct dfamust on demand

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Fri, 6 Jun 2014 13:38:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>, Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17715 <at> debbugs.gnu.org
Subject: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 04 Jul 2015 13:43:13 -0700
Thanks for looking into this.

One little thing I noticed while reading that patch.  dfaalloc could be declared 
with _GL_ATTRIBUTE_MALLOC; this is true both before and after the patch is 
applied.  I don't know if it's worth bothering to declaring it that way, though, 
as I doubt it'd improve the quality of the generated code.  Plus, 
_GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.




This bug report was last modified 10 years and 20 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.