From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 09:37:12 2014 Received: (at submit) by debbugs.gnu.org; 6 Jun 2014 13:37:12 +0000 Received: from localhost ([127.0.0.1]:46651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsuKT-0002An-Lt for submit@debbugs.gnu.org; Fri, 06 Jun 2014 09:37:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57036) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsuKQ-0002A8-9Z for submit@debbugs.gnu.org; Fri, 06 Jun 2014 09:37:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsuKC-0006Am-3a for submit@debbugs.gnu.org; Fri, 06 Jun 2014 09:37:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsuKC-0006Ai-0L for submit@debbugs.gnu.org; Fri, 06 Jun 2014 09:36:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsuK4-0000Kl-Aw for bug-grep@gnu.org; Fri, 06 Jun 2014 09:36:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsuJw-00064g-LB for bug-grep@gnu.org; Fri, 06 Jun 2014 09:36:44 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:43573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsuJv-00064H-VR for bug-grep@gnu.org; Fri, 06 Jun 2014 09:36:36 -0400 Received: from imp03 (mailgw7.kcn.ne.jp [61.86.15.238]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id AA56EE80025 for ; Fri, 6 Jun 2014 22:36:31 +0900 (JST) Received: from mail03.kcn.ne.jp ([61.86.6.182]) by imp03 with bizsmtp id B1cX1o00C3veGq5011cXNe; Fri, 06 Jun 2014 22:36:31 +0900 X-Direction: outbound X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.33] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail03.kcn.ne.jp (Postfix) with ESMTPA id 38FC0141009A for ; Fri, 6 Jun 2014 22:36:31 +0900 (JST) Date: Fri, 06 Jun 2014 22:36:31 +0900 From: Norihiro Tanaka To: bug-grep@gnu.org Subject: [PATCH] dfa: build struct dfamust on demand Message-Id: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5391C07F000000005F58_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_5391C07F000000005F58_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit If we don't use KWset, struct dfamust doesn't have to build. This patch make a change that it's built on demand. --------_5391C07F000000005F58_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-build-struct-dfamust-on-demand.patch" Content-Disposition: attachment; filename="0001-dfa-build-struct-dfamust-on-demand.patch" Content-Transfer-Encoding: base64 RnJvbSA0NDMyZGU1MGY4Y2ZmMDQ4NTAwNTc5NGUyZDEyMzQ4ZGU3Y2Y3ZTExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBGcmksIDYgSnVuIDIwMTQgMTk6MDg6MDggKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IGJ1aWxkIHN0cnVjdCBkZmFtdXN0IG9uIGRlbWFuZAoKSWYgd2UgZG9uJ3QgdXNlIEtXc2V0LCBz dHJ1Y3QgZGZhbXVzdCBkb2Vzbid0IGhhdmUgdG8gYnVpbGQuICBOb3cgaXQncwpidWlsdCBvbiBk ZW1hbmQuCiogc3JjL2RmYS5jIChzdHJ1Y3QgZGZhKTogUmVtb3ZlIGF0dHJpYnV0ZSBgbXVzdHMn LgooZGZhY29tcCk6IERvbid0IGJ1aWxkIGRmYW11c3QgaGVyZS4KKGRmYW11c3RmcmVlKTogTmV3 IGZ1bmN0aW9uIHRvIGRlYWxsb2NhdGUgYSBzdHJ1Y3QgZGZhbXVzdC4KKGRmYW11c3QpOiBBZHZh bmNlIGl0IHRvIHRoZSBnbG9iYWwgZnVuY3Rpb24sIGFuZCBpdCByZXR1cm5zIHN0cnVjdCBkZmFt dXN0LgooZGZhbXVzdHMpOiBSZW1vdmUgaXQuCiogc3JjL2RmYS5oIChkZmFtdXN0ZnJlZSk6IEFk ZCBwcm90b3R5cGUgZm9yIGl0LgooZGZhbXVzdCk6IEFkZCBwcm90b3R5cGUgZm9yIGl0LgooZGZh bXVzdHMpOiBSZW1vdmUgcHJvdG90eXBlIGZvciBpdC4KKiBzcmMvZGZhc2VhcmNoLmMgKGt3c211 c3RzKTogVXNlIG5ldyBpbnRlcmZhY2Ugb2YgZGZhLgotLS0KIHNyYy9kZmEuYyAgICAgICB8IDU5 ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiBzcmMvZGZhLmggICAgICAgfCAgOCArKysrKy0tLQogc3JjL2RmYXNlYXJjaC5jIHwgNjAgKysr KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAz IGZpbGVzIGNoYW5nZWQsIDU0IGluc2VydGlvbnMoKyksIDczIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL3NyYy9kZmEuYyBiL3NyYy9kZmEuYwppbmRleCA1MjJhMDI3Li5jZjBkOWFmIDEwMDY0 NAotLS0gYS9zcmMvZGZhLmMKKysrIGIvc3JjL2RmYS5jCkBAIC00MjAsOSArNDIwLDYgQEAgc3Ry dWN0IGRmYQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuZXdsaW5lIGlzIHN0 b3JlZCBzZXBhcmF0ZWx5IGFuZCBoYW5kbGVkCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGFzIGEgc3BlY2lhbCBjYXNlLiAgTmV3bGluZSBpcyBhbHNvIHVzZWQKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgYXMgYSBzZW50aW5lbCBhdCB0aGUgZW5kIG9mIHRo ZSBidWZmZXIuICAqLwotICBzdHJ1Y3QgZGZhbXVzdCAqbXVzdHM7ICAgICAgICAvKiBMaXN0IG9m IHN0cmluZ3MsIGF0IGxlYXN0IG9uZSBvZiB3aGljaAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpcyBrbm93biB0byBhcHBlYXIgaW4gYW55IHIuZS4gbWF0Y2hpbmcKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGhlIGRmYS4gICovCiAgIHBvc2l0aW9uX3Nl dCBtYl9mb2xsb3dzOwkvKiBGb2xsb3cgc2V0IGFkZGVkIGJ5IEFOWUNIQVIgYW5kL29yIE1CQ1NF VAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvbiBkZW1hbmQuICAqLwogICBp bnQgKm1iX21hdGNoX2xlbnM7ICAgICAgICAgICAvKiBBcnJheSBvZiBsZW5ndGggcmVkdWNlZCBi eSBBTllDSEFSIGFuZC9vcgpAQCAtNDM5LDcgKzQzNiw2IEBAIHN0cnVjdCBkZmEKICNkZWZpbmUg QUNDRVBUU19JTl9DT05URVhUKHByZXYsIGN1cnIsIHN0YXRlLCBkZmEpIFwKICAgU1VDQ0VFRFNf SU5fQ09OVEVYVCAoKGRmYSkuc3RhdGVzW3N0YXRlXS5jb25zdHJhaW50LCBwcmV2LCBjdXJyKQog Ci1zdGF0aWMgdm9pZCBkZmFtdXN0IChzdHJ1Y3QgZGZhICpkZmEpOwogc3RhdGljIHZvaWQgcmVn ZXhwICh2b2lkKTsKIAogc3RhdGljIHZvaWQKQEAgLTM1MjcsNyArMzUyMyw2IEBAIGRmYXNzYnVp bGQgKHN0cnVjdCBkZmEgKmQpCiAgIHN1cC0+ZmFpbHMgPSBOVUxMOwogICBzdXAtPnN1Y2Nlc3Mg PSBOVUxMOwogICBzdXAtPm5ld2xpbmVzID0gTlVMTDsKLSAgc3VwLT5tdXN0cyA9IE5VTEw7CiAK ICAgc3VwLT5jaGFyY2xhc3NlcyA9IHhubWFsbG9jIChzdXAtPmNhbGxvYywgc2l6ZW9mICpzdXAt PmNoYXJjbGFzc2VzKTsKICAgbWVtY3B5IChzdXAtPmNoYXJjbGFzc2VzLCBkLT5jaGFyY2xhc3Nl cywKQEAgLTM1OTEsNyArMzU4Niw2IEBAIGRmYWNvbXAgKGNoYXIgY29uc3QgKnMsIHNpemVfdCBs ZW4sIHN0cnVjdCBkZmEgKmQsIGludCBzZWFyY2hmbGFnKQogICBkZmFpbml0IChkKTsKICAgZGZh bWJjYWNoZSAoZCk7CiAgIGRmYXBhcnNlIChzLCBsZW4sIGQpOwotICBkZmFtdXN0IChkKTsKICAg ZGZhc3NidWlsZCAoZCk7CiAgIGRmYW9wdGltaXplIChkKTsKICAgZGZhYW5hbHl6ZSAoZCwgc2Vh cmNoZmxhZyk7CkBAIC0zNjA3LDcgKzM2MDEsNiBAQCB2b2lkCiBkZmFmcmVlIChzdHJ1Y3QgZGZh ICpkKQogewogICBzaXplX3QgaTsKLSAgc3RydWN0IGRmYW11c3QgKmRtLCAqbmRtOwogCiAgIGZy ZWUgKGQtPmNoYXJjbGFzc2VzKTsKICAgZnJlZSAoZC0+dG9rZW5zKTsKQEAgLTM2NDMsMTMgKzM2 MzYsNiBAQCBkZmFmcmVlIChzdHJ1Y3QgZGZhICpkKQogICAgICAgZnJlZSAoZC0+c3VjY2Vzcyk7 CiAgICAgfQogCi0gIGZvciAoZG0gPSBkLT5tdXN0czsgZG07IGRtID0gbmRtKQotICAgIHsKLSAg ICAgIG5kbSA9IGRtLT5uZXh0OwotICAgICAgZnJlZSAoZG0tPm11c3QpOwotICAgICAgZnJlZSAo ZG0pOwotICAgIH0KLQogICBpZiAoZC0+c3VwZXJzZXQpCiAgICAgZGZhZnJlZSAoZC0+c3VwZXJz ZXQpOwogfQpAQCAtMzY3MCw5ICszNjU2LDcgQEAgZGZhZnJlZSAoc3RydWN0IGRmYSAqZCkKICAg ICAgICAgc2VxdWVuY2VzIHRoYXQgbXVzdCBjb25zdGl0dXRlIHRoZSBtYXRjaCAoImlzIikKIAog ICAgV2hlbiB3ZSBnZXQgdG8gdGhlIHJvb3Qgb2YgdGhlIHRyZWUsIHdlIHVzZSBvbmUgb2YgdGhl IGxvbmdlc3Qgb2YgaXRzCi0gICBjYWxjdWxhdGVkICJpbiIgc2VxdWVuY2VzIGFzIG91ciBhbnN3 ZXIuICBUaGUgc2VxdWVuY2Ugd2UgZmluZCBpcyByZXR1cm5lZCBpbgotICAgZC0+bXVzdCAod2hl cmUgImQiIGlzIHRoZSBzaW5nbGUgYXJndW1lbnQgcGFzc2VkIHRvICJkZmFtdXN0Iik7Ci0gICB0 aGUgbGVuZ3RoIG9mIHRoZSBzZXF1ZW5jZSBpcyByZXR1cm5lZCBpbiBkLT5tdXN0bi4KKyAgIGNh bGN1bGF0ZWQgImluIiBzZXF1ZW5jZXMgYXMgb3VyIGFuc3dlci4KIAogICAgVGhlIHNlcXVlbmNl cyBjYWxjdWxhdGVkIGZvciB0aGUgdmFyaW91cyB0eXBlcyBvZiBub2RlIChpbiBwc2V1ZG8gQU5T SSBjKQogICAgYXJlIHNob3duIGJlbG93LiAgInAiIGlzIHRoZSBvcGVyYW5kIG9mIHVuYXJ5IG9w ZXJhdG9ycyAoYW5kIHRoZSBsZWZ0LWhhbmQKQEAgLTM4OTYsOCArMzg4MCw4IEBAIGZyZWVtdXN0 IChtdXN0ICptcCkKICAgZnJlZSAobXApOwogfQogCi1zdGF0aWMgdm9pZAotZGZhbXVzdCAoc3Ry dWN0IGRmYSAqZCkKK3N0cnVjdCBkZmFtdXN0ICoKK2RmYW11c3QgKHN0cnVjdCBkZmEgY29uc3Qg KmQpCiB7CiAgIG11c3QgKm1wID0gTlVMTDsKICAgY2hhciBjb25zdCAqcmVzdWx0ID0gIiI7CkBA IC00MDY3LDMwICs0MDUxLDI4IEBAIGRmYW11c3QgKHN0cnVjdCBkZmEgKmQpCiAgICAgICAgICAg ICAgIHQgPSBqOwogICAgICAgICAgICAgICB3aGlsZSAoKytqIDwgTk9UQ0hBUikKICAgICAgICAg ICAgICAgICBpZiAodHN0Yml0IChqLCAqY2NsKQotICAgICAgICAgICAgICAgICAgICAmJiAhIChj YXNlX2ZvbGQgJiYgIWQtPm11bHRpYnl0ZQorICAgICAgICAgICAgICAgICAgICAmJiAhIChjYXNl X2ZvbGQgJiYgTUJfQ1VSX01BWCA9PSAxCiAgICAgICAgICAgICAgICAgICAgICAgICAgICYmIHRv dXBwZXIgKGopID09IHRvdXBwZXIgKHQpKSkKICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICAgICAgICBpZiAoaiA8IE5PVENIQVIpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgICAgICB9CiAgICAgICAgICAgbXAtPmlzWzBdID0gbXAtPmxlZnRbMF0gPSBtcC0+cmlnaHRb MF0KLSAgICAgICAgICAgID0gY2FzZV9mb2xkICYmICFkLT5tdWx0aWJ5dGUgPyB0b3VwcGVyICh0 KSA6IHQ7CisgICAgICAgICAgICA9IGNhc2VfZm9sZCAmJiBNQl9DVVJfTUFYID09IDEgPyB0b3Vw cGVyICh0KSA6IHQ7CiAgICAgICAgICAgbXAtPmlzWzFdID0gbXAtPmxlZnRbMV0gPSBtcC0+cmln aHRbMV0gPSAnXDAnOwogICAgICAgICAgIG1wLT5pbiA9IGVubGlzdCAobXAtPmluLCBtcC0+aXMs IDEpOwogICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQogZG9uZToKLSAgaWYgKCpy ZXN1bHQpCi0gICAgewotICAgICAgZG0gPSB4bWFsbG9jIChzaXplb2YgKmRtKTsKLSAgICAgIGRt LT5leGFjdCA9IGV4YWN0OwotICAgICAgZG0tPmJlZ2xpbmUgPSBiZWdsaW5lOwotICAgICAgZG0t PmVuZGxpbmUgPSBlbmRsaW5lOwotICAgICAgZG0tPm11c3QgPSB4c3RyZHVwIChyZXN1bHQpOwot ICAgICAgZG0tPm5leHQgPSBkLT5tdXN0czsKLSAgICAgIGQtPm11c3RzID0gZG07Ci0gICAgfQor ICBpZiAoISpyZXN1bHQpCisgICAgcmV0dXJuIE5VTEw7CisKKyAgZG0gPSB4bWFsbG9jIChzaXpl b2YgKmRtKTsKKyAgZG0tPmV4YWN0ID0gZXhhY3Q7CisgIGRtLT5iZWdsaW5lID0gYmVnbGluZTsK KyAgZG0tPmVuZGxpbmUgPSBlbmRsaW5lOworICBkbS0+bXVzdCA9IHhzdHJkdXAgKHJlc3VsdCk7 CiAKICAgd2hpbGUgKG1wKQogICAgIHsKQEAgLTQwOTgsMTggKzQwODAsMjEgQEAgZG9uZToKICAg ICAgIGZyZWVtdXN0IChtcCk7CiAgICAgICBtcCA9IHByZXY7CiAgICAgfQorCisgIHJldHVybiBk bTsKIH0KIAotc3RydWN0IGRmYSAqCi1kZmFhbGxvYyAodm9pZCkKK3ZvaWQKK2RmYW11c3RmcmVl IChzdHJ1Y3QgZGZhbXVzdCAqZG0pCiB7Ci0gIHJldHVybiB4bWFsbG9jIChzaXplb2YgKHN0cnVj dCBkZmEpKTsKKyAgZnJlZSAoZG0tPm11c3QpOworICBmcmVlIChkbSk7CiB9CiAKLXN0cnVjdCBk ZmFtdXN0ICpfR0xfQVRUUklCVVRFX1BVUkUKLWRmYW11c3RzIChzdHJ1Y3QgZGZhIGNvbnN0ICpk KQorc3RydWN0IGRmYSAqCitkZmFhbGxvYyAodm9pZCkKIHsKLSAgcmV0dXJuIGQtPm11c3RzOwor ICByZXR1cm4geG1hbGxvYyAoc2l6ZW9mIChzdHJ1Y3QgZGZhKSk7CiB9CiAKIC8qIHZpbTpzZXQg c2hpZnR3aWR0aD0yOiAqLwpkaWZmIC0tZ2l0IGEvc3JjL2RmYS5oIGIvc3JjL2RmYS5oCmluZGV4 IGYzMGMzY2IuLmVkYjYzMjQgMTAwNjQ0Ci0tLSBhL3NyYy9kZmEuaAorKysgYi9zcmMvZGZhLmgK QEAgLTMwLDcgKzMwLDYgQEAgc3RydWN0IGRmYW11c3QKICAgYm9vbCBiZWdsaW5lOwogICBib29s IGVuZGxpbmU7CiAgIGNoYXIgKm11c3Q7Ci0gIHN0cnVjdCBkZmFtdXN0ICpuZXh0OwogfTsKIAog LyogVGhlIGRmYSBzdHJ1Y3R1cmUuIEl0IGlzIGNvbXBsZXRlbHkgb3BhcXVlLiAqLwpAQCAtNDMs OCArNDIsMTEgQEAgc3RydWN0IGRmYTsKICAgIGNhbGxpbmcgZGZhZnJlZSgpIG9uIGl0LiAqLwog ZXh0ZXJuIHN0cnVjdCBkZmEgKmRmYWFsbG9jICh2b2lkKTsKIAotLyogUmV0dXJuIHRoZSBkZmFt dXN0cyBhc3NvY2lhdGVkIHdpdGggYSBkZmEuICovCi1leHRlcm4gc3RydWN0IGRmYW11c3QgKmRm YW11c3RzIChzdHJ1Y3QgZGZhIGNvbnN0ICopOworLyogQnVpbGQgYW5kIHJldHVybiB0aGUgc3Ry dWN0IGRmYW11c3QgZnJvbSB0aGUgZ2l2ZW4gc3RydWN0IGRmYS4gKi8KK2V4dGVybiBzdHJ1Y3Qg ZGZhbXVzdCAqZGZhbXVzdCAoc3RydWN0IGRmYSBjb25zdCAqKTsKKworLyogRnJlZSB0aGUgc3Rv cmFnZSBoZWxkIGJ5IHRoZSBjb21wb25lbnRzIG9mIGEgc3RydWN0IGRmYW11c3QuICovCitleHRl cm4gdm9pZCBkZmFtdXN0ZnJlZSAoc3RydWN0IGRmYW11c3QgKik7CiAKIC8qIGRmYXN5bnRheCgp IHRha2VzIHRocmVlIGFyZ3VtZW50czsgdGhlIGZpcnN0IHNldHMgdGhlIHN5bnRheCBiaXRzIGRl c2NyaWJlZAogICAgZWFybGllciBpbiB0aGlzIGZpbGUsIHRoZSBzZWNvbmQgc2V0cyB0aGUgY2Fz ZS1mb2xkaW5nIGZsYWcsIGFuZCB0aGUKZGlmZiAtLWdpdCBhL3NyYy9kZmFzZWFyY2guYyBiL3Ny Yy9kZmFzZWFyY2guYwppbmRleCA3N2I0ZTNlLi5hZmU1NTE3IDEwMDY0NAotLS0gYS9zcmMvZGZh c2VhcmNoLmMKKysrIGIvc3JjL2RmYXNlYXJjaC5jCkBAIC04Niw0MSArODYsMzUgQEAgZGZhd2Fy biAoY2hhciBjb25zdCAqbWVzZykKIHN0YXRpYyB2b2lkCiBrd3NtdXN0cyAodm9pZCkKIHsKLSAg c3RydWN0IGRmYW11c3QgY29uc3QgKmRtID0gZGZhbXVzdHMgKGRmYSk7Ci0gIGlmIChkbSkKKyAg c3RydWN0IGRmYW11c3QgKmRtID0gZGZhbXVzdCAoZGZhKTsKKyAgaWYgKCFkbSkKKyAgICByZXR1 cm47CisgIGt3c2luaXQgKCZrd3NldCk7CisgIC8qIEZpcnN0LCB3ZSBjb21waWxlIGluIHRoZSBz dWJzdHJpbmdzIGtub3duIHRvIGJlIGV4YWN0CisgICAgIG1hdGNoZXMuICBUaGUga3dzZXQgbWF0 Y2hlciB3aWxsIHJldHVybiB0aGUgaW5kZXgKKyAgICAgb2YgdGhlIG1hdGNoaW5nIHN0cmluZyB0 aGF0IGl0IGNob29zZXMuICovCisgIGlmIChkbS0+ZXhhY3QpCiAgICAgewotICAgICAga3dzaW5p dCAoJmt3c2V0KTsKLSAgICAgIC8qIEZpcnN0LCB3ZSBjb21waWxlIGluIHRoZSBzdWJzdHJpbmdz IGtub3duIHRvIGJlIGV4YWN0Ci0gICAgICAgICBtYXRjaGVzLiAgVGhlIGt3c2V0IG1hdGNoZXIg d2lsbCByZXR1cm4gdGhlIGluZGV4Ci0gICAgICAgICBvZiB0aGUgbWF0Y2hpbmcgc3RyaW5nIHRo YXQgaXQgY2hvb3Nlcy4gKi8KLSAgICAgIGZvciAoOyBkbTsgZG0gPSBkbS0+bmV4dCkKLSAgICAg ICAgewotICAgICAgICAgIGlmICghZG0tPmV4YWN0KQotICAgICAgICAgICAgY29udGludWU7Ci0g ICAgICAgICAgKytrd3NldF9leGFjdF9tYXRjaGVzOwotICAgICAgICAgIHNpemVfdCBvbGRfbGVu ID0gc3RybGVuIChkbS0+bXVzdCk7Ci0gICAgICAgICAgc2l6ZV90IG5ld19sZW4gPSBvbGRfbGVu ICsgZG0tPmJlZ2xpbmUgKyBkbS0+ZW5kbGluZTsKLSAgICAgICAgICBjaGFyICptdXN0ID0geG1h bGxvYyAobmV3X2xlbik7Ci0gICAgICAgICAgY2hhciAqbXAgPSBtdXN0OwotICAgICAgICAgICpt cCA9IGVvbGJ5dGU7Ci0gICAgICAgICAgbXAgKz0gZG0tPmJlZ2xpbmU7Ci0gICAgICAgICAgYmVn bGluZSB8PSBkbS0+YmVnbGluZTsKLSAgICAgICAgICBtZW1jcHkgKG1wLCBkbS0+bXVzdCwgb2xk X2xlbik7Ci0gICAgICAgICAgaWYgKGRtLT5lbmRsaW5lKQotICAgICAgICAgICAgbXBbb2xkX2xl bl0gPSBlb2xieXRlOwotICAgICAgICAgIGt3c2luY3IgKGt3c2V0LCBtdXN0LCBuZXdfbGVuKTsK LSAgICAgICAgICBmcmVlIChtdXN0KTsKLSAgICAgICAgfQotICAgICAgLyogTm93LCB3ZSBjb21w aWxlIHRoZSBzdWJzdHJpbmdzIHRoYXQgd2lsbCByZXF1aXJlCi0gICAgICAgICB0aGUgdXNlIG9m IHRoZSByZWdleHAgbWF0Y2hlci4gICovCi0gICAgICBmb3IgKGRtID0gZGZhbXVzdHMgKGRmYSk7 IGRtOyBkbSA9IGRtLT5uZXh0KQotICAgICAgICB7Ci0gICAgICAgICAgaWYgKGRtLT5leGFjdCkK LSAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgIGt3c2luY3IgKGt3c2V0LCBkbS0+bXVz dCwgc3RybGVuIChkbS0+bXVzdCkpOwotICAgICAgICB9Ci0gICAgICBrd3NwcmVwIChrd3NldCk7 CisgICAgICArK2t3c2V0X2V4YWN0X21hdGNoZXM7CisgICAgICBzaXplX3Qgb2xkX2xlbiA9IHN0 cmxlbiAoZG0tPm11c3QpOworICAgICAgc2l6ZV90IG5ld19sZW4gPSBvbGRfbGVuICsgZG0tPmJl Z2xpbmUgKyBkbS0+ZW5kbGluZTsKKyAgICAgIGNoYXIgKm11c3QgPSB4bWFsbG9jIChuZXdfbGVu KTsKKyAgICAgIGNoYXIgKm1wID0gbXVzdDsKKyAgICAgICptcCA9IGVvbGJ5dGU7CisgICAgICBt cCArPSBkbS0+YmVnbGluZTsKKyAgICAgIGJlZ2xpbmUgfD0gZG0tPmJlZ2xpbmU7CisgICAgICBt ZW1jcHkgKG1wLCBkbS0+bXVzdCwgb2xkX2xlbik7CisgICAgICBpZiAoZG0tPmVuZGxpbmUpCisg ICAgICAgIG1wW29sZF9sZW5dID0gZW9sYnl0ZTsKKyAgICAgIGt3c2luY3IgKGt3c2V0LCBtdXN0 LCBuZXdfbGVuKTsKKyAgICAgIGZyZWUgKG11c3QpOwogICAgIH0KKyAgLyogTm93LCB3ZSBjb21w aWxlIHRoZSBzdWJzdHJpbmdzIHRoYXQgd2lsbCByZXF1aXJlCisgICAgIHRoZSB1c2Ugb2YgdGhl IHJlZ2V4cCBtYXRjaGVyLiAgKi8KKyAgZWxzZQorICAgIGt3c2luY3IgKGt3c2V0LCBkbS0+bXVz dCwgc3RybGVuIChkbS0+bXVzdCkpOworICBrd3NwcmVwIChrd3NldCk7CisgIGRmYW11c3RmcmVl IChkbSk7CiB9CiAKIHZvaWQKLS0gCjIuMC4wCgo= --------_5391C07F000000005F58_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 09:50:04 2014 Received: (at 17715) by debbugs.gnu.org; 6 Jun 2014 13:50:04 +0000 Received: from localhost ([127.0.0.1]:46688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsuWw-0002dD-PK for submit@debbugs.gnu.org; Fri, 06 Jun 2014 09:50:03 -0400 Received: from frenzy.freefriends.org ([66.54.153.139]:47797 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsuWt-0002ci-UB for 17715@debbugs.gnu.org; Fri, 06 Jun 2014 09:50:00 -0400 X-Envelope-From: arnold@skeeve.com Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.8/8.14.8) with ESMTP id s56DnwWx020643; Fri, 6 Jun 2014 07:49:58 -0600 Received: (from arnold@localhost) by freefriends.org (8.14.8/8.14.8/submit) id s56DnvpF020642; Fri, 6 Jun 2014 13:49:57 GMT From: arnold@skeeve.com Message-Id: <201406061349.s56DnvpF020642@freefriends.org> X-Authentication-Warning: frenzy.freefriends.org: arnold set sender to arnold@skeeve.com using -f Date: Fri, 06 Jun 2014 07:49:57 -0600 To: noritnk@kcn.ne.jp, 17715@debbugs.gnu.org Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> In-Reply-To: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17715 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Norihiro Tanaka wrote: > If we don't use KWset, struct dfamust doesn't have to build. This patch > make a change that it's built on demand. Gawk doesn't use KWset - does this patch affect gawk? Thanks, Arnold From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 10:44:43 2014 Received: (at 17715) by debbugs.gnu.org; 6 Jun 2014 14:44:43 +0000 Received: from localhost ([127.0.0.1]:47354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsvNp-0004dP-TI for submit@debbugs.gnu.org; Fri, 06 Jun 2014 10:44:43 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:35448) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsvNj-0004cu-Cy for 17715@debbugs.gnu.org; Fri, 06 Jun 2014 10:44:36 -0400 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 287186C1512 for <17715@debbugs.gnu.org>; Fri, 6 Jun 2014 23:44:28 +0900 (JST) Received: from mail07.kcn.ne.jp ([61.86.6.186]) by imp02 with bizsmtp id B2kU1o00240oyB9012kUzv; Fri, 06 Jun 2014 23:44:28 +0900 X-OrgRCPT: 17715@debbugs.gnu.org Received: from [10.120.1.33] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id E5E14D500B6; Fri, 6 Jun 2014 23:44:27 +0900 (JST) Date: Fri, 06 Jun 2014 23:44:27 +0900 From: Norihiro Tanaka To: arnold@skeeve.com Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand In-Reply-To: <201406061349.s56DnvpF020642@freefriends.org> References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> <201406061349.s56DnvpF020642@freefriends.org> Message-Id: <20140606234427.5F5D.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17715 Cc: 17715@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Arnold Robbins wrote: > Gawk doesn't use KWset - does this patch affect gawk? Yes, but it will be especially happy for Gawk. No longer dfamust() is called in Gawk after this change, because its output isn't be used anywhere even before the change. So a case that dfamust() is very slow as bug#17700 will speed-up. Thanks, Norihiro From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 14:43:26 2015 Received: (at 17715) by debbugs.gnu.org; 4 Jul 2015 18:43:26 +0000 Received: from localhost ([127.0.0.1]:39921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBSPN-00045N-E2 for submit@debbugs.gnu.org; Sat, 04 Jul 2015 14:43:26 -0400 Received: from mail-yk0-f181.google.com ([209.85.160.181]:35659) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBSPK-000455-JL for 17715@debbugs.gnu.org; Sat, 04 Jul 2015 14:43:24 -0400 Received: by ykfs198 with SMTP id s198so13780986ykf.2 for <17715@debbugs.gnu.org>; Sat, 04 Jul 2015 11:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=yFBwDalqFDQ5VsqLe+zAe1GyX9sDgVETQ8sQmj8AkS4=; b=nOUGc3Xm2kT/MlZ8ZilwNT3V4QNt6EybexQlg8YR37/8ihs7Rv4HnIzW3J1owmcqSq boUFGCb7j8f6mu25xaLebji0Hzw7teo9DchobbfCX3YcimeVp0XbLJVFqsNVucNejryZ HIqEWx2bu3b2am8r8bBHJ6xMojdyY2JsNOks0rFjO9ILU91hcbK0fn5Ikt++fefEdh6R +W/s5I/iJJe5FHmf4nc24+DflfwzOetn8oku+TeOMa6o9WqMuQfP4LwD6/sGgBKzgOqa locieF2Zv4yOu1u0NcaYt5BTzY284yJvql2W+5K+aYi02KDQNCVU0Ic1g6s32JyHXMjA j1zg== X-Received: by 10.129.84.4 with SMTP id i4mr36312150ywb.77.1436035396869; Sat, 04 Jul 2015 11:43:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Sat, 4 Jul 2015 11:42:57 -0700 (PDT) In-Reply-To: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Sat, 4 Jul 2015 11:42:57 -0700 X-Google-Sender-Auth: sdd3UnX535ldRgUD9Z7Q-WD7a8k Message-ID: Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=001a114d8584b73d27051a110bb7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17715 Cc: 17715@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a114d8584b73d27051a110bb7 Content-Type: text/plain; charset=UTF-8 On Fri, Jun 6, 2014 at 6:36 AM, Norihiro Tanaka wrote: > If we don't use KWset, struct dfamust doesn't have to build. This patch > make a change that it's built on demand. Thank you for that patch. I've adjusted the commit log as well as comments in dfasearch.c that have been inaccurate for some time. Here is the revised patch I will push later today or tomorrow: --001a114d8584b73d27051a110bb7 Content-Type: text/x-patch; charset=US-ASCII; name="0001-dfa-build-struct-dfamust-on-demand.patch" Content-Disposition: attachment; filename="0001-dfa-build-struct-dfamust-on-demand.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ibpec3dn1 RnJvbSBmNDFiMWJjZDU3ZWVlNTUwYWY0OWJkYmUzYTdhMjQzYTIxOGZhZjQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBGcmksIDYgSnVuIDIwMTQgMTk6MDg6MDggKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IGJ1aWxkIHN0cnVjdCBkZmFtdXN0IG9uIGRlbWFuZAoKSWYgd2Ugd29uJ3QgdXNlIEtXc2V0LCBk byBub3QgYnVpbGQgYSAic3RydWN0IGRmYW11c3QiLgpOb3cgaXQgaXMgYnVpbHQgb25seSB3aGVu IG5lZWRlZC4KKiBzcmMvZGZhLmMgKHN0cnVjdCBkZmEpIFttdXN0c106IFJlbW92ZSBtZW1iZXIu CihkZmFjb21wKTogRG9uJ3QgYnVpbGQgZGZhbXVzdCBoZXJlLgooZGZhbXVzdGZyZWUpOiBOZXcg ZnVuY3Rpb24gdG8gZnJlZSBhIHN0cnVjdCBkZmFtdXN0LgooZGZhbXVzdCk6IE1ha2UgaXQgYSBn bG9iYWwgZnVuY3Rpb24sIGFuZCBtYWtlIGl0IHJldHVybiBhIHBvaW50ZXIKdG8gYSBtYWxsb2Mn ZCBzdHJ1Y3QgZGZhbXVzdC4KKGRmYW11c3RzKTogUmVtb3ZlIGl0LgoqIHNyYy9kZmEuaCAoc3Ry dWN0IGRmYW11c3QpIFtuZXh0XTogUmVtb3ZlIG1lbWJlci4KSW4gdGhlIGltcGxlbWVudGF0aW9u IHByZWNlZGluZyB0aGlzIHBhdGNoLCB0aGVyZSB3YXMKbmV2ZXIgbW9yZSB0aGFuIG9uZSBvZiB0 aGVzZSBpbiBhIGdpdmVuICJzdHJ1Y3QgZGZhIi4KKGRmYW11c3RmcmVlLCBkZmFtdXN0KTogQWRk IHByb3RvdHlwZXMuCihkZmFtdXN0cyk6IFJlbW92ZSBwcm90b3R5cGUuCiogc3JjL2RmYXNlYXJj aC5jIChrd3NtdXN0cyk6IEFkYXB0IHRvIHVzZSB0aGUgbmV3IGludGVyZmFjZS4KVXBkYXRlIHRo ZSBjb21tZW50cyB0byByZWZsZWN0IHJlYWxpdHkuClRoaXMgYWRkcmVzc2VzIGh0dHA6Ly9idWdz LmdudS5vcmcvMTc3MTUKLS0tCiBzcmMvZGZhLmMgICAgICAgfCA2MCArKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiBzcmMvZGZhLmggICAgICAg fCAgOCArKysrKy0tLQogc3JjL2RmYXNlYXJjaC5jIHwgNjIgKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDU2 IGluc2VydGlvbnMoKyksIDc0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9kZmEuYyBi L3NyYy9kZmEuYwppbmRleCBjN2I2NTllLi45ZjAyNGJiIDEwMDY0NAotLS0gYS9zcmMvZGZhLmMK KysrIGIvc3JjL2RmYS5jCkBAIC00MjksOSArNDI5LDYgQEAgc3RydWN0IGRmYQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBhcyBhIHNlbnRpbmVsIGF0IHRoZSBlbmQgb2YgdGhl IGJ1ZmZlci4gICovCiAgIHN0YXRlX251bSBpbml0c3RhdGVfbGV0dGVyOyAgIC8qIEluaXRpYWwg c3RhdGUgZm9yIGxldHRlciBjb250ZXh0LiAgKi8KICAgc3RhdGVfbnVtIGluaXRzdGF0ZV9vdGhl cnM7ICAgLyogSW5pdGlhbCBzdGF0ZSBmb3Igb3RoZXIgY29udGV4dHMuICAqLwotICBzdHJ1Y3Qg ZGZhbXVzdCAqbXVzdHM7ICAgICAgICAvKiBMaXN0IG9mIHN0cmluZ3MsIGF0IGxlYXN0IG9uZSBv ZiB3aGljaAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpcyBrbm93biB0byBh cHBlYXIgaW4gYW55IHIuZS4gbWF0Y2hpbmcKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdGhlIGRmYS4gICovCiAgIHBvc2l0aW9uX3NldCBtYl9mb2xsb3dzOwkvKiBGb2xsb3cg c2V0IGFkZGVkIGJ5IEFOWUNIQVIgYW5kL29yIE1CQ1NFVAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBvbiBkZW1hbmQuICAqLwogICBpbnQgKm1iX21hdGNoX2xlbnM7ICAgICAg ICAgICAvKiBBcnJheSBvZiBsZW5ndGggcmVkdWNlZCBieSBBTllDSEFSIGFuZC9vcgpAQCAtNDQ4 LDcgKzQ0NSw2IEBAIHN0cnVjdCBkZmEKICNkZWZpbmUgQUNDRVBUU19JTl9DT05URVhUKHByZXYs IGN1cnIsIHN0YXRlLCBkZmEpIFwKICAgU1VDQ0VFRFNfSU5fQ09OVEVYVCAoKGRmYSkuc3RhdGVz W3N0YXRlXS5jb25zdHJhaW50LCBwcmV2LCBjdXJyKQoKLXN0YXRpYyB2b2lkIGRmYW11c3QgKHN0 cnVjdCBkZmEgKmRmYSk7CiBzdGF0aWMgdm9pZCByZWdleHAgKHZvaWQpOwoKIHN0YXRpYyB2b2lk CkBAIC0zNjQ3LDcgKzM2NDMsNiBAQCBkZmFzc2J1aWxkIChzdHJ1Y3QgZGZhICpkKQogICBzdXAt PmZhaWxzID0gTlVMTDsKICAgc3VwLT5zdWNjZXNzID0gTlVMTDsKICAgc3VwLT5uZXdsaW5lcyA9 IE5VTEw7Ci0gIHN1cC0+bXVzdHMgPSBOVUxMOwoKICAgc3VwLT5jaGFyY2xhc3NlcyA9IHhubWFs bG9jIChzdXAtPmNhbGxvYywgc2l6ZW9mICpzdXAtPmNoYXJjbGFzc2VzKTsKICAgaWYgKGQtPmNp bmRleCkKQEAgLTM3MTQsNyArMzcwOSw2IEBAIGRmYWNvbXAgKGNoYXIgY29uc3QgKnMsIHNpemVf dCBsZW4sIHN0cnVjdCBkZmEgKmQsIGludCBzZWFyY2hmbGFnKQogICBkZmFpbml0IChkKTsKICAg ZGZhbWJjYWNoZSAoZCk7CiAgIGRmYXBhcnNlIChzLCBsZW4sIGQpOwotICBkZmFtdXN0IChkKTsK ICAgZGZhc3NidWlsZCAoZCk7CiAgIGRmYW9wdGltaXplIChkKTsKICAgZGZhYW5hbHl6ZSAoZCwg c2VhcmNoZmxhZyk7CkBAIC0zNzMwLDcgKzM3MjQsNiBAQCB2b2lkCiBkZmFmcmVlIChzdHJ1Y3Qg ZGZhICpkKQogewogICBzaXplX3QgaTsKLSAgc3RydWN0IGRmYW11c3QgKmRtLCAqbmRtOwoKICAg ZnJlZSAoZC0+Y2hhcmNsYXNzZXMpOwogICBmcmVlIChkLT50b2tlbnMpOwpAQCAtMzc2NiwxMyAr Mzc1OSw2IEBAIGRmYWZyZWUgKHN0cnVjdCBkZmEgKmQpCiAgICAgICBmcmVlIChkLT5zdWNjZXNz KTsKICAgICB9CgotICBmb3IgKGRtID0gZC0+bXVzdHM7IGRtOyBkbSA9IG5kbSkKLSAgICB7Ci0g ICAgICBuZG0gPSBkbS0+bmV4dDsKLSAgICAgIGZyZWUgKGRtLT5tdXN0KTsKLSAgICAgIGZyZWUg KGRtKTsKLSAgICB9Ci0KICAgaWYgKGQtPnN1cGVyc2V0KQogICAgIGRmYWZyZWUgKGQtPnN1cGVy c2V0KTsKIH0KQEAgLTM3OTMsOSArMzc3OSw3IEBAIGRmYWZyZWUgKHN0cnVjdCBkZmEgKmQpCiAg ICAgICAgIHNlcXVlbmNlcyB0aGF0IG11c3QgY29uc3RpdHV0ZSB0aGUgbWF0Y2ggKCJpcyIpCgog ICAgV2hlbiB3ZSBnZXQgdG8gdGhlIHJvb3Qgb2YgdGhlIHRyZWUsIHdlIHVzZSBvbmUgb2YgdGhl IGxvbmdlc3Qgb2YgaXRzCi0gICBjYWxjdWxhdGVkICJpbiIgc2VxdWVuY2VzIGFzIG91ciBhbnN3 ZXIuICBUaGUgc2VxdWVuY2Ugd2UgZmluZCBpcyByZXR1cm5lZCBpbgotICAgZC0+bXVzdCAod2hl cmUgImQiIGlzIHRoZSBzaW5nbGUgYXJndW1lbnQgcGFzc2VkIHRvICJkZmFtdXN0Iik7Ci0gICB0 aGUgbGVuZ3RoIG9mIHRoZSBzZXF1ZW5jZSBpcyByZXR1cm5lZCBpbiBkLT5tdXN0bi4KKyAgIGNh bGN1bGF0ZWQgImluIiBzZXF1ZW5jZXMgYXMgb3VyIGFuc3dlci4KCiAgICBUaGUgc2VxdWVuY2Vz IGNhbGN1bGF0ZWQgZm9yIHRoZSB2YXJpb3VzIHR5cGVzIG9mIG5vZGUgKGluIHBzZXVkbyBBTlNJ IGMpCiAgICBhcmUgc2hvd24gYmVsb3cuICAicCIgaXMgdGhlIG9wZXJhbmQgb2YgdW5hcnkgb3Bl cmF0b3JzIChhbmQgdGhlIGxlZnQtaGFuZApAQCAtNDAxOSw4ICs0MDAzLDggQEAgZnJlZW11c3Qg KG11c3QgKm1wKQogICBmcmVlIChtcCk7CiB9Cgotc3RhdGljIHZvaWQKLWRmYW11c3QgKHN0cnVj dCBkZmEgKmQpCitzdHJ1Y3QgZGZhbXVzdCAqCitkZmFtdXN0IChzdHJ1Y3QgZGZhIGNvbnN0ICpk KQogewogICBtdXN0ICptcCA9IE5VTEw7CiAgIGNoYXIgY29uc3QgKnJlc3VsdCA9ICIiOwpAQCAt NDAyOSw3ICs0MDEzLDYgQEAgZGZhbXVzdCAoc3RydWN0IGRmYSAqZCkKICAgYm9vbCBleGFjdCA9 IGZhbHNlOwogICBib29sIGJlZ2xpbmUgPSBmYWxzZTsKICAgYm9vbCBlbmRsaW5lID0gZmFsc2U7 Ci0gIHN0cnVjdCBkZmFtdXN0ICpkbTsKCiAgIGZvciAocmkgPSAwOyByaSA8IGQtPnRpbmRleDsg KytyaSkKICAgICB7CkBAIC00MTkwLDMwICs0MTczLDI4IEBAIGRmYW11c3QgKHN0cnVjdCBkZmEg KmQpCiAgICAgICAgICAgICAgIHQgPSBqOwogICAgICAgICAgICAgICB3aGlsZSAoKytqIDwgTk9U Q0hBUikKICAgICAgICAgICAgICAgICBpZiAodHN0Yml0IChqLCAqY2NsKQotICAgICAgICAgICAg ICAgICAgICAmJiAhIChjYXNlX2ZvbGQgJiYgIWQtPm11bHRpYnl0ZQorICAgICAgICAgICAgICAg ICAgICAmJiAhIChjYXNlX2ZvbGQgJiYgTUJfQ1VSX01BWCA9PSAxCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICYmIHRvdXBwZXIgKGopID09IHRvdXBwZXIgKHQpKSkKICAgICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgICBpZiAoaiA8IE5PVENIQVIpCiAgICAgICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgbXAtPmlzWzBdID0gbXAtPmxlZnRb MF0gPSBtcC0+cmlnaHRbMF0KLSAgICAgICAgICAgID0gY2FzZV9mb2xkICYmICFkLT5tdWx0aWJ5 dGUgPyB0b3VwcGVyICh0KSA6IHQ7CisgICAgICAgICAgICA9IGNhc2VfZm9sZCAmJiBNQl9DVVJf TUFYID09IDEgPyB0b3VwcGVyICh0KSA6IHQ7CiAgICAgICAgICAgbXAtPmlzWzFdID0gbXAtPmxl ZnRbMV0gPSBtcC0+cmlnaHRbMV0gPSAnXDAnOwogICAgICAgICAgIG1wLT5pbiA9IGVubGlzdCAo bXAtPmluLCBtcC0+aXMsIDEpOwogICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQog ZG9uZToKLSAgaWYgKCpyZXN1bHQpCi0gICAgewotICAgICAgZG0gPSB4bWFsbG9jIChzaXplb2Yg KmRtKTsKLSAgICAgIGRtLT5leGFjdCA9IGV4YWN0OwotICAgICAgZG0tPmJlZ2xpbmUgPSBiZWds aW5lOwotICAgICAgZG0tPmVuZGxpbmUgPSBlbmRsaW5lOwotICAgICAgZG0tPm11c3QgPSB4c3Ry ZHVwIChyZXN1bHQpOwotICAgICAgZG0tPm5leHQgPSBkLT5tdXN0czsKLSAgICAgIGQtPm11c3Rz ID0gZG07Ci0gICAgfQorICBpZiAoISpyZXN1bHQpCisgICAgcmV0dXJuIE5VTEw7CisKKyAgc3Ry dWN0IGRmYW11c3QgKmRtID0geG1hbGxvYyAoc2l6ZW9mICpkbSk7CisgIGRtLT5leGFjdCA9IGV4 YWN0OworICBkbS0+YmVnbGluZSA9IGJlZ2xpbmU7CisgIGRtLT5lbmRsaW5lID0gZW5kbGluZTsK KyAgZG0tPm11c3QgPSB4c3RyZHVwIChyZXN1bHQpOwoKICAgd2hpbGUgKG1wKQogICAgIHsKQEAg LTQyMjEsMTggKzQyMDIsMjEgQEAgZG9uZToKICAgICAgIGZyZWVtdXN0IChtcCk7CiAgICAgICBt cCA9IHByZXY7CiAgICAgfQorCisgIHJldHVybiBkbTsKIH0KCi1zdHJ1Y3QgZGZhICoKLWRmYWFs bG9jICh2b2lkKQordm9pZAorZGZhbXVzdGZyZWUgKHN0cnVjdCBkZmFtdXN0ICpkbSkKIHsKLSAg cmV0dXJuIHhtYWxsb2MgKHNpemVvZiAoc3RydWN0IGRmYSkpOworICBmcmVlIChkbS0+bXVzdCk7 CisgIGZyZWUgKGRtKTsKIH0KCi1zdHJ1Y3QgZGZhbXVzdCAqX0dMX0FUVFJJQlVURV9QVVJFCi1k ZmFtdXN0cyAoc3RydWN0IGRmYSBjb25zdCAqZCkKK3N0cnVjdCBkZmEgKgorZGZhYWxsb2MgKHZv aWQpCiB7Ci0gIHJldHVybiBkLT5tdXN0czsKKyAgcmV0dXJuIHhtYWxsb2MgKHNpemVvZiAoc3Ry dWN0IGRmYSkpOwogfQoKIC8qIHZpbTpzZXQgc2hpZnR3aWR0aD0yOiAqLwpkaWZmIC0tZ2l0IGEv c3JjL2RmYS5oIGIvc3JjL2RmYS5oCmluZGV4IDlmOTU0MTUuLmU0YmViN2UgMTAwNjQ0Ci0tLSBh L3NyYy9kZmEuaAorKysgYi9zcmMvZGZhLmgKQEAgLTMwLDcgKzMwLDYgQEAgc3RydWN0IGRmYW11 c3QKICAgYm9vbCBiZWdsaW5lOwogICBib29sIGVuZGxpbmU7CiAgIGNoYXIgKm11c3Q7Ci0gIHN0 cnVjdCBkZmFtdXN0ICpuZXh0OwogfTsKCiAvKiBUaGUgZGZhIHN0cnVjdHVyZS4gSXQgaXMgY29t cGxldGVseSBvcGFxdWUuICovCkBAIC00Myw4ICs0MiwxMSBAQCBzdHJ1Y3QgZGZhOwogICAgY2Fs bGluZyBkZmFmcmVlKCkgb24gaXQuICovCiBleHRlcm4gc3RydWN0IGRmYSAqZGZhYWxsb2MgKHZv aWQpOwoKLS8qIFJldHVybiB0aGUgZGZhbXVzdHMgYXNzb2NpYXRlZCB3aXRoIGEgZGZhLiAqLwot ZXh0ZXJuIHN0cnVjdCBkZmFtdXN0ICpkZmFtdXN0cyAoc3RydWN0IGRmYSBjb25zdCAqKTsKKy8q IEJ1aWxkIGFuZCByZXR1cm4gdGhlIHN0cnVjdCBkZmFtdXN0IGZyb20gdGhlIGdpdmVuIHN0cnVj dCBkZmEuICovCitleHRlcm4gc3RydWN0IGRmYW11c3QgKmRmYW11c3QgKHN0cnVjdCBkZmEgY29u c3QgKik7CisKKy8qIEZyZWUgdGhlIHN0b3JhZ2UgaGVsZCBieSB0aGUgY29tcG9uZW50cyBvZiBh IHN0cnVjdCBkZmFtdXN0LiAqLworZXh0ZXJuIHZvaWQgZGZhbXVzdGZyZWUgKHN0cnVjdCBkZmFt dXN0ICopOwoKIC8qIGRmYXN5bnRheCgpIHRha2VzIHRocmVlIGFyZ3VtZW50czsgdGhlIGZpcnN0 IHNldHMgdGhlIHN5bnRheCBiaXRzIGRlc2NyaWJlZAogICAgZWFybGllciBpbiB0aGlzIGZpbGUs IHRoZSBzZWNvbmQgc2V0cyB0aGUgY2FzZS1mb2xkaW5nIGZsYWcsIGFuZCB0aGUKZGlmZiAtLWdp dCBhL3NyYy9kZmFzZWFyY2guYyBiL3NyYy9kZmFzZWFyY2guYwppbmRleCBjOGZjOTFiLi44Yjhh ZjA2IDEwMDY0NAotLS0gYS9zcmMvZGZhc2VhcmNoLmMKKysrIGIvc3JjL2RmYXNlYXJjaC5jCkBA IC04Niw0MSArODYsMzcgQEAgZGZhd2FybiAoY2hhciBjb25zdCAqbWVzZykKIHN0YXRpYyB2b2lk CiBrd3NtdXN0cyAodm9pZCkKIHsKLSAgc3RydWN0IGRmYW11c3QgY29uc3QgKmRtID0gZGZhbXVz dHMgKGRmYSk7Ci0gIGlmIChkbSkKKyAgc3RydWN0IGRmYW11c3QgKmRtID0gZGZhbXVzdCAoZGZh KTsKKyAgaWYgKCFkbSkKKyAgICByZXR1cm47CisgIGt3c2luaXQgKCZrd3NldCk7CisgIGlmIChk bS0+ZXhhY3QpCiAgICAgewotICAgICAga3dzaW5pdCAoJmt3c2V0KTsKLSAgICAgIC8qIEZpcnN0 LCB3ZSBjb21waWxlIGluIHRoZSBzdWJzdHJpbmdzIGtub3duIHRvIGJlIGV4YWN0Ci0gICAgICAg ICBtYXRjaGVzLiAgVGhlIGt3c2V0IG1hdGNoZXIgd2lsbCByZXR1cm4gdGhlIGluZGV4Ci0gICAg ICAgICBvZiB0aGUgbWF0Y2hpbmcgc3RyaW5nIHRoYXQgaXQgY2hvb3Nlcy4gKi8KLSAgICAgIGZv ciAoOyBkbTsgZG0gPSBkbS0+bmV4dCkKLSAgICAgICAgewotICAgICAgICAgIGlmICghZG0tPmV4 YWN0KQotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgKytrd3NldF9leGFjdF9tYXRj aGVzOwotICAgICAgICAgIHNpemVfdCBvbGRfbGVuID0gc3RybGVuIChkbS0+bXVzdCk7Ci0gICAg ICAgICAgc2l6ZV90IG5ld19sZW4gPSBvbGRfbGVuICsgZG0tPmJlZ2xpbmUgKyBkbS0+ZW5kbGlu ZTsKLSAgICAgICAgICBjaGFyICptdXN0ID0geG1hbGxvYyAobmV3X2xlbik7Ci0gICAgICAgICAg Y2hhciAqbXAgPSBtdXN0OwotICAgICAgICAgICptcCA9IGVvbGJ5dGU7Ci0gICAgICAgICAgbXAg Kz0gZG0tPmJlZ2xpbmU7Ci0gICAgICAgICAgYmVnbGluZSB8PSBkbS0+YmVnbGluZTsKLSAgICAg ICAgICBtZW1jcHkgKG1wLCBkbS0+bXVzdCwgb2xkX2xlbik7Ci0gICAgICAgICAgaWYgKGRtLT5l bmRsaW5lKQotICAgICAgICAgICAgbXBbb2xkX2xlbl0gPSBlb2xieXRlOwotICAgICAgICAgIGt3 c2luY3IgKGt3c2V0LCBtdXN0LCBuZXdfbGVuKTsKLSAgICAgICAgICBmcmVlIChtdXN0KTsKLSAg ICAgICAgfQotICAgICAgLyogTm93LCB3ZSBjb21waWxlIHRoZSBzdWJzdHJpbmdzIHRoYXQgd2ls bCByZXF1aXJlCi0gICAgICAgICB0aGUgdXNlIG9mIHRoZSByZWdleHAgbWF0Y2hlci4gICovCi0g ICAgICBmb3IgKGRtID0gZGZhbXVzdHMgKGRmYSk7IGRtOyBkbSA9IGRtLT5uZXh0KQotICAgICAg ICB7Ci0gICAgICAgICAgaWYgKGRtLT5leGFjdCkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAg ICAgICAgIGt3c2luY3IgKGt3c2V0LCBkbS0+bXVzdCwgc3RybGVuIChkbS0+bXVzdCkpOwotICAg ICAgICB9Ci0gICAgICBrd3NwcmVwIChrd3NldCk7CisgICAgICAvKiBQcmVwYXJlIGEgc3Vic3Ry aW5nIHdob3NlIHByZXNlbmNlIGltcGxpZXMgYSBtYXRjaC4KKyAgICAgICAgIFRoZSBrd3NldCBt YXRjaGVyIHdpbGwgcmV0dXJuIHRoZSBpbmRleCBvZiB0aGUgbWF0Y2hpbmcKKyAgICAgICAgIHN0 cmluZyB0aGF0IGl0IGNob29zZXMuICovCisgICAgICArK2t3c2V0X2V4YWN0X21hdGNoZXM7Cisg ICAgICBzaXplX3Qgb2xkX2xlbiA9IHN0cmxlbiAoZG0tPm11c3QpOworICAgICAgc2l6ZV90IG5l d19sZW4gPSBvbGRfbGVuICsgZG0tPmJlZ2xpbmUgKyBkbS0+ZW5kbGluZTsKKyAgICAgIGNoYXIg Km11c3QgPSB4bWFsbG9jIChuZXdfbGVuKTsKKyAgICAgIGNoYXIgKm1wID0gbXVzdDsKKyAgICAg ICptcCA9IGVvbGJ5dGU7CisgICAgICBtcCArPSBkbS0+YmVnbGluZTsKKyAgICAgIGJlZ2xpbmUg fD0gZG0tPmJlZ2xpbmU7CisgICAgICBtZW1jcHkgKG1wLCBkbS0+bXVzdCwgb2xkX2xlbik7Cisg ICAgICBpZiAoZG0tPmVuZGxpbmUpCisgICAgICAgIG1wW29sZF9sZW5dID0gZW9sYnl0ZTsKKyAg ICAgIGt3c2luY3IgKGt3c2V0LCBtdXN0LCBuZXdfbGVuKTsKKyAgICAgIGZyZWUgKG11c3QpOwor ICAgIH0KKyAgZWxzZQorICAgIHsKKyAgICAgIC8qIE90aGVyd2lzZSwgZmlsdGVyaW5nIHdpdGgg dGhpcyBzdWJzdHJpbmcgc2hvdWxkIGhlbHAgcmVkdWNlIHRoZQorICAgICAgICAgc2VhcmNoIHNw YWNlLCBidXQgd2UnbGwgc3RpbGwgaGF2ZSB0byB1c2UgdGhlIHJlZ2V4cCBtYXRjaGVyLiAgKi8K KyAgICAgIGt3c2luY3IgKGt3c2V0LCBkbS0+bXVzdCwgc3RybGVuIChkbS0+bXVzdCkpOwogICAg IH0KKyAga3dzcHJlcCAoa3dzZXQpOworICBkZmFtdXN0ZnJlZSAoZG0pOwogfQoKIHZvaWQKLS0g CjIuMy43Cgo= --001a114d8584b73d27051a110bb7-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 16:43:25 2015 Received: (at 17715) by debbugs.gnu.org; 4 Jul 2015 20:43:25 +0000 Received: from localhost ([127.0.0.1]:39980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBUHU-0007Wp-Ir for submit@debbugs.gnu.org; Sat, 04 Jul 2015 16:43:24 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52469) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBUHQ-0007WR-AO for 17715@debbugs.gnu.org; Sat, 04 Jul 2015 16:43:21 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 301AF1608D4; Sat, 4 Jul 2015 13:43:14 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YW7brvgoC6Dx; Sat, 4 Jul 2015 13:43:13 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 77BCC16091D; Sat, 4 Jul 2015 13:43:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NcvWxBVt4uwF; Sat, 4 Jul 2015 13:43:13 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5154D1608D4; Sat, 4 Jul 2015 13:43:13 -0700 (PDT) Message-ID: <55984561.2070405@cs.ucla.edu> Date: Sat, 04 Jul 2015 13:43:13 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jim Meyering , Norihiro Tanaka Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 17715 Cc: 17715@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Thanks for looking into this. One little thing I noticed while reading that patch. dfaalloc could be declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the patch is applied. I don't know if it's worth bothering to declaring it that way, though, as I doubt it'd improve the quality of the generated code. Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 17:52:25 2015 Received: (at 17715) by debbugs.gnu.org; 4 Jul 2015 21:52:25 +0000 Received: from localhost ([127.0.0.1]:40000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBVMG-00014L-HX for submit@debbugs.gnu.org; Sat, 04 Jul 2015 17:52:24 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]:33131) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBVME-000147-F7 for 17715@debbugs.gnu.org; Sat, 04 Jul 2015 17:52:23 -0400 Received: by ykdv136 with SMTP id v136so120667646ykd.0 for <17715@debbugs.gnu.org>; Sat, 04 Jul 2015 14:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=GQTmD/RTmG0Ub52uNLYMd61PuA1eQvx/C5LIhSCBSio=; b=ynG70C/xmoSA8cJLGiky+Rnce4+BiyGcXV1RQEe59zWAxbhGsW/CgAvC40NOjip5gm ZZA3ovcKNPK0JY2PytyHYeDlXefSZJ7KvQXdR2Xm2Kl/A1oBQIlKy5h95j61ysgCHXmz SZ9TKlitJKLvwzjuIplr1SRtb28mbORoxTrrZguj2yUaV4Zp0wTYmQsU6EXcDaC0UGFW 0T6Ilr0XQVaf+c+uH9PcNpDvk8dliPeVdeVQZMGSG6Snhp59Hi8YpYwOlv51/GLl1Kni 1LmSDWhTjkk7FUoEFUIOhOdnOQRpJ+0Dsql0sGinWor1ulzGBooQrlbHzm3EQ/54D6MJ dSEw== X-Received: by 10.13.226.145 with SMTP id l139mr48382867ywe.67.1436046736537; Sat, 04 Jul 2015 14:52:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Sat, 4 Jul 2015 14:51:57 -0700 (PDT) In-Reply-To: <55984561.2070405@cs.ucla.edu> References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> <55984561.2070405@cs.ucla.edu> From: Jim Meyering Date: Sat, 4 Jul 2015 14:51:57 -0700 X-Google-Sender-Auth: oYn4muwJV_qnYJD2qdvY9bdWmok Message-ID: Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand To: Paul Eggert Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17715 Cc: 17715@debbugs.gnu.org, Norihiro Tanaka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert wrote: > Thanks for looking into this. > > One little thing I noticed while reading that patch. dfaalloc could be > declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the > patch is applied. I don't know if it's worth bothering to declaring it that > way, though, as I doubt it'd improve the quality of the generated code. > Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now. Good idea. I prefer to add it, on principle. To permit that change, I'll move the inclusion of xalloc.h -- the header that defines it -- from dfa.c to dfa.h. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 20:18:11 2015 Received: (at 17715-done) by debbugs.gnu.org; 5 Jul 2015 00:18:11 +0000 Received: from localhost ([127.0.0.1]:40035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBXdK-0006g5-M9 for submit@debbugs.gnu.org; Sat, 04 Jul 2015 20:18:11 -0400 Received: from mail-yk0-f175.google.com ([209.85.160.175]:34366) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBXdI-0006fm-45 for 17715-done@debbugs.gnu.org; Sat, 04 Jul 2015 20:18:08 -0400 Received: by ykfy125 with SMTP id y125so121908908ykf.1 for <17715-done@debbugs.gnu.org>; Sat, 04 Jul 2015 17:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=l51xA1wA3NEcBmZUl85eh4DoyuS47KTCOpzdb3rBHKU=; b=TeUg/rMEKsMy6RlupXBDU7CoEZ/0zbVherot92WLGWiUIoAX981ypluXCMRlkbjtqV PaaZivXTdR2b0HgIMqckKaIHiHEabGzeqo+Nk6wJFtMqdZGhlFqpJtEylRP35vOArlBr OpvZWSFABuUY+HGs1ibMXbkgAFVOJVwkw0KoIiG0nUMLND1HAQNn6Zr5Mc9Bt79YV046 OSkOLjoYMbIEJZA62fTljbteJq4g60cf95RtRa7uBREaJT5uSbQP8+d7DXvknBXIkW6R 61+T03CGmVPKiOKm72Aj5ZHgq3C+gag3Fi+izkQXe9Fknr86+LiFVJ9Npdu0wcV1X1G/ shEQ== X-Received: by 10.170.190.203 with SMTP id h194mr9670112yke.110.1436055482457; Sat, 04 Jul 2015 17:18:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Sat, 4 Jul 2015 17:17:42 -0700 (PDT) In-Reply-To: References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> <55984561.2070405@cs.ucla.edu> From: Jim Meyering Date: Sat, 4 Jul 2015 17:17:42 -0700 X-Google-Sender-Auth: Wgz9RBGOFOZ92A3thTJ0wykDCyA Message-ID: Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand To: Paul Eggert Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17715-done Cc: 17715-done@debbugs.gnu.org, Norihiro Tanaka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Jul 4, 2015 at 2:51 PM, Jim Meyering wrote: > On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert wrote: >> Thanks for looking into this. >> >> One little thing I noticed while reading that patch. dfaalloc could be >> declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the >> patch is applied. I don't know if it's worth bothering to declaring it that >> way, though, as I doubt it'd improve the quality of the generated code. >> Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now. > > Good idea. I prefer to add it, on principle. > To permit that change, I'll move the inclusion of xalloc.h -- > the header that defines it -- from dfa.c to dfa.h. Pushed with that change. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 23:33:54 2015 Received: (at 17715) by debbugs.gnu.org; 5 Jul 2015 03:33:54 +0000 Received: from localhost ([127.0.0.1]:40065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBagk-0003ax-CX for submit@debbugs.gnu.org; Sat, 04 Jul 2015 23:33:54 -0400 Received: from freefriends.org ([96.88.95.60]:34666) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBagi-0003an-5g for 17715@debbugs.gnu.org; Sat, 04 Jul 2015 23:33:53 -0400 X-Envelope-From: arnold@skeeve.com Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.9/8.14.9) with ESMTP id t653XVCm016128; Sat, 4 Jul 2015 21:33:31 -0600 Received: (from arnold@localhost) by freefriends.org (8.14.9/8.14.9/submit) id t653XU3B016122; Sun, 5 Jul 2015 03:33:30 GMT From: arnold@skeeve.com Message-Id: <201507050333.t653XU3B016122@freefriends.org> X-Authentication-Warning: frenzy.freefriends.org: arnold set sender to arnold@skeeve.com using -f Date: Sat, 04 Jul 2015 21:33:30 -0600 To: jim@meyering.net, eggert@cs.ucla.edu Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> <55984561.2070405@cs.ucla.edu> In-Reply-To: User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17715 Cc: 17715@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Jim Meyering wrote: > On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert wrote: > > Thanks for looking into this. > > > > One little thing I noticed while reading that patch. dfaalloc could be > > declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the > > patch is applied. I don't know if it's worth bothering to declaring it that > > way, though, as I doubt it'd improve the quality of the generated code. > > Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now. > > Good idea. I prefer to add it, on principle. > To permit that change, I'll move the inclusion of xalloc.h -- > the header that defines it -- from dfa.c to dfa.h. > > Please don't. I'd prefer not to have to deal with having that symbol visible. Thanks, Arnold From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 04 23:53:28 2015 Received: (at 17715) by debbugs.gnu.org; 5 Jul 2015 03:53:28 +0000 Received: from localhost ([127.0.0.1]:40073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBazf-00048e-FT for submit@debbugs.gnu.org; Sat, 04 Jul 2015 23:53:27 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:33041) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBazd-00048O-H6 for 17715@debbugs.gnu.org; Sat, 04 Jul 2015 23:53:26 -0400 Received: by ykeo3 with SMTP id o3so2818611yke.0 for <17715@debbugs.gnu.org>; Sat, 04 Jul 2015 20:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=q3SO66CsprdTfkmGIK1mevY11pMNaFOn9X+luW8jMR4=; b=glUpJ6K0xYL2E/fUcDEHITGPfif/PkJRK6RxEO1nYMhd/QsMF2Xa/+DU81CqXe3D4p jmhRaDuZ/QZhRhsszN82VDyYoxx+GE34ZQbB3orLlILE4n36kfRZ7lZJnA8VLreCmtUS 1g2wFVAXFa8OWivl94/8v9DJnS1lqSMX1GPHltLVOBX0Bbuc72UgzqNpmgEcPwac8/Z3 sy9kQ6dXzzfs5DOmf3vLXrbCieGaaZ9YGUiAXEMlaBh+Vc8S84cTQvWwjgiUhQgaAZ7h leyHtt9WgmotABc6I/AY9b25rd5hJpQQV+Ad0KTtmtuMlehnM7hC8nTZ1QiUQnTu2IY/ gj0A== X-Received: by 10.13.226.145 with SMTP id l139mr49375913ywe.67.1436068400032; Sat, 04 Jul 2015 20:53:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Sat, 4 Jul 2015 20:53:00 -0700 (PDT) In-Reply-To: <201507050333.t653XU3B016122@freefriends.org> References: <20140606223624.5F54.27F6AC2D@kcn.ne.jp> <55984561.2070405@cs.ucla.edu> <201507050333.t653XU3B016122@freefriends.org> From: Jim Meyering Date: Sat, 4 Jul 2015 20:53:00 -0700 X-Google-Sender-Auth: Wl8zKcEwI_ltLDBTXjga0qqkl0s Message-ID: Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand To: Aharon Robbins Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17715 Cc: 17715@debbugs.gnu.org, Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Jul 4, 2015 at 8:33 PM, wrote: > Jim Meyering wrote: > >> On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert wrote: >> > Thanks for looking into this. >> > >> > One little thing I noticed while reading that patch. dfaalloc could be >> > declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the >> > patch is applied. I don't know if it's worth bothering to declaring it that >> > way, though, as I doubt it'd improve the quality of the generated code. >> > Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now. >> >> Good idea. I prefer to add it, on principle. >> To permit that change, I'll move the inclusion of xalloc.h -- >> the header that defines it -- from dfa.c to dfa.h. > > Please don't. I'd prefer not to have to deal with having that symbol > visible. How does making that symbol visible from gawk's dfa.h cause trouble? If it's an issue, just append an #undef at the end of your dfa.h. From unknown Wed Aug 20 03:38:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Aug 2015 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator