GNU bug report logs - #17700
[PATCH] dfa: speed-up for a pattern that many atoms are catenated

Previous Next

Full log

Message #31 received at 17700 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, arnold <at> skeeve.com
Cc: 17700 <at> debbugs.gnu.org
Subject: Re: bug#17700: [PATCH] dfa: speed-up for a pattern that many atoms
 are catenated
Date: Fri, 06 Jun 2014 07:25:40 -0700

Norihiro Tanaka wrote:
> BTW, even before make
> this change, dfamusts is terminated by NUL byte.

Yes, that's right, this patch doesn't affect whether the DFA code works 
correctly on NUL bytes.  There is a performance issue: if the pattern 
contains NUL bytes the DFA code doesn't operate as efficiently as it 
will does the pattern contains only non-NUL bytes.  But this performance 
issue is unaffected by the recent change.

It's low priority to fix the performance issue, but if we wanted to fix 
it among many other things we should use memmem instead of strstr.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.