GNU bug report logs - #17679
Wrong :type for `gnus-signature-limit'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17679 in the body.
You can then email your comments to 17679 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Samuel Bronson <naesten <at> gmail.com>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Wrong :type for `gnus-signature-limit'
Date: Tue, 03 Jun 2014 13:52:38 -0400

[Message part 1 (text/plain, inline)]

I see this in `gnus-art.el':

[Message part 2 (text/x-emacs-lisp, inline)]

(defcustom gnus-signature-limit nil
  "Provide a limit to what is considered a signature.
If it is a number, no signature may not be longer (in characters) than
that number.  If it is a floating point number, no signature may be
longer (in lines) than that number.  If it is a function, the function
will be called without any parameters, and if it returns nil, there is
no signature in the buffer.  If it is a string, it will be used as a
regexp.  If it matches, the text in question is not a signature.

This can also be a list of the above values."
  :type '(choice (const nil)
		 (integer :value 200)
		 (number :value 4.0)
		 function
		 (regexp :value ".*"))
  :group 'gnus-article-signature)

[Message part 3 (text/plain, inline)]

I can't help but notice that the :type neglects the case "This can also
be a list of the above values." from the docstring.

Gnus v5.13
GNU Emacs 24.3.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2013-12-22 on binet, modified by Debian

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!

Message #8 received at 17679 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Samuel Bronson <naesten <at> gmail.com>
Cc: 17679 <at> debbugs.gnu.org
Subject: Re: bug#17679: Wrong :type for `gnus-signature-limit'
Date: Wed, 25 Jan 2017 18:32:03 +0100

Samuel Bronson <naesten <at> gmail.com> writes:

> (defcustom gnus-signature-limit nil
>   "Provide a limit to what is considered a signature.
> If it is a number, no signature may not be longer (in characters) than
> that number.  If it is a floating point number, no signature may be
> longer (in lines) than that number.  If it is a function, the function
> will be called without any parameters, and if it returns nil, there is
> no signature in the buffer.  If it is a string, it will be used as a
> regexp.  If it matches, the text in question is not a signature.
>
> This can also be a list of the above values."
>   :type '(choice (const nil)
> 		 (integer :value 200)
> 		 (number :value 4.0)
> 		 function
> 		 (regexp :value ".*"))
>   :group 'gnus-article-signature)
>
> I can't help but notice that the :type neglects the case "This can also
> be a list of the above values." from the docstring.

OK; fixed in the Emacs master now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.