GNU bug report logs - #17677
gnus: confusing error message from `gnus-topic-unindent'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17677 in the body.
You can then email your comments to 17677 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Samuel Bronson <naesten <at> gmail.com>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: gnus: confusing error message from `gnus-topic-unindent'
Date: Tue, 03 Jun 2014 13:26:42 -0400

When I invoke `gnus-topic-unindent' and it can't see how to unindent the
topic any further, it says (e.g.) "Nothing to indent Gnus into".  This
rather confused me about the key handling at first, since (at least for
the first sub-topic) this is exactly the same message I get for
`gnus-topic-indent'. (Also for the top-level topic, but I doubt anyone
would seriously attempt to indent/unindent that?)

It's also not immediately obvious that the message makes any sense even
if you s/indent/unindent/, though upon reflection I guess it sort-of
does: there isn't exactly a grandparent or parent of the top-level topic
into which to move the top-level topic or its children, respectively.

Gnus v5.13
GNU Emacs 24.3.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2013-12-22 on binet, modified by Debian

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!

Message #8 received at 17677 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Samuel Bronson <naesten <at> gmail.com>
Cc: 17677 <at> debbugs.gnu.org
Subject: Re: bug#17677: gnus: confusing error message from
 `gnus-topic-unindent'
Date: Wed, 25 Jan 2017 18:28:08 +0100

Samuel Bronson <naesten <at> gmail.com> writes:

> When I invoke `gnus-topic-unindent' and it can't see how to unindent the
> topic any further, it says (e.g.) "Nothing to indent Gnus into".  This
> rather confused me about the key handling at first, since (at least for
> the first sub-topic) this is exactly the same message I get for
> `gnus-topic-indent'. (Also for the top-level topic, but I doubt anyone
> would seriously attempt to indent/unindent that?)

I've now changed the error message to:

     (unless grandparent
-      (error "Nothing to indent %s into" topic))
+      (error "Can't unindent %s further" topic))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.