GNU bug report logs - #17675
24.4.50; *gud* buffer keeps on getting buried

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Noam Postavsky <npostavs <at> gmail.com>, Michael Welsh Duggan <mwd <at> md5i.com>
Cc: 17675 <at> debbugs.gnu.org
Subject: bug#17675: 24.4.50; *gud* buffer keeps on getting buried
Date: Mon, 21 May 2018 08:49:57 +0200

>> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
>> index 24d5469..71dc574 100644
>> --- a/lisp/progmodes/gud.el
>> +++ b/lisp/progmodes/gud.el
>> @@ -2603,7 +2603,12 @@ comint mode, which see."
>>   		      file-subst)))
>>   	 (filepart (and file-word (concat "-" (file-name-nondirectory file))))
>>   	 (existing-buffer (get-buffer (concat "*gud" filepart "*"))))
>> -    (switch-to-buffer (concat "*gud" filepart "*"))
>> +    (select-window
>
> Is this select-window call neeeded?

Yes because 'display-buffer' does not select the window it uses.

>> +      (display-buffer
>> +       (get-buffer-create (concat "*gud" filepart "*"))
>> +       '(display-buffer-reuse-window
>> +         display-buffer-in-previous-window
>> +         display-buffer-same-window display-buffer-pop-up-window)))
>>       (when (and existing-buffer (get-buffer-process existing-buffer))
>>         (error "This program is already being debugged"))
>>       ;; Set the dir, in case the buffer already existed with a different dir.
>
> Martin, I see the switch-to-buffer is still present in master now,
> should it be fixed?

If you think that this might solve Bug#22374, I'd go for it.  Can you
explain how it solves that bug?

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.