From unknown Sat Sep 13 02:39:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17668 <17668@debbugs.gnu.org> To: bug#17668 <17668@debbugs.gnu.org> Subject: Status: [PATCH] build: be more specific about .git directory before enabling warnings Reply-To: bug#17668 <17668@debbugs.gnu.org> Date: Sat, 13 Sep 2025 09:39:41 +0000 retitle 17668 [PATCH] build: be more specific about .git directory before e= nabling warnings reassign 17668 coreutils submitter 17668 Ben Walton severity 17668 normal tag 17668 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 02 11:34:34 2014 Received: (at submit) by debbugs.gnu.org; 2 Jun 2014 15:34:34 +0000 Received: from localhost ([127.0.0.1]:41035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrUFt-00046G-Aa for submit@debbugs.gnu.org; Mon, 02 Jun 2014 11:34:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57877) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrO1j-0008JZ-Gp for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:55:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrO1W-0004Ks-Bf for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:55:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, URIBL_BLACK autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrO1W-0004Ko-9F for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:55:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrO1P-0005vk-Em for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:55:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrO1H-00048f-9r for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:55:11 -0400 Received: from jimi.chass.utoronto.ca ([128.100.160.32]:50801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrO1H-00045f-5Q for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:55:03 -0400 Received: from hendrix.chass.utoronto.ca ([128.100.160.33]:39244 ident=93) by jimi.chass.utoronto.ca with esmtp (Exim 4.76) (envelope-from ) id 1WrO1E-0005AZ-Qj ; Mon, 02 Jun 2014 04:55:00 -0400 Received: from 86-42-132-190-dynamic.b-ras1.bbh.dublin.eircom.net ([86.42.132.190]:32789 helo=neilyoung) (auth info: dovecot_plain:bwalton@chass.utoronto.ca) by hendrix.chass.utoronto.ca with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1WrO1C-0003wA-FK ; Mon, 02 Jun 2014 04:54:58 -0400 Received: from bwalton by neilyoung with local (Exim 4.82) (envelope-from ) id 1WrO1E-0005sn-24; Mon, 02 Jun 2014 09:55:00 +0100 From: Ben Walton To: bug-coreutils@gnu.org Subject: [PATCH] build: be more specific about .git directory before enabling warnings Date: Mon, 2 Jun 2014 09:54:56 +0100 Message-Id: <1401699296-22582-1-git-send-email-bdwalton@gmail.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 02 Jun 2014 11:34:29 -0400 Cc: Ben Walton , P@draigbrady.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * configure.ac: When looking for a .git checkout, restrict it to git checkouts that contain a coreutils-specific tag. Signed-off-by: Ben Walton --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index a7a8bfc..96af9be 100644 --- a/configure.ac +++ b/configure.ac @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings], # we're running from a git repo, then auto enable the warnings. gl_gcc_warnings=no gl_GCC_VERSION_IFELSE([4], [6], - [test -d "$srcdir"/.git && gl_gcc_warnings=yes])] + [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])] ) if test "$gl_gcc_warnings" = yes; then -- 1.9.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 02 12:31:19 2014 Received: (at 17668) by debbugs.gnu.org; 2 Jun 2014 16:31:19 +0000 Received: from localhost ([127.0.0.1]:41101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrV8k-00061P-Oz for submit@debbugs.gnu.org; Mon, 02 Jun 2014 12:31:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20687) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrV8e-000614-N7 for 17668@debbugs.gnu.org; Mon, 02 Jun 2014 12:31:12 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s52GV36F025683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Jun 2014 12:31:04 -0400 Received: from [10.3.113.133] (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s52GV39T029117; Mon, 2 Jun 2014 12:31:03 -0400 Message-ID: <538CA6C7.2060803@redhat.com> Date: Mon, 02 Jun 2014 10:31:03 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Ben Walton , 17668@debbugs.gnu.org Subject: Re: bug#17668: [PATCH] build: be more specific about .git directory before enabling warnings References: <1401699296-22582-1-git-send-email-bdwalton@gmail.com> In-Reply-To: <1401699296-22582-1-git-send-email-bdwalton@gmail.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C2pBWMPwJC11UF8C4cBXA9jkKGuPmBpS1" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 17668 Cc: P@draigbrady.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C2pBWMPwJC11UF8C4cBXA9jkKGuPmBpS1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/02/2014 02:54 AM, Ben Walton wrote: > * configure.ac: When looking for a .git checkout, restrict it to git > checkouts that contain a coreutils-specific tag. >=20 > Signed-off-by: Ben Walton > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/configure.ac b/configure.ac > index a7a8bfc..96af9be 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings], > # we're running from a git repo, then auto enable the warnings. > gl_gcc_warnings=3Dno > gl_GCC_VERSION_IFELSE([4], [6], > - [test -d "$srcdir"/.git && gl_gcc_warnings=3D= yes])] > + [test -f "$srcdir"/.git/refs/tags/v8.22 && gl= _gcc_warnings=3Dyes])] NACK. Git can compress tags to reside in other locations than =2Egit/refs/tags (run 'git gc --aggressive' for example). The idea of testing for coreutils.git has merit, but you need to come up with a more robust test. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --C2pBWMPwJC11UF8C4cBXA9jkKGuPmBpS1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjKbHAAoJEKeha0olJ0NqFv8H/RnH66iGaOZ01Ioqi2GybUXO 99U6akcHW8e0+niBpWGUw0nPEp5F7q1pOEkM1KaKfL4cOft73DGjGDbgJRsUlSeB ktOizkXIHnrOri2XOZ+dq+CC76HlITQpTnD5//pe9kFXzHmuDS1D7awH/efxbT9w NxceJ5xcRt4GSskSK/MD0eqNsdm2pAWPg889+nZfliN/9jCIdYL7qjgRVUt+HQQp 8mpuyj1w5YqXOba2GtLJ+Cyzi3Ho3DpWuHNfhtf//Yd9m38I1+cR2l0ZYq0FUVm5 Vbl5q4N3DWUDehnRbTOhD/zVi0QbTkoClIbow00d1A6pEchY0kQmbenWhAWtSBk= =YGcJ -----END PGP SIGNATURE----- --C2pBWMPwJC11UF8C4cBXA9jkKGuPmBpS1-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 02 13:47:03 2014 Received: (at 17668-done) by debbugs.gnu.org; 2 Jun 2014 17:47:03 +0000 Received: from localhost ([127.0.0.1]:41192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrWK3-0008Lm-4e for submit@debbugs.gnu.org; Mon, 02 Jun 2014 13:47:03 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:12508) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrWJx-0008LT-2E for 17668-done@debbugs.gnu.org; Mon, 02 Jun 2014 13:46:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApUBAL63jFNtTC0B/2dsb2JhbAANTINZg0S/bQGBK4MZAQEBBCMPAUYQCw0BCgICBRYLAgIJAwIBAgEPNgYNAQUCAQGIKgMWqWh3nlENhgQXgSqLEoEyZAeCdYFLAQOYBwGDNoVYhiSHa4FBgWw Received: from unknown (HELO [192.168.1.79]) ([109.76.45.1]) by mail2.vodafone.ie with ESMTP; 02 Jun 2014 18:46:46 +0100 Message-ID: <538CB885.3080900@draigBrady.com> Date: Mon, 02 Jun 2014 18:46:45 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eric Blake Subject: Re: bug#17668: [PATCH] build: be more specific about .git directory before enabling warnings References: <1401699296-22582-1-git-send-email-bdwalton@gmail.com> <538CA6C7.2060803@redhat.com> In-Reply-To: <538CA6C7.2060803@redhat.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 06/02/2014 05:31 PM, Eric Blake wrote: > On 06/02/2014 02:54 AM, Ben Walton wrote: >> * configure.ac: When looking for a .git checkout, restrict it to git >> checkouts that contain a coreutils-specific tag. >> >> Signed-off-by: Ben Walton >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index a7a8bfc..96af9be 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings], >> # we're running from a git repo, then auto enable the warnings. >> gl_gcc_warnings=no >> gl_GCC_VERSION_IFELSE([4], [6], >> - [test -d "$srcdir"/.git && gl_gcc_warnings=yes])] >> + [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])] > > NACK. Git can compress tags to reside in other locations than > .git/refs/tags (run 'git gc --aggressive' for example). The idea of > testing for coreutils.git has merit, but you need to come up with a more > robust test. [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [213.233.128.44 listed in list.dnswl.org] 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: configure.ac] X-Debbugs-Envelope-To: 17668-done Cc: 17668-done@debbugs.gnu.org, Ben Walton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 06/02/2014 05:31 PM, Eric Blake wrote: > On 06/02/2014 02:54 AM, Ben Walton wrote: >> * configure.ac: When looking for a .git checkout, restrict it to git >> checkouts that contain a coreutils-specific tag. >> >> Signed-off-by: Ben Walton >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index a7a8bfc..96af9be 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings], >> # we're running from a git repo, then auto enable the warnings. >> gl_gcc_warnings=no >> gl_GCC_VERSION_IFELSE([4], [6], >> - [test -d "$srcdir"/.git && gl_gcc_warnings=yes])] >> + [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])] > > NACK. Git can compress tags to reside in other locations than > .git/refs/tags (run 'git gc --aggressive' for example). The idea of > testing for coreutils.git has merit, but you need to come up with a more > robust test. [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [213.233.128.44 listed in list.dnswl.org] 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: configure.ac] On 06/02/2014 05:31 PM, Eric Blake wrote: > On 06/02/2014 02:54 AM, Ben Walton wrote: >> * configure.ac: When looking for a .git checkout, restrict it to git >> checkouts that contain a coreutils-specific tag. >> >> Signed-off-by: Ben Walton >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index a7a8bfc..96af9be 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings], >> # we're running from a git repo, then auto enable the warnings. >> gl_gcc_warnings=no >> gl_GCC_VERSION_IFELSE([4], [6], >> - [test -d "$srcdir"/.git && gl_gcc_warnings=yes])] >> + [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])] > > NACK. Git can compress tags to reside in other locations than > .git/refs/tags (run 'git gc --aggressive' for example). The idea of > testing for coreutils.git has merit, but you need to come up with a more > robust test. Importing the tarball into git for patch management is a fine and useful thing to do, so we should support that. We could probably leverage that .tarball-version is only in the tarball. I'll merge this in and commit in your name: test -d "$srcdir"/.git \ && ! test -f .tarball-version \ && gl_gcc_warnings=yes thanks, Pádraig. From unknown Sat Sep 13 02:39:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 01 Jul 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator