Subject: bug#17668: closed (Re: bug#17668: [PATCH] build: be more specific about .git directory before enabling warnings)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 02 Jun 2014 17:48:02 +0000

Your bug report

#17668: [PATCH] build: be more specific about .git directory before enabling warnings

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
17668: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17668
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#17668: [PATCH] build: be more specific about .git directory before enabling warnings
From: Pádraig Brady <[email-masked]>
To: Eric Blake <[email-masked]>
Cc: [email-masked], Ben Walton <[email-masked]>
Date: Mon, 02 Jun 2014 18:46:45 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

On 06/02/2014 05:31 PM, Eric Blake wrote:
> On 06/02/2014 02:54 AM, Ben Walton wrote:
>>   * configure.ac: When looking for a .git checkout, restrict it to git
>>     checkouts that contain a coreutils-specific tag.
>>
>> Signed-off-by: Ben Walton <[email-masked]>
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index a7a8bfc..96af9be 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
>>     # we're running from a git repo, then auto enable the warnings.
>>     gl_gcc_warnings=no
>>     gl_GCC_VERSION_IFELSE([4], [6],
>> -                         [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
>> +                         [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])]
> 
> NACK.  Git can compress tags to reside in other locations than
> .git/refs/tags (run 'git gc --aggressive' for example).  The idea of
> testing for coreutils.git has merit, but you need to come up with a more
> robust test.

Importing the tarball into git for patch management is a
fine and useful thing to do, so we should support that.

We could probably leverage that .tarball-version is only in the tarball.
I'll merge this in and commit in your name:

  test -d "$srcdir"/.git \
  && ! test -f .tarball-version \
  && gl_gcc_warnings=yes

thanks,
Pádraig.

Subject: [PATCH] build: be more specific about .git directory before enabling warnings
From: Ben Walton <[email-masked]>
To: [email-masked]
Cc: Ben Walton <[email-masked]>, [email-masked]
Date: Mon, 2 Jun 2014 09:54:56 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

  * configure.ac: When looking for a .git checkout, restrict it to git
    checkouts that contain a coreutils-specific tag.

Signed-off-by: Ben Walton <[email-masked]>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index a7a8bfc..96af9be 100644
--- a/configure.ac
+++ b/configure.ac
@@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
    # we're running from a git repo, then auto enable the warnings.
    gl_gcc_warnings=no
    gl_GCC_VERSION_IFELSE([4], [6],
-                         [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
+                         [test -f "$srcdir"/.git/refs/tags/v8.22 && gl_gcc_warnings=yes])]
 )
 
 if test "$gl_gcc_warnings" = yes; then
-- 
1.9.1