From unknown Sat Sep 13 04:54:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17667: [PATCH] df: Initialize a variable to squash a compiler warning Resent-From: Ben Walton Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 02 Jun 2014 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17667 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 17667@debbugs.gnu.org Cc: Ben Walton X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140172327315769 (code B ref -1); Mon, 02 Jun 2014 15:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jun 2014 15:34:33 +0000 Received: from localhost ([127.0.0.1]:41033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrUFr-00046A-VS for submit@debbugs.gnu.org; Mon, 02 Jun 2014 11:34:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48883) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrNJm-0007Ck-2e for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:10:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrNJW-0007EO-P6 for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:10:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrNJW-0007EK-Mj for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:09:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrNJO-0008Se-F2 for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:09:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrNJG-0007Bi-7x for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:09:42 -0400 Received: from jimi.chass.utoronto.ca ([128.100.160.32]:50701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrNJG-0007Bc-3N for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:09:34 -0400 Received: from hendrix.chass.utoronto.ca ([128.100.160.33]:38917 ident=93) by jimi.chass.utoronto.ca with esmtp (Exim 4.76) (envelope-from ) id 1WrNJF-0004sT-CU ; Mon, 02 Jun 2014 04:09:33 -0400 Received: from 86-42-132-190-dynamic.b-ras1.bbh.dublin.eircom.net ([86.42.132.190]:60766 helo=neilyoung) (auth info: dovecot_plain:bwalton@chass.utoronto.ca) by hendrix.chass.utoronto.ca with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1WrNJD-0002i9-BC ; Mon, 02 Jun 2014 04:09:31 -0400 Received: from bwalton by neilyoung with local (Exim 4.82) (envelope-from ) id 1WrNJE-0005fx-S7; Mon, 02 Jun 2014 09:09:32 +0100 From: Ben Walton Date: Mon, 2 Jun 2014 09:09:30 +0100 Message-Id: <1401696570-21785-1-git-send-email-bdwalton@gmail.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Mon, 02 Jun 2014 11:34:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * src/df.c: get_dev - With strict error checking, gcc complained that v may have been used prior to initialization. To avoid this, initialize to NULL. Signed-off-by: Ben Walton --- src/df.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/df.c b/src/df.c index 01ecca6..059c958 100644 --- a/src/df.c +++ b/src/df.c @@ -924,7 +924,7 @@ get_dev (char const *disk, char const *mount_point, char const* file, char buf[LONGEST_HUMAN_READABLE + 2]; char *cell; - struct field_values_t *v; + struct field_values_t *v = NULL; switch (columns[col]->field_type) { case BLOCK_FLD: @@ -934,7 +934,7 @@ get_dev (char const *disk, char const *mount_point, char const* file, v = &inode_values; break; case OTHER_FLD: - v = NULL; + /* Rely on NULL initialization. */ break; default: assert (!"bad field_type"); -- 1.9.1 From unknown Sat Sep 13 04:54:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ben Walton Subject: bug#17667: closed (Re: bug#17667: [PATCH] df: Initialize a variable to squash a compiler warning) Message-ID: References: <538CCEEB.7070208@draigBrady.com> <1401696570-21785-1-git-send-email-bdwalton@gmail.com> X-Gnu-PR-Message: they-closed 17667 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 17667@debbugs.gnu.org Date: Mon, 02 Jun 2014 19:23:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1401736982-26746-1" This is a multi-part message in MIME format... ------------=_1401736982-26746-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17667: [PATCH] df: Initialize a variable to squash a compiler warning which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17667@debbugs.gnu.org. --=20 17667: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17667 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1401736982-26746-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17667-done) by debbugs.gnu.org; 2 Jun 2014 19:22:40 +0000 Received: from localhost ([127.0.0.1]:41297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrXoY-0006wi-PX for submit@debbugs.gnu.org; Mon, 02 Jun 2014 15:22:39 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:23345) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrXoR-0006wP-6m for 17667-done@debbugs.gnu.org; Mon, 02 Jun 2014 15:22:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBACHOjFNtTC0B/2dsb2JhbAANTMcKAYErgxkBAQEEJwsBRhALDQEKCRYPCQMCAQIBDzYGDQEFAgEBiCoDFqogn0wNhUIXjDyCFgeEQAEDmAcBiQ6GJIks Received: from unknown (HELO [192.168.1.79]) ([109.76.45.1]) by mail2.vodafone.ie with ESMTP; 02 Jun 2014 20:22:20 +0100 Message-ID: <538CCEEB.7070208@draigBrady.com> Date: Mon, 02 Jun 2014 20:22:19 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Ben Walton Subject: Re: bug#17667: [PATCH] df: Initialize a variable to squash a compiler warning References: <1401696570-21785-1-git-send-email-bdwalton@gmail.com> In-Reply-To: <1401696570-21785-1-git-send-email-bdwalton@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17667-done Cc: 17667-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 06/02/2014 09:09 AM, Ben Walton wrote: > * src/df.c: get_dev - With strict error checking, gcc complained that > v may have been used prior to initialization. To avoid > this, initialize to NULL. > > Signed-off-by: Ben Walton > --- > src/df.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/df.c b/src/df.c > index 01ecca6..059c958 100644 > --- a/src/df.c > +++ b/src/df.c > @@ -924,7 +924,7 @@ get_dev (char const *disk, char const *mount_point, char const* file, > char buf[LONGEST_HUMAN_READABLE + 2]; > char *cell; > > - struct field_values_t *v; > + struct field_values_t *v = NULL; > switch (columns[col]->field_type) > { > case BLOCK_FLD: > @@ -934,7 +934,7 @@ get_dev (char const *disk, char const *mount_point, char const* file, > v = &inode_values; > break; > case OTHER_FLD: > - v = NULL; > + /* Rely on NULL initialization. */ > break; > default: > assert (!"bad field_type"); This is because assert() is not declared __noreturn__ on Solaris 10. That can be an important admonition for a compiler so I'm wondering should be detect this and provide a __noreturn__ wrapper. Anyway what I don't want to do is change the current logic to avoid such bogus warnings. What we could do here is to tweak the assert path only to avoid the warning as follows. OK to push the following instead in your name? thanks, Pádraig. diff --git a/src/df.c b/src/df.c index 82b0c5f..c08ad97 100644 --- a/src/df.c +++ b/src/df.c @@ -953,6 +953,7 @@ get_dev (char const *disk, char const *mount_point, char con v = NULL; break; default: + v = NULL; /* avoid warnings where assert() is not __noreturn__. */ assert (!"bad field_type"); } ------------=_1401736982-26746-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Jun 2014 15:34:33 +0000 Received: from localhost ([127.0.0.1]:41033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrUFr-00046A-VS for submit@debbugs.gnu.org; Mon, 02 Jun 2014 11:34:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48883) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrNJm-0007Ck-2e for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:10:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrNJW-0007EO-P6 for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:10:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrNJW-0007EK-Mj for submit@debbugs.gnu.org; Mon, 02 Jun 2014 04:09:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrNJO-0008Se-F2 for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:09:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrNJG-0007Bi-7x for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:09:42 -0400 Received: from jimi.chass.utoronto.ca ([128.100.160.32]:50701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrNJG-0007Bc-3N for bug-coreutils@gnu.org; Mon, 02 Jun 2014 04:09:34 -0400 Received: from hendrix.chass.utoronto.ca ([128.100.160.33]:38917 ident=93) by jimi.chass.utoronto.ca with esmtp (Exim 4.76) (envelope-from ) id 1WrNJF-0004sT-CU ; Mon, 02 Jun 2014 04:09:33 -0400 Received: from 86-42-132-190-dynamic.b-ras1.bbh.dublin.eircom.net ([86.42.132.190]:60766 helo=neilyoung) (auth info: dovecot_plain:bwalton@chass.utoronto.ca) by hendrix.chass.utoronto.ca with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1WrNJD-0002i9-BC ; Mon, 02 Jun 2014 04:09:31 -0400 Received: from bwalton by neilyoung with local (Exim 4.82) (envelope-from ) id 1WrNJE-0005fx-S7; Mon, 02 Jun 2014 09:09:32 +0100 From: Ben Walton To: bug-coreutils@gnu.org Subject: [PATCH] df: Initialize a variable to squash a compiler warning Date: Mon, 2 Jun 2014 09:09:30 +0100 Message-Id: <1401696570-21785-1-git-send-email-bdwalton@gmail.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 02 Jun 2014 11:34:29 -0400 Cc: Ben Walton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * src/df.c: get_dev - With strict error checking, gcc complained that v may have been used prior to initialization. To avoid this, initialize to NULL. Signed-off-by: Ben Walton --- src/df.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/df.c b/src/df.c index 01ecca6..059c958 100644 --- a/src/df.c +++ b/src/df.c @@ -924,7 +924,7 @@ get_dev (char const *disk, char const *mount_point, char const* file, char buf[LONGEST_HUMAN_READABLE + 2]; char *cell; - struct field_values_t *v; + struct field_values_t *v = NULL; switch (columns[col]->field_type) { case BLOCK_FLD: @@ -934,7 +934,7 @@ get_dev (char const *disk, char const *mount_point, char const* file, v = &inode_values; break; case OTHER_FLD: - v = NULL; + /* Rely on NULL initialization. */ break; default: assert (!"bad field_type"); -- 1.9.1 ------------=_1401736982-26746-1-- From unknown Sat Sep 13 04:54:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17667: [PATCH] df: Initialize a variable to squash a compiler warning Resent-From: Ben Walton Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 02 Jun 2014 19:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17667 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 17667-done@debbugs.gnu.org Received: via spool by 17667-done@debbugs.gnu.org id=D17667.140173737727388 (code D ref 17667); Mon, 02 Jun 2014 19:30:02 +0000 Received: (at 17667-done) by debbugs.gnu.org; 2 Jun 2014 19:29:37 +0000 Received: from localhost ([127.0.0.1]:41305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrXvM-00077f-OZ for submit@debbugs.gnu.org; Mon, 02 Jun 2014 15:29:37 -0400 Received: from mail-yh0-f47.google.com ([209.85.213.47]:50287) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrXvJ-00077S-U5 for 17667-done@debbugs.gnu.org; Mon, 02 Jun 2014 15:29:34 -0400 Received: by mail-yh0-f47.google.com with SMTP id z6so4228124yhz.6 for <17667-done@debbugs.gnu.org>; Mon, 02 Jun 2014 12:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=5iwyWnB0rPeXlLZuZvrTcl5/EiFln52or3jymLhle+s=; b=btuys4zfxtnVu2vYJTw+HMz7b+KopR47PjCqBleh9X48XIVl0FooXXoaNUccPlLj4Y IMx283KW9Vlxctbi8lgfOGGhmqul9Q6M6IcMpi90k8lxM4EK/bRKTCzB1lemoC6hxbnU 3KtT6AXqt++BIh44Y00CfIuD0+Cvp87w5Wp5p7q2n97F82AWS7nULTc8jHKhONwx415E AIF3Q4IN+kPkYcu50cxdU1NTG3t0lo3PGksblhydulQSypwp7r5e0pRmQzf22Zdw1ek2 +zjMwziPB5Un15b0HPsTxMXRf1Ch02GyyuX61OdFiyGD7x+OLX2VNUYRGuGXx/L2x15s qtzA== MIME-Version: 1.0 X-Received: by 10.236.202.7 with SMTP id c7mr5850929yho.153.1401737367995; Mon, 02 Jun 2014 12:29:27 -0700 (PDT) Received: by 10.170.62.213 with HTTP; Mon, 2 Jun 2014 12:29:27 -0700 (PDT) In-Reply-To: <538CCEEB.7070208@draigBrady.com> References: <1401696570-21785-1-git-send-email-bdwalton@gmail.com> <538CCEEB.7070208@draigBrady.com> Date: Mon, 2 Jun 2014 20:29:27 +0100 Message-ID: From: Ben Walton Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Jun 2, 2014 at 8:22 PM, P=C3=A1draig Brady wrote= : > On 06/02/2014 09:09 AM, Ben Walton wrote: >> * src/df.c: get_dev - With strict error checking, gcc complained that >> v may have been used prior to initialization. To avoid >> this, initialize to NULL. >> >> Signed-off-by: Ben Walton >> --- >> src/df.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/df.c b/src/df.c >> index 01ecca6..059c958 100644 >> --- a/src/df.c >> +++ b/src/df.c >> @@ -924,7 +924,7 @@ get_dev (char const *disk, char const *mount_point, = char const* file, >> char buf[LONGEST_HUMAN_READABLE + 2]; >> char *cell; >> >> - struct field_values_t *v; >> + struct field_values_t *v =3D NULL; >> switch (columns[col]->field_type) >> { >> case BLOCK_FLD: >> @@ -934,7 +934,7 @@ get_dev (char const *disk, char const *mount_point, = char const* file, >> v =3D &inode_values; >> break; >> case OTHER_FLD: >> - v =3D NULL; >> + /* Rely on NULL initialization. */ >> break; >> default: >> assert (!"bad field_type"); > > This is because assert() is not declared __noreturn__ on Solaris 10. > That can be an important admonition for a compiler > so I'm wondering should be detect this and provide a __noreturn__ wrapper= . Ah. Ok. That makes sense. I think providing this wrapper is likely a good thing although this is a corner case we're catching here. > > Anyway what I don't want to do is change the current logic > to avoid such bogus warnings. What we could do here > is to tweak the assert path only to avoid the warning as follows. > OK to push the following instead in your name? Ack, that's fine with me. Thanks -Ben > > thanks, > P=C3=A1draig. > > diff --git a/src/df.c b/src/df.c > index 82b0c5f..c08ad97 100644 > --- a/src/df.c > +++ b/src/df.c > @@ -953,6 +953,7 @@ get_dev (char const *disk, char const *mount_point, c= har con > v =3D NULL; > break; > default: > + v =3D NULL; /* avoid warnings where assert() is not __noreturn= __. */ > assert (!"bad field_type"); > } > > --=20 ---------------------------------------------------------------------------= ------------------------------------------------ Take the risk of thinking for yourself. Much more happiness, truth, beauty and wisdom will come to you that way. -Christopher Hitchens ---------------------------------------------------------------------------= ------------------------------------------------ From unknown Sat Sep 13 04:54:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17667: [PATCH] df: Initialize a variable to squash a compiler warning Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 02 Jun 2014 19:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17667 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 17667@debbugs.gnu.org, P@draigBrady.com, bdwalton@gmail.com Received: via spool by 17667-submit@debbugs.gnu.org id=B17667.14017389132296 (code B ref 17667); Mon, 02 Jun 2014 19:56:01 +0000 Received: (at 17667) by debbugs.gnu.org; 2 Jun 2014 19:55:13 +0000 Received: from localhost ([127.0.0.1]:41327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrYK9-0000ay-70 for submit@debbugs.gnu.org; Mon, 02 Jun 2014 15:55:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8632) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrYK5-0000ah-L5 for 17667@debbugs.gnu.org; Mon, 02 Jun 2014 15:55:11 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s52Jt7oT022576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Jun 2014 15:55:07 -0400 Received: from [10.3.113.133] (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s52Jt67s020354; Mon, 2 Jun 2014 15:55:06 -0400 Message-ID: <538CD69A.4060904@redhat.com> Date: Mon, 02 Jun 2014 13:55:06 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <1401696570-21785-1-git-send-email-bdwalton@gmail.com> <538CCEEB.7070208@draigBrady.com> In-Reply-To: <538CCEEB.7070208@draigBrady.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MBgaOkWqcn3QuSW63mRBqCk1NIoHE5oB8" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -5.7 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MBgaOkWqcn3QuSW63mRBqCk1NIoHE5oB8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/02/2014 01:22 PM, P=C3=A1draig Brady wrote: >> default: >> assert (!"bad field_type"); >=20 > This is because assert() is not declared __noreturn__ on Solaris 10. Huh? assert(nonzero) returns normally. I thought __noreturn__ was reserved for functions like exit() that really cannot return; assert(0) does not return, but that does not mean it has the same semantics as exit(). (Well, technically assert() is a macro, while the __noreturn__ semantics have to be attached to a function invoked by the macro - but how do you portably determine which function is going to be invoked by the macro?) > That can be an important admonition for a compiler > so I'm wondering should be detect this and provide a __noreturn__ wrapp= er. In glibc, it is not assert() that is marked __noreturn__, but the __assert_fail() internal function call that only gets triggered for assert(0). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MBgaOkWqcn3QuSW63mRBqCk1NIoHE5oB8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjNaaAAoJEKeha0olJ0Nq5UYH/2+bOgHLxo6wLyv3Ds+yMpkB bEO4RxJPfwomBlgIXEwRtkgZjqoUzOEHz06CEAaWBtkz+/KGh3KSFWQIRdsI7NpE /Lr24cGLWBy5lPchfvCHKrIohObvVDxitWOpVvrc9Di1fqmKbVvRILwheIUUxX1u b54zgMYEuaIh7Lk+OJ/J1lNVfMbuUGZFHE7/cdoppdco3DZSVbfzQp18v2MJvSyb 1Ey/rLVKCezeK2EME5ZiJUE+O8FmQSGPFzr3mRbr863riTdhDGThw5t9JJdQ83pE 3LpX1uGez/dGbbZBRFQWynhFEqHT0HDNVd6gwzc5YqwKT0G0SXxE9mQCvO9Gkxo= =l54W -----END PGP SIGNATURE----- --MBgaOkWqcn3QuSW63mRBqCk1NIoHE5oB8--