From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Christopher Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 May 2014 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17633@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140138554315041 (code B ref -1); Thu, 29 May 2014 17:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2014 17:45:43 +0000 Received: from localhost ([127.0.0.1]:36371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq4Od-0003uV-1c for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56655) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq4Oa-0003uF-Si for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq4OJ-0002cj-3Q for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq4OJ-0002ca-1f for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq4OE-0006Xj-0L for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 13:45:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq4O8-0002Tz-Vz for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 13:45:17 -0400 Received: from ristopher.com ([81.4.108.209]:51952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq4O8-0002T5-Qo for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 13:45:12 -0400 Received: by ristopher.com (Postfix, from userid 0) id 084932177B; Thu, 29 May 2014 13:45:10 -0400 (EDT) From: Christopher Schmidt Message-ID: <8738fs32e1@ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Thu, 29 May 2014 13:45:09 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) emacs -q # Drag the mode line with the mouse. mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p This is a regression. In GNU Emacs 24.3.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) Repository revision: 117171 eliz@gnu.org-20140529164749-nz9x3hi1ipkv9cfk Windowing system distributor `The X.Org Foundation', version 11.0.11204000 From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 May 2014 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17633@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140138932723047 (code B ref -1); Thu, 29 May 2014 18:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2014 18:48:47 +0000 Received: from localhost ([127.0.0.1]:36409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq5Ne-0005zf-OP for submit@debbugs.gnu.org; Thu, 29 May 2014 14:48:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49932) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq5Nb-0005zP-Gb for submit@debbugs.gnu.org; Thu, 29 May 2014 14:48:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq5NM-0008OO-Ko for submit@debbugs.gnu.org; Thu, 29 May 2014 14:48:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq5NM-0008OF-IV for submit@debbugs.gnu.org; Thu, 29 May 2014 14:48:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq5NE-0000jp-QI for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 14:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq5N7-0008JO-9B for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 14:48:20 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:11120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq5N7-0008JG-4M for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 14:48:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWKAsLNAcLFBgNiCgIr0aiUxePARaEIgSpGYFqgXGBWyGBLg X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWKAsLNAcLFBgNiCgIr0aiUxePARaEIgSpGYFqgXGBWyGBLg X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="64992193" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 May 2014 14:48:12 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1DFA2601BC; Thu, 29 May 2014 14:48:12 -0400 (EDT) From: Stefan Monnier Message-ID: References: <8738fs32e1@ristopher.com> Date: Thu, 29 May 2014 14:48:12 -0400 In-Reply-To: <8738fs32e1@ristopher.com> (Christopher Schmidt's message of "Thu, 29 May 2014 13:45:09 -0400 (EDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) > emacs -q > # Drag the mode line with the mouse. > mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Indeed, we have a call to that function, while I removed it a year ago. Not sure how I managed not to notice that call. I do wonder tho: do you have a recipe to reproduce the problem? I tried to hit the bug, but wasn't able to (even after reading the code and trying to infer the circumstances that would lead to it). This is a piece of code that we should probably revisit, so having such a recipe would help me understand how the code works. Stefan From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Christopher Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 May 2014 19:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17633@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140139043125443 (code B ref -1); Thu, 29 May 2014 19:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2014 19:07:11 +0000 Received: from localhost ([127.0.0.1]:36428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq5fS-0006cJ-Jv for submit@debbugs.gnu.org; Thu, 29 May 2014 15:07:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34257) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq5fQ-0006bl-0a for submit@debbugs.gnu.org; Thu, 29 May 2014 15:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq5fJ-0001mH-Uy for submit@debbugs.gnu.org; Thu, 29 May 2014 15:07:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq5fJ-0001mC-SQ for submit@debbugs.gnu.org; Thu, 29 May 2014 15:07:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq5fJ-0001U9-50 for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 15:07:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq5fH-0001lf-KD for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 15:07:01 -0400 Received: from ristopher.com ([2a00:d880:3:2::cf4:fc91]:60986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq5fH-0001lL-DH for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 15:06:59 -0400 Received: by ristopher.com (Postfix, from userid 0) id 109F220A7D; Thu, 29 May 2014 15:06:57 -0400 (EDT) From: Christopher Schmidt In-Reply-To: (Stefan Monnier's message of "Thu, 29 May 2014 14:48:12 -0400") Message-ID: <877g548kvk@ristopher.com> References: <8738fs32e1@ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Thu, 29 May 2014 15:06:56 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier writes: > I do wonder tho: do you have a recipe to reproduce the problem? I > tried to hit the bug, but wasn't able to (even after reading the code > and trying to infer the circumstances that would lead to it). >> emacs -q >> # Drag the mode line with the mouse. That is my recipe. FWIW there is another major bug: emacs -q # Click the mode line's buffer identification string ("*GNU Emacs*") button-activate: Symbol's function definition is void: nil This bug only occurs when point is on a character with a keymap. emacs seems to use the keymap of the character at point rather than the one of the character that was actually clicked at. From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 May 2014 20:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17633@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14013955893636 (code B ref -1); Thu, 29 May 2014 20:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2014 20:33:09 +0000 Received: from localhost ([127.0.0.1]:36478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq70f-0000wY-Dw for submit@debbugs.gnu.org; Thu, 29 May 2014 16:33:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55274) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq70c-0000wE-V0 for submit@debbugs.gnu.org; Thu, 29 May 2014 16:33:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq70O-0005gu-2D for submit@debbugs.gnu.org; Thu, 29 May 2014 16:33:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq70N-0005gq-VK for submit@debbugs.gnu.org; Thu, 29 May 2014 16:32:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq70F-0000nG-Hm for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 16:32:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq707-0005eT-4k for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 16:32:43 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:43462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq707-0005eP-1F for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 16:32:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWKAsLNAcLFBgNiCgIr0aiUxePARaEIgSpGYFqgXGBWyGBLg X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWKAsLNAcLFBgNiCgIr0aiUxePARaEIgSpGYFqgXGBWyGBLg X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65001099" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 May 2014 16:32:34 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1BBD1601BC; Thu, 29 May 2014 16:32:34 -0400 (EDT) From: Stefan Monnier Message-ID: References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> Date: Thu, 29 May 2014 16:32:34 -0400 In-Reply-To: <877g548kvk@ristopher.com> (Christopher Schmidt's message of "Thu, 29 May 2014 15:06:56 -0400 (EDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) >>> emacs -q >>> # Drag the mode line with the mouse. > That is my recipe. Hmm.... when I try that, I get a frame with a single window, so I can try to drag the mode line, but it won't budge. And I don't get any error. So, I tried to add a C-x 2. I can then move the mode line, but then again, I don't get any error. Oh, wait, right, I see it now: I had used "emacs -Q" rather than "emacs -q". Thanks. > FWIW there is another major bug: > emacs -q > # Click the mode line's buffer identification string ("*GNU Emacs*") > button-activate: Symbol's function definition is void: nil > This bug only occurs when point is on a character with a keymap. emacs > seems to use the keymap of the character at point rather than the one of > the character that was actually clicked at. Can you make it a separate bug-report? Stefan From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Christopher Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 May 2014 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17633@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14013964395519 (code B ref -1); Thu, 29 May 2014 20:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2014 20:47:19 +0000 Received: from localhost ([127.0.0.1]:36493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq7EM-0001Qw-Bo for submit@debbugs.gnu.org; Thu, 29 May 2014 16:47:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41997) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq7EK-0001Qg-2a for submit@debbugs.gnu.org; Thu, 29 May 2014 16:47:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq7EE-0003V2-5W for submit@debbugs.gnu.org; Thu, 29 May 2014 16:47:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq7EE-0003Ux-2Z for submit@debbugs.gnu.org; Thu, 29 May 2014 16:47:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq7ED-0005e6-2s for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 16:47:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq7EC-0003UC-8l for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 16:47:09 -0400 Received: from ristopher.com ([2a00:d880:3:2::cf4:fc91]:60991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq7EC-0003TY-2X for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 16:47:08 -0400 Received: by ristopher.com (Postfix, from userid 0) id 70DFE20738; Thu, 29 May 2014 16:47:05 -0400 (EDT) From: Christopher Schmidt In-Reply-To: (Stefan Monnier's message of "Thu, 29 May 2014 16:32:34 -0400") Message-ID: <87sins71nx@ristopher.com> References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Thu, 29 May 2014 16:47:05 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier writes: >> FWIW there is another major bug: > >> emacs -q >> # Click the mode line's buffer identification string ("*GNU Emacs*") >> button-activate: Symbol's function definition is void: nil >> This bug only occurs when point is on a character with a keymap. >> emacs seems to use the keymap of the character at point rather than >> the one of the character that was actually clicked at. > > Can you make it a separate bug-report? AFAICS both issues are manifestations of the same bug because both of them only come up if point is on a character with a dedicated keymap. From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 May 2014 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17633@debbugs.gnu.org Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.140153975811122 (code B ref 17633); Sat, 31 May 2014 12:36:02 +0000 Received: (at 17633) by debbugs.gnu.org; 31 May 2014 12:35:58 +0000 Received: from localhost ([127.0.0.1]:38478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqiVx-0002tK-O3 for submit@debbugs.gnu.org; Sat, 31 May 2014 08:35:58 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:9439) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqiVu-0002t0-JS for 17633@debbugs.gnu.org; Sat, 31 May 2014 08:35:55 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBVigLCzQHCxQYDTeHcQivRqJTF48BFoQiBKkZgWqBcYFbIYEu X-IPAS-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBVigLCzQHCxQYDTeHcQivRqJTF48BFoQiBKkZgWqBcYFbIYEu X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65163087" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 May 2014 08:34:48 -0400 Received: by pastel.home (Postfix, from userid 20848) id 79EB9601AD; Sat, 31 May 2014 08:34:28 -0400 (EDT) From: Stefan Monnier Message-ID: References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> Date: Sat, 31 May 2014 08:34:28 -0400 In-Reply-To: <87sins71nx@ristopher.com> (Christopher Schmidt's message of "Thu, 29 May 2014 16:47:05 -0400 (EDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > AFAICS both issues are manifestations of the same bug because both of > them only come up if point is on a character with a dedicated keymap. Indeed, I installed the patch below which seems to fix them. Can you confirm it fixes the problems you've seen? Stefan === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-05-31 01:01:19 +0000 +++ lisp/ChangeLog 2014-05-31 12:32:03 +0000 @@ -1,5 +1,8 @@ 2014-05-31 Stefan Monnier + * mouse.el (mouse-posn-property): Ignore posn-point for mode-line + clicks (bug#17633). + * leim/quail/latin-pre.el ("latin-2-prefix"): Use ",," rather than ", " for the single comma, since ", " is *very* common in normal French text (bug#17643). === modified file 'lisp/mouse.el' --- lisp/mouse.el 2014-05-18 22:53:27 +0000 +++ lisp/mouse.el 2014-05-31 12:30:47 +0000 @@ -658,7 +658,10 @@ (str (posn-string pos))) (or (and str (get-text-property (cdr str) property (car str))) - (and pt + ;; FIXME: mouse clicks on the mode-line come with a position in + ;; (nth 5). Maybe we should change the C code instead so that + ;; mouse-clicks don't include a position there! + (and pt (not (memq (posn-area pos) '(mode-line header-line))) (get-char-property pt property w)))) (get-char-property pos property))) From unknown Wed Aug 20 04:11:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Schmidt Subject: bug#17633: closed (Re: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p) Message-ID: References: <87tx86xg2u@ristopher.com> <8738fs32e1@ristopher.com> X-Gnu-PR-Message: they-closed 17633 X-Gnu-PR-Package: emacs Reply-To: 17633@debbugs.gnu.org Date: Sat, 31 May 2014 12:56:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1401540963-13789-1" This is a multi-part message in MIME format... ------------=_1401540963-13789-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mou= se--remap-link-click-p which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17633@debbugs.gnu.org. --=20 17633: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17633 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1401540963-13789-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17633-done) by debbugs.gnu.org; 31 May 2014 12:56:00 +0000 Received: from localhost ([127.0.0.1]:38482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqipK-0003aA-LZ for submit@debbugs.gnu.org; Sat, 31 May 2014 08:56:00 -0400 Received: from ristopher.com ([81.4.108.209]:58170) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqipE-0003Zx-VR for 17633-done@debbugs.gnu.org; Sat, 31 May 2014 08:55:54 -0400 Received: by ristopher.com (Postfix, from userid 0) id 4D749206B6; Sat, 31 May 2014 08:55:50 -0400 (EDT) From: Christopher Schmidt To: 17633-done@debbugs.gnu.org Subject: Re: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p In-Reply-To: (Stefan Monnier's message of "Sat, 31 May 2014 08:34:28 -0400") Message-ID: <87tx86xg2u@ristopher.com> References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> MIME-Version: 1.0 Content-Type: text/plain Date: Sat, 31 May 2014 08:55:49 -0400 (EDT) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17633-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: >> AFAICS both issues are manifestations of the same bug because both of >> them only come up if point is on a character with a dedicated keymap. > > Indeed, I installed the patch below which seems to fix them. Can you > confirm it fixes the problems you've seen? The problems are gone now. Thanks a lot! ------------=_1401540963-13789-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 May 2014 17:45:43 +0000 Received: from localhost ([127.0.0.1]:36371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq4Od-0003uV-1c for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56655) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq4Oa-0003uF-Si for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq4OJ-0002cj-3Q for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq4OJ-0002ca-1f for submit@debbugs.gnu.org; Thu, 29 May 2014 13:45:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq4OE-0006Xj-0L for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 13:45:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq4O8-0002Tz-Vz for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 13:45:17 -0400 Received: from ristopher.com ([81.4.108.209]:51952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq4O8-0002T5-Qo for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 13:45:12 -0400 Received: by ristopher.com (Postfix, from userid 0) id 084932177B; Thu, 29 May 2014 13:45:10 -0400 (EDT) From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Message-ID: <8738fs32e1@ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Thu, 29 May 2014 13:45:09 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) emacs -q # Drag the mode line with the mouse. mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p This is a regression. In GNU Emacs 24.3.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) Repository revision: 117171 eliz@gnu.org-20140529164749-nz9x3hi1ipkv9cfk Windowing system distributor `The X.Org Foundation', version 11.0.11204000 ------------=_1401540963-13789-1-- From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 May 2014 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 17633@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.140154124914421 (code B ref 17633); Sat, 31 May 2014 13:01:02 +0000 Received: (at 17633) by debbugs.gnu.org; 31 May 2014 13:00:49 +0000 Received: from localhost ([127.0.0.1]:38489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wqiu0-0003kW-Qz for submit@debbugs.gnu.org; Sat, 31 May 2014 09:00:49 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:53631) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wqitw-0003kE-Ql for 17633@debbugs.gnu.org; Sat, 31 May 2014 09:00:45 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N6F00L00V1ZVZ00@mtaout27.012.net.il> for 17633@debbugs.gnu.org; Sat, 31 May 2014 15:57:29 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6F00KPQVZTXB40@mtaout27.012.net.il>; Sat, 31 May 2014 15:57:29 +0300 (IDT) Date: Sat, 31 May 2014 16:00:55 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <831tvaf6go.fsf@gnu.org> References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Date: Sat, 31 May 2014 08:34:28 -0400 > > 2014-05-31 Stefan Monnier > > + * mouse.el (mouse-posn-property): Ignore posn-point for mode-line > + clicks (bug#17633). > + > * leim/quail/latin-pre.el ("latin-2-prefix"): Use ",," rather than ", " > for the single comma, since ", " is *very* common in normal French text > (bug#17643). > > === modified file 'lisp/mouse.el' > --- lisp/mouse.el 2014-05-18 22:53:27 +0000 > +++ lisp/mouse.el 2014-05-31 12:30:47 +0000 > @@ -658,7 +658,10 @@ > (str (posn-string pos))) > (or (and str > (get-text-property (cdr str) property (car str))) > - (and pt > + ;; FIXME: mouse clicks on the mode-line come with a position in > + ;; (nth 5). Maybe we should change the C code instead so that > + ;; mouse-clicks don't include a position there! > + (and pt (not (memq (posn-area pos) '(mode-line header-line))) > (get-char-property pt property w)))) > (get-char-property pos property))) Can you explain the problem in more detail? I'm afraid I don't understand the problem with mouse clicks on mode line. From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 May 2014 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17633@debbugs.gnu.org Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.140154817027929 (code B ref 17633); Sat, 31 May 2014 14:57:01 +0000 Received: (at 17633) by debbugs.gnu.org; 31 May 2014 14:56:10 +0000 Received: from localhost ([127.0.0.1]:39039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wqkhc-0007GO-FT for submit@debbugs.gnu.org; Sat, 31 May 2014 10:56:09 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55791) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqkhZ-0007Fq-SX for 17633@debbugs.gnu.org; Sat, 31 May 2014 10:56:06 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgEnLyMFCws0BwsUGA0kiAQIr0aiUxeOegeEOAEDqRmBaoFxgVshgS4 X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgEnLyMFCws0BwsUGA0kiAQIr0aiUxeOegeEOAEDqRmBaoFxgVshgS4 X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65172121" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 May 2014 10:56:00 -0400 Received: by pastel.home (Postfix, from userid 20848) id D800E601AD; Sat, 31 May 2014 10:55:54 -0400 (EDT) From: Stefan Monnier Message-ID: References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> <831tvaf6go.fsf@gnu.org> Date: Sat, 31 May 2014 10:55:54 -0400 In-Reply-To: <831tvaf6go.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 May 2014 16:00:55 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Can you explain the problem in more detail? I'm afraid I don't > understand the problem with mouse clicks on mode line. I think the real fix (which I intend to install into trunk) is the one below: including `point' in a mouse-click is simply incorrect since the current position of point has nothing to do with the mouse event. Stefan === modified file 'src/keyboard.c' --- src/keyboard.c 2014-05-30 04:12:08 +0000 +++ src/keyboard.c 2014-05-31 13:42:02 +0000 @@ -5266,9 +5266,7 @@ &object, &dx, &dy, &width, &height); if (STRINGP (string)) string_info = Fcons (string, make_number (charpos)); - textpos = (w == XWINDOW (selected_window) - && current_buffer == XBUFFER (w->contents)) - ? PT : marker_position (w->pointm); + textpos = Qnil; xret = wx; yret = wy; From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 May 2014 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 17633@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.14015546669923 (code B ref 17633); Sat, 31 May 2014 16:45:02 +0000 Received: (at 17633) by debbugs.gnu.org; 31 May 2014 16:44:26 +0000 Received: from localhost ([127.0.0.1]:39066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqmOQ-0002Zz-09 for submit@debbugs.gnu.org; Sat, 31 May 2014 12:44:26 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:41687) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqmOL-0002ZW-1O for 17633@debbugs.gnu.org; Sat, 31 May 2014 12:44:22 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N6G0050061VVI00@mtaout27.012.net.il> for 17633@debbugs.gnu.org; Sat, 31 May 2014 19:41:05 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6G003PV6CHLO30@mtaout27.012.net.il>; Sat, 31 May 2014 19:41:05 +0300 (IDT) Date: Sat, 31 May 2014 19:44:11 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <838uphdhk4.fsf@gnu.org> References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> <831tvaf6go.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: 17633@debbugs.gnu.org > Date: Sat, 31 May 2014 10:55:54 -0400 > > > Can you explain the problem in more detail? I'm afraid I don't > > understand the problem with mouse clicks on mode line. > > I think the real fix (which I intend to install into trunk) is the > one below: including `point' in a mouse-click is simply incorrect since > the current position of point has nothing to do with the mouse event. But why does it hurt to include the window's point in the click? Other kinds of click on non-text parts do include some kind of position, so why is this one a problem? Btw, your patch won't compile, because 'textpos' is not a Lisp object. From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 May 2014 20:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17633@debbugs.gnu.org Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.14015670647222 (code B ref 17633); Sat, 31 May 2014 20:12:01 +0000 Received: (at 17633) by debbugs.gnu.org; 31 May 2014 20:11:04 +0000 Received: from localhost ([127.0.0.1]:39190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqpcN-0001sQ-S8 for submit@debbugs.gnu.org; Sat, 31 May 2014 16:11:04 -0400 Received: from relais.videotron.ca ([24.201.245.36]:38744) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqpcL-0001s5-JR for 17633@debbugs.gnu.org; Sat, 31 May 2014 16:11:02 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from fmsmemgm.homelinux.net ([24.201.169.131]) by VL-VM-MR004.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0N6G00LO7G2D7N70@VL-VM-MR004.ip.videotron.ca> for 17633@debbugs.gnu.org; Sat, 31 May 2014 16:11:01 -0400 (EDT) Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 83199AE226; Sat, 31 May 2014 16:11:02 -0400 (EDT) From: Stefan Monnier Message-id: References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> <831tvaf6go.fsf@gnu.org> <838uphdhk4.fsf@gnu.org> Date: Sat, 31 May 2014 16:11:02 -0400 In-reply-to: <838uphdhk4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > But why does it hurt to include the window's point in the click? Because mouse-posn-property then checks the text-property at point. > Other kinds of click on non-text parts do include some kind of > position, so why is this one a problem? Usually those positions are at least somewhat related to the position of the mouse. But indeed mouse-posn-property should probably ignore the posn-point info for the other non-text parts. > Btw, your patch won't compile, because 'textpos' is not a Lisp object. Yes, it was just to show the intention. Stefan From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2014 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 17633@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.140159051529802 (code B ref 17633); Sun, 01 Jun 2014 02:42:01 +0000 Received: (at 17633) by debbugs.gnu.org; 1 Jun 2014 02:41:55 +0000 Received: from localhost ([127.0.0.1]:39333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wqvid-0007kb-3g for submit@debbugs.gnu.org; Sat, 31 May 2014 22:41:55 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:35423) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wqvia-0007kI-6c for 17633@debbugs.gnu.org; Sat, 31 May 2014 22:41:53 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N6G00L00WBB3G00@mtaout25.012.net.il> for 17633@debbugs.gnu.org; Sun, 01 Jun 2014 05:38:23 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6G001LDXZZX820@mtaout25.012.net.il>; Sun, 01 Jun 2014 05:38:23 +0300 (IDT) Date: Sun, 01 Jun 2014 05:41:34 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83sinpbbc1.fsf@gnu.org> References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> <831tvaf6go.fsf@gnu.org> <838uphdhk4.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: 17633@debbugs.gnu.org > Date: Sat, 31 May 2014 16:11:02 -0400 > > > But why does it hurt to include the window's point in the click? > > Because mouse-posn-property then checks the text-property at point. It shouldn't do that. This sounds like a problem with mouse-posn-property rather than with make_lispy_position. From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2014 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17633@debbugs.gnu.org Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.140163234828360 (code B ref 17633); Sun, 01 Jun 2014 14:20:02 +0000 Received: (at 17633) by debbugs.gnu.org; 1 Jun 2014 14:19:08 +0000 Received: from localhost ([127.0.0.1]:39983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wr6bL-0007NJ-3I for submit@debbugs.gnu.org; Sun, 01 Jun 2014 10:19:07 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:27972) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wr6bH-0007MZ-OR for 17633@debbugs.gnu.org; Sun, 01 Jun 2014 10:19:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIxALNAcLFBgNJIgECK9GolMXjnoHhDgEqRmBaoFxgVshgS4 X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIxALNAcLFBgNJIgECK9GolMXjnoHhDgEqRmBaoFxgVshgS4 X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65254640" Received: from 206-248-131-163.dsl.teksavvy.com (HELO ceviche.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 01 Jun 2014 10:18:58 -0400 Received: by ceviche.home (Postfix, from userid 20848) id ADB17660D4; Sun, 1 Jun 2014 10:18:57 -0400 (EDT) From: Stefan Monnier Message-ID: References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> <831tvaf6go.fsf@gnu.org> <838uphdhk4.fsf@gnu.org> <83sinpbbc1.fsf@gnu.org> Date: Sun, 01 Jun 2014 10:18:57 -0400 In-Reply-To: <83sinpbbc1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Jun 2014 05:41:34 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> > But why does it hurt to include the window's point in the click? >> Because mouse-posn-property then checks the text-property at point. > It shouldn't do that. This sounds like a problem with > mouse-posn-property rather than with make_lispy_position. In the case of fringe clicks, I agree that these events's buffer-position info is worthwhile and that mouse-posn-property should ignore it, but in the case of mode-line clicks, the click is completely unrelated to the particular position of point at that moment, os including that info is just asking for trouble, Stefan From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2014 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 17633@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.14016346891322 (code B ref 17633); Sun, 01 Jun 2014 14:59:02 +0000 Received: (at 17633) by debbugs.gnu.org; 1 Jun 2014 14:58:09 +0000 Received: from localhost ([127.0.0.1]:39991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wr7D7-0000LG-G1 for submit@debbugs.gnu.org; Sun, 01 Jun 2014 10:58:09 -0400 Received: from mtaout26.012.net.il ([80.179.55.182]:57632) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wr7D3-0000Kd-L5 for 17633@debbugs.gnu.org; Sun, 01 Jun 2014 10:58:07 -0400 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N6H00100VTGHE00@mtaout26.012.net.il> for 17633@debbugs.gnu.org; Sun, 01 Jun 2014 17:54:38 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6H00P7CW323C30@mtaout26.012.net.il>; Sun, 01 Jun 2014 17:54:38 +0300 (IDT) Date: Sun, 01 Jun 2014 17:57:47 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83oaycbrtg.fsf@gnu.org> References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> <831tvaf6go.fsf@gnu.org> <838uphdhk4.fsf@gnu.org> <83sinpbbc1.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: 17633@debbugs.gnu.org > Date: Sun, 01 Jun 2014 10:18:57 -0400 > > >> > But why does it hurt to include the window's point in the click? > >> Because mouse-posn-property then checks the text-property at point. > > It shouldn't do that. This sounds like a problem with > > mouse-posn-property rather than with make_lispy_position. > > In the case of fringe clicks, I agree that these events's > buffer-position info is worthwhile and that mouse-posn-property should > ignore it, but in the case of mode-line clicks, the click is completely > unrelated to the particular position of point at that moment, os > including that info is just asking for trouble, It's not necessarily unrelated. Imagine some feature that wants to change the effect of such a click depending on point. There's nothing especially hilarious about that. From unknown Wed Aug 20 04:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2014 21:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17633@debbugs.gnu.org Received: via spool by 17633-submit@debbugs.gnu.org id=B17633.140165723215788 (code B ref 17633); Sun, 01 Jun 2014 21:14:01 +0000 Received: (at 17633) by debbugs.gnu.org; 1 Jun 2014 21:13:52 +0000 Received: from localhost ([127.0.0.1]:40086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrD4i-00046a-3x for submit@debbugs.gnu.org; Sun, 01 Jun 2014 17:13:52 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:31315) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WrD4e-00046B-RI for 17633@debbugs.gnu.org; Sun, 01 Jun 2014 17:13:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQHCxQYDSSIBAivRqJTF456B4Q4BKkZgWqBcYFbIYEu X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQHCxQYDSSIBAivRqJTF456B4Q4BKkZgWqBcYFbIYEu X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65276400" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 01 Jun 2014 17:13:42 -0400 Received: by pastel.home (Postfix, from userid 20848) id A95F5601AD; Sun, 1 Jun 2014 17:13:42 -0400 (EDT) From: Stefan Monnier Message-ID: References: <8738fs32e1@ristopher.com> <877g548kvk@ristopher.com> <87sins71nx@ristopher.com> <831tvaf6go.fsf@gnu.org> <838uphdhk4.fsf@gnu.org> <83sinpbbc1.fsf@gnu.org> <83oaycbrtg.fsf@gnu.org> Date: Sun, 01 Jun 2014 17:13:42 -0400 In-Reply-To: <83oaycbrtg.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Jun 2014 17:57:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > It's not necessarily unrelated. Imagine some feature that wants to > change the effect of such a click depending on point. There's nothing > especially hilarious about that. No, but there's no need for point to be included in the click event. Stefan