From unknown Fri Aug 15 12:51:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17632 <17632@debbugs.gnu.org> To: bug#17632 <17632@debbugs.gnu.org> Subject: Status: [PATCH] dfa: fix off-by-one under-allocation from recent change Reply-To: bug#17632 <17632@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:51:40 +0000 retitle 17632 [PATCH] dfa: fix off-by-one under-allocation from recent chan= ge reassign 17632 grep submitter 17632 Jim Meyering severity 17632 normal tag 17632 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 12:48:44 2014 Received: (at submit) by debbugs.gnu.org; 29 May 2014 16:48:44 +0000 Received: from localhost ([127.0.0.1]:36329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq3VT-00020W-Td for submit@debbugs.gnu.org; Thu, 29 May 2014 12:48:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46884) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq3VQ-00020E-FN for submit@debbugs.gnu.org; Thu, 29 May 2014 12:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq3VK-0004Py-IM for submit@debbugs.gnu.org; Thu, 29 May 2014 12:48:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq3VK-0004Pu-G1 for submit@debbugs.gnu.org; Thu, 29 May 2014 12:48:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq3VJ-00063i-MX for bug-grep@gnu.org; Thu, 29 May 2014 12:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wq3VH-0004Oi-E6 for bug-grep@gnu.org; Thu, 29 May 2014 12:48:33 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:61472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wq3VH-0004OS-4W for bug-grep@gnu.org; Thu, 29 May 2014 12:48:31 -0400 Received: by mail-wi0-f176.google.com with SMTP id n15so5850051wiw.9 for ; Thu, 29 May 2014 09:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=9ix55FSE3wPjGR1AoiJY6KzrdmiFpmLVeREYEe7dPjs=; b=OoaIEe5XYNCvBDs1t/BAZXkq7kioOMRZaDtCWJJ0g9bBjyxhQ1TZfQVGVGRGpuzhPr /fpTVevGDsRZYJS9Ks07aTrJEXdxAw9hYd2jZYcSqOgfkXWdDI1EIBQ0aK6Sbf7HjArI kJIwiRdej+5hi7WRR6O5b3rl5yeKCtmDZX8tZdp7DfrBMAjobJeqkf+F0RX/fy9ryNJO KB5IytEb9vcC9hDVIbplHPwt6zsMp8FZCaGWUcAbrpYnuIxVxekERMq+g/1mlM6Fa652 HXGQjFjulBB6Ib5UK2XTRu+XkxACZuuC+ms6sfbY/gK0I+ptakFrAy/hOUjQcLXZ07er OMVg== X-Received: by 10.180.105.1 with SMTP id gi1mr32139718wib.30.1401382107774; Thu, 29 May 2014 09:48:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Thu, 29 May 2014 09:48:07 -0700 (PDT) From: Jim Meyering Date: Thu, 29 May 2014 09:48:07 -0700 X-Google-Sender-Auth: fcMuYNP2aWh41whEM4hz07blvj0 Message-ID: Subject: [PATCH] dfa: fix off-by-one under-allocation from recent change To: bug-grep@gnu.org, Norihiro Tanaka Content-Type: multipart/mixed; boundary=f46d04428316bc878204fa8cb2e0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --f46d04428316bc878204fa8cb2e0 Content-Type: text/plain; charset=ISO-8859-1 There was another bug, that made nearly all tests fail when run under valgrind or with ASAN-enabled binaries. Here's the patch: --f46d04428316bc878204fa8cb2e0 Content-Type: text/plain; charset=US-ASCII; name="0001-dfa-fix-off-by-one-under-allocation-from-recent-chan.txt" Content-Disposition: attachment; filename="0001-dfa-fix-off-by-one-under-allocation-from-recent-chan.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hvsapg5z0 RnJvbSBmZDVjOTNkNTgwZmZlOGQyN2NhZGViODI5NjAwZGI5NzQ0NjQ0MzdmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog VGh1LCAyOSBNYXkgMjAxNCAwOTo0NDo0MSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGRmYTogZml4 IG9mZi1ieS1vbmUgdW5kZXItYWxsb2NhdGlvbiBmcm9tIHJlY2VudCBjaGFuZ2UKCkNvbW1pdCB2 Mi4xOS0xMC1nYzMyZmY2NyBtaXN0YWtlbmx5IG1hZGUgdGhpcyBjaGFuZ2U6CiAgLXJlYWxsb2Nf dHJhbnNfaWZfbmVjZXNzYXJ5IChkLCAxKTsKICArcmVhbGxvY190cmFuc19pZl9uZWNlc3Nhcnkg KGQsIDApOwp3aGljaCBsZWQgdG8gYSBoZWFwIGJ1ZmZlciBvdmVyZmxvdy4KKiBzcmMvZGZhLmMg KGRmYWV4ZWMpOiBBbGxvY2F0ZSBzcGFjZSBmb3Igb25lIHN0YXRlLCBhcyBiZWZvcmUuCi0tLQog c3JjL2RmYS5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2RmYS5jIGIvc3JjL2RmYS5jCmluZGV4IDBmMjdmODUu LjQ4YTgzY2QgMTAwNjQ0Ci0tLSBhL3NyYy9kZmEuYworKysgYi9zcmMvZGZhLmMKQEAgLTMyNjEs NyArMzI2MSw3IEBAIGRmYWV4ZWMgKHN0cnVjdCBkZmEgKmQsIGNoYXIgY29uc3QgKmJlZ2luLCBj aGFyICplbmQsCgogICBpZiAoIWQtPnRyYWxsb2MpCiAgICAgewotICAgICAgcmVhbGxvY190cmFu c19pZl9uZWNlc3NhcnkgKGQsIDApOworICAgICAgcmVhbGxvY190cmFuc19pZl9uZWNlc3Nhcnkg KGQsIDEpOwogICAgICAgYnVpbGRfc3RhdGUgKDAsIGQpOwogICAgIH0KCi0tIAoyLjAuMC5yYzMK Cg== --f46d04428316bc878204fa8cb2e0-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 12:56:37 2014 Received: (at 17632) by debbugs.gnu.org; 29 May 2014 16:56:37 +0000 Received: from localhost ([127.0.0.1]:36345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq3d6-0002HE-Fy for submit@debbugs.gnu.org; Thu, 29 May 2014 12:56:36 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:48287) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq3d3-0002Gq-HB for 17632@debbugs.gnu.org; Thu, 29 May 2014 12:56:34 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5E298A60005; Thu, 29 May 2014 09:56:27 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TbJ65pN2lZM5; Thu, 29 May 2014 09:56:08 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 3EE0439E8012; Thu, 29 May 2014 09:56:08 -0700 (PDT) Message-ID: <538766A3.4030203@cs.ucla.edu> Date: Thu, 29 May 2014 09:56:03 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Jim Meyering , 17632@debbugs.gnu.org, noritnk@kcn.ne.jp Subject: Re: bug#17632: [PATCH] dfa: fix off-by-one under-allocation from recent change References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17632 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On 05/29/2014 09:48 AM, Jim Meyering wrote: > There was another bug, that made nearly all tests fail when > run under valgrind or with ASAN-enabled binaries. Thanks for catching that. I should have noticed it, since I squashed nearly the same bug before 2.19 came out. It was reintroduced in a post-2.19 patch. From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 14:11:40 2014 Received: (at 17632-done) by debbugs.gnu.org; 29 May 2014 18:11:40 +0000 Received: from localhost ([127.0.0.1]:36380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq4nj-0004kk-Qv for submit@debbugs.gnu.org; Thu, 29 May 2014 14:11:40 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:34685) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq4nh-0004kR-Kg for 17632-done@debbugs.gnu.org; Thu, 29 May 2014 14:11:38 -0400 Received: by mail-we0-f177.google.com with SMTP id x48so825551wes.36 for <17632-done@debbugs.gnu.org>; Thu, 29 May 2014 11:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=OlWkpGGamIhB7NDXbw1HBhWqOCdZYS/P/7hQMRRXFh0=; b=ePWFuyzsGMOUq3lM9vW3G9d0PsxSsGcyCZRrdOHhgB/np2hICuEt6W96PwKPphfnrM kwiefv9hq8S9zoN8xVvw5QmMkpQvY+aee45BWk3MTUHsGW8IoEVbMHafQanp0iFEZXFn uM7wO4vm1f0bTts8olJ1EmREz7Fob2wfvRXwkvLZfnRWW/fxiSTQ1DSPq3T/+5f8I7b3 ByKKtVksjzo0m6HrYZGgKbWtWzZef2ECYBiYdQ9DngFqTnhJt0dMcQb5Db+gCDmbJ48p 1wrwEE0y7Xat68nUt7lKcq7vzBG0iKncoE4w+xiW5cNXnVmssUT8VZcGq74PcGTakNG4 BHqQ== X-Received: by 10.180.93.234 with SMTP id cx10mr14223959wib.18.1401387091831; Thu, 29 May 2014 11:11:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Thu, 29 May 2014 11:11:11 -0700 (PDT) In-Reply-To: <538766A3.4030203@cs.ucla.edu> References: <538766A3.4030203@cs.ucla.edu> From: Jim Meyering Date: Thu, 29 May 2014 11:11:11 -0700 X-Google-Sender-Auth: TwvQMzw74Q56tdPL6DK8HeSWebk Message-ID: Subject: Re: bug#17632: [PATCH] dfa: fix off-by-one under-allocation from recent change To: Paul Eggert Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17632-done Cc: 17632-done@debbugs.gnu.org, Norihiro Tanaka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, May 29, 2014 at 9:56 AM, Paul Eggert wrote: > On 05/29/2014 09:48 AM, Jim Meyering wrote: >> >> There was another bug, that made nearly all tests fail when >> run under valgrind or with ASAN-enabled binaries. Pushed. I'll make a pre-release snapshot this evening. From unknown Fri Aug 15 12:51:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Jun 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator