GNU bug report logs - #17630
24.3.91; gv expander for a few places are incorrect

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Thu, 29 May 2014 11:38:01 UTC

Severity: normal

Found in version 24.3.91

Done: Leo Liu <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Leo Liu <sdl.web <at> gmail.com>
To: 17630 <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#17630: 24.3.91; gv expander for a few places are incorrect
Date: Thu, 29 May 2014 19:36:22 +0800

Hi Stefan,

These are incorrect:

(gv-define-simple-setter window-buffer set-window-buffer)
(gv-define-simple-setter window-display-table set-window-display-table 'fix)
(gv-define-simple-setter window-dedicated-p set-window-dedicated-p)
(gv-define-simple-setter window-hscroll set-window-hscroll)
(gv-define-simple-setter window-point set-window-point)
(gv-define-simple-setter window-start set-window-start)

The getter allows optional WINDOW arg but the setter requires WINDOW
arg. For example:

  (setf (window-buffer) (get-buffer "abc")) expands incorrectly to
  (set-window-buffer (get-buffer "abc"))

They should probably all be re-defined using gv-define-setter.

Leo
This bug report was last modified 11 years and 44 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.