From unknown Sat Aug 09 12:59:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17630 <17630@debbugs.gnu.org> To: bug#17630 <17630@debbugs.gnu.org> Subject: Status: 24.3.91; gv expander for a few places are incorrect Reply-To: bug#17630 <17630@debbugs.gnu.org> Date: Sat, 09 Aug 2025 19:59:37 +0000 retitle 17630 24.3.91; gv expander for a few places are incorrect reassign 17630 emacs submitter 17630 Leo Liu severity 17630 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 07:37:04 2014 Received: (at submit) by debbugs.gnu.org; 29 May 2014 11:37:05 +0000 Received: from localhost ([127.0.0.1]:35267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wpyds-0003W1-Gp for submit@debbugs.gnu.org; Thu, 29 May 2014 07:37:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49610) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wpydq-0003VU-VO for submit@debbugs.gnu.org; Thu, 29 May 2014 07:37:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wpydc-0004XX-JK for submit@debbugs.gnu.org; Thu, 29 May 2014 07:36:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wpydc-0004XT-H3 for submit@debbugs.gnu.org; Thu, 29 May 2014 07:36:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpydT-0002Sh-FZ for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 07:36:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WpydK-0004Uh-DC for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 07:36:39 -0400 Received: from mail-pb0-x22c.google.com ([2607:f8b0:400e:c01::22c]:64411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpydK-0004Tt-5x for bug-gnu-emacs@gnu.org; Thu, 29 May 2014 07:36:30 -0400 Received: by mail-pb0-f44.google.com with SMTP id rq2so238709pbb.3 for ; Thu, 29 May 2014 04:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=8PlupxK4v1BYnz01nt6UzF6wbz3/XbhbghFej5gxsq8=; b=advUUi4XIgTIit5ViJtpTPceLW9dUVeXscQ2fNCmd4V4/4zb+AirBYPszaMQ2rI34Q 4I23BeGIGhTWn9Yw41Y33nb36Ln9YmMrXW9BZsiP4ooXCbYZO42PrIiiuZeoVcDKdbsw 9Y0TIeVvREHGyCQDB4w3Fz5oERiDROBNsaBhr4RLy/fmTWNYp8I1bpVGJN6+xVrayQzf e565jZ5P58GAL6D6Bf7iGzH2Y/HEovKqMliquRGMFjSlLU1RKM0nyTKcMl6/qEllGEto a30Jw9rDtX7ERFdE7dysv9IIpfDPPlg2+REglNc6GXOPFLE+YsiF4CxyIfROnmW8KtOQ dQTQ== X-Received: by 10.66.146.199 with SMTP id te7mr8164866pab.106.1401363388336; Thu, 29 May 2014 04:36:28 -0700 (PDT) Received: from fortuna ([222.130.180.115]) by mx.google.com with ESMTPSA id dz4sm1974924pab.47.2014.05.29.04.36.26 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 29 May 2014 04:36:27 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3.91; gv expander for a few places are incorrect X-Debbugs-CC: Stefan Monnier Date: Thu, 29 May 2014 19:36:22 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi Stefan, These are incorrect: (gv-define-simple-setter window-buffer set-window-buffer) (gv-define-simple-setter window-display-table set-window-display-table 'fix) (gv-define-simple-setter window-dedicated-p set-window-dedicated-p) (gv-define-simple-setter window-hscroll set-window-hscroll) (gv-define-simple-setter window-point set-window-point) (gv-define-simple-setter window-start set-window-start) The getter allows optional WINDOW arg but the setter requires WINDOW arg. For example: (setf (window-buffer) (get-buffer "abc")) expands incorrectly to (set-window-buffer (get-buffer "abc")) They should probably all be re-defined using gv-define-setter. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 09:18:22 2014 Received: (at 17630) by debbugs.gnu.org; 29 May 2014 13:18:22 +0000 Received: from localhost ([127.0.0.1]:35374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq0Dt-0006LB-TL for submit@debbugs.gnu.org; Thu, 29 May 2014 09:18:22 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61830) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq0Dr-0006Ku-Qa for 17630@debbugs.gnu.org; Thu, 29 May 2014 09:18:20 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="64952765" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 May 2014 09:18:13 -0400 Received: by pastel.home (Postfix, from userid 20848) id C4A59601BC; Thu, 29 May 2014 09:18:13 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#17630: 24.3.91; gv expander for a few places are incorrect Message-ID: References: Date: Thu, 29 May 2014 09:18:13 -0400 In-Reply-To: (Leo Liu's message of "Thu, 29 May 2014 19:36:22 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17630 Cc: 17630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The getter allows optional WINDOW arg but the setter requires WINDOW > arg. For example: > (setf (window-buffer) (get-buffer "abc")) expands incorrectly to > (set-window-buffer (get-buffer "abc")) > They should probably all be re-defined using gv-define-setter. Indeed. Tho maybe a better fix is to get rid of the asymmetry between the getter and the setter. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 23:46:34 2014 Received: (at 17630) by debbugs.gnu.org; 30 May 2014 03:46:34 +0000 Received: from localhost ([127.0.0.1]:36729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqDm5-0007g1-Db for submit@debbugs.gnu.org; Thu, 29 May 2014 23:46:33 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:63495) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqDm2-0007fg-KJ for 17630@debbugs.gnu.org; Thu, 29 May 2014 23:46:31 -0400 Received: by mail-pa0-f41.google.com with SMTP id kx10so1223351pab.28 for <17630@debbugs.gnu.org>; Thu, 29 May 2014 20:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=tm4dbyJiCQv5mRwFZPt6w00ilp2pGekAfBENJlQnVtw=; b=n1JIJXA+IKVes9WilI4VQZj5JU95xDiUktc0WGtPWEk08yGhd4NzJ9BYcJc6yc3MKa MPCfSO0lXNWC6mKi8iuiaBEMD4uRVPnPPHy6ATud99SjxbfAUuD/s7hdv9w+d+gnmO/U I+HGRWO//grYrQleKFzEaaGuYgQpIrXKJJTv2LRN8SeYQ1syoVagoXgSEwwis32qIKEP 4IYaN+EexjgrfmG84z/XkUubdcxB6OvcPvcJ/NOVdd6Tqa20Muyf9SM4IMiJf/pmpMX2 bGj41SeThQGxr+Dyi0CeQNtfB3LkoUmXsmKV74gpSVEIny5n6l++mo/U73XkszegCqcZ YSXQ== X-Received: by 10.66.218.36 with SMTP id pd4mr14413529pac.141.1401421584419; Thu, 29 May 2014 20:46:24 -0700 (PDT) Received: from fortuna ([222.130.180.115]) by mx.google.com with ESMTPSA id nw13sm11947676pab.37.2014.05.29.20.46.21 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 29 May 2014 20:46:23 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#17630: 24.3.91; gv expander for a few places are incorrect References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Fri, 30 May 2014 11:46:18 +0800 In-Reply-To: (Stefan Monnier's message of "Thu, 29 May 2014 09:18:13 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17630 Cc: 17630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2014-05-29 09:18 -0400, Stefan Monnier wrote: > Indeed. Tho maybe a better fix is to get rid of the asymmetry between > the getter and the setter. Yes but the situation is both odd and logical. Due to the naming of the setter the WINDOW arg naturally should appear first. For example: (set-window-parameter PARAMETER VALUE &optional WINDOW) is less clear. Making the WINDOW arg required in the getter has downsides as well. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri May 30 12:21:25 2014 Received: (at 17630) by debbugs.gnu.org; 30 May 2014 16:21:25 +0000 Received: from localhost ([127.0.0.1]:37938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqPYX-0001Ak-0S for submit@debbugs.gnu.org; Fri, 30 May 2014 12:21:25 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:59564) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqPYQ-0001AU-OO for 17630@debbugs.gnu.org; Fri, 30 May 2014 12:21:19 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 6F29E2C0AD; Fri, 30 May 2014 12:21:14 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 78EBF1E5B74; Fri, 30 May 2014 12:20:49 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 5845BB40F6; Fri, 30 May 2014 12:20:49 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#17630: 24.3.91; gv expander for a few places are incorrect Message-ID: References: Date: Fri, 30 May 2014 12:20:49 -0400 In-Reply-To: (Leo Liu's message of "Fri, 30 May 2014 11:46:18 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17630 Cc: 17630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > Yes but the situation is both odd and logical. Due to the naming of the > setter the WINDOW arg naturally should appear first. For example: > (set-window-parameter PARAMETER VALUE &optional WINDOW) > is less clear. Making the WINDOW arg required in the getter has > downsides as well. Indeed. So I guess the better fix is to use gv-define-setter, indeed. BTW, IIRC these setter definitions come straight from the old CL code, so this bug has been with us for a while. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 30 23:04:32 2014 Received: (at 17630) by debbugs.gnu.org; 31 May 2014 03:04:32 +0000 Received: from localhost ([127.0.0.1]:38321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqZax-0000FN-SZ for submit@debbugs.gnu.org; Fri, 30 May 2014 23:04:32 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:42259) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqZaw-0000F7-82 for 17630@debbugs.gnu.org; Fri, 30 May 2014 23:04:31 -0400 Received: by mail-pa0-f53.google.com with SMTP id lj1so1263838pab.12 for <17630@debbugs.gnu.org>; Fri, 30 May 2014 20:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=4zcL7CAoTJ+Vb+aYjanPTp0bDHBQa0bDWNbA5IKBH0w=; b=NqXcIe6SfcsqRxbAJXVpKSDzAJK2ym7nqmJ2tSnVxYYOwOeUKG709oeNNwbD0haw/0 sLe7IOBMZt2I50hDn3xFVqQFPSDPNZ4II9co/IEVA6C/jSgw7XjGYECz2EbJIHBdwZOu dVnjgOEcMUoqfxyApf0UykwOr5eUaUxnamMhiHSGWtCDDPpdLxBK7h1yHdMHgDFDXqkX oKCsO9Q3C6hLy5j8jEo2vA66ahf+2FIP/JjNhOAuFj207q/0l53mhbq2QTZpcd7DV1iz LktwARA5M1lOem1NTSEuHzKbjlkigA2OG6u/LoXTzV6yCEy0o3grEtMoKF2ytV00eMAw 0qjA== X-Received: by 10.69.20.10 with SMTP id gy10mr23759406pbd.162.1401505464015; Fri, 30 May 2014 20:04:24 -0700 (PDT) Received: from fortuna ([222.130.180.115]) by mx.google.com with ESMTPSA id pv4sm27057028pac.14.2014.05.30.20.04.17 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Fri, 30 May 2014 20:04:22 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#17630: 24.3.91; gv expander for a few places are incorrect References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Sat, 31 May 2014 11:04:07 +0800 In-Reply-To: (Stefan Monnier's message of "Fri, 30 May 2014 12:20:49 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17630 Cc: 17630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2014-05-30 12:20 -0400, Stefan Monnier wrote: > Indeed. So I guess the better fix is to use gv-define-setter, indeed. > BTW, IIRC these setter definitions come straight from the old CL code, > so this bug has been with us for a while. Indeed, though the return value of (setf (window-buffer ...) ...) is a regression. The fix is trivial. Do you mind installing it in emacs-24? === modified file 'lisp/emacs-lisp/gv.el' --- lisp/emacs-lisp/gv.el 2014-02-21 19:01:19 +0000 +++ lisp/emacs-lisp/gv.el 2014-05-31 02:50:44 +0000 @@ -340,13 +340,16 @@ (gv-define-simple-setter process-filter set-process-filter) (gv-define-simple-setter process-sentinel set-process-sentinel) (gv-define-simple-setter process-get process-put) -(gv-define-simple-setter window-buffer set-window-buffer) -(gv-define-simple-setter window-display-table set-window-display-table 'fix) -(gv-define-simple-setter window-dedicated-p set-window-dedicated-p) -(gv-define-simple-setter window-hscroll set-window-hscroll) (gv-define-simple-setter window-parameter set-window-parameter) -(gv-define-simple-setter window-point set-window-point) -(gv-define-simple-setter window-start set-window-start) +(gv-define-setter window-buffer (v &optional w) + `(progn (set-window-buffer ,w ,v) ,v)) +(gv-define-setter window-display-table (v &optional w) + `(progn (set-window-display-table ,w ,v) ,v)) +(gv-define-setter window-dedicated-p (v &optional w) + `(set-window-dedicated-p ,w ,v)) +(gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v)) +(gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v)) +(gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v)) (gv-define-setter buffer-local-value (val var buf) (macroexp-let2 nil v val From debbugs-submit-bounces@debbugs.gnu.org Sat May 31 10:32:56 2014 Received: (at 17630) by debbugs.gnu.org; 31 May 2014 14:32:56 +0000 Received: from localhost ([127.0.0.1]:39021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqkL9-0006VX-Qv for submit@debbugs.gnu.org; Sat, 31 May 2014 10:32:56 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:40239) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqkL6-0006VF-V5 for 17630@debbugs.gnu.org; Sat, 31 May 2014 10:32:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65170557" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 May 2014 10:32:47 -0400 Received: by pastel.home (Postfix, from userid 20848) id DE462601AD; Sat, 31 May 2014 10:32:46 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#17630: 24.3.91; gv expander for a few places are incorrect Message-ID: References: Date: Sat, 31 May 2014 10:32:46 -0400 In-Reply-To: (Leo Liu's message of "Sat, 31 May 2014 11:04:07 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17630 Cc: 17630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The fix is trivial. Do you mind installing it in emacs-24? I think it's OK, go ahead. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 31 10:37:21 2014 Received: (at 17630) by debbugs.gnu.org; 31 May 2014 14:37:21 +0000 Received: from localhost ([127.0.0.1]:39029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqkPQ-0006fQ-OU for submit@debbugs.gnu.org; Sat, 31 May 2014 10:37:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:6531) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqkPO-0006f5-8E for 17630@debbugs.gnu.org; Sat, 31 May 2014 10:37:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALDiYSFBgNJIgM0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALDiYSFBgNJIgM0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65170846" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 May 2014 10:37:12 -0400 Received: by pastel.home (Postfix, from userid 20848) id 81A89601AD; Sat, 31 May 2014 10:37:12 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#17630: 24.3.91; gv expander for a few places are incorrect Message-ID: References: Date: Sat, 31 May 2014 10:37:12 -0400 In-Reply-To: (Leo Liu's message of "Sat, 31 May 2014 11:04:07 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17630 Cc: 17630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > +(gv-define-setter window-buffer (v &optional w) > + `(progn (set-window-buffer ,w ,v) ,v)) Actually, this is wrong. C-h f gv-define-setter says: The first arg in ARGLIST (the one that receives VAL) receives an expression which can do arbitrary things, whereas the other arguments are all guaranteed to be pure and copyable. So using ,v twice will cause havoc in things like (setf (window-buffer foo) (pop buffer)) -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 31 11:48:01 2014 Received: (at 17630-done) by debbugs.gnu.org; 31 May 2014 15:48:01 +0000 Received: from localhost ([127.0.0.1]:39052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqlVp-0000a4-7N for submit@debbugs.gnu.org; Sat, 31 May 2014 11:48:01 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:45987) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqlVm-0000Zh-Et for 17630-done@debbugs.gnu.org; Sat, 31 May 2014 11:47:59 -0400 Received: by mail-pa0-f41.google.com with SMTP id kx10so2748549pab.0 for <17630-done@debbugs.gnu.org>; Sat, 31 May 2014 08:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=TE/WYuR7TPXtJ3f0+RAKi+VN7PGzDvFKk3bTrGxV+Lk=; b=k2Gs7XgECdGYx9eQFgmltKDwJ/AEG4VQmdQbGYl7GZYIGjfXh/Z8/w4OiwfeD8Qpoa oZEOOXOu/Av5KhKUDMgzGTSQuiA4pyNKdKLUQAv2iHPlmbN61JmdJ8Vs/+yozGwrvlUZ /lH5DnU8hyA1IsfFHsnoKHHruYR+2zyt44/2Y8+EJIZO+hGIvmQezgfS8BhBy3d1jakS ayGxCqCtOA3NBM2HGyhCDuNF0OMeloaS4V1fDo88w9FBVNrBMd6qZcNyQYMPLfAl/RcP /JKa/rYox14ZWNF7he/udB4LMI4aB889fWbJyTK4DUDrVOsca6m5UB4Mg8XEEac/VkSj xbog== X-Received: by 10.69.20.10 with SMTP id gy10mr27824899pbd.162.1401551272242; Sat, 31 May 2014 08:47:52 -0700 (PDT) Received: from fortuna ([221.217.232.254]) by mx.google.com with ESMTPSA id ib5sm11877402pbb.55.2014.05.31.08.47.50 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Sat, 31 May 2014 08:47:51 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#17630: 24.3.91; gv expander for a few places are incorrect References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Sat, 31 May 2014 23:47:43 +0800 In-Reply-To: (Stefan Monnier's message of "Sat, 31 May 2014 10:37:12 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17630-done Cc: 17630-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in 24.4. On 2014-05-31 10:37 -0400, Stefan Monnier wrote: > So using ,v twice will cause havoc in things like > > (setf (window-buffer foo) (pop buffer)) The curse of multiple evaluation. I think I have corrected this. Thanks, Leo From unknown Sat Aug 09 12:59:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 29 Jun 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator