From debbugs-submit-bounces@debbugs.gnu.org Wed May 28 19:46:22 2014 Received: (at submit) by debbugs.gnu.org; 28 May 2014 23:46:22 +0000 Received: from localhost ([127.0.0.1]:34933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpnY5-0002Bm-1v for submit@debbugs.gnu.org; Wed, 28 May 2014 19:46:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41460) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpnXy-0002BV-Id for submit@debbugs.gnu.org; Wed, 28 May 2014 19:46:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WpnXk-0006SD-Bw for submit@debbugs.gnu.org; Wed, 28 May 2014 19:46:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpnXk-0006S6-97 for submit@debbugs.gnu.org; Wed, 28 May 2014 19:46:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpnXe-0004NG-3W for bug-gnu-emacs@gnu.org; Wed, 28 May 2014 19:46:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WpnXX-0006Oq-UQ for bug-gnu-emacs@gnu.org; Wed, 28 May 2014 19:45:54 -0400 Received: from hampton-mail.hostforweb.net ([205.234.204.210]:55211 helo=hampton.hostforweb.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpnXX-0006O7-Qf for bug-gnu-emacs@gnu.org; Wed, 28 May 2014 19:45:47 -0400 Received: from localhost.localdomain ([127.0.0.1]:48218 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1WpnXR-003HxG-Nw; Wed, 28 May 2014 18:45:42 -0500 Date: Thu, 29 May 2014 08:45:40 +0900 Message-ID: From: Katsumi Yamaoka To: bug-gnu-emacs@gnu.org Subject: 24.4.50; bootstrap failure Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/24.4.50 (i686-pc-cygwin) Cancel-Lock: sha1:egsN33XP1VPU2uALizlFaG2gJX8= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: yamaoka X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, Bootstrap fails since yesterday. I have no clue for this but bootstrap-emacs seems to do nothing and to quit silently. ,---- (Note: there is no `Wrote *.elc' message.) | [...] | Dumping under the name emacs | Maximum static heap usage: 10470112 of 13631488 bytes | 46131 pure bytes used | cd ../lisp; make -w compile-first EMACS="../src/bootstrap-emacs.exe" | make[3]: Entering directory '/Work/Emacs/lisp' | Compiling emacs-lisp/macroexp.el | Compiling emacs-lisp/cconv.el | Compiling emacs-lisp/byte-opt.el | Compiling emacs-lisp/bytecomp.el | Compiling emacs-lisp/autoload.el | [...] `---- Is there a thing I should do next? Thanks. In GNU Emacs 24.4.50.1 (i686-pc-cygwin, GTK+ Version 3.10.7) of TODAY on localhost Repository revision: LATEST Windowing system distributor `The Cygwin/X Project', version 11.0.11501000 Configured using: `configure --verbose --with-x-toolkit=gtk3' From debbugs-submit-bounces@debbugs.gnu.org Wed May 28 22:02:43 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 02:02:43 +0000 Received: from localhost ([127.0.0.1]:34985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wppg2-0006G6-G7 for submit@debbugs.gnu.org; Wed, 28 May 2014 22:02:42 -0400 Received: from hampton-mail.hostforweb.net ([205.234.204.210]:34019 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wppg0-0006Fq-5u for 17622@debbugs.gnu.org; Wed, 28 May 2014 22:02:40 -0400 Received: from localhost.localdomain ([127.0.0.1]:53805 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1Wppfr-000tzt-L0 for 17622@debbugs.gnu.org; Wed, 28 May 2014 21:02:32 -0500 Date: Thu, 29 May 2014 11:02:32 +0900 Message-ID: From: Katsumi Yamaoka To: 17622@debbugs.gnu.org Subject: Re: bug#17622: 24.4.50; bootstrap failure References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/24.4.50 (i686-pc-cygwin) Cancel-Lock: sha1:4ffQqJw/RiSbZj5V6qCoT7MqqP4= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: yamaoka X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17622 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) A gdb backtrace is attached below. On Thu, 29 May 2014 08:45:40 +0900, Katsumi Yamaoka wrote: > Bootstrap fails since yesterday. I have no clue for this but > bootstrap-emacs seems to do nothing and to quit silently. > ,---- (Note: there is no `Wrote *.elc' message.) >| [...] >| Dumping under the name emacs >| Maximum static heap usage: 10470112 of 13631488 bytes >| 46131 pure bytes used >| cd ../lisp; make -w compile-first EMACS="../src/bootstrap-emacs.exe" >| make[3]: Entering directory '/Work/Emacs/lisp' >| Compiling emacs-lisp/macroexp.el >| Compiling emacs-lisp/cconv.el >| Compiling emacs-lisp/byte-opt.el >| Compiling emacs-lisp/bytecomp.el >| Compiling emacs-lisp/autoload.el >| [...] > `---- $ gdb ./bootstrap-emacs.exe GNU gdb (GDB) 7.6.50.20130728-cvs (cygwin-special) Copyright (C) 2013 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "i686-pc-cygwin". Type "show configuration" for configuration details. For bug reporting instructions, please see: . Find the GDB manual and other documentation resources online at: . For help, type "help". Type "apropos word" to search for commands related to "word". .. Reading symbols from /Work/Emacs/src/bootstrap-emacs.exe...done. warning: File "/Work/Emacs/src/.gdbinit" auto-loading has been declined by your `auto-load safe-path' set to "$debugdir:$datadir/auto-load". To enable execution of this file add add-auto-load-safe-path /Work/Emacs/src/.gdbinit line to your configuration file "/home/yamaoka/.gdbinit". To completely disable this security protection add set auto-load safe-path / line to your configuration file "/home/yamaoka/.gdbinit". For more information about this security protection see the "Auto-loading safe path" section in the GDB manual. E.g., run from the shell: info "(gdb)Auto-loading safe path" ^[[?1034h(gdb) r Starting program: /Work/Emacs/src/bootstrap-emacs.exe [New Thread 11900.0x28f8] [New Thread 11900.0x2d58] Program received signal SIGSEGV, Segmentation fault. mmap_alloc (var=var@entry=0x935118 , nbytes=nbytes@entry=46) at buffer.c:4895 4895 r->next->prev = r; (gdb) bt #0 mmap_alloc (var=var@entry=0x935118 , nbytes=nbytes@entry=46) at buffer.c:4895 #1 0x004e23a9 in mmap_realloc (nbytes=46, var=0x935118 ) at buffer.c:4934 #2 enlarge_buffer_text (b=b@entry=0x935000 , delta=delta@entry=0) at buffer.c:5042 #3 0x004e397d in init_buffer () at buffer.c:5290 #4 0x005b2d2f in main (argc=1, argv=0x22ac1c) at emacs.c:1379 (gdb) q A debugging session is active. Inferior 1 [process 11900] will be killed. Quit anyway? (y or n) From debbugs-submit-bounces@debbugs.gnu.org Wed May 28 22:04:17 2014 Received: (at control) by debbugs.gnu.org; 29 May 2014 02:04:17 +0000 Received: from localhost ([127.0.0.1]:34989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpphZ-0006Jn-5x for submit@debbugs.gnu.org; Wed, 28 May 2014 22:04:17 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50419 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpphW-0006Jb-AM for control@debbugs.gnu.org; Wed, 28 May 2014 22:04:15 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WpphV-0002EY-W3 for control@debbugs.gnu.org; Wed, 28 May 2014 22:04:14 -0400 Date: Wed, 28 May 2014 22:04:13 -0400 Message-Id: Subject: control message for bug 17624 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) merge 17622 17624 From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 00:57:14 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 04:57:14 +0000 Received: from localhost ([127.0.0.1]:35065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpsOv-0005qu-BL for submit@debbugs.gnu.org; Thu, 29 May 2014 00:57:13 -0400 Received: from hampton-mail.hostforweb.net ([205.234.204.210]:56520 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpsOs-0005qY-UM for 17622@debbugs.gnu.org; Thu, 29 May 2014 00:57:11 -0400 Received: from localhost.localdomain ([127.0.0.1]:39769 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1WpsOj-003L4G-JU; Wed, 28 May 2014 23:57:03 -0500 Date: Thu, 29 May 2014 13:56:59 +0900 Message-ID: From: Katsumi Yamaoka To: 17622@debbugs.gnu.org Subject: Re: bug#17622: 24.4.50; bootstrap failure References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/24.4.50 (i686-pc-cygwin) Cancel-Lock: sha1:DjEYrAEED61LMZVDtV5y+8U+HVY= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: yamaoka X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17622 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I verified simply reverting r117168 builds Emacs successfully on Cygwin. On Thu, 29 May 2014 11:02:32 +0900, Katsumi Yamaoka wrote: > A gdb backtrace is attached below. > On Thu, 29 May 2014 08:45:40 +0900, Katsumi Yamaoka wrote: >> Bootstrap fails since yesterday. I have no clue for this but >> bootstrap-emacs seems to do nothing and to quit silently. >> ,---- (Note: there is no `Wrote *.elc' message.) >>| [...] >>| Dumping under the name emacs >>| Maximum static heap usage: 10470112 of 13631488 bytes >>| 46131 pure bytes used >>| cd ../lisp; make -w compile-first EMACS="../src/bootstrap-emacs.exe" >>| make[3]: Entering directory '/Work/Emacs/lisp' >>| Compiling emacs-lisp/macroexp.el >>| Compiling emacs-lisp/cconv.el >>| Compiling emacs-lisp/byte-opt.el >>| Compiling emacs-lisp/bytecomp.el >>| Compiling emacs-lisp/autoload.el >>| [...] >> `---- > $ gdb ./bootstrap-emacs.exe > GNU gdb (GDB) 7.6.50.20130728-cvs (cygwin-special) > Copyright (C) 2013 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "i686-pc-cygwin". > Type "show configuration" for configuration details. > For bug reporting instructions, please see: > . > Find the GDB manual and other documentation resources online at: > . > For help, type "help". > Type "apropos word" to search for commands related to "word". > .. > Reading symbols from /Work/Emacs/src/bootstrap-emacs.exe...done. > warning: File "/Work/Emacs/src/.gdbinit" auto-loading has been declined by your `auto-load safe-path' set to "$debugdir:$datadir/auto-load". > To enable execution of this file add > add-auto-load-safe-path /Work/Emacs/src/.gdbinit > line to your configuration file "/home/yamaoka/.gdbinit". > To completely disable this security protection add > set auto-load safe-path / > line to your configuration file "/home/yamaoka/.gdbinit". > For more information about this security protection see the > "Auto-loading safe path" section in the GDB manual. E.g., run from the shell: > info "(gdb)Auto-loading safe path" > ^[[?1034h(gdb) r > Starting program: /Work/Emacs/src/bootstrap-emacs.exe > [New Thread 11900.0x28f8] > [New Thread 11900.0x2d58] > Program received signal SIGSEGV, Segmentation fault. > mmap_alloc (var=var@entry=0x935118 , > nbytes=nbytes@entry=46) at buffer.c:4895 > 4895 r->next->prev = r; > (gdb) bt > #0 mmap_alloc (var=var@entry=0x935118 , > nbytes=nbytes@entry=46) at buffer.c:4895 > #1 0x004e23a9 in mmap_realloc (nbytes=46, > var=0x935118 ) at buffer.c:4934 > #2 enlarge_buffer_text (b=b@entry=0x935000 , > delta=delta@entry=0) at buffer.c:5042 > #3 0x004e397d in init_buffer () at buffer.c:5290 > #4 0x005b2d2f in main (argc=1, argv=0x22ac1c) at emacs.c:1379 > (gdb) q > A debugging session is active. > Inferior 1 [process 11900] will be killed. > Quit anyway? (y or n) From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 08:38:40 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 12:38:40 +0000 Received: from localhost ([127.0.0.1]:35304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpzbP-0005AT-2F for submit@debbugs.gnu.org; Thu, 29 May 2014 08:38:39 -0400 Received: from limerock01.mail.cornell.edu ([128.84.12.99]:47155) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpzbG-0005A2-Fq for 17622@debbugs.gnu.org; Thu, 29 May 2014 08:38:31 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4TCcK21018563; Thu, 29 May 2014 08:38:20 -0400 Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4TCcJSc013722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 29 May 2014 08:38:19 -0400 Message-ID: <53872A40.3020000@cornell.edu> Date: Thu, 29 May 2014 08:38:24 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Katsumi Yamaoka , 17622@debbugs.gnu.org Subject: Re: bug#17622: 24.4.50; bootstrap failure References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17622 Cc: Eli Zaretskii , Fabrice Popineau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/29/2014 12:56 AM, Katsumi Yamaoka wrote: > I verified simply reverting r117168 builds Emacs successfully on > Cygwin. The removal of mmap_set_vars is what caused the problem. The following patch fixes restores mmap_set_vars and fixes the problem. Eli and Fabrice, is the w32 build still OK with this patch? === modified file 'src/buffer.c' --- src/buffer.c 2014-05-27 17:31:17 +0000 +++ src/buffer.c 2014-05-29 12:23:53 +0000 @@ -4855,6 +4855,38 @@ } +/* Set or reset variables holding references to mapped regions. + If not RESTORE_P, set all variables to null. If RESTORE_P, set all + variables to the start of the user-areas of mapped regions. + + This function is called from Fdump_emacs to ensure that the dumped + Emacs doesn't contain references to memory that won't be mapped + when Emacs starts. */ + +void +mmap_set_vars (bool restore_p) +{ + struct mmap_region *r; + + if (restore_p) + { + mmap_regions = mmap_regions_1; + mmap_fd = mmap_fd_1; + for (r = mmap_regions; r; r = r->next) + *r->var = MMAP_USER_AREA (r); + } + else + { + for (r = mmap_regions; r; r = r->next) + *r->var = NULL; + mmap_regions_1 = mmap_regions; + mmap_regions = NULL; + mmap_fd_1 = mmap_fd; + mmap_fd = -1; + } +} + + /* Allocate a block of storage large enough to hold NBYTES bytes of data. A pointer to the data is returned in *VAR. VAR is thus the address of some variable which will use the data area. === modified file 'src/emacs.c' --- src/emacs.c 2014-05-27 17:31:17 +0000 +++ src/emacs.c 2014-05-29 12:28:19 +0000 @@ -2155,8 +2155,13 @@ malloc_state_ptr = malloc_get_state (); #endif +#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT + mmap_set_vars (0); +#endif unexec (SSDATA (filename), !NILP (symfile) ? SSDATA (symfile) : 0); - +#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT + mmap_set_vars (1); +#endif #ifdef DOUG_LEA_MALLOC free (malloc_state_ptr); #endif Ken From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 08:56:15 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 12:56:15 +0000 Received: from localhost ([127.0.0.1]:35308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpzsR-0005ev-8s for submit@debbugs.gnu.org; Thu, 29 May 2014 08:56:15 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:46521) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpzsK-0005eR-8S for 17622@debbugs.gnu.org; Thu, 29 May 2014 08:56:08 -0400 Received: by mail-ig0-f171.google.com with SMTP id c1so3710311igq.4 for <17622@debbugs.gnu.org>; Thu, 29 May 2014 05:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=dSKDcqHUKuQVZgT+D/DHezzZu/0MN8s+4tinWqFSIAI=; b=s+k1DrTp4Ey2+EJWngQQfjT325gvUXYnKRE97HFd/i8XeBdJSyTfUYn0xhj8RVS7/6 igV7VVTkqGjtOAJ9dcPhoSw57876foXkNflG/i+ekjfbE9cMXnBncad0dQ7CyCD4HCfi nFmLHKeooC4RvHK6QZ3qH/+Sbh8SVhnrAa2PY8eSodPGX9VlppFWhByHIB5F0CjjEmKk eZH92BPwyghzK2NxB+yLqmXpvo+SecIrfBAcaKy9SY2XuFtj8AxdElJA9yZCrtT0lykZ ZEQ9+rWK41tcKJFhpN7cav6kwSgguF0atg3x5wDo+JtsGWolVxjFABEczqiknSmxovnx 4uKQ== X-Received: by 10.50.143.34 with SMTP id sb2mr10138451igb.11.1401368158297; Thu, 29 May 2014 05:55:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.10.202 with HTTP; Thu, 29 May 2014 05:55:38 -0700 (PDT) In-Reply-To: <53872A40.3020000@cornell.edu> References: <53872A40.3020000@cornell.edu> From: Fabrice Popineau Date: Thu, 29 May 2014 14:55:38 +0200 Message-ID: Subject: Re: bug#17622: 24.4.50; bootstrap failure To: Ken Brown Content-Type: multipart/alternative; boundary=001a1135effe4665ab04fa8973dd X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17622 Cc: 17622@debbugs.gnu.org, Katsumi Yamaoka , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1135effe4665ab04fa8973dd Content-Type: text/plain; charset=UTF-8 Probably ok because I ran like this for a while, but I wonder if it couldn't be handled at the beginning of bufffer.c:init_buffer() instead. What I suggest is do what mmap_set_vars(0) does inside init_buffer() rather than reinstate mmap_set_vars(). Not a great advantage, except to clarify that these pointers should be initialized when starting the dumped emacs instead of relying on what is dumped. Fabrice 2014-05-29 14:38 GMT+02:00 Ken Brown : > On 5/29/2014 12:56 AM, Katsumi Yamaoka wrote: > >> I verified simply reverting r117168 builds Emacs successfully on >> Cygwin. >> > > The removal of mmap_set_vars is what caused the problem. The following > patch fixes restores mmap_set_vars and fixes the problem. Eli and Fabrice, > is the w32 build still OK with this patch? > > === modified file 'src/buffer.c' > --- src/buffer.c 2014-05-27 17:31:17 +0000 > +++ src/buffer.c 2014-05-29 12:23:53 +0000 > @@ -4855,6 +4855,38 @@ > } > > > +/* Set or reset variables holding references to mapped regions. > + If not RESTORE_P, set all variables to null. If RESTORE_P, set all > + variables to the start of the user-areas of mapped regions. > + > + This function is called from Fdump_emacs to ensure that the dumped > + Emacs doesn't contain references to memory that won't be mapped > + when Emacs starts. */ > + > +void > +mmap_set_vars (bool restore_p) > +{ > + struct mmap_region *r; > + > + if (restore_p) > + { > + mmap_regions = mmap_regions_1; > + mmap_fd = mmap_fd_1; > + for (r = mmap_regions; r; r = r->next) > + *r->var = MMAP_USER_AREA (r); > + } > + else > + { > + for (r = mmap_regions; r; r = r->next) > + *r->var = NULL; > + mmap_regions_1 = mmap_regions; > + mmap_regions = NULL; > + mmap_fd_1 = mmap_fd; > + mmap_fd = -1; > + } > +} > + > + > /* Allocate a block of storage large enough to hold NBYTES bytes of > data. A pointer to the data is returned in *VAR. VAR is thus the > address of some variable which will use the data area. > > === modified file 'src/emacs.c' > --- src/emacs.c 2014-05-27 17:31:17 +0000 > +++ src/emacs.c 2014-05-29 12:28:19 +0000 > @@ -2155,8 +2155,13 @@ > malloc_state_ptr = malloc_get_state (); > #endif > > +#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT > + mmap_set_vars (0); > +#endif > unexec (SSDATA (filename), !NILP (symfile) ? SSDATA (symfile) : 0); > - > +#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT > + mmap_set_vars (1); > +#endif > #ifdef DOUG_LEA_MALLOC > free (malloc_state_ptr); > #endif > > > Ken > --001a1135effe4665ab04fa8973dd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Probably ok because I ran like this for a while,=C2=A0but I wonder if it couldn't be handled at the beginning of bufffer.c:i= nit_buffer() instead.
What I suggest is do what mmap_set_vars(0) = does=C2=A0
inside init_buffer() rather than reinstate mmap_set_vars().
= Not a great advantage, except to clarify that these pointers should be init= ialized
when starting the dumped emacs instead of relying on what= is dumped.

Fabrice




<= /div>


2014-05-29 14:38 GMT+02:00 Ken Brown <kbrown@cornell.edu>:
On 5/29/2014 12:56 AM, Katsumi Yamaoka wrote= :
I verified simply reverting r117168 builds Emacs successfully on
Cygwin.

The removal of mmap_set_vars is what caused the problem. =C2=A0The followin= g patch fixes restores mmap_set_vars and fixes the problem. =C2=A0Eli and F= abrice, is the w32 build still OK with this patch?

=3D=3D=3D modified file 'src/buffer.c'
--- src/buffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-27 17:31:17 +0000
+++ src/buffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-29 12:23:53 +0000
@@ -4855,6 +4855,38 @@
=C2=A0}


+/* Set or reset variables holding references to mapped regions.
+ =C2=A0 If not RESTORE_P, set all variables to null. =C2=A0If RESTORE_P, s= et all
+ =C2=A0 variables to the start of the user-areas of mapped regions.
+
+ =C2=A0 This function is called from Fdump_emacs to ensure that the dumped=
+ =C2=A0 Emacs doesn't contain references to memory that won't be m= apped
+ =C2=A0 when Emacs starts. =C2=A0*/
+
+void
+mmap_set_vars (bool restore_p)
+{
+ =C2=A0struct mmap_region *r;
+
+ =C2=A0if (restore_p)
+ =C2=A0 =C2=A0{
+ =C2=A0 =C2=A0 =C2=A0mmap_regions =3D mmap_regions_1;
+ =C2=A0 =C2=A0 =C2=A0mmap_fd =3D mmap_fd_1;
+ =C2=A0 =C2=A0 =C2=A0for (r =3D mmap_regions; r; r =3D r->next)
+ =C2=A0 =C2=A0 =C2=A0 *r->var =3D MMAP_USER_AREA (r);
+ =C2=A0 =C2=A0}
+ =C2=A0else
+ =C2=A0 =C2=A0{
+ =C2=A0 =C2=A0 =C2=A0for (r =3D mmap_regions; r; r =3D r->next)
+ =C2=A0 =C2=A0 =C2=A0 *r->var =3D NULL;
+ =C2=A0 =C2=A0 =C2=A0mmap_regions_1 =3D mmap_regions;
+ =C2=A0 =C2=A0 =C2=A0mmap_regions =3D NULL;
+ =C2=A0 =C2=A0 =C2=A0mmap_fd_1 =3D mmap_fd;
+ =C2=A0 =C2=A0 =C2=A0mmap_fd =3D -1;
+ =C2=A0 =C2=A0}
+}
+
+
=C2=A0/* Allocate a block of storage large enough to hold NBYTES bytes of =C2=A0 =C2=A0 data. =C2=A0A pointer to the data is returned in *VAR. =C2=A0= VAR is thus the
=C2=A0 =C2=A0 address of some variable which will use the data area.

=3D=3D=3D modified file 'src/emacs.c'
--- src/emacs.c 2014-05-27 17:31:17 +0000
+++ src/emacs.c 2014-05-29 12:28:19 +0000
@@ -2155,8 +2155,13 @@
=C2=A0 =C2=A0malloc_state_ptr =3D malloc_get_state ();
=C2=A0#endif

+#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT
+ =C2=A0mmap_set_vars (0);
+#endif
=C2=A0 =C2=A0unexec (SSDATA (filename), !NILP (symfile) ? SSDATA (symfile) = : 0);
-
+#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT
+ =C2=A0mmap_set_vars (1);
+#endif
=C2=A0#ifdef DOUG_LEA_MALLOC
=C2=A0 =C2=A0free (malloc_state_ptr);
=C2=A0#endif


Ken

--001a1135effe4665ab04fa8973dd-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 09:29:16 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 13:29:16 +0000 Received: from localhost ([127.0.0.1]:35379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq0OQ-0006dY-Ea for submit@debbugs.gnu.org; Thu, 29 May 2014 09:29:14 -0400 Received: from limerock03.mail.cornell.edu ([128.84.12.34]:51967) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq0ON-0006dE-V1 for 17622@debbugs.gnu.org; Thu, 29 May 2014 09:29:12 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4TDT5ZU003127; Thu, 29 May 2014 09:29:06 -0400 Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4TDT4sS003297 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 29 May 2014 09:29:05 -0400 Message-ID: <53873626.4020704@cornell.edu> Date: Thu, 29 May 2014 09:29:10 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Fabrice Popineau Subject: Re: bug#17622: 24.4.50; bootstrap failure References: <53872A40.3020000@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17622 Cc: 17622@debbugs.gnu.org, Katsumi Yamaoka , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/29/2014 8:55 AM, Fabrice Popineau wrote: > Probably ok because I ran like this for a while, > but I wonder if it couldn't be handled at the beginning of > bufffer.c:init_buffer() instead. > What I suggest is do what mmap_set_vars(0) does > inside init_buffer() rather than reinstate mmap_set_vars(). > Not a great advantage, except to clarify that these pointers should be > initialized > when starting the dumped emacs instead of relying on what is dumped. I'm not familiar enough with this code to start making changes. If you think you see a way to fix the bug that's better than reinstating mmap_set_vars, please just do it. Thanks. Ken From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 09:55:02 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 13:55:02 +0000 Received: from localhost ([127.0.0.1]:35385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq0nJ-0007NN-2k for submit@debbugs.gnu.org; Thu, 29 May 2014 09:55:01 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:54927) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq0nB-0007Mw-PI for 17622@debbugs.gnu.org; Thu, 29 May 2014 09:54:54 -0400 Received: by mail-ie0-f176.google.com with SMTP id rl12so293549iec.7 for <17622@debbugs.gnu.org>; Thu, 29 May 2014 06:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=VAQYIE3L+/t3hIAvmBXTzt9foh5rB/GZ+GTf++EgMbQ=; b=WvM+54i83kOfy1t70KeOBaVynvyp4hvOXsAo5ZkpqE3Zu2oZqSuWESVziuUERADhSE axCvNHPFM2tRXq7+wIcqXG0fpKIPT4EqcKccBfqZPpLZRoyLFundO0IoUiUgNPA7YzRm b6ychNpE7HMR9BKxp2FH4d2v21bdLKBAmEHQT0kraxpFhltJsIrVTXYa3UxW4BwN5NpZ Mdy16hAWWDPxQ1KdxLjnyDbGc0n2HkjSSNd8as1bBFY24cCDN3IFzi79H7iUx/B0yy1T EVsqHYNc7wyfk3RXl675lIGlBXxuAjc9Tb8TVDVEihPJ+EuW7VIxIRvTOm/fJDO2UTtO Ro2w== X-Received: by 10.42.185.72 with SMTP id cn8mr7260062icb.63.1401371683892; Thu, 29 May 2014 06:54:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.10.202 with HTTP; Thu, 29 May 2014 06:54:23 -0700 (PDT) In-Reply-To: References: <53872A40.3020000@cornell.edu> From: Fabrice Popineau Date: Thu, 29 May 2014 15:54:23 +0200 Message-ID: Subject: Re: bug#17622: 24.4.50; bootstrap failure To: Ken Brown Content-Type: multipart/alternative; boundary=20cf303bfebe6ab58204fa8a4583 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17622 Cc: 17622 <17622@debbugs.gnu.org>, Katsumi Yamaoka , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --20cf303bfebe6ab58204fa8a4583 Content-Type: text/plain; charset=UTF-8 This should fix the problem: --- ../trunk/src/buffer.c 2014-05-29 15:51:11.632003900 +0200 +++ src/buffer.c 2014-05-29 15:50:54.192190300 +0200 @@ -4703,11 +4703,6 @@ static int mmap_fd; -/* Temporary storage for mmap_set_vars, see there. */ - -static struct mmap_region *mmap_regions_1; -static int mmap_fd_1; - /* Page size on this system. */ static int mmap_page_size; @@ -5282,6 +5277,9 @@ { struct buffer *b; + mmap_regions = NULL; + mmap_fd = -1; + /* We cannot dump buffers with meaningful addresses that can be used by the dumped Emacs. We map new memory for them here. */ FOR_EACH_BUFFER (b) by initializing explicitly variables that need it. We can also remove unsused variables. Waiting for confirmation (or failure!). Fabrice 2014-05-29 14:55 GMT+02:00 Fabrice Popineau : > Probably ok because I ran like this for a while, > but I wonder if it couldn't be handled at the beginning of > bufffer.c:init_buffer() instead. > What I suggest is do what mmap_set_vars(0) does > inside init_buffer() rather than reinstate mmap_set_vars(). > Not a great advantage, except to clarify that these pointers should be > initialized > when starting the dumped emacs instead of relying on what is dumped. > > Fabrice > > > > > > > 2014-05-29 14:38 GMT+02:00 Ken Brown : > > On 5/29/2014 12:56 AM, Katsumi Yamaoka wrote: >> >>> I verified simply reverting r117168 builds Emacs successfully on >>> Cygwin. >>> >> >> The removal of mmap_set_vars is what caused the problem. The following >> patch fixes restores mmap_set_vars and fixes the problem. Eli and Fabrice, >> is the w32 build still OK with this patch? >> >> === modified file 'src/buffer.c' >> --- src/buffer.c 2014-05-27 17:31:17 +0000 >> +++ src/buffer.c 2014-05-29 12:23:53 +0000 >> @@ -4855,6 +4855,38 @@ >> } >> >> >> +/* Set or reset variables holding references to mapped regions. >> + If not RESTORE_P, set all variables to null. If RESTORE_P, set all >> + variables to the start of the user-areas of mapped regions. >> + >> + This function is called from Fdump_emacs to ensure that the dumped >> + Emacs doesn't contain references to memory that won't be mapped >> + when Emacs starts. */ >> + >> +void >> +mmap_set_vars (bool restore_p) >> +{ >> + struct mmap_region *r; >> + >> + if (restore_p) >> + { >> + mmap_regions = mmap_regions_1; >> + mmap_fd = mmap_fd_1; >> + for (r = mmap_regions; r; r = r->next) >> + *r->var = MMAP_USER_AREA (r); >> + } >> + else >> + { >> + for (r = mmap_regions; r; r = r->next) >> + *r->var = NULL; >> + mmap_regions_1 = mmap_regions; >> + mmap_regions = NULL; >> + mmap_fd_1 = mmap_fd; >> + mmap_fd = -1; >> + } >> +} >> + >> + >> /* Allocate a block of storage large enough to hold NBYTES bytes of >> data. A pointer to the data is returned in *VAR. VAR is thus the >> address of some variable which will use the data area. >> >> === modified file 'src/emacs.c' >> --- src/emacs.c 2014-05-27 17:31:17 +0000 >> +++ src/emacs.c 2014-05-29 12:28:19 +0000 >> @@ -2155,8 +2155,13 @@ >> malloc_state_ptr = malloc_get_state (); >> #endif >> >> +#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT >> + mmap_set_vars (0); >> +#endif >> unexec (SSDATA (filename), !NILP (symfile) ? SSDATA (symfile) : 0); >> - >> +#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT >> + mmap_set_vars (1); >> +#endif >> #ifdef DOUG_LEA_MALLOC >> free (malloc_state_ptr); >> #endif >> >> >> Ken >> > > --20cf303bfebe6ab58204fa8a4583 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
This should fix the problem:

--- .= ./trunk/src/buffer.c =C2=A0 =C2=A0 =C2=A0 2014-05-29 15:51:11.632003900 +02= 00
+++ src/buffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-29 15:50:5= 4.192190300 +0200
@@ -4703,11 +4703,6 @@

=C2=A0static int mmap_fd;

-/* = Temporary storage for mmap_set_vars, see there. =C2=A0*/
-
<= div>-static struct mmap_region *mmap_regions_1;
-static int mmap_= fd_1;
-
=C2=A0/* Page size on this system. =C2=A0*/

=
=C2=A0static int mmap_page_size;
@@ -5282,6 +5277,9 @@=
=C2=A0 =C2=A0{
=C2=A0 =C2=A0 =C2=A0struct buffer *b;

+ =C2=A0 =C2=A0mmap_regions =3D NULL;
+ =C2=A0 =C2=A0mmap_fd =3D -1;
+
=C2=A0 =C2=A0 =C2= =A0/* We cannot dump buffers with meaningful addresses that can be
=C2=A0 =C2=A0 =C2=A0 =C2=A0 used by the dumped Emacs. =C2=A0We map new me= mory for them here. =C2=A0*/
=C2=A0 =C2=A0 =C2=A0FOR_EACH_BUFFER = (b)

by initializing explicitly variables that need it= . We can also remove unsused variables.
Waiting for confirmation = (or failure!).

Fabrice


2014-05-29 14:55 GMT+02:00 Fabrice Popin= eau <fabrice.popineau@gmail.com>:
Probably ok because I ran like this for a while,=C2=A0but I wonder if it couldn't be handled at the beginning of bufffer.c:i= nit_buffer() instead.
What I suggest is do what mmap_set_vars(0) = does=C2=A0
inside init_buffer() rather than reinstate mmap_set_vars().
= Not a great advantage, except to clarify that these pointers should be init= ialized
when starting the dumped emacs instead of relying on what= is dumped.

Fabrice




<= /div>


2014-05-29 14:38 GMT+02:00 Ken Brown <kbrown@cornell.edu>:

On 5/29/2014 12:56 AM, Katsumi Yamaoka wrote= :
I verified simply reverting r117168 builds Emacs successfully on
Cygwin.

The removal of mmap_set_vars is what caused the problem. =C2=A0The followin= g patch fixes restores mmap_set_vars and fixes the problem. =C2=A0Eli and F= abrice, is the w32 build still OK with this patch?

=3D=3D=3D modified file 'src/buffer.c'
--- src/buffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-27 17:31:17 +0000
+++ src/buffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-29 12:23:53 +0000
@@ -4855,6 +4855,38 @@
=C2=A0}


+/* Set or reset variables holding references to mapped regions.
+ =C2=A0 If not RESTORE_P, set all variables to null. =C2=A0If RESTORE_P, s= et all
+ =C2=A0 variables to the start of the user-areas of mapped regions.
+
+ =C2=A0 This function is called from Fdump_emacs to ensure that the dumped=
+ =C2=A0 Emacs doesn't contain references to memory that won't be m= apped
+ =C2=A0 when Emacs starts. =C2=A0*/
+
+void
+mmap_set_vars (bool restore_p)
+{
+ =C2=A0struct mmap_region *r;
+
+ =C2=A0if (restore_p)
+ =C2=A0 =C2=A0{
+ =C2=A0 =C2=A0 =C2=A0mmap_regions =3D mmap_regions_1;
+ =C2=A0 =C2=A0 =C2=A0mmap_fd =3D mmap_fd_1;
+ =C2=A0 =C2=A0 =C2=A0for (r =3D mmap_regions; r; r =3D r->next)
+ =C2=A0 =C2=A0 =C2=A0 *r->var =3D MMAP_USER_AREA (r);
+ =C2=A0 =C2=A0}
+ =C2=A0else
+ =C2=A0 =C2=A0{
+ =C2=A0 =C2=A0 =C2=A0for (r =3D mmap_regions; r; r =3D r->next)
+ =C2=A0 =C2=A0 =C2=A0 *r->var =3D NULL;
+ =C2=A0 =C2=A0 =C2=A0mmap_regions_1 =3D mmap_regions;
+ =C2=A0 =C2=A0 =C2=A0mmap_regions =3D NULL;
+ =C2=A0 =C2=A0 =C2=A0mmap_fd_1 =3D mmap_fd;
+ =C2=A0 =C2=A0 =C2=A0mmap_fd =3D -1;
+ =C2=A0 =C2=A0}
+}
+
+
=C2=A0/* Allocate a block of storage large enough to hold NBYTES bytes of =C2=A0 =C2=A0 data. =C2=A0A pointer to the data is returned in *VAR. =C2=A0= VAR is thus the
=C2=A0 =C2=A0 address of some variable which will use the data area.

=3D=3D=3D modified file 'src/emacs.c'
--- src/emacs.c 2014-05-27 17:31:17 +0000
+++ src/emacs.c 2014-05-29 12:28:19 +0000
@@ -2155,8 +2155,13 @@
=C2=A0 =C2=A0malloc_state_ptr =3D malloc_get_state ();
=C2=A0#endif

+#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT
+ =C2=A0mmap_set_vars (0);
+#endif
=C2=A0 =C2=A0unexec (SSDATA (filename), !NILP (symfile) ? SSDATA (symfile) = : 0);
-
+#if defined USE_MMAP_FOR_BUFFERS && !defined WINDOWSNT
+ =C2=A0mmap_set_vars (1);
+#endif
=C2=A0#ifdef DOUG_LEA_MALLOC
=C2=A0 =C2=A0free (malloc_state_ptr);
=C2=A0#endif


Ken


--20cf303bfebe6ab58204fa8a4583-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 10:17:52 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 14:17:52 +0000 Received: from localhost ([127.0.0.1]:36146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq19P-0008CK-NX for submit@debbugs.gnu.org; Thu, 29 May 2014 10:17:52 -0400 Received: from limerock01.mail.cornell.edu ([128.84.12.99]:47045) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq19J-0008Bz-Gb for 17622@debbugs.gnu.org; Thu, 29 May 2014 10:17:46 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4TEHZxH015145; Thu, 29 May 2014 10:17:35 -0400 Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4TEHY56023039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 29 May 2014 10:17:34 -0400 Message-ID: <53874183.4070003@cornell.edu> Date: Thu, 29 May 2014 10:17:39 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Fabrice Popineau Subject: Re: bug#17622: 24.4.50; bootstrap failure References: <53872A40.3020000@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17622 Cc: 17622 <17622@debbugs.gnu.org>, Katsumi Yamaoka , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/29/2014 9:54 AM, Fabrice Popineau wrote: > This should fix the problem: > > --- ../trunk/src/buffer.c 2014-05-29 15:51:11.632003900 +0200 > +++ src/buffer.c 2014-05-29 15:50:54.192190300 +0200 > @@ -4703,11 +4703,6 @@ > > static int mmap_fd; > > -/* Temporary storage for mmap_set_vars, see there. */ > - > -static struct mmap_region *mmap_regions_1; > -static int mmap_fd_1; > - > /* Page size on this system. */ > > static int mmap_page_size; > @@ -5282,6 +5277,9 @@ > { > struct buffer *b; > > + mmap_regions = NULL; > + mmap_fd = -1; > + > /* We cannot dump buffers with meaningful addresses that can be > used by the dumped Emacs. We map new memory for them here. */ > FOR_EACH_BUFFER (b) > > by initializing explicitly variables that need it. We can also remove > unsused variables. > Waiting for confirmation (or failure!). Confirmed. Thanks. Ken From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 10:24:49 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 14:24:49 +0000 Received: from localhost ([127.0.0.1]:36151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1G9-0008NR-6t for submit@debbugs.gnu.org; Thu, 29 May 2014 10:24:49 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:65166) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1G3-0008N4-4i for 17622@debbugs.gnu.org; Thu, 29 May 2014 10:24:43 -0400 Received: by mail-ie0-f172.google.com with SMTP id tp5so345294ieb.31 for <17622@debbugs.gnu.org>; Thu, 29 May 2014 07:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=mJgQe5HIWOmNAcFWQ7qrbXKmuIKO2rvnO6+B1wA6lB4=; b=okZxnUARxnqTn0dNhhH61CeffzeXBLPb5hFihv/bnV2hEzPbUgufBVW5ZVU8juscCd GoQKscJIM/mDgyV7NvHcvs8KuB2eYoYuWvVf46rZQtEilugGxnTQaA+YTHUcPNwOajD2 4X0UVQvpdAhEhjXzo6688o1D5llVTn0csiWrAKquMlOXVavOthzC6IP5cGR0dvXuCWhn i3i1wnMavt5onG3nOG9Yi1CUl5Jrb1Sy37afJCBA+x+A0ulk872BGhMkurgWcdywXAF2 9mypEm2Yr4Cfh772cSQx96nCDDZoVPFU9uPKEbw6nSUNd5dLE3fsb7utWogyp0mlibWA WBsw== X-Received: by 10.50.20.8 with SMTP id j8mr10846427ige.17.1401373472885; Thu, 29 May 2014 07:24:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.10.202 with HTTP; Thu, 29 May 2014 07:24:12 -0700 (PDT) In-Reply-To: <53874183.4070003@cornell.edu> References: <53872A40.3020000@cornell.edu> <53874183.4070003@cornell.edu> From: Fabrice Popineau Date: Thu, 29 May 2014 16:24:12 +0200 Message-ID: Subject: Re: bug#17622: 24.4.50; bootstrap failure To: Ken Brown Content-Type: multipart/alternative; boundary=047d7bd752660c93e504fa8ab077 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17622 Cc: 17622 <17622@debbugs.gnu.org>, Katsumi Yamaoka , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bd752660c93e504fa8ab077 Content-Type: text/plain; charset=UTF-8 Thanks, albeit I missed the obvious. === modified file 'src/buffer.c' --- src/buffer.c 2014-05-27 17:31:17 +0000 +++ src/buffer.c 2014-05-29 14:22:37 +0000 @@ -4703,11 +4703,6 @@ static int mmap_fd; -/* Temporary storage for mmap_set_vars, see there. */ - -static struct mmap_region *mmap_regions_1; -static int mmap_fd_1; - /* Page size on this system. */ static int mmap_page_size; @@ -5282,6 +5277,10 @@ { struct buffer *b; +#ifndef WINDOWSNT + mmap_regions = NULL; + mmap_fd = -1; +#endif /* We cannot dump buffers with meaningful addresses that can be used by the dumped Emacs. We map new memory for them here. */ FOR_EACH_BUFFER (b) Fabrice 2014-05-29 16:17 GMT+02:00 Ken Brown : > On 5/29/2014 9:54 AM, Fabrice Popineau wrote: > >> This should fix the problem: >> >> --- ../trunk/src/buffer.c 2014-05-29 15:51:11.632003900 +0200 >> +++ src/buffer.c 2014-05-29 15:50:54.192190300 +0200 >> @@ -4703,11 +4703,6 @@ >> >> static int mmap_fd; >> >> -/* Temporary storage for mmap_set_vars, see there. */ >> - >> -static struct mmap_region *mmap_regions_1; >> -static int mmap_fd_1; >> - >> /* Page size on this system. */ >> >> static int mmap_page_size; >> @@ -5282,6 +5277,9 @@ >> { >> struct buffer *b; >> >> + mmap_regions = NULL; >> + mmap_fd = -1; >> + >> /* We cannot dump buffers with meaningful addresses that can be >> used by the dumped Emacs. We map new memory for them here. */ >> FOR_EACH_BUFFER (b) >> >> by initializing explicitly variables that need it. We can also remove >> unsused variables. >> Waiting for confirmation (or failure!). >> > > Confirmed. Thanks. > > Ken > > --047d7bd752660c93e504fa8ab077 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks, albeit I missed the obvious.

=3D=3D=3D modified file 'src/buffer.c'
--- src/buffer.= c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-27 17:31:17 +0000
+++ src/bu= ffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-29 14:22:37 +0000
@@ -4703,11 +4703,6 @@

=C2=A0static int mmap_= fd;

-/* Temporary storage for mmap_set_vars, see t= here. =C2=A0*/
-
-static struct mmap_region *mmap_regio= ns_1;
-static int mmap_fd_1;
-
=C2=A0/* Page size on thi= s system. =C2=A0*/

=C2=A0static int mmap_page_size= ;
@@ -5282,6 +5277,10 @@
=C2=A0 =C2=A0{
=C2= =A0 =C2=A0 =C2=A0struct buffer *b;

+#ifndef WINDOWSNT
+ =C2=A0 =C2=A0mmap_region= s =3D NULL;
+ =C2=A0 =C2=A0mmap_fd =3D -1;
+#endif
=C2=A0 =C2=A0 =C2=A0/* We cannot dump buffers with meaningful address= es that can be
=C2=A0 =C2=A0 =C2=A0 =C2=A0 used by the dumped Ema= cs. =C2=A0We map new memory for them here. =C2=A0*/
=C2=A0 =C2=A0 =C2=A0FOR_EACH_BUFFER (b)

Fabrice


2014-05-29 16:17 GMT+02:00 Ken Brown <kbrown@cornell.edu>= :
On 5/29/2014 9:54 AM, Fabric= e Popineau wrote:
This should fix the problem:

--- ../trunk/src/buffer.c =C2=A0 =C2=A0 =C2=A0 2014-05-29 15:51:11.63200390= 0 +0200
+++ src/buffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A02014-05-29 15:50:54.192190300 += 0200
@@ -4703,11 +4703,6 @@

=C2=A0 static int mmap_fd;

-/* Temporary storage for mmap_set_vars, see there. =C2=A0*/
-
-static struct mmap_region *mmap_regions_1;
-static int mmap_fd_1;
-
=C2=A0 /* Page size on this system. =C2=A0*/

=C2=A0 static int mmap_page_size;
@@ -5282,6 +5277,9 @@
=C2=A0 =C2=A0 {
=C2=A0 =C2=A0 =C2=A0 struct buffer *b;

+ =C2=A0 =C2=A0mmap_regions =3D NULL;
+ =C2=A0 =C2=A0mmap_fd =3D -1;
+
=C2=A0 =C2=A0 =C2=A0 /* We cannot dump buffers with meaningful addresses th= at can be
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0used by the dumped Emacs. =C2=A0We map ne= w memory for them here. =C2=A0*/
=C2=A0 =C2=A0 =C2=A0 FOR_EACH_BUFFER (b)

by initializing explicitly variables that need it. We can also remove
unsused variables.
Waiting for confirmation (or failure!).

Confirmed. =C2=A0Thanks.

Ken


--047d7bd752660c93e504fa8ab077-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 10:59:38 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 14:59:38 +0000 Received: from localhost ([127.0.0.1]:36170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1nt-0000vb-ML for submit@debbugs.gnu.org; Thu, 29 May 2014 10:59:38 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:43105) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1nq-0000vH-5w for 17622@debbugs.gnu.org; Thu, 29 May 2014 10:59:35 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N6C00C00BV66A00@mtaout24.012.net.il> for 17622@debbugs.gnu.org; Thu, 29 May 2014 17:56:06 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6C00DIHC5IBO00@mtaout24.012.net.il>; Thu, 29 May 2014 17:56:06 +0300 (IDT) Date: Thu, 29 May 2014 17:59:39 +0300 From: Eli Zaretskii Subject: Re: bug#17622: 24.4.50; bootstrap failure In-reply-to: X-012-Sender: halo1@inter.net.il To: Katsumi Yamaoka Message-id: <83y4xkhbqc.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17622 Cc: 17622@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 29 May 2014 13:56:59 +0900 > From: Katsumi Yamaoka > > I verified simply reverting r117168 builds Emacs successfully on > Cygwin. Yes, that revision, together with a lot of bathwater, threw out a bit of the baby. Sorry about that. Please try the latest trunk. From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 11:00:12 2014 Received: (at control) by debbugs.gnu.org; 29 May 2014 15:00:12 +0000 Received: from localhost ([127.0.0.1]:36174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1oN-0000xU-IT for submit@debbugs.gnu.org; Thu, 29 May 2014 11:00:12 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:35944) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1oF-0000w6-Nm for control@debbugs.gnu.org; Thu, 29 May 2014 11:00:04 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N6C00M00BW2R300@mtaout25.012.net.il> for control@debbugs.gnu.org; Thu, 29 May 2014 17:56:35 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6C00IJKC6BB460@mtaout25.012.net.il> for control@debbugs.gnu.org; Thu, 29 May 2014 17:56:35 +0300 (IDT) Date: Thu, 29 May 2014 18:00:05 +0300 From: Eli Zaretskii Subject: Re: bug#17624: 24.4.50; Emacs crashes during bootstrap on FreeBSD 10 In-reply-to: <20140529.102145.350085029400280945.kasahara@nc.kyushu-u.ac.jp> X-012-Sender: halo1@inter.net.il To: control@debbugs.gnu.org Message-id: <83wqd4hbpm.fsf@gnu.org> References: <20140529.102145.350085029400280945.kasahara@nc.kyushu-u.ac.jp> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 17624 17622 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 11:08:44 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 15:08:44 +0000 Received: from localhost ([127.0.0.1]:36186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1we-0001Fc-BV for submit@debbugs.gnu.org; Thu, 29 May 2014 11:08:44 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:36090) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1wY-0001FB-Hz for 17622@debbugs.gnu.org; Thu, 29 May 2014 11:08:38 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N6C00K00CKGXE00@a-mtaout22.012.net.il> for 17622@debbugs.gnu.org; Thu, 29 May 2014 18:08:27 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6C00KD6CQ3WV10@a-mtaout22.012.net.il>; Thu, 29 May 2014 18:08:27 +0300 (IDT) Date: Thu, 29 May 2014 18:08:39 +0300 From: Eli Zaretskii Subject: Re: bug#17622: 24.4.50; bootstrap failure In-reply-to: <53872A40.3020000@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83r43chbbc.fsf@gnu.org> References: <53872A40.3020000@cornell.edu> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17622 Cc: 17622@debbugs.gnu.org, yamaoka@jpl.org, fabrice.popineau@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 29 May 2014 08:38:24 -0400 > From: Ken Brown > CC: Eli Zaretskii , > Fabrice Popineau > > On 5/29/2014 12:56 AM, Katsumi Yamaoka wrote: > > I verified simply reverting r117168 builds Emacs successfully on > > Cygwin. > > The removal of mmap_set_vars is what caused the problem. The following > patch fixes restores mmap_set_vars and fixes the problem. Eli and > Fabrice, is the w32 build still OK with this patch? Yes, but there's no need to return all this cruft, as most of it is not needed. We only need to reset mmap_regions and mmap_fd. I installed a patch just now that should fix the crashes, please take a look. (It also removes two unused variables, and fixes the initialization of buffer text in init_buffer, which was slightly wrong.) From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 11:10:56 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 15:10:56 +0000 Received: from localhost ([127.0.0.1]:36197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1ym-0001Kb-2Z for submit@debbugs.gnu.org; Thu, 29 May 2014 11:10:55 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:60293) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq1yg-0001KA-9v for 17622@debbugs.gnu.org; Thu, 29 May 2014 11:10:50 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N6C00M00CR6UG00@a-mtaout20.012.net.il> for 17622@debbugs.gnu.org; Thu, 29 May 2014 18:09:31 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6C00M4QCRVS120@a-mtaout20.012.net.il>; Thu, 29 May 2014 18:09:31 +0300 (IDT) Date: Thu, 29 May 2014 18:09:43 +0300 From: Eli Zaretskii Subject: Re: bug#17622: 24.4.50; bootstrap failure In-reply-to: X-012-Sender: halo1@inter.net.il To: Fabrice Popineau Message-id: <83ppiwhb9k.fsf@gnu.org> References: <53872A40.3020000@cornell.edu> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17622 Cc: 17622@debbugs.gnu.org, yamaoka@jpl.org, kbrown@cornell.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Fabrice Popineau > Date: Thu, 29 May 2014 14:55:38 +0200 > Cc: Katsumi Yamaoka , 17622@debbugs.gnu.org, Eli Zaretskii > > but I wonder if it couldn't be handled at the beginning of > bufffer.c:init_buffer() instead. That's what I did, except that we should only do that in emacs, not in temacs, so init_buffer now accepts a flag variable to achieve that. From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 11:12:44 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 15:12:44 +0000 Received: from localhost ([127.0.0.1]:36202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq20W-0001Og-72 for submit@debbugs.gnu.org; Thu, 29 May 2014 11:12:44 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:52876) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq20Q-0001OF-MP for 17622@debbugs.gnu.org; Thu, 29 May 2014 11:12:38 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N6C00K00CNBEN00@mtaout27.012.net.il> for 17622@debbugs.gnu.org; Thu, 29 May 2014 18:09:18 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6C00GFNCRITB40@mtaout27.012.net.il>; Thu, 29 May 2014 18:09:18 +0300 (IDT) Date: Thu, 29 May 2014 18:12:40 +0300 From: Eli Zaretskii Subject: Re: bug#17622: 24.4.50; bootstrap failure In-reply-to: X-012-Sender: halo1@inter.net.il To: Fabrice Popineau Message-id: <83oayghb4n.fsf@gnu.org> References: <53872A40.3020000@cornell.edu> <53874183.4070003@cornell.edu> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17622 Cc: 17622@debbugs.gnu.org, yamaoka@jpl.org, kbrown@cornell.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Fabrice Popineau > Date: Thu, 29 May 2014 16:24:12 +0200 > Cc: Katsumi Yamaoka , 17622 <17622@debbugs.gnu.org>, Eli Zaretskii > > @@ -5282,6 +5277,10 @@ > { > struct buffer *b; > > +#ifndef WINDOWSNT > + mmap_regions = NULL; > + mmap_fd = -1; > +#endif > /* We cannot dump buffers with meaningful addresses that can be > used by the dumped Emacs. We map new memory for them here. */ > FOR_EACH_BUFFER (b) That's what I did, except that this (and the FOR_EACH_BUFFER loop after it) should only be done in the dumped emacs. From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 12:45:02 2014 Received: (at 17622) by debbugs.gnu.org; 29 May 2014 16:45:02 +0000 Received: from localhost ([127.0.0.1]:36325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq3Rt-0000jJ-C4 for submit@debbugs.gnu.org; Thu, 29 May 2014 12:45:01 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:38916) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq3Rq-0000iz-Iw for 17622@debbugs.gnu.org; Thu, 29 May 2014 12:44:59 -0400 Received: by mail-ie0-f175.google.com with SMTP id y20so556995ier.34 for <17622@debbugs.gnu.org>; Thu, 29 May 2014 09:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=G7Jqm4chV7RwQ9IG9+kCnOtyPj2dnVUCVGSCcIhSgts=; b=GeUQpFU83q4zj45ceRlkMlQHnjg9FfcAnR0Rg4jZeqQhT9kXy8GgNcACfIO+FVK+BJ wbBPbCrA67GIXV0V3kkHDv9mnmS6LzVEoi/tDskjm4b5bfS36KQN7RRpFmI27gKhiXUK 44ZjPMwEqpsU9oqEX1aZazPZ/SkisBLGFfQ8EUaAKR2VITRiJqBAg+FdWZXWkJ2408JB SxLqIwhJtADG4hEp9JaQjUB5yLdsdcP0MTTyqQ8DfJ4axNwJZBiE/cRwPEuaH0vASg0S 9DLiukNHcFRncSNutjHQikzq/wh/gnk8iInCbmcOWUVhpdhkyLGc02oDN1x+szLcaWQ4 uL4A== X-Received: by 10.42.191.202 with SMTP id dn10mr9279578icb.14.1401381892797; Thu, 29 May 2014 09:44:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.10.202 with HTTP; Thu, 29 May 2014 09:44:32 -0700 (PDT) In-Reply-To: <83oayghb4n.fsf@gnu.org> References: <53872A40.3020000@cornell.edu> <53874183.4070003@cornell.edu> <83oayghb4n.fsf@gnu.org> From: Fabrice Popineau Date: Thu, 29 May 2014 18:44:32 +0200 Message-ID: Subject: Re: bug#17622: 24.4.50; bootstrap failure To: Eli Zaretskii Content-Type: multipart/alternative; boundary=20cf301d4400ea3ba504fa8ca55a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17622 Cc: 17622 <17622@debbugs.gnu.org>, Katsumi Yamaoka , Ken Brown X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --20cf301d4400ea3ba504fa8ca55a Content-Type: text/plain; charset=UTF-8 Ok, thanks for fixing it in the repo. Fabrice 2014-05-29 17:12 GMT+02:00 Eli Zaretskii : > > From: Fabrice Popineau > > Date: Thu, 29 May 2014 16:24:12 +0200 > > Cc: Katsumi Yamaoka , 17622 <17622@debbugs.gnu.org>, > Eli Zaretskii > > > > @@ -5282,6 +5277,10 @@ > > { > > struct buffer *b; > > > > +#ifndef WINDOWSNT > > + mmap_regions = NULL; > > + mmap_fd = -1; > > +#endif > > /* We cannot dump buffers with meaningful addresses that can be > > used by the dumped Emacs. We map new memory for them here. */ > > FOR_EACH_BUFFER (b) > > That's what I did, except that this (and the FOR_EACH_BUFFER loop > after it) should only be done in the dumped emacs. > --20cf301d4400ea3ba504fa8ca55a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ok, thanks for fixing it in the repo.

F= abrice


2014-05-29 17:12 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Thu, 29 May 2014 16:24:12 +0200
> Cc: Katsumi Yamaoka <yamaoka@jpl= .org>, 17622 <17622@debb= ugs.gnu.org>, Eli Zaretskii <eliz= @gnu.org>
>
> @@ -5282,6 +5277,10 @@
> =C2=A0 =C2=A0{
> =C2=A0 =C2=A0 =C2=A0struct buffer *b;
>
> +#ifndef WINDOWSNT
> + =C2=A0 =C2=A0mmap_regions =3D NULL;
> + =C2=A0 =C2=A0mmap_fd =3D -1;
> +#endif
> =C2=A0 =C2=A0 =C2=A0/* We cannot dump buffers with meaningful addresse= s that can be
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 used by the dumped Emacs. =C2=A0We map new= memory for them here. =C2=A0*/
> =C2=A0 =C2=A0 =C2=A0FOR_EACH_BUFFER (b)

That's what I did, except that this (and the FOR_EACH_BUFFER loop=
after it) should only be done in the dumped emacs.

--20cf301d4400ea3ba504fa8ca55a-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 18:52:14 2014 Received: (at 17622-done) by debbugs.gnu.org; 29 May 2014 22:52:14 +0000 Received: from localhost ([127.0.0.1]:36572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq9BF-0005TX-Rw for submit@debbugs.gnu.org; Thu, 29 May 2014 18:52:14 -0400 Received: from hampton-mail.hostforweb.net ([205.234.204.210]:38997 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq9BD-0005TG-JK for 17622-done@debbugs.gnu.org; Thu, 29 May 2014 18:52:12 -0400 Received: from localhost.localdomain ([127.0.0.1]:43545 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1Wq9B6-001Vpk-04; Thu, 29 May 2014 17:52:04 -0500 Date: Fri, 30 May 2014 07:52:02 +0900 Message-ID: From: Katsumi Yamaoka To: 17622-done@debbugs.gnu.org Subject: Re: bug#17622: 24.4.50; bootstrap failure References: <53872A40.3020000@cornell.edu> <53874183.4070003@cornell.edu> <83oayghb4n.fsf@gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/24.4.50 (i686-pc-cygwin) Cancel-Lock: sha1:4SzOpAbAqfvfWo880a5Q+VcYXSc= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: yamaoka X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17622-done Cc: Eli Zaretskii , Fabrice Popineau , Ken Brown X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Thu, 29 May 2014 18:44:32 +0200, Fabrice Popineau wrote: > Ok, thanks for fixing it in the repo. I got Emacs that runs as normal. Thanks to all! From unknown Sun Jun 22 03:58:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Jun 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator