From unknown Mon Aug 18 04:42:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17616: patch for svg-clock.el Resent-From: dieter@schoen.or.at Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 May 2014 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17616 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17616@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140129102511205 (code B ref -1); Wed, 28 May 2014 15:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 May 2014 15:30:25 +0000 Received: from localhost ([127.0.0.1]:34687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wpfo2-0002nt-CS for submit@debbugs.gnu.org; Wed, 28 May 2014 11:30:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54572) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpbyY-0001jW-4b for submit@debbugs.gnu.org; Wed, 28 May 2014 07:24:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WpbyI-0003US-QV for submit@debbugs.gnu.org; Wed, 28 May 2014 07:24:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpbyI-0003UC-O1 for submit@debbugs.gnu.org; Wed, 28 May 2014 07:24:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpbyA-00058y-Ci for bug-gnu-emacs@gnu.org; Wed, 28 May 2014 07:24:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wpby1-0003Cj-QZ for bug-gnu-emacs@gnu.org; Wed, 28 May 2014 07:24:30 -0400 Received: from postrelay210.edis.at ([91.227.204.210]:40418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wpby1-0003Br-Fg for bug-gnu-emacs@gnu.org; Wed, 28 May 2014 07:24:21 -0400 Received: from mailrelay.edis.at (postrelay210.edis.at [91.227.204.210]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by postrelay210.edis.at (Postfix) with ESMTPS id 857382001CC9 for ; Wed, 28 May 2014 13:24:19 +0200 (CEST) Received: from schoen.or.at ([::ffff:91.227.204.20]) (AUTH: LOGIN dieter@schoen.or.at) by mailrelay.edis.at with esmtp; Wed, 28 May 2014 13:24:19 +0200 id 0000000006003364.000000005385C763.00000B58 MIME-Version: 1.0 X-Mailer: AfterLogic WebMail PHP X-Originating-IP: 194.138.12.168 X-Priority: 3 (Normal) Message-ID: From: dieter@schoen.or.at Date: Wed, 28 May 2014 11:24:19 +0000 (GMT) Content-Type: multipart/alternative; boundary="--=_NextPart_264c1bab1ab5a1609157824d0dce8574" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Wed, 28 May 2014 11:30:17 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) ----=_NextPart_264c1bab1ab5a1609157824d0dce8574 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: Quoted-Printable Hi, I am using GNU Emacs 24.4.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2014-05-28 and svg-clock 0.5. I found that because svg-clock calls (image-mode) every second, the mess= age "Type C-c C-c to view the image as an image." is displayed at the bottom of the screen every second. That overwrites all other messages. The following patch works for me: - it switched on image-mode when svg-clock is started - it only calls image-toggle-display-image when the buffer is in image-mode. I have seen that the latest commit fixes an issue with image-mode, but a= s far as I can tell, my patch does not introduce a regression. diff --git a/packages/svg-clock/svg-clock.el b/packages/svg-clock/svg-clock.el index 3897243..ff98e5b 100644 --- a/packages/svg-clock/svg-clock.el +++ b/packages/svg-clock/svg-clock.el @@ -186,8 +186,8 @@ TIME must have the form (SECOND MINUTE HOUR ...), as= returned by `decode-time'." (svg-clock-replace "%SIZE%" (format "%d" svg-clock--actual-size))= (svg-clock-replace "%SCALE%" (format "%f" (/ svg-clock--actual-size 100.0))= ) - (image-mode) - (image-toggle-display-image)))) + (when (derived-mode-p 'image-mode) + (image-toggle-display-image))))) (defun svg-clock-update () "Update the clock." @@ -245,6 +245,7 @@ Optionally PERFORM-UPDATE immediately." (setq svg-clock-timer (run-with-timer 0 1 'svg-clock-update)) (svg-clock-mode) + (image-mode) (message "Clock started"))) kind regards, dieter ----=_NextPart_264c1bab1ab5a1609157824d0dce8574 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: Quoted-Printable
Hi,
I am us= ing GNU Emacs 24.4.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) o= f 2014-05-28
and  = ;svg-clock 0.5.

I found that because sv= g-clock calls (image-mode) every second, the message
"Type C-c C-c to view the image as an ima= ge."
is displayed at t= he bottom of the screen every second. 
That overwrites all other messages.
The following patch works for me:
- it switched on image-mod= e when svg-clock is started
- it only calls image-toggle-display-image when the buffer is in ima= ge-mode.

I have seen that the latest co= mmit fixes an issue with image-mode, but as far as I can tell,
my patch does not introduce a r= egression.

=
diff --git a/packages/svg-cl= ock/svg-clock.el b/packages/svg-clock/svg-clock.el
index 3897243..ff98e5b 100644
<= div>--- a/packages/svg-clock/svg-clock.= el
+++ b/packages/svg-= clock/svg-clock.el
@@ = -186,8 +186,8 @@ TIME must have the form (SECOND MINUTE HOUR ...), as re= turned by `decode-time'."
       (svg-clock-replace "%SIZE%" (format "%d" = svg-clock--actual-size))
       (svg-clock-replace "%SCALE%"
<= div>          =                 (format "%f" (/ = svg-clock--actual-size 100.0)))
-      (image-mode)
-      (image-toggle-display-image= ))))
+     &= nbsp;(when (derived-mode-p 'image-mode)
+        (image-toggle-display-ima= ge)))))
 <= /div>
 (defun svg-clock-update= ()
   "Upda= te the clock."
@@ -245= ,6 +245,7 @@ Optionally PERFORM-UPDATE immediately."
     (setq svg-clock-timer=
      =      (run-with-timer 0 1 'svg-clock-update))
=
     (svg-clock-mod= e)
+    (ima= ge-mode)
   =  (message "Clock started")))
 
kind regards,
dieter
<= /body> ----=_NextPart_264c1bab1ab5a1609157824d0dce8574-- From unknown Mon Aug 18 04:42:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17616: patch for svg-clock.el Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2014 02:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17616 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: dieter@schoen.or.at Cc: Ulf Jasper , 17616@debbugs.gnu.org Received: via spool by 17616-submit@debbugs.gnu.org id=B17616.140158829720542 (code B ref 17616); Sun, 01 Jun 2014 02:05:01 +0000 Received: (at 17616) by debbugs.gnu.org; 1 Jun 2014 02:04:57 +0000 Received: from localhost ([127.0.0.1]:39295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wqv8q-0005LG-Qt for submit@debbugs.gnu.org; Sat, 31 May 2014 22:04:57 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:10133) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wqv8o-0005L0-43 for 17616@debbugs.gnu.org; Sat, 31 May 2014 22:04:54 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDYgoCNIZF456BxaEIgEDqRmBaoNMIQ X-IPAS-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDYgoCNIZF456BxaEIgEDqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65209527" Received: from 206-248-131-163.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 May 2014 22:04:45 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id D1625AE0BC; Sat, 31 May 2014 22:04:45 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Sat, 31 May 2014 22:04:45 -0400 In-Reply-To: (dieter@schoen.or.at's message of "Wed, 28 May 2014 11:24:19 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I found that because svg-clock calls (image-mode) every second, the message > "Type C-c C-c to view the image as an image." is displayed at the bottom of [...] > --- a/packages/svg-clock/svg-clock.el > +++ b/packages/svg-clock/svg-clock.el > @@ -186,7 +186,7 @@ TIME must have the form (SECOND MINUTE HOUR ...), asreturned by `decode-time'." > (svg-clock-replace "%SIZE%" (format "%d" svg-clock--actual-size)) > (svg-clock-replace "%SCALE%" > (format "%f" (/ svg-clock--actual-size 100.0))) > - (image-mode) > - (image-toggle-display-image)))) > + (when (derived-mode-p 'image-mode) > + (image-toggle-display-image))))) > (defun svg-clock-update () > "Update the clock." > @@ -245,4 +245,5 @@ Optionally PERFORM-UPDATE immediately." > (setq svg-clock-timer > (run-with-timer 0 1 'svg-clock-update)) > (svg-clock-mode) > + (image-mode) > (message "Clock started"))) Your patch was quite mangled, please try to use software that does mess it up so badly next time. In any case I installed it into the `elpa' branch, thank you. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 31 22:07:03 2014 Received: (at control) by debbugs.gnu.org; 1 Jun 2014 02:07:03 +0000 Received: from localhost ([127.0.0.1]:39300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqvAt-0005Pz-CO for submit@debbugs.gnu.org; Sat, 31 May 2014 22:07:03 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20659) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqvAr-0005PQ-TW for control@debbugs.gnu.org; Sat, 31 May 2014 22:07:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArQGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEGT0zCzQSFBgNiDDSGRePARaEIgEDqRmBaoNMIQ X-IPAS-Result: ArQGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEGT0zCzQSFBgNiDDSGRePARaEIgEDqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65209617" Received: from 206-248-131-163.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 May 2014 22:06:56 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 44023AE0BC; Sat, 31 May 2014 22:06:56 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#17616: patch for svg-clock.el Message-ID: References: Date: Sat, 31 May 2014 22:06:56 -0400 In-Reply-To: (dieter@schoen.or.at's message of "Wed, 28 May 2014 11:24:19 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) close 17616 thanks From unknown Mon Aug 18 04:42:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17616: patch for svg-clock.el Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2014 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17616 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , dieter@schoen.or.at Cc: 17616@debbugs.gnu.org Received: via spool by 17616-submit@debbugs.gnu.org id=B17616.14016079181531 (code B ref 17616); Sun, 01 Jun 2014 07:32:02 +0000 Received: (at 17616) by debbugs.gnu.org; 1 Jun 2014 07:31:58 +0000 Received: from localhost ([127.0.0.1]:39445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wr0FK-0000Oc-AM for submit@debbugs.gnu.org; Sun, 01 Jun 2014 03:31:58 -0400 Received: from mout.gmx.net ([212.227.17.22]:53196) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wr0FH-0000OH-A4 for 17616@debbugs.gnu.org; Sun, 01 Jun 2014 03:31:56 -0400 Received: from [194.118.138.5] ([194.118.138.5]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Mh9cj-1XDBvp1lJ3-00MO2q; Sun, 01 Jun 2014 09:31:48 +0200 Message-ID: <538AD6E0.9000205@gmx.at> Date: Sun, 01 Jun 2014 09:31:44 +0200 From: martin rudalics MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:cZGI8XmRMfQCtnbt0wXYP7lyNNsImAyrV18V8hxOEsPcw/fDrRR 2MP4dg2ek6FXe97a9+XSdpG/mJq5G5xBBrCImDB0UBvz8SP3iwz8WfdhBTD0PQFMrp9H1Kj xhHETpWxgi2fjVF9K3Xy0lPWXAN21wb7aySJUGLMssM1F3XkniksQhcV5XKIsBBEfml7B2D EtWT/v1JyIhu9srgFXTIw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Your patch was quite mangled, please try to use software that does mess > it up so badly next time. Please try to not follow such advice. martin