From unknown Mon Aug 18 11:21:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17605: [PATCH] dfa: simplify building intial state Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Tue, 27 May 2014 00:00:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17605 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: 17605@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14011487663607 (code B ref -1); Tue, 27 May 2014 00:00:05 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2014 23:59:26 +0000 Received: from localhost ([127.0.0.1]:60960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wp4ne-0000w6-8n for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wp4nb-0000vn-Ug for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wp4nN-0005tV-S3 for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wp4nN-0005tR-P6 for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wp4nG-0006OW-0L for bug-grep@gnu.org; Mon, 26 May 2014 19:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wp4n8-0005qj-Bx for bug-grep@gnu.org; Mon, 26 May 2014 19:59:01 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:37811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wp4n8-0005qK-2t for bug-grep@gnu.org; Mon, 26 May 2014 19:58:54 -0400 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 435686C1777 for ; Tue, 27 May 2014 08:58:51 +0900 (JST) Received: from mail07.kcn.ne.jp ([61.86.6.186]) by imp02 with bizsmtp id 6nyr1o00840oyB901nyrJr; Tue, 27 May 2014 08:58:51 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.56] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id 1A3D3D5009A for ; Tue, 27 May 2014 08:58:51 +0900 (JST) Date: Tue, 27 May 2014 08:58:48 +0900 From: Norihiro Tanaka Message-Id: <20140527085500.16BF.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5383D3E90000000016F8_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_5383D3E90000000016F8_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit I see that initialization isn't needed in build_state_zero(). So remove it and simplify. --------_5383D3E90000000016F8_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-simplify-building-intial-state.patch" Content-Disposition: attachment; filename="0001-dfa-simplify-building-intial-state.patch" Content-Transfer-Encoding: base64 RnJvbSA2ZWIwNjAzNWY0YWNkN2FkZjZkM2ZlMTY2NDcxNzQwYmQ2MzNmNmRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTYXQsIDI0IE1heSAyMDE0IDA5OjI2OjMxICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZGZh OiBzaW1wbGlmeSBidWlsZGluZyBpbnRpYWwgc3RhdGUKCkluaXRpYWxpemF0aW9uIG9mIG1lbWJl cnMgb2Ygc3RydWN0IGRmYSBpc24ndCBuZWVkZWQgaW4KYnVpbGRfc3RhdGVfemVybygpLiAgU28g cmVtb3ZlIHRoZW0sIGFuZCBzaW1wbGlmeS4KCiogc3JjL2RmYS5jIChidWlsZF9zdGF0ZV96ZXJv KTogUmVtb3ZlIGl0LgooZGZhZXhlYyk6IENhbGwgcmVhbGxvY190cmFuc19pZl9uZWNlc3Nhcnkg YW5kIGJ1aWxkX3N0YXRlIGRpcmVjdGx5LgotLS0KIHNyYy9kZmEuYyB8IDIxICsrKystLS0tLS0t LS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2RmYS5jIGIvc3JjL2RmYS5jCmluZGV4IDcwZGMwNDYuLmMy NTMyMmQgMTAwNjQ0Ci0tLSBhL3NyYy9kZmEuYworKysgYi9zcmMvZGZhLmMKQEAgLTI4OTYsMjIg KzI4OTYsNiBAQCBidWlsZF9zdGF0ZSAoc3RhdGVfbnVtIHMsIHN0cnVjdCBkZmEgKmQpCiAgICAg ZC0+dHJhbnNbc10gPSB0cmFuczsKIH0KIAotc3RhdGljIHZvaWQKLWJ1aWxkX3N0YXRlX3plcm8g KHN0cnVjdCBkZmEgKmQpCi17Ci0gIC8qIEluaXRpYWwgc2l6ZSBvZiB0aGUgdHJhbnNpdGlvbiB0 YWJsZXM7IG11c3QgYmUgcG9zaXRpdmUuICAqLwotICBpbnQgaW5pdGlhbF90YWJfc2l6ZSA9IDE7 Ci0KLSAgZC0+dHJhbGxvYyA9IDA7Ci0gIGQtPnRyY291bnQgPSAwOwotICBkLT50cmFucyA9IE5V TEw7Ci0gIGQtPmZhaWxzID0gTlVMTDsKLSAgZC0+c3VjY2VzcyA9IE5VTEw7Ci0gIGQtPm5ld2xp bmVzID0gTlVMTDsKLSAgcmVhbGxvY190cmFuc19pZl9uZWNlc3NhcnkgKGQsIGluaXRpYWxfdGFi X3NpemUpOwotICBidWlsZF9zdGF0ZSAoMCwgZCk7Ci19Ci0KIC8qIE11bHRpYnl0ZSBjaGFyYWN0 ZXIgaGFuZGxpbmcgc3ViLXJvdXRpbmVzIGZvciBkZmFleGVjLiAgKi8KIAogLyogUmV0dXJuIHZh bHVlcyBvZiB0cmFuc2l0X3N0YXRlX3NpbmdsZWJ5dGUsIGFuZApAQCAtMzI3NSw3ICszMjU5LDEw IEBAIGRmYWV4ZWMgKHN0cnVjdCBkZmEgKmQsIGNoYXIgY29uc3QgKmJlZ2luLCBjaGFyICplbmQs CiAgIHNpemVfdCBubGNvdW50ID0gMDsKIAogICBpZiAoIWQtPnRyYWxsb2MpCi0gICAgYnVpbGRf c3RhdGVfemVybyAoZCk7CisgICAgeworICAgICAgcmVhbGxvY190cmFuc19pZl9uZWNlc3Nhcnkg KGQsIDApOworICAgICAgYnVpbGRfc3RhdGUgKDAsIGQpOworICAgIH0KIAogICBzID0gczEgPSAw OwogICBwID0gbWJwID0gKHVuc2lnbmVkIGNoYXIgY29uc3QgKikgYmVnaW47Ci0tIAoxLjkuMwoK --------_5383D3E90000000016F8_MULTIPART_MIXED_-- From unknown Mon Aug 18 11:21:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Norihiro Tanaka Subject: bug#17605: closed (Re: bug#17605: [PATCH] dfa: simplify building intial state) Message-ID: References: <5383E296.7010606@cs.ucla.edu> <20140527085500.16BF.27F6AC2D@kcn.ne.jp> X-Gnu-PR-Message: they-closed 17605 X-Gnu-PR-Package: grep X-Gnu-PR-Keywords: patch Reply-To: 17605@debbugs.gnu.org Date: Tue, 27 May 2014 00:57:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1401152224-15531-1" This is a multi-part message in MIME format... ------------=_1401152224-15531-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17605: [PATCH] dfa: simplify building intial state which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17605@debbugs.gnu.org. --=20 17605: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17605 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1401152224-15531-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17605-done) by debbugs.gnu.org; 27 May 2014 00:56:09 +0000 Received: from localhost ([127.0.0.1]:60996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wp5gW-00040O-KX for submit@debbugs.gnu.org; Mon, 26 May 2014 20:56:08 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:56563) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wp5gT-0003zZ-PI; Mon, 26 May 2014 20:56:06 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id B18CB39E8012; Mon, 26 May 2014 17:55:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 81as4YlliltR; Mon, 26 May 2014 17:55:51 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2008339E8011; Mon, 26 May 2014 17:55:51 -0700 (PDT) Message-ID: <5383E296.7010606@cs.ucla.edu> Date: Mon, 26 May 2014 17:55:50 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Norihiro Tanaka Subject: Re: bug#17605: [PATCH] dfa: simplify building intial state References: <20140527085500.16BF.27F6AC2D@kcn.ne.jp> In-Reply-To: <20140527085500.16BF.27F6AC2D@kcn.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17605-done Cc: 17605-done@debbugs.gnu.org, 17604-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Thanks, I've pushed those changes, along with the changes for Bug#17604. ------------=_1401152224-15531-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 May 2014 23:59:26 +0000 Received: from localhost ([127.0.0.1]:60960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wp4ne-0000w6-8n for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wp4nb-0000vn-Ug for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wp4nN-0005tV-S3 for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wp4nN-0005tR-P6 for submit@debbugs.gnu.org; Mon, 26 May 2014 19:59:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wp4nG-0006OW-0L for bug-grep@gnu.org; Mon, 26 May 2014 19:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wp4n8-0005qj-Bx for bug-grep@gnu.org; Mon, 26 May 2014 19:59:01 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:37811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wp4n8-0005qK-2t for bug-grep@gnu.org; Mon, 26 May 2014 19:58:54 -0400 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 435686C1777 for ; Tue, 27 May 2014 08:58:51 +0900 (JST) Received: from mail07.kcn.ne.jp ([61.86.6.186]) by imp02 with bizsmtp id 6nyr1o00840oyB901nyrJr; Tue, 27 May 2014 08:58:51 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.56] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id 1A3D3D5009A for ; Tue, 27 May 2014 08:58:51 +0900 (JST) Date: Tue, 27 May 2014 08:58:48 +0900 From: Norihiro Tanaka To: bug-grep@gnu.org Subject: [PATCH] dfa: simplify building intial state Message-Id: <20140527085500.16BF.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5383D3E90000000016F8_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_5383D3E90000000016F8_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit I see that initialization isn't needed in build_state_zero(). So remove it and simplify. --------_5383D3E90000000016F8_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-simplify-building-intial-state.patch" Content-Disposition: attachment; filename="0001-dfa-simplify-building-intial-state.patch" Content-Transfer-Encoding: base64 RnJvbSA2ZWIwNjAzNWY0YWNkN2FkZjZkM2ZlMTY2NDcxNzQwYmQ2MzNmNmRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTYXQsIDI0IE1heSAyMDE0IDA5OjI2OjMxICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZGZh OiBzaW1wbGlmeSBidWlsZGluZyBpbnRpYWwgc3RhdGUKCkluaXRpYWxpemF0aW9uIG9mIG1lbWJl cnMgb2Ygc3RydWN0IGRmYSBpc24ndCBuZWVkZWQgaW4KYnVpbGRfc3RhdGVfemVybygpLiAgU28g cmVtb3ZlIHRoZW0sIGFuZCBzaW1wbGlmeS4KCiogc3JjL2RmYS5jIChidWlsZF9zdGF0ZV96ZXJv KTogUmVtb3ZlIGl0LgooZGZhZXhlYyk6IENhbGwgcmVhbGxvY190cmFuc19pZl9uZWNlc3Nhcnkg YW5kIGJ1aWxkX3N0YXRlIGRpcmVjdGx5LgotLS0KIHNyYy9kZmEuYyB8IDIxICsrKystLS0tLS0t LS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2RmYS5jIGIvc3JjL2RmYS5jCmluZGV4IDcwZGMwNDYuLmMy NTMyMmQgMTAwNjQ0Ci0tLSBhL3NyYy9kZmEuYworKysgYi9zcmMvZGZhLmMKQEAgLTI4OTYsMjIg KzI4OTYsNiBAQCBidWlsZF9zdGF0ZSAoc3RhdGVfbnVtIHMsIHN0cnVjdCBkZmEgKmQpCiAgICAg ZC0+dHJhbnNbc10gPSB0cmFuczsKIH0KIAotc3RhdGljIHZvaWQKLWJ1aWxkX3N0YXRlX3plcm8g KHN0cnVjdCBkZmEgKmQpCi17Ci0gIC8qIEluaXRpYWwgc2l6ZSBvZiB0aGUgdHJhbnNpdGlvbiB0 YWJsZXM7IG11c3QgYmUgcG9zaXRpdmUuICAqLwotICBpbnQgaW5pdGlhbF90YWJfc2l6ZSA9IDE7 Ci0KLSAgZC0+dHJhbGxvYyA9IDA7Ci0gIGQtPnRyY291bnQgPSAwOwotICBkLT50cmFucyA9IE5V TEw7Ci0gIGQtPmZhaWxzID0gTlVMTDsKLSAgZC0+c3VjY2VzcyA9IE5VTEw7Ci0gIGQtPm5ld2xp bmVzID0gTlVMTDsKLSAgcmVhbGxvY190cmFuc19pZl9uZWNlc3NhcnkgKGQsIGluaXRpYWxfdGFi X3NpemUpOwotICBidWlsZF9zdGF0ZSAoMCwgZCk7Ci19Ci0KIC8qIE11bHRpYnl0ZSBjaGFyYWN0 ZXIgaGFuZGxpbmcgc3ViLXJvdXRpbmVzIGZvciBkZmFleGVjLiAgKi8KIAogLyogUmV0dXJuIHZh bHVlcyBvZiB0cmFuc2l0X3N0YXRlX3NpbmdsZWJ5dGUsIGFuZApAQCAtMzI3NSw3ICszMjU5LDEw IEBAIGRmYWV4ZWMgKHN0cnVjdCBkZmEgKmQsIGNoYXIgY29uc3QgKmJlZ2luLCBjaGFyICplbmQs CiAgIHNpemVfdCBubGNvdW50ID0gMDsKIAogICBpZiAoIWQtPnRyYWxsb2MpCi0gICAgYnVpbGRf c3RhdGVfemVybyAoZCk7CisgICAgeworICAgICAgcmVhbGxvY190cmFuc19pZl9uZWNlc3Nhcnkg KGQsIDApOworICAgICAgYnVpbGRfc3RhdGUgKDAsIGQpOworICAgIH0KIAogICBzID0gczEgPSAw OwogICBwID0gbWJwID0gKHVuc2lnbmVkIGNoYXIgY29uc3QgKikgYmVnaW47Ci0tIAoxLjkuMwoK --------_5383D3E90000000016F8_MULTIPART_MIXED_-- ------------=_1401152224-15531-1--