GNU bug report logs - #17604
dfa: avoid to clear a transition table for initial state

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Mon, 26 May 2014 23:51:01 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: bug#17604: closed (Re: bug#17605: [PATCH] dfa: simplify building
 intial state)
Date: Tue, 27 May 2014 00:57:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#17604: dfa: avoid to clear a transition table for initial state

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17604 <at> debbugs.gnu.org.

-- 
17604: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17604
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17605-done <at> debbugs.gnu.org, 17604-done <at> debbugs.gnu.org
Subject: Re: bug#17605: [PATCH] dfa: simplify building intial state
Date: Mon, 26 May 2014 17:55:50 -0700
Thanks, I've pushed those changes, along with the changes for Bug#17604.

[Message part 3 (message/rfc822, inline)]
From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: dfa: avoid to clear a transition table for initial state
Date: Tue, 27 May 2014 08:49:26 +0900
[Message part 4 (text/plain, inline)]
If number of DFA states reaches at 1024, all transition tables are
cleared in build_state() in order to avoid out-of-memory.  However, for
initial state that shouldn't be done, because it's always used.

BTW, this patch enables to revert a previous patch "grep: do not count
newline before the start  of buffer", because no longer the code is never
be run through at a first character of a text.
[0001-dfa-avoid-to-clear-a-transition-table-for-initial-st.patch (text/plain, attachment)]
[0002-dfa-revert-grep-do-not-count-newline-before-the-star.patch (text/plain, attachment)]

This bug report was last modified 11 years and 54 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.