From debbugs-submit-bounces@debbugs.gnu.org Sun May 25 13:30:13 2014 Received: (at submit) by debbugs.gnu.org; 25 May 2014 17:30:13 +0000 Received: from localhost ([127.0.0.1]:59841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WocFQ-00072g-Ga for submit@debbugs.gnu.org; Sun, 25 May 2014 13:30:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42849) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WocFK-00070q-Aw for submit@debbugs.gnu.org; Sun, 25 May 2014 13:30:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WocFD-0008AN-H2 for submit@debbugs.gnu.org; Sun, 25 May 2014 13:30:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WocFD-0008AJ-EQ for submit@debbugs.gnu.org; Sun, 25 May 2014 13:29:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WocFB-0002oW-Ig for bug-gnu-emacs@gnu.org; Sun, 25 May 2014 13:29:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WocF9-00089r-Jg for bug-gnu-emacs@gnu.org; Sun, 25 May 2014 13:29:57 -0400 Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:52634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WocF9-00089S-4f for bug-gnu-emacs@gnu.org; Sun, 25 May 2014 13:29:55 -0400 Received: by mail-lb0-f176.google.com with SMTP id p9so3780685lbv.35 for ; Sun, 25 May 2014 10:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=hDdsop8FodUgH435IMMsWtybfuFrpn3u/R9uBipRwa0=; b=j27GVfcmqEGNNhsc2uQW52G7hTMdLqWRbNy4SE3jOath+Mz5v8CeLAKOASBMioPxel qGPLSR6beE8xNj03AqzRHZfFriyl/JEGjPuuKQsKamp2g85qFDG/mpw2DVVj8kz7JDJV 2E7FKdAEWaRpNRNd9wJ2GZYXCVWryzw0FIjIQcrctFOF23YzGnV1FypU3ZhbqGwxPUds kPrJM5fArtToiAEc2saTffrevbxrRu4Ecow9Z2IbREE/tOG3veVqXOJpO60Qbcm7vPp4 pormSwgJopZKekdwKNcwTtL+i9fwesK74nJmYujqn60GTW4+LpWhIoeaybqjpAeEsfnJ nu7A== MIME-Version: 1.0 X-Received: by 10.112.29.79 with SMTP id i15mr13242860lbh.26.1401038993253; Sun, 25 May 2014 10:29:53 -0700 (PDT) Received: by 10.112.20.106 with HTTP; Sun, 25 May 2014 10:29:53 -0700 (PDT) Date: Sun, 25 May 2014 19:29:53 +0200 Message-ID: Subject: * lisp/vc/vc-hg.el (vc-hg-create-tag)(vc-hg-retrieve-tag): Fix needed functions. From: =?UTF-8?Q?Santiago_Pay=C3=A0_i_Miralta?= To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=001a1133ed7a826e4204fa3ccffe X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a1133ed7a826e4204fa3ccffe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi emacs, I wish to fix the lisp/vc/vc-hg.el (vc-hg-create-tag) and (vc-hg-retrieve-tag) funcions. These functions are not yet implemented in the module. In the create-tag function a `bookmark' is created instead a `branch' when branchp is non-nil, as is a soft branch and may be a more used branching behaviour (citation needed). In the retrieve-tag function a FIXME is yet needed (not compulsory) and would be nice update the *vc-change-log* buffer so the `@' symbol is displayed in the log graph in the retrieved revision. 2014-05-25 Santiago Pay=C3=A0 i Miralta * lisp/vc/vc-hg.el (vc-hg-create-tag): New implemented function. * lisp/vc/vc-hg.es (vc-hg-retrieve-tag): New implemented function. >From 7efe806a53b8636f9195b03cb5043ddeed732ee7 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Santiago=3D20Pay=3DC3=3DA0=3D20i=3D20Miralta?=3D Date: Sun, 25 May 2014 19:28:50 +0200 Subject: [PATCH] * lisp/vc/vc-hg.el (vc-hg-create-tag)(vc-hg-retrieve-tag): Fix needed functions. In the create-tag function a `bookmark' is created instead a `branch' when branchp is non-nil, as is a soft branch and may be a more used branching behaviour (citation needed). In the retrieve-tag function a FIXME is yet needed (not compulsory) and would be nice update the *vc-change-log* buffer so the `@' symbol is displayed in the log graph in the retrieved revision. --- lisp/vc/vc-hg.el | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index 05b53a3..bbc8c91 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -82,8 +82,8 @@ ;; - annotate-current-time () NOT NEEDED ;; - annotate-extract-revision-at-line () OK ;; TAG SYSTEM -;; - create-tag (dir name branchp) NEEDED -;; - retrieve-tag (dir name update) NEEDED +;; - create-tag (dir name branchp) OK +;; - retrieve-tag (dir name update) OK FIXME UPDATE BUFFERS ;; MISCELLANEOUS ;; - make-version-backups-p (file) ?? ;; - repository-hostname (dirname) ?? @@ -382,6 +382,26 @@ Optional arg REVISION is a revision to annotate from." (expand-file-name (match-string-no-properties 4) (vc-hg-root default-directory))))))) +;;; Tag system + +(defun vc-hg-create-tag (dir name branchp) + "Attach the tag NAME to the state of the working copy." + (let ((default-directory dir)) + (and (vc-hg-command nil 0 nil "status") + (if branchp + (vc-hg-command nil 0 nil "bookmark" name) + (vc-hg-command nil 0 nil "tag" name))))) + +(defun vc-hg-retrieve-tag (dir name update) + "Retrieve the version tagged by NAME of all registered files at or below DIR." + (let ((default-directory dir)) + (vc-hg-command nil 0 nil "update" name) + ;; FIXME: update buffers if `update' is true + ;; TODO: update *vc-change-log* buffer so can see @ if --graph + )) + +;;; Miscellaneous + (defun vc-hg-previous-revision (_file rev) (let ((newrev (1- (string-to-number rev)))) (when (>=3D newrev 0) --=20 1.7.9.5 --001a1133ed7a826e4204fa3ccffe Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi emacs,
=

I wish to fix the lisp= /vc/vc-hg.el (vc-hg-create-tag) and (vc-hg-retrieve-tag) funcions. These fu= nctions are not yet implemented in the module.

In the create-tag function a `bookmark' is created instead a `branch= 9; when branchp is non-nil, as is a soft branch and may be a more used bran= ching behaviour (citation needed).

In the retrieve-tag fu= nction a FIXME is yet needed (not compulsory) and would be nice update the = *vc-change-log* buffer so the `@' symbol is displayed in the log graph = in the retrieved revision.

2014-05-25 Santiago Pay=C3=A0 i Miralta <santiagopim@gmail.com>

=C2=A0 =C2=A0 =C2=A0 = =C2=A0 * lisp/vc/vc-hg.el (vc-hg-create-tag): New implemented function.

=C2=A0 =C2=A0 =C2=A0 = =C2=A0 * lisp/vc/vc-hg.es (vc-hg-retrieve-t= ag): New implemented function.

From 7efe806a53b8636f9195b03cb5043ddeed732ee7 = Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?Santiago=3D20Pay=3DC3=3DA0=3D20i=3D20Mira= lta?=3D <santiagopim@gmail.com<= /a>>
Date: Sun, 25 May 2014 19:28:50 +0200
Subject: [PATCH] * lisp/vc/vc-hg.el (vc-hg-create-tag)(vc-hg-retriev= e-tag):
=C2=A0Fix needed functions.
In the create-tag function a `bookmark' is created inst= ead a `branch' when branchp is non-nil, as is a soft branch and may be = a more used branching behaviour (citation needed).

In the retrieve-tag functi= on a FIXME is yet needed (not compulsory) and would be nice update the *vc-= change-log* buffer so the `@' symbol is displayed in the log graph in t= he retrieved revision.
---
=C2=A0lisp/vc/vc-hg.el | = =C2=A0 24 ++++++++++++++++++++++--
=C2=A01 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.= el
index 05b53a3..bbc8c91 100644
--- a/lisp/vc/vc-hg.el
+++ b/li= sp/vc/vc-hg.el
@@ -82,8 +82,8 @@
=C2=A0;; - an= notate-current-time () =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0NOT NEEDED
=C2=A0;; - annotate-extract-revision-at-line () =C2=A0 =C2= =A0 =C2=A0OK
=C2=A0;; TAG SYSTEM
-;; - create-tag (dir name branchp) =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 NEEDED
= -;; - retrieve-tag = (dir name update) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NEEDED
+;; - create-tag (dir name branchp) =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 OK
+;; - retrieve-tag (dir= name update) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0OK FIXME UPDATE BUFF= ERS
=C2=A0;; MISCELLANEOUS
=C2=A0;;= - make-version-backups-p (file) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = ??
=C2=A0;; - repository-hostname (dirname) =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ??
= @@ -382,6 +382,26 @= @ Optional arg REVISION is a revision to annotate from."
=C2=A0 = =C2=A0 =C2=A0 =C2=A0(expand-file-name (match-string-no-properties 4)=
=C2=A0 (vc-hg-root default-directory)))= ))))
=C2=A0
+;;; Tag system
+
<= div class=3D"gmail_default" style> +(defun vc-hg-creat= e-tag (dir name branchp)
+ =C2=A0"Attach t= he tag NAME to the state of the working copy."
+ =C2=A0(let ((default-directory dir))
+ =C2=A0(and (vc-hg-command nil 0 nil "status")
+ =C2=A0 =C2=A0 =C2=A0 (if branchp
+ =C2=A0 (vc-hg-co= mmand nil 0 nil "bookmark" name)
+ (vc-hg= -command nil 0 nil "tag" name)))))
+
+(defun vc-hg-retrieve-tag (dir name update)
+ =C2=A0"Retri= eve the version tagged by NAME of all registered files at or below DIR.&quo= t;
+ =C2=A0(let ((default-directory dir))
+ =C2=A0 =C2=A0(vc-hg-command nil 0 nil "update" = name)
+ =C2=A0 =C2=A0;; FIXME: update buffers i= f `update' is true
+ =C2=A0 =C2=A0;; TODO: update *vc-change-log* buffer so ca= n see @ if --graph
+ =C2=A0 =C2=A0))
+
+;;; Miscellaneous
+
=C2=A0(defun vc-hg-previous-revision (_file rev)
=C2=A0 =C2=A0(let (= (newrev (1- (string-to-number rev))))
=C2=A0 = =C2=A0 =C2=A0(when (>=3D newrev 0)
--=C2=A0
1.7.9.5

--001a1133ed7a826e4204fa3ccffe-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 12:39:47 2014 Received: (at 17586) by debbugs.gnu.org; 6 Jun 2014 16:39:48 +0000 Received: from localhost ([127.0.0.1]:39770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsxBD-0001hg-IU for submit@debbugs.gnu.org; Fri, 06 Jun 2014 12:39:47 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:17980) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsxB9-0001hH-Rx for 17586@debbugs.gnu.org; Fri, 06 Jun 2014 12:39:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqgXGBWyE X-IPAS-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="66042752" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Jun 2014 12:39:38 -0400 Received: by pastel.home (Postfix, from userid 20848) id 021B8600D1; Fri, 6 Jun 2014 12:39:37 -0400 (EDT) From: Stefan Monnier To: Santiago =?windows-1252?Q?Pay=E0?= i Miralta Subject: Re: bug#17586: * lisp/vc/vc-hg.el (vc-hg-create-tag)(vc-hg-retrieve-tag): Fix needed functions. Message-ID: References: Date: Fri, 06 Jun 2014 12:39:37 -0400 In-Reply-To: ("Santiago =?windows-1252?Q?Pay=E0?= i Miralta"'s message of "Sun, 25 May 2014 19:29:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17586 Cc: 17586@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I wish to fix the lisp/vc/vc-hg.el (vc-hg-create-tag) and > (vc-hg-retrieve-tag) funcions. These functions are not yet implemented in > the module. Installed into `trunk', after fixing the patch's wrapping, as well as the code's indentation. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 13:22:49 2015 Received: (at control) by debbugs.gnu.org; 13 May 2015 17:22:49 +0000 Received: from localhost ([127.0.0.1]:44042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YsaMq-0006v2-QZ for submit@debbugs.gnu.org; Wed, 13 May 2015 13:22:49 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37017 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YsaMo-0006ut-4N for control@debbugs.gnu.org; Wed, 13 May 2015 13:22:46 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YsaMn-0004oM-Ic for control@debbugs.gnu.org; Wed, 13 May 2015 13:22:45 -0400 Date: Wed, 13 May 2015 13:22:45 -0400 Message-Id: Subject: control message for bug 17586 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 17586 25.1 From unknown Mon Aug 18 11:28:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jun 2015 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator